50327 Commits

Author SHA1 Message Date
Petr Skoda
fed02be153 MDL-30147 do not expect text comparison exceptions when not in debug mode
Unfortunately the column type fetching is too expensive, we do extra verification in debug mode only.
2011-11-19 09:44:33 +01:00
Petr Skoda
a453ec079f MDL-30147 optional verification if dml exception when table missing 2011-11-19 09:39:07 +01:00
Eloy Lafuente (stronk7)
870896eca1 MDL-30147 dml - mysql and no params now behaving "standard" 2011-11-19 09:27:10 +01:00
Eloy Lafuente (stronk7)
a8097d6dda MDL-30147 dml - one more test behavior without params 2011-11-19 09:27:09 +01:00
Eloy Lafuente (stronk7)
8f201c9ded MDL-30147 dml - added some tests demoing bad get_columns() behavior 2011-11-19 09:27:09 +01:00
Petr Skoda
69ac5d478f MDL-30147 do not rely on dml exception type outside of dml layer
The trouble is that dml driver methods (insert, update, select) are not guaranteed to return the same exception class for various db problems and coding style issues. The recommended practice is to catch dml_exception only.
2011-11-19 09:25:11 +01:00
Petr Skoda
c04e80e328 MDL-30147 detect missing table when processing query conditions 2011-11-19 09:16:51 +01:00
Andrew Davis
22e23da6f4 MDL-29814 message: made html personal messages store a plain text version as a fallback 2011-11-19 15:35:23 +08:00
AMOS bot
967bc47c80 Merge branch 'master' into install_master 2011-11-19 00:30:59 +00:00
Mary Evans
2062be1a01 MDL-30359 Fixes for dir-rtl in theme_base CSS 2011-11-19 00:04:41 +00:00
Chris Scribner
036e84c389 MDL-30354 lti - B27 - locallib changes 2011-11-18 12:38:41 -05:00
Eloy Lafuente (stronk7)
f218cdab34 Merge branch 'MDL-29591-master-2' of git://git.luns.net.uk/moodle 2011-11-18 17:28:53 +01:00
Eloy Lafuente (stronk7)
668933bcaa MDL-20534 lti: B14 - tiny bit, but savepoint tests require that 2011-11-18 17:19:59 +01:00
Chris Scribner
532ae9aa34 MDL-30295 lti - Adding lti:manage localization string. 2011-11-18 11:19:07 -05:00
Chris Scribner
efba8960e1 MDL-20534 lti: B11 - Making language file changes (re-order, markdown, remove newlines in strings) 2011-11-18 11:18:36 -05:00
Eloy Lafuente (stronk7)
194f2c60ef MDL-20534 lti: B14 - whitespace and comment fixes 2011-11-18 16:05:22 +01:00
Andrew Robert Nicols
7d7d82de03 MDL-29591 Check for permission before overwriting course idnumber when restoring 2011-11-18 14:54:00 +00:00
Eloy Lafuente (stronk7)
3a2927081c Merge branch 'MDL-30290' of git://github.com/scriby/moodle 2011-11-18 13:40:16 +01:00
Marina Glancy
a19d1057ca MDL-30270, MDL-30269: rubric interface/usability improvements:
- In rubric editor the line 'Current rubric status' is hidden if there is no status yet
- If present the style of the status is the same as on manage.php page
- For newly created rubric 'Add criterion' button is pre-pressed automatically
- Changed JavaScript to work for Mac browsers default settings and for IPad
- MDL-30269: added explanation message about score to grade mapping
- fixed bug with non-javascript 'Add criterion' behaviour
2011-11-18 15:35:24 +08:00
Aparup Banerjee
8adce198e4 Merge branch 'MDL-30279-master' of git://github.com/ankitagarwal/moodle 2011-11-18 15:34:18 +08:00
AMOS bot
00db87ad38 Automatically generated installer lang files 2011-11-18 00:30:45 +00:00
Eloy Lafuente (stronk7)
fe41ba7489 on-demand release 2.2beta 2011-11-18 01:20:35 +01:00
Eloy Lafuente (stronk7)
d9f2975413 Merge branch 'install_master' of git://github.com/amosbot/moodle 2011-11-18 01:17:52 +01:00
Chris Scribner
38936053a3 MDL-20534 lti: B9 - Adding db/log.php 2011-11-17 16:41:45 -05:00
Chris Scribner
aeae316274 MDL-20534 lti: B28 - Accidentally included Copyright header in wrong file. 2011-11-17 16:30:20 -05:00
Chris Scribner
8f45215d1c MDL-20534 lti: B28 - Update attribution headers. 2011-11-17 16:29:50 -05:00
Chris Scribner
76519c52f0 MDL-20534 lti: B11 - Making language file changes (re-order, markdown, remove newlines in strings) 2011-11-17 15:50:14 -05:00
Eloy Lafuente (stronk7)
8a9426bc17 MDL-29350 Prevent memory/time problems if there are zillions of combinations 2011-11-17 20:10:02 +01:00
Eloy Lafuente (stronk7)
408ea3b547 Merge branch 'MDL-29350-master-2' of git://git.luns.net.uk/moodle 2011-11-17 17:15:00 +01:00
Charles Severance
6edcab7a1a MDL-20534
Undo change that Chris already did.
2011-11-17 10:35:07 -05:00
Charles Severance
461bde28d8 MDL-20534
Add the tool_consumer_info fields and fix parsing of custom parameters.
2011-11-17 10:34:58 -05:00
Chris Scribner
34eb05018f MDL-20534 lti: Some cleanup of locallib.php 2011-11-17 10:34:45 -05:00
Charles Severance
ddcfda87d6 MDL-20534
I ran the software through the certification and caught a few nits:

The error return is 'failure' not 'error'
The spec says that it needs to return 'failure' for out of range or non-numeric grades
The result score needs a language tag, hard-coded as 'en'
Setting a grade multiplied by 100 but reading the grade did not divide by 100
All those are now fixed with this patch as well as this bit of cruft:

I removed the "extension service url" as it is not implemented in service.php

Feel free to review and adjust - probably the one place you might want to refactor
is that I put code to catch out-of-range-and non-numeric in
lti_parse_grade_replace_message and threw an exception on error and then caught
it in service.php and sent back the 'failure' message. Feel free to refactor a
bit if you see this done in a cleaner manner.
2011-11-17 10:34:23 -05:00
Chris Scribner
0297a3d4b7 MDL-20534 lti: Updating the tool consumer information strings to match newest spec version. 2011-11-17 10:34:07 -05:00
Chris Scribner
776e5cfa0f MDL-20534 lti: B8 - Switching from $ME to $FULLME to properly detect SSL requests. 2011-11-17 09:35:56 -05:00
Chris Scribner
b07878ec7d MDL-20534 lti: B14 - Implementing "show description on course page" 2011-11-17 09:28:40 -05:00
Mary Evans
e3b977ac83 MDL-30319 changed lang $string Light to Light/Blue in theme_mymobile 2011-11-17 13:51:30 +00:00
Eloy Lafuente (stronk7)
f71e41691a Merge branch 'MDL-30182' of git://github.com/timhunt/moodle 2011-11-17 10:53:56 +01:00
Tim Hunt
0850e6301a MDL-30182 fix missing include. Sorry. 2011-11-17 08:02:20 +00:00
Charles Fulton
9f2dc66f72 MDL-30279 show full date and time for all wiki revisions 2011-11-17 08:54:50 +05:30
Sam Hemelryk
b750c6b388 Merge branch 'MDL-24577-master-1' of git://git.luns.net.uk/moodle 2011-11-17 14:53:38 +13:00
Peter Bulmer
bfad2f2fff MDL-30313 plagiarism support for unformated rsults
support for obtaining plagiarism detection results without
html formatting
2011-11-17 14:12:03 +13:00
AMOS bot
7d82204fab Automatically generated installer lang files 2011-11-17 00:55:25 +00:00
Eloy Lafuente (stronk7)
1f40b7e252 Merge branch 'MDL-29743' of git://github.com/timhunt/moodle 2011-11-17 01:22:22 +01:00
Sam Hemelryk
28ab9dbe98 Merge branch 'MDL-29893-master' of git://github.com/ankitagarwal/moodle 2011-11-17 13:11:46 +13:00
Eloy Lafuente (stronk7)
d647c2d608 Merge branch 'MDL-30069' of git://github.com/timhunt/moodle 2011-11-17 00:45:00 +01:00
Eloy Lafuente (stronk7)
e929eb0353 Merge branch 'MDL-30122' of git://github.com/timhunt/moodle 2011-11-17 00:33:54 +01:00
Eloy Lafuente (stronk7)
b22dc5374c Merge branch 'MDL-30167' of git://github.com/timhunt/moodle 2011-11-17 00:29:18 +01:00
Eloy Lafuente (stronk7)
e5bac3491a Merge branch 'MDL-30182' of git://github.com/timhunt/moodle 2011-11-17 00:18:25 +01:00
Eloy Lafuente (stronk7)
2c9073ab2a Merge branch 'MDL-30186' of git://github.com/timhunt/moodle 2011-11-17 00:11:29 +01:00