1450 Commits

Author SHA1 Message Date
Paul Holden
ab151f86ab
MDL-75081 grade: fix rogue gradebook scenarios containing invalid steps. 2024-02-07 09:07:04 +08:00
Huong Nguyen
7c82e1206d Merge branch 'MDL-68652-401-1' of https://github.com/ilyatregubov/moodle into MOODLE_401_STABLE 2023-12-07 09:33:33 +07:00
Jun Pataleta
ee9d740ccf
MDL-80043 gradereport_grader: No need to pass header parameter
No need to pass a value for the header parameter in
print_grade_page_head() because:
1. The default grade plugin name will be used anyway.
2. It will allow the use of the editingmode_title lang string for the
grader report so the page title can reflect the display mode of the
grader report, especially when editing mode is turned on.
2023-12-06 13:55:15 +08:00
Ilya Tregubov
13c201fbc7 MDL-68652 mod_forum: Only include gradable users in grading 2023-12-06 12:47:29 +08:00
Ilya Tregubov
348efc1495 MDL-68652 core_grades: Refactor grades functions.
get_gradable_users now has extra param to retrieve only active
users. Grade reports hase their own grade_report::get_gradable_users
since they decided whether to inlcude active users from report preferences
2023-12-05 10:53:31 +08:00
Jun Pataleta
cc6b3c161f
MDL-80043 gradereport_grader: Define editingmode_title lang string 2023-12-01 09:15:04 +08:00
Jun Pataleta
fe3ff7dd69
MDL-80043 gradereport_singleview: Improve heading wordings
* Make the headings for the single view easier to read and understand
* When on editing mode, update the heading for the grade and user
screens to convey to the user that the page is currently on editing
mode. This is helpful for screen reader users as they can immediately
know the current display mode of the single view report page when this
gets read via the page title.
2023-12-01 09:15:03 +08:00
Jun Pataleta
ed48b54542
MDL-80121 gradereport_singleview: Increase zero-state heading level
With the h2 heading not being rendered on the zero-state pages of the
Single view report, we need to increase the heading level of the
"Search for a user to view all their grades" and
"Select a grade item above" headings from h3 to h2.
2023-11-15 19:30:26 +08:00
Jun Pataleta
6637197d97
MDL-79062 gradereport_grader: Set numeric type for grade value inputs
* Set grade inputs for grade items with type set to GRADE_VALUE to
number and add min and max input attributes, where necessary.
2023-11-02 21:45:26 +08:00
Jun Pataleta
15409cfa41
MDL-79062 gradereport_grader: Remove setting of tabindex >= 1
Tab indices that are greater than or equal to 1 break the natural
tab order of the document and may cause problems for keyboard users.
2023-11-02 09:51:39 +08:00
David Woloszyn
1652b5281e MDL-42189 gradereport_overview: Report hidden from suspended enrolments 2023-10-23 09:47:19 +11:00
Jake Dallimore
925c36fb1d
Merge branch 'MDL-79056-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-10-03 12:03:58 +08:00
Jun Pataleta
adc138d1f1
MDL-79056 gradereport_user: Make column heading IDs unique
Associate column headings of user report tables to the user ID that the
report is being generated for. This will prevent duplicate IDs for the
report columns when multiple user report tables are displayed on the
User report page.
2023-09-29 11:03:36 +08:00
Jun Pataleta
aff1f3a400
MDL-79056 gradereport_user: Set grade category and item names as th
* The table cells mentioned in the `headers` attribute of other table
cells need to be using the table header <th> tag. Otherwise, HTML
validation fails.
2023-09-29 11:03:36 +08:00
Mihail Geshoski
ebf12946d6 MDL-78813 gradereport_grader: Revert border-top-width css change
Revert the modification of the border-top-width css attribute
to the grader table and the table header. This change seems to
be unnecessary.
2023-09-26 13:32:02 +02:00
Kevin Percy
00bd11b539 MDL-78813 gradereport_grader: Fixed help icon covering course average 2023-09-26 11:21:00 +02:00
Jun Pataleta
c0ec027149
MDL-79057 grade: Remove block-level elements within buttons
Replace <div> tags within <button> tags for the selector
buttons in the grade pages.
2023-09-15 17:37:20 +08:00
Jun Pataleta
51655f3485
MDL-79057 gradereport_singleview: Use proper hidden attribute value
HTML attribute hidden="1" is invalid. It either needs to be set to an
empty string or use the keyword "hidden" for its value.
2023-09-06 18:39:15 +08:00
Jun Pataleta
bf9a2f43ad
MDL-79057 gradereport_singleview: Remove tabindex > 0 for elements
A tab index with a non-zero value messes up with the logical tab order
of a page.
2023-09-06 18:39:15 +08:00
Andrew Nicols
d474c049d1
Merge branch 'MDL-79045-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-09-01 10:47:34 +08:00
Jun Pataleta
489a9fc818
MDL-79045 grade: Don't enclose grade user_heading in $OUTPUT->heading()
Do not enclose \core_grades_renderer::user_heading() in
$OUTPUT->heading() and enclose the user's name in the user heading in
<h2> tags instead.
- Having <div> inside <h2> results in errors in HTML validation.
- Enclosing the whole user heading in <h2> results in the other
elements in the user heading (Message, Add to contacts) to be announced
to screen readers which can result in confusion.
2023-08-31 09:24:08 +08:00
Paul Holden
e4ba5d276d
MDL-78533 grade: relax param type of itemname in external structures.
Ensure it conforms to the same format as allowed for course modules.
2023-08-21 10:54:24 +01:00
Simey Lameze
fd046bf6d6 MDL-78684 behat: fix behat failures 2023-08-17 21:01:05 +08:00
Angelia Dela Cruz
efb38571e5 MDL-78684 Behat: Replace gradebook navigation to use page resolvers
This commit also does other things such as:
- Replace manual steps to setup gradebook by data generators
- Added support for outcomes and scales page resolvers
- Behat clean up
2023-08-01 15:55:33 +08:00
Shamim Rezaie
ddb1b56f36 MDL-77375 gradereport_singleview: set boundary of the dropdowns 2023-07-02 00:06:14 +10:00
Andrew Nicols
196ed7530b
Merge branch 'MDL-69231-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-06-15 10:56:53 +08:00
Ilya Tregubov
c162f90445
MDL-76445 gradereport_singleview: Fix Behat test
When you unenrol a user, the notification blocks some tertiary
navigation links.
2023-06-14 11:38:04 +08:00
Ilya Tregubov
b699da1461
MDL-76445 core_grades: Use group select instead of group search
On Moodle 4.1 we don't have group search on grader report.
That is only available in 4.2+
2023-06-14 09:34:22 +08:00
Mihail Geshoski
6ceb137f04 MDL-76445 gradereport_singleview: Usability fixes 2023-06-13 15:20:03 +08:00
Mihail Geshoski
e60edbf0cb MDL-76445 gradereport_user: Usability fixes 2023-06-13 15:20:03 +08:00
Simey Lameze
fc10598d63 MDL-69231 behat: remaining work for role capability generator
This commit does few things:
* Unify data generators usage to role short name.
* Replace remaining manual steps to use the new data generator.
* Also replaced other manual steps to set config to use data generators.
* Tidy up of some tests, aligning pipes and splitting one line steps into multiple lines.
* Fixes tests to have one Given/When/Then per scenario.
2023-06-02 12:42:35 +08:00
Andrew Nicols
b67b10af29 MDL-69231 behat: Update tests to use new generator 2023-06-02 12:42:35 +08:00
Ilya Tregubov
e19573d6bf Merge branch 'MDL-77810-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-03 13:08:52 +08:00
Paul Holden
569a71daea
MDL-77810 gradereport_summary: show localised plugin name in report. 2023-04-27 15:19:33 +01:00
Mihail Geshoski
f90a55979a MDL-77546 gradereport_singleview: Fix item order in grade item selector 2023-04-27 12:01:23 +08:00
Simey Lameze
c0bea2a82d MDL-77960 behat: make verification steps more specific 2023-04-19 11:57:37 +08:00
Ilya Tregubov
0d0fbec616 Merge branch 'MDL-77770-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-04-18 12:01:46 +08:00
Ilya Tregubov
ca751bdc1f Merge branch 'MDL-76855-401' of https://github.com/Chocolate-lightning/moodle into MOODLE_401_STABLE 2023-04-18 11:18:32 +08:00
Paul Holden
df4f8dd322
Merge branch 'MDL-76212-401-nav' of https://github.com/kevpercy/moodle into MOODLE_401_STABLE 2023-04-17 11:50:54 +01:00
Mathew May
faa121ad30 MDL-76855 gradereport_user: Prevent parent access errors 2023-04-17 11:26:03 +08:00
Ilya Tregubov
8dc9cd6cdc MDL-77324 gradereport_singleview: Make action menus consistent 2023-04-13 16:59:23 +08:00
Kevin Percy
5b8ad6ae30 MDL-76212 gradebook_nav: Fixed tertiary nav for smaller screens 2023-04-12 14:12:50 +08:00
Paul Holden
eb12428324
MDL-77770 gradereport_user: fix errors when no users to navigate. 2023-04-06 14:41:03 +01:00
Jun Pataleta
bb61d8392b Merge branch 'MDL-77559-401-2' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-03-09 15:57:44 +08:00
Andrew Nicols
cd48ae56c7 MDL-77559 js: Rebuild all JS with Node 16 2023-03-09 09:53:19 +08:00
Paul Holden
01fc104779 MDL-76809 gradereport_history: pre-filter report userids filter.
Ensure current user is able to access each of the provided userids.
2023-03-08 10:00:50 +08:00
Jun Pataleta
a377bf30c4 Merge branch 'MDL-75012-401-5' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-03-02 12:31:09 +08:00
Andrew Nicols
288620b0b4 MDL-75012 js: Full build of all grunt things 2023-03-02 12:15:25 +08:00
Andrew Nicols
74fe0b04be MDL-77141 gradereport_user: Adjust course name to fix test 2023-03-02 11:50:08 +08:00
Luca Bösch
c7d9fa690d MDL-77141 gradebook: Correct course name in user report 2023-02-24 10:43:16 +01:00