15782 Commits

Author SHA1 Message Date
David Monllao
5f4b4e918d MDL-38041 behat: Adding hook
Stops execution when the output contains
an exception, a debugging message or a PHP
debug message.
2013-05-03 10:05:08 +08:00
David Monllao
b060de934b MDL-38041 behat: Adding styles to debugging messages
Only when a simulated user session
is running.
2013-05-03 10:05:08 +08:00
Eloy Lafuente (stronk7)
e7ff753cab Merge branch 'wip-MDL-39432-m25-i' of git://github.com/samhemelryk/moodle 2013-05-02 03:33:35 +02:00
Eloy Lafuente (stronk7)
cedb0aab5a MDL-39434 Bump all versions near 2.5 release 2013-05-01 18:03:29 +02:00
Eloy Lafuente (stronk7)
2f679b426a Merge branch 'MDL-39444' of git://github.com/timhunt/moodle 2013-05-01 16:55:36 +02:00
Tim Hunt
296daf41c7 MDL-39444 get_string: remove unnecessary clean_param
This clean_param was added as part of MDL-22015. It is a good idea when
developer debug is turned on, but it showed up as a surprisingly
expensive cost in our profiling.

This change:

1. Removes the check during string_extist. This will not change
behaviour, the method returns false if the string does not exist.

2. In get_string, it only does the check if debugging is set to
DEVELOPER level.
2013-05-01 10:16:37 +01:00
Sam Hemelryk
15f89e2872 MDL-39422 course: converted closures to fix eAccelerator issues 2013-05-01 18:43:27 +12:00
Dan Poltawski
dd4a197e0f MDL-39207 badges: don't use curl version depedent constant
It seems that CURLOPT_CONNECTTIMEOUT_MS is depdendent on the version
of curl compiled against. We don't need milliseconds here anyway, so
switch to the seconds value.
2013-05-01 07:21:58 +01:00
Eloy Lafuente (stronk7)
bee592add8 Merge branch 'wip-MDL-39216-m25' of git://github.com/samhemelryk/moodle 2013-05-01 02:29:36 +02:00
Sam Hemelryk
a697000b53 MDL-39216 url: included test for empty string param 2013-05-01 12:27:36 +12:00
Eloy Lafuente (stronk7)
6a222aa127 Merge branch 'MDL-39232_master' of git://github.com/dmonllao/moodle 2013-05-01 00:47:32 +02:00
Dan Poltawski
1af49024a5 Merge branch 'MDL-39207_master' of git://github.com/totara/openbadges 2013-04-30 14:42:44 +01:00
Dan Poltawski
0542fdc6b4 Merge branch 'w17_MDL-39343_m25_installupgrade' of git://github.com/skodak/moodle 2013-04-30 13:37:52 +01:00
Petr Škoda
e2e35e71f9 MDL-39343 disable all caching in install and upgrades
This should resolve all problem on developer machines when switching branches or when restoring previous Moodle databases. It also prevents any potential problems during upgrades such as concurrent DB modification and resolves chicken egg problems in future caching upgrades.
2013-04-30 10:27:34 +02:00
Damyon Wiese
34e46d7556 Merge branch 'mdl-39335' of git://github.com/vostreltsov/moodle 2013-04-30 15:51:12 +08:00
Dan Poltawski
e0b3f5f235 Merge branch 'w17_MDL-39077_m25_sizes' of git://github.com/skodak/moodle 2013-04-30 08:24:31 +01:00
Damyon Wiese
59d003497c Merge branch 'MDL-39351' of git://github.com/timhunt/moodle 2013-04-30 14:13:25 +08:00
Damyon Wiese
4969053f25 Merge branch 'MDL-39246' of git://github.com/timhunt/moodle 2013-04-30 12:02:36 +08:00
David Monllao
550d842e3c MDL-39232 behat Normalize feature tags according to component names 2013-04-30 11:54:47 +08:00
Sam Hemelryk
5c8f681713 MDL-39216 url: moodle_url now handles empty param values properly 2013-04-30 11:09:47 +12:00
Sam Hemelryk
45d9752205 MDL-39216 url: updated tests to show desired outcome 2013-04-30 11:09:47 +12:00
Sam Hemelryk
616396a6cf MDL-39216 url: new moodle_url tests for valueless params 2013-04-30 11:09:47 +12:00
Dan Poltawski
a10393e19f Merge branch 'MDL-39378' of git://github.com/timhunt/moodle 2013-04-29 17:00:53 +01:00
Dan Poltawski
e947caf4a1 Merge branch 'MDL-39389' of git://github.com/stronk7/moodle 2013-04-29 14:15:23 +01:00
Dan Poltawski
1f65889ab3 Merge branch 'MDL-39390' of git://github.com/stronk7/moodle 2013-04-29 14:12:37 +01:00
Dan Poltawski
fcb6d4aac8 Merge branch 'MDL-27071' of git://github.com/stronk7/moodle 2013-04-29 10:27:29 +01:00
Damyon Wiese
883e6a77ce Merge branch 'w17_MDL-39356_m25_cacert' of git://github.com/skodak/moodle 2013-04-29 16:05:08 +08:00
Damyon Wiese
ea03f1149e Merge branch 'MDL-30940-master' of git://github.com/FMCorz/moodle 2013-04-29 14:03:34 +08:00
Damyon Wiese
bd45c1aa47 Merge branch 'MDL-36024-master' of https://github.com/mackensen/moodle 2013-04-29 10:45:55 +08:00
Eloy Lafuente (stronk7)
20c9916396 MDL-27071 Allow Oracle IN() to use > 1000 items
By using a pivoting strategy, we modify the list
of params (QM and NAMED supported) into a
subquery, so the 1000 limit in Oracle (ORA-01795)
is not thrown anymore.
2013-04-29 01:22:38 +02:00
Sam Hemelryk
0c5d8ccb9a Merge branch 'w17_MDL-39336_m25_install' of git://github.com/skodak/moodle 2013-04-29 11:15:05 +12:00
Eloy Lafuente (stronk7)
9b2ebc4587 MDL-27071 Add big IN() unit tests
Let's verify how all databases perform with a big
number of parameters (10000) using IN() SQL clauses.
Both using QM and NAMED parameters.

Ideally only Oracle fails, and only it will need fixing.
2013-04-29 01:11:10 +02:00
Sam Hemelryk
036b18a297 Merge branch 'MDL-39355-m' of git://github.com/andrewnicols/moodle 2013-04-29 11:07:26 +12:00
Yuliya Bozhko
7e06ea6ab4 MDL-39207 badges: Generate badge assertions using user's backpack email if it is set 2013-04-29 10:15:30 +12:00
Petr Škoda
c2140b5d95 MDL-39356 add ca certificate bundles for cURL
This is necessary because PHP in Windows does not have any certificates and some *nix systems have outdated or missing ca bundles too.

The order is:
1/ dataroot/moodleorgca.crt always wins - needs to be added manually by admin
2/ php.ini setting "curl.cainfo" is next
3/ on Windows libdir/cacert.pem is used because it does not have any default cert bundles
4/ system default is the last - the previous value, ok for properly configured *nix systems
2013-04-28 20:58:58 +02:00
Eloy Lafuente (stronk7)
bae2846c2c MDL-39390 delete old moodle_database column cache
With MDL-39389 all the remaining drivers have been moved
from the in-memory, per-request ::columns cache to
the MUC (databasemeta) alternative.

That makes the old cache unused, so this is, simply about to
delete it, and warn in upgrade notes for potential sites
using custom moodle_database drivers.
2013-04-28 18:33:33 +02:00
Eloy Lafuente (stronk7)
f33d4784fe MDL-39389 add databasemeta cache to pdo_sqlite
Done in a separate commit, coz this driver is not
truly supported, but considering it as a reference
for people developing drivers... it's better to
have it supporting the databasemeta cache.
2013-04-28 18:14:17 +02:00
Eloy Lafuente (stronk7)
9043466103 MDL-39389 add databasemeta cache to ms/oci drivers 2013-04-28 18:12:38 +02:00
Petr Škoda
f869cb2326 MDL-39077 add more unit tests for get_max_upload_sizes() 2013-04-27 16:08:15 +02:00
Petr Škoda
5520fc9526 MDL-39077 fix regression in previous commit, the limit should be always included in maxbytes 2013-04-27 16:00:59 +02:00
Damyon Wiese
7adfadc6b8 MDL-39077 get_max_upload_sizes always include option for 0
Always include an option for 0 in the list of bytes even if sitebytes is not set.
2013-04-27 15:54:41 +02:00
Petr Škoda
ca5d6066a7 MDL-39336 some themes may use $SITE->shortname in page layout before installation finishes 2013-04-26 21:33:15 +02:00
Petr Škoda
ec3ce3a97d MDL-39336 do not print debug output before finishing installation 2013-04-26 21:33:15 +02:00
Tim Hunt
328ac3069b MDL-39378 Improve s() performance.
These changes give about a 10% speed-up in this function. The significant changes are:
1. Simplify the if logic to remove unnecssary cases.
2. Dont pass default argument values to htmlspecialchars, just using the
   defaults is faster.
3. I can confirm that /i regex is faster than the equivalent regex without the i.

I also added more unit tests to test the edge cases.
2013-04-26 18:49:25 +01:00
Tim Hunt
0c6f9e759b MDL-39378 s(): fix bad hex regex 2013-04-26 18:38:29 +01:00
Valeriy Streltsov
1977123ea5 MDL-39335: add an ord() unicode analog to textlib. 2013-04-26 12:12:03 +00:00
Charles Fulton
ef8a733aa6 MDL-36024 enrol: enable grade recovery for all enrol plugins 2013-04-26 05:08:23 -07:00
Tim Hunt
a72e05ce9c MDL-39351 collapsed editor had grey bars above and below. 2013-04-26 11:55:56 +01:00
Tim Hunt
15dedb1168 MDL-39246 JavaScript: store the time the page starts loading.
This helps synchronise time on the client side with time on the server.
If you wait until a js_init_call runs, you might have had to wait an
unknown number of seconds while all the JS loads. Therefore, we capture
the current time as soon as possible in <head>.

This is a bit like adding .jsenabled to <body> as soon as possible, to
reduce visual flicker.
2013-04-26 11:55:17 +01:00
Dan Poltawski
1c97061a35 MDL-39341 boostrapbase: fix some missing renames 2013-04-26 09:54:21 +01:00