I added a destructor to csv_import_reader ensure the file is closed.
I also ensured that the gradeimport_csv unit tests did not hold onto a
reference to the csv_import_reader object while the phpunit framework
tries to tidy up moodledata.
Finally, to stop CiBoT complaining, I fixed up the PHP4-style
declarations in the CSV import class.
Fixing the upgrade script so that they attach the new blocks
to the right my_pages entry. An upgrade script has also been
added to fix the existing bad data.
Postgres and MySQL treat values that are null differently
when sorting. MySQL will sort null values above fields with
values and Postgres will be vice versa. I removed the checks
against the Admin User.
Oracle treats lower case values different to upper case values
and so I have modified the test so that all Names start with
an Uppercase letter.
Also, ensure that clicking the + icon adds the question on the right
page.
Bit of this fix are a bit hacky, but we have to deal with the fact there
is not a good general solution to MDL-47604.
When upgrading from 'Sum of grades' to natural aggregation the
weights were no automatically assigned and the grade totals were
wrong. This has now been rectified.
For some reason, Safari behaves incorrectly when dealing with RTL content
where the table has a max-width of 100%.
This issue is a part of the MDL-25544 Epic.
Even if the navbar is in a static header, it should only be respected if it
is fixed still.
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
As part of this, I tweaked the LTR style a bit, in a way that is both an
improvement (I hope) and also to reduce the amount of RTL-specific code
required. (Thanks to Fred for spotting some of the problems.)
Also, I changed one course style in boostrapbase, where the RTL rule was
different from the LTR rule.
Finally, I saw some repeated RTL rules in the quiz styles.css, and so
eliminated the the duplicate rules.
If a handler is disabled, the user should be informed of this issue.
This issue is a part of the MDL-47194 Task.
This issue is a part of the MDL-39707 Epic.
