26422 Commits

Author SHA1 Message Date
nicolasconnault
5fad506139 MDL-9629 Category edit page now implements delete, show/hide, lock/unlock, moveup/movedown and move actions. The edit icon is also shown but not yet implemented. 2007-06-01 04:02:37 +00:00
toyomoyo
83a021c10a adding some form headers to help read 2007-06-01 02:44:34 +00:00
skodak
b5ebd0962f bgufixing and external grading improvements 2007-05-31 20:34:41 +00:00
csantossaenz
3b2c6f99b6 Fixed a problem with cmi.interactions.n.objectives.n.id duplicated ids 2007-05-31 16:24:53 +00:00
toyomoyo
0afbd23c9e gradebook backup and restore fixes 2007-05-31 09:00:09 +00:00
nicolasconnault
88e794d6c8 MDL-9628 Move work on the category edit page 2007-05-31 08:57:05 +00:00
thepurpleblob
caa99ee735 Fixed typo stopping image importing working 2007-05-31 08:32:07 +00:00
nicolasconnault
0fc7f62445 MDL-9506 MDL-9137 MDL-9629
Added a number of small getters and setters to grade_item and grade_category, to hide the structural differences between the two, and provide a common interface for cases when we are not sure whether an $object is of one type or another.
The grade_tree::renumber() method now adds complete objects to the need_update array, because both grade_category and grade_item need to update their parent field when moved to a different parent. Amazingly, these important changes worked straight away (after 1 hour of coding without testing anything), and all the unit tests passed!
2007-05-31 03:15:43 +00:00
skodak
bffe39c6d5 MDL-4687 Password expiration support for AD (with patch) - patch by Iñaki Arenaza, thanks! 2007-05-30 08:54:52 +00:00
skodak
66fc70dd2e MDL-9954 LDAP auth settings form problem with 'Member Attribute' and 'Member Attribute uses dn'; patch by Iñaki Arenaza - thanks! 2007-05-30 08:49:19 +00:00
nicolasconnault
5bfa0d793a Implemented a test version of the gradebook category edit page, and developed the get_edit_tree method in grade_tree. Items can be successfully moved up and down, and a "move" button lets the user select a source element, then a destination box. All actions use POST. 2007-05-30 08:48:11 +00:00
skodak
81fb221d31 MDL-9626 Enable user signup with Active Directory (via LDAP); patch by Iñaki Arenaza - thanks! 2007-05-30 08:47:00 +00:00
toyomoyo
ca9cd23cf9 more fixes for gradebook backup/restore 2007-05-30 08:45:13 +00:00
toyomoyo
48ca6fd871 fix ordering bug when restoring grade item 2007-05-30 06:38:23 +00:00
toyomoyo
9bfd009441 added itemtype to backup/restore, only restore a mod type gradeitem if user data is included 2007-05-30 06:23:21 +00:00
nicolasconnault
c3096060de MDL-9506 Added ksort() of each level of categories and items for the gradebook. Unsorted arrays caused erratic behaviour when moving elements of the tree around. 2007-05-30 05:47:26 +00:00
toyomoyo
bb15b33bf9 respecting sortorder when restoring grade_itmes, other minor fixes 2007-05-30 05:32:47 +00:00
nicolasconnault
a3d5594248 MDL-9506 Refactored grade_tree::get_tree by doing the following:
- Extracted the $fillers array into a class variable
- Extracted the addition of elements to grade_tree::fillers into a new add_fillers($array) method
- Extracted the inclusion of fillers into the tree_array to a new include_fillers($tree, $object=NULL) method
- Removed the building of the tree_filled, which was already performed by build_tree_filled()
- Removed the generation of next_sortorder and previous_sortorder attributes, which was already performed by renumber()
Result is a much leaner and scalable set of methods, and a tighter definition of responsibilities for the varying classes. I think I have also noticed a significant inprovement in speed.
2007-05-30 03:09:38 +00:00
toyomoyo
770156e5f8 fixing a typo 2007-05-30 02:22:43 +00:00
toyomoyo
a246d4d269 during backup parent categories need to go before children 2007-05-30 02:20:56 +00:00
wildgirl
dde9f3e1a3 typo fix MDL-8093 2007-05-29 17:26:45 +00:00
thepurpleblob
2377f8dcd4 MDL-9716
'answernumbering' field now supported
2007-05-29 15:19:12 +00:00
csantossaenz
ef24d5b8fd Fixed problem with cmi.interactions.n.id duplicated ids 2007-05-29 11:22:49 +00:00
dwoolhead
6cc1a80532 MDL-9729 Ensure start of week day calculation observes user timezone setting in the same way as month start and end dates. Prevents incorrect display of dates (1 out) on main Moodle calendar display although mini calendar display is correct. (Merged from 1.8 stable branch) 2007-05-29 09:56:44 +00:00
toyomoyo
bc1637c730 restore for gradebook, needs testing for grade_history, outcomes, categories, calculations and text 2007-05-29 09:00:48 +00:00
jamiesensei
dc1f768351 reverting commit 1.889 "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary. 2007-05-29 06:27:38 +00:00
jamiesensei
d65cb30f63 reverting last commit "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary. 2007-05-29 06:14:09 +00:00
jamiesensei
24a905f98b fixed bug in parsing urls 2007-05-29 06:14:09 +00:00
nicolasconnault
646323549e MDL-9506 Resolved recursion issues in grade_tree:renumber and grade_tree::get_neighbour_element. Unit tests all pass now. 2007-05-29 04:07:04 +00:00
nicolasconnault
de420c11c5 MDL-9317 Applying Petr's second patch 2007-05-29 00:56:44 +00:00
mark-nielsen
e72be0548e Merging in changes for MDL-9947 and MDL-9923 from MOODLE_18_STABLE 2007-05-28 18:55:15 +00:00
jamiesensei
099f7fb6ca added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE. 2007-05-28 14:25:40 +00:00
jamiesensei
b1a61961aa MDL-9745 "Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen." Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problem MDL-9745 with form elements in groups. Second part of commit in HEAD, missed a bit in HEAD. 2007-05-28 14:21:09 +00:00
bobopinna
416050aa9a patched a parse error 2007-05-28 12:53:42 +00:00
jamiesensei
5eb1924f01 MDL-9745 Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen. Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problems with form elements in groups. 2007-05-28 12:17:40 +00:00
skodak
7bddd4b787 MDL-9632; MDL-9545 basic assignment grading support - event triggers implemented + some minor cleanup 2007-05-28 08:55:15 +00:00
skodak
37db0ab8f8 MDL-9960 update_record() does not store NULLs; I hope it will not break anything 2007-05-28 08:49:40 +00:00
skodak
b5b65852c6 apply magic quotes before using var in sql query in fetch_all_using_this() 2007-05-28 08:20:07 +00:00
bobopinna
27a46315e2 Added the starting point for CMIFeedback type checking 2007-05-28 08:18:25 +00:00
nicolasconnault
c91ed4be0d MDL-9506 Category and Item now set their own courseid if not set explicitly, and if they have enough information from
other sources. category::set_as_parent has a new constraint: cannot set over children from different courses.
Applied recursion to grade_tree::renumber(), but still some fine-tuning to do, since only grade_items are getting updated in DB.
2007-05-28 08:00:19 +00:00
nicolasconnault
d990776605 MDL-9137 Applied parts of Petr's patch on the gradebook objects. Unit tests unaffected. 2007-05-28 02:05:21 +00:00
nicolasconnault
526e1a8a25 MDL-9506 Corrected a number of small errors in unit tests and classes. 2007-05-28 01:26:58 +00:00
jamiesensei
3673f6bc3b added more phpdoc comments for hardFreezeAllVisibleExcept 2007-05-28 00:50:11 +00:00
jamiesensei
56015454dd new method hardFreezeAllVisibleExcept 2007-05-28 00:46:11 +00:00
nicolasconnault
4e83465eed Removed non-standard :endif notation. 2007-05-28 00:22:17 +00:00
skodak
271c7a98bc MDL-9959 debugging() shows warnings when called from call_user_func() functions
MDL-9958 addslashes_recursive() and stripslashes_recursive() modifies function parameter in PHP5
2007-05-27 22:55:52 +00:00
bobopinna
36938e1a67 fixed translation file for othersettings string 2007-05-27 21:24:51 +00:00
bobopinna
8e4838ffd7 Fixed some bugs that block ADL test suite
Still to fix ex CMIFeedback type
2007-05-27 21:22:27 +00:00
bobopinna
d7ffd685d2 added a new string for exit activity instead using the old one 2007-05-27 17:13:16 +00:00
bobopinna
bb8f14335a Added exitactivity link in navigation bar 2007-05-27 17:08:54 +00:00