347 Commits

Author SHA1 Message Date
mudrd8mz
0a39261b8e MDL-19877 adding a script producing a test PDF 2009-07-20 17:32:44 +00:00
tjhunt
1c5648f169 todochecker: don't match variables called $todo or fields called ->todo. 2009-07-17 07:40:54 +00:00
tjhunt
6180cdc97a todochecker: Match todo case-insensitively :-( that finds a lot more. 2009-07-17 07:26:12 +00:00
tjhunt
05280d5f97 todochecker: bug summary in tool tip. 2009-07-17 07:19:43 +00:00
tjhunt
a89d8e0709 todochecker script: skip third party code. 2009-07-17 05:56:49 +00:00
tjhunt
1d13c75c15 blocks editing ui: MDL-19398 Can how precisely control block positioning using the edit icon
This mostly works now, but ...
* The UI needs further work. In particular we need a non-advanced mode.
* This only works for blocks that use a new edit_form.php to replace config_instance.html.
* .. and so far I have only implemented edit_form.php for the HTML block so far.
* Needs to be enabled (with no block-specific config) for blocks without instance config, so you can control their positioning.
2009-07-16 10:50:19 +00:00
nicolasconnault
5daf5d3589 MDL-19840 Fixed a bug in regex delimiter quoting 2009-07-16 03:21:19 +00:00
tjhunt
4bea5e8582 moodlellib: MDL-19828 PARAM_LOCALURL should accept URLs like course/view.php?id=2 2009-07-15 06:17:39 +00:00
tjhunt
485e46611a Fix block manager unit tests. 2009-07-14 04:18:58 +00:00
tjhunt
aa2e96e9ce developer tools MDL-19772: Script to list all todos in code
And make sure they link to an open tracker issue as per
http://docs.moodle.org/en/Development:Coding_style#TODO_comments_must_link_to_a_tracker_issue
2009-07-13 04:27:05 +00:00
mudrd8mz
897b5c820b MDL-19731 get_renderer() accepts optional subtype
The initial patch has been reviewed at the issue page. This commit also
fixes template_renderer_factory::get_renderer() and sets up folders for
subtypes there.
2009-07-08 09:37:06 +00:00
tjhunt
ebebf55cad output: MDL-19690 icon_finder classes and $OUTPUT->mod/old_icon_url
This is ready to replace $CFG->pixpath and $CFG->modpixpath soon.
2009-07-02 08:49:25 +00:00
tjhunt
db8d89d822 MDL-19077 I just found a way to reduce the coupling between the classes. 2009-07-02 07:06:25 +00:00
tjhunt
b2104e9799 Fix typo 2009-06-30 12:29:14 +00:00
tjhunt
c84a2dbea2 MDL-19077 - change how $OUTPUT is initialised.
Please read the comment at the top of bootstrap_renderer in setuplib.php
2009-06-29 05:00:45 +00:00
stronk7
081a63a9eb MDL-19579 code coverage - add more initial $includecoverage attributes 2009-06-26 17:49:15 +00:00
tjhunt
82bba20e55 themes: MDL-19077 fix unit test regression 2009-06-26 10:26:31 +00:00
tjhunt
34a2777ccb themes: MDL-19077 new $OUTPUT->header/footer to replace print_header/footer.
Also, part of the change from weblib.php functions to $OUTPUT-> methods.

This is part of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F

This is a big change, and the result is not perfect yet. Expect some debugging output
on some pages.

The main part of these changes are that $OUTPUT->header now looks for a file
in the theme called layout.php, rather than header.html and footer.html. Also
you can have special templates for certain pages like layout-home.php. There is
fallback code for Moodle 1.9 themes, so they still work.

A few of the old arguments to print_header are no longer supported. (You get an
exception if you try to use them.) Sam H will be cleaning those up.

All the weblib functions that have been replaced with $OUTPUT-> have version in
deprecatedlib, so existing code will go on working for the foreseeable future.
2009-06-26 09:06:16 +00:00
tjhunt
88b02e3b22 Remove experimental part of string_manger. Also, improve class comment. 2009-06-25 04:02:36 +00:00
tjhunt
8954245a1b themes: MDL-19077 start implementing moodle_core_renderer
Only a couple of methods implemented. Please review the API and
tell me if you are not happy with the direction I am taking.
2009-06-23 10:41:22 +00:00
stronk7
db3a1eb8fd MDL-19579 code coverage - prepare ddl & moodlelib tests to support code coverage 2009-06-23 09:30:59 +00:00
tjhunt
73af8b1139 Fix notice in blockmanager unit tests. 2009-06-22 07:26:50 +00:00
tjhunt
8e8b806600 Fix some problems with the filelib unit tests, and stop hiding the true cause of another failure. 2009-06-22 07:17:59 +00:00
tjhunt
b44b6c4599 Fix accesslib unit tests. 2009-06-22 07:16:26 +00:00
tjhunt
9fa62210e8 Fix pagelib unit tests. 2009-06-22 06:30:21 +00:00
nicolasconnault
31c2087d1e MDL-19566 Refactored some of the more complex regular expressions in their own function and added unit tests for them. 2009-06-22 06:07:56 +00:00
tjhunt
64208b5de5 MDL-16438 fix string manager unit tests. 2009-06-22 06:03:53 +00:00
nicolasconnault
6dbcaceef1 MDL-19418 Replaced ereg* by preg* 2009-06-22 01:22:37 +00:00
tjhunt
571fa82824 themes: MDL-19077 implement the renderer_factory instrastructure.
This is part of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F

The concept is that all the print_... functions in weblib get replaced  by methods
on a moodle_core_renderer class. Then, the theme can choose whether to
use the standard moodle_core_renderer class, or another implemenatation of
its own choosing, to generate different HTML.

Also, becuase Moodle is modular, we may need a moodle_mod_forum_renderer
and so on.

In order for the theme to be able to choose which renderers get created, we
introduce the concept  of a renderer factory, as in the factory design pattern.
The theme will choose which factory should be used, and that then creates
the renderer objects based on the module name.

This commit includes 4 types of factory:
* standard_renderer_factory
* custom_corners_renderer_factory
* theme_overridden_renderer_factory
* template_renderer_factory

All this with unit tests and PHP doc comments.

Note, this new code is not actually used yet. Still todo:
1. actually define the moodle_core_renderer class, and deprecate a lot of weblib functions.
2. make theme_setup initialise everything, so it is used.
2009-06-18 10:43:13 +00:00
tjhunt
32941d74c8 Move extra ajaxlib unit tests to the right place. 2009-06-17 07:35:33 +00:00
tjhunt
1ee9d0d764 Fix boilerplate. 2009-06-17 07:32:18 +00:00
fmarier
3e83641fdc MDL-2794 testweblib: adapt the unit tests to the output of new html2text library 2009-06-15 06:08:42 +00:00
jerome
2b06294b9a authentication MDL-19182 split auth.php lang file into multiple files separate for each plugin 2009-06-11 03:34:46 +00:00
skodak
bf8e93d704 MDL-18293 $DB->somethiong is using exceptions, no need for ifs tehre, removing useless strings 2009-06-03 20:00:08 +00:00
skodak
1aa01caf90 MDL-16231 reimplemented deleting of files + cron cleanup 2009-06-03 08:10:21 +00:00
skodak
4eef139962 MDL-14589 file browsing refactoring - moving url encoding to filelib.php for now 2009-05-20 22:32:02 +00:00
tjhunt
bb46a4fa2a blocklib: MDL-19010 refactor blocklib to use block_manager to get the blocks for rendering 2009-05-06 09:15:05 +00:00
tjhunt
08eab89703 blocklib: MDL-19010 add block and get_blocks methods 2009-05-06 09:14:42 +00:00
tjhunt
86b5ea0f85 blocklib: MDL-19010 start of block_manager - get and set regions 2009-05-06 09:14:01 +00:00
tjhunt
c33db6e690 moodle_page: MDL-12212 clarify some comments 2009-05-06 09:13:40 +00:00
tjhunt
93d4a373f9 blocklib: MDL-19010 always include blocklib in setup.php, stip includes elsewhere 2009-05-06 09:13:16 +00:00
tjhunt
5ed70539f9 moodle_page: MDL-12212 ->subpage field 2009-05-06 09:03:49 +00:00
tjhunt
5ec434a9c2 moodle_page: MDL-12212 ->cm and ->activityrecord fields 2009-05-06 09:03:33 +00:00
tjhunt
934524d70b moodle_page: MDL-12212 new implementation of user_allowed_editing 2009-05-06 09:01:42 +00:00
tjhunt
830dd6e9cd moodle_page: MDL-12212 reimplement user_is_editing, deprecate isediting 2009-05-06 08:59:29 +00:00
tjhunt
ad52c04f4c moodle_page: MDL-12212 Kill legacy url_... and blocks_... methods
Start calling $PAGE->set_url in all the places it will be necessary
Start of a stub implementation of $PAGE->blocks to stop other things breaking
Remove some of the special case methods in admin_page
2009-05-06 08:55:53 +00:00
tjhunt
75781f879c moodle_page: MDL-12212 ->url and cleanup init of $FULLME, etc. 2009-05-06 08:50:32 +00:00
tjhunt
82611d8d33 moodle_page: MDL-12212 ->docspath 2009-05-06 08:48:13 +00:00
tjhunt
d7ab887938 moodle_page: MDL-14306 (part of MDL-12212) class name on body with ->category
If ->allowcategorythemes is set, includes all parent categories too
2009-05-06 08:46:48 +00:00
tjhunt
948203a5e8 moodle_page: MDL-12212 ->category and ->categories 2009-05-06 08:46:05 +00:00