3442 Commits

Author SHA1 Message Date
Kyle Matter
68ef883354 MDL-50650 core_grades: allow grade imports larger than 100 points 2023-12-04 12:34:44 +08:00
Andrew Nicols
525212f2d2
MDL-78496 core: Address phpcs issues with upgrade.php files 2023-11-19 21:20:53 +08:00
Andrew Nicols
545b36cd4a
MDL-78496 upgrade: remove all the < 4.1.0 upgrade steps
Also includes an upgrade step to prevent upgrading from any
version < 2021112802 (v4.1.0) as anti-cheating measure.
2023-11-17 23:25:36 +08:00
Ilya Tregubov
ddd19a3bf2
Merge branch 'MDL-80121-main' of https://github.com/junpataleta/moodle 2023-11-16 10:00:39 +08:00
Jun Pataleta
3bb574b35a
MDL-80121 gradereport_singleview: Increase zero-state heading level
With the h2 heading not being rendered on the zero-state pages of the
Single view report, we need to increase the heading level of the
"Search for a user to view all their grades" and
"Select a grade item above" headings from h3 to h2.
2023-11-15 19:22:57 +08:00
Jun Pataleta
51a6181e16
MDL-80121 grade: Trim heading
In order to prevent rendering an empty heading <h2>, we need to make
sure that the $heading parameter passed to print_grade_page_head() is
not an empty string.
2023-11-15 19:20:55 +08:00
Jake Dallimore
c65f392532
Merge branch 'MDL-76588-master-2' of https://github.com/ilyatregubov/moodle 2023-11-15 12:10:59 +08:00
Ilya Tregubov
44f1937c57
Merge branch 'MDL-71941-master' of https://github.com/lucaboesch/moodle 2023-11-06 13:43:43 +08:00
Huong Nguyen
dfa2fd8445 Merge branch 'MDL-79062-master-2' of https://github.com/junpataleta/moodle 2023-11-06 10:51:05 +07:00
Ilya Tregubov
e37eb30a09
MDL-76588 gradereport_summary: Summary report hack
This is a hack since average is not correct for summary report
when we have suspended users. But since we don't want to change
display to user - it is set to match 4.1 behavior.
2023-11-03 13:46:43 +08:00
Ilya Tregubov
4cae211e4a
MDL-76588 gradereport_user: Deprecate calculate_averages
Calculate_average is used instead.
2023-11-03 12:40:55 +08:00
Ilya Tregubov
4a0770d0ca
MDL-76588 gradereport_grader: Deprecate get_right_avg_row
Calculate_average is used instead.
2023-11-03 12:40:50 +08:00
Ilya Tregubov
d47c36b28b
MDL-76588 core_grades: Refactor calculate_average for hidden grades case.
On grader report we include hidden grades in averages calculations.
On user report we don't include hidden grades. So to allow using of
calculate_averages it needs to be refactored for this case.

We also have to add group id param to calculate_average since for
grader report we calculate both overall average and group average
2023-11-03 12:40:46 +08:00
Luca Bösch
1e2300fbd6 MDL-71941 core_grades: use 'gradenoun' core string 2023-11-02 16:02:32 +01:00
Jun Pataleta
99bcfc1cdb
MDL-79062 grade: Behat test fixes
* Feature: We can use a minimum grade different than zero
  - Use correct minimum input values.
  - Use data generators for faster test execution.
* Scenario: Disable category overriding
  - Use the field name to ensure that the correct field is being tested.
2023-11-02 17:33:31 +08:00
Jun Pataleta
a8dcfdcbce
MDL-79062 grades: Sort-by-name menu item accessibility fixes
* <h6> tags cannot be in table cells. Replace them with <div> tags.
* Group the ascending/descending sort menu items to better indicate
where they belong to.
2023-11-02 17:33:31 +08:00
Jun Pataleta
8b39ae9369
MDL-79062 gradereport_grader: Set numeric type for grade value inputs
* Set grade inputs for grade items with type set to GRADE_VALUE to
number and add min and max input attributes, where necessary.
2023-11-02 17:33:31 +08:00
Jun Pataleta
ab08ac740c
MDL-79062 gradereport_grader: Remove setting of tabindex >= 1
Tab indices that are greater than or equal to 1 break the natural
tab order of the document and may cause problems for keyboard users.
2023-11-02 09:50:00 +08:00
Ilya Tregubov
02878ebd9c
MDL-77326 gradereport_summary: Fix modinfo.
Also deprecate methods properly.
2023-10-31 10:15:06 +08:00
Ilya Tregubov
9df50931e0
MDL-77326 gradereport_summary: Use appropriate icons. 2023-10-31 10:15:06 +08:00
Ilya Tregubov
f44338eda0
MDL-77326 core_grades: Refactor grade report functions.
Those should be reusable
2023-10-31 10:15:05 +08:00
David Woloszyn
b3b45e31cd MDL-42189 gradereport_overview: Report hidden from suspended enrolments 2023-10-23 09:45:27 +11:00
Huong Nguyen
13f1247bc0 Merge branch 'MDL-78775-master' of https://github.com/ilyatregubov/moodle 2023-10-20 09:29:15 +07:00
Ilya Tregubov
ff4f9bf9a2
MDL-78775 gradereport_grade: Fix Behat.
Sort by lastname before doing any assertions.
2023-10-20 09:55:20 +08:00
Huong Nguyen
2f147dcd30 Merge branch 'MDL-78775-master' of https://github.com/ilyatregubov/moodle 2023-10-18 12:55:22 +07:00
Ilya Tregubov
cb2cf0602d
MDL-78775 core_grades: Fix Behat 2023-10-18 12:54:28 +08:00
Huong Nguyen
b3f32d6ad7 Merge branch 'MDL-78775-master' of https://github.com/ilyatregubov/moodle 2023-10-17 10:46:25 +07:00
Huong Nguyen
7d55464846 Merge branch 'MDL-79653-master' of https://github.com/andelacruz/moodle 2023-10-16 10:54:15 +07:00
Ilya Tregubov
9048eb1e53
MDL-78775 core_grades: Fix saving on grader report page
When we have a pagination on grader page and search for user
that is not on first page, saving was throwing an error
since page didn't have enough data
2023-10-13 14:08:31 +08:00
Angelia Dela Cruz
2f728f2c0f MDL-79653 gradingform_guide: Behat coverage for deleting marking guide 2023-10-13 10:31:38 +08:00
Jun Pataleta
9beff03a96
MDL-79626 upgrade: add the 4.3.0 separation line to all upgrade scripts 2023-10-10 10:44:17 +08:00
Sara Arjona
02d5e79b6f
Merge branch 'MDL-79613-master' of https://github.com/snake/moodle 2023-10-06 08:31:11 +02:00
Jake Dallimore
12fa9a8d22
MDL-79613 core_grade: revert the removal of searchwidget templates
These templates are needed by plugins which use the now-deprecated
searchwidget (located in grade/amd/src/searchwidget/basewidget.js)
in order to keep that deprecated widget working during the deprecation
time period. This also clarifies the js deprecation notice.
2023-10-06 12:22:33 +08:00
Sara Arjona
9877a06246
Merge branch 'MDL-79551-master-rc' of https://github.com/junpataleta/moodle 2023-10-04 12:28:14 +02:00
Jun Pataleta
d5d7835a0a
MDL-79551 versions: Make CiBoT happy
* Use array short syntax for $plugin->dependencies
* Add trailing comma for multi-line $plugin->dependencies array
2023-10-04 14:04:29 +08:00
Jun Pataleta
94bc2cd38b
MDL-79551 versions: bump all versions and requires near release 2023-10-04 13:57:17 +08:00
Paul Holden
f5f6ce375e MDL-79426 gradeimport_csv: safely preview CSV content during import. 2023-10-04 01:24:20 +00:00
Jake Dallimore
d7c348cfe1
Merge branch 'MDL-79056-master' of https://github.com/junpataleta/moodle 2023-10-03 12:02:52 +08:00
Huong Nguyen
96b03bc501
Merge branch 'MDL-79555-master' of https://github.com/ilyatregubov/moodle 2023-10-03 09:44:04 +07:00
Ilya Tregubov
f591de2b58
MDL-79555 core_grades: Remove copy pasted code.
Seems that data from form was overridden for no reason.
2023-10-02 17:31:43 +08:00
Ilya Tregubov
c80e366051
Merge branch 'MDL-79458-master' of https://github.com/ferranrecio/moodle 2023-10-02 13:30:07 +08:00
Jun Pataleta
7998d80302
MDL-79056 gradereport_user: Make column heading IDs unique
Associate column headings of user report tables to the user ID that the
report is being generated for. This will prevent duplicate IDs for the
report columns when multiple user report tables are displayed on the
User report page.
2023-09-29 11:03:14 +08:00
Jun Pataleta
af22c038b7
MDL-79056 gradereport_user: Set grade category and item names as th
* The table cells mentioned in the `headers` attribute of other table
cells need to be using the table header <th> tag. Otherwise, HTML
validation fails.
2023-09-29 11:03:14 +08:00
Huong Nguyen
f61b060182
Merge branch 'MDL-78813-master' of https://github.com/mihailges/moodle 2023-09-28 12:01:25 +07:00
Jun Pataleta
3c7b5c983e
Merge branch 'MDL-78905-master' of https://github.com/mihailges/moodle 2023-09-27 23:34:05 +08:00
Mihail Geshoski
65b75f18cc MDL-78813 gradereport_grader: Revert border-top-width css change
Revert the modification of the border-top-width css attribute
to the grader table and the table header. This change seems to
be unnecessary.
2023-09-27 10:02:03 +02:00
Mihail Geshoski
8b9efc3135 MDL-78813 gradereport_grader: Make the average row sticky again
After MDL-75762 the overall average row in the grader report
was no longer properly pinned and hidden behind the sticky footer.
This change ensures that the overall average row is pinned again
at the top of the sticky footer when vertically scrolling. Also,
leveragning on the new sticky footer 'toggled' event it is making
sure that the row is properly pinned on narrower screens where the
sticky footer appears and disappears dynamically when scrolling.
2023-09-27 10:02:03 +02:00
Kevin Percy
01687d9125 MDL-78813 gradereport_grader: Fixed help icon covering course average 2023-09-27 10:02:03 +02:00
Mihail Geshoski
867e05ea34 MDL-78905 grades: Carry over form data without validation
Avoids validating form data which is carried over from the
simple dynamic form to the advanced form page when creating
or editing grade items, categories and outcomes in the
Gradebook setup.
2023-09-27 09:19:40 +02:00
Ferran Recio
0184a477d5 MDL-79458 output: fix action menu subpanel behats 2023-09-26 13:22:51 +02:00