1338 Commits

Author SHA1 Message Date
David Monllao
974053b93f MDL-48881 mod_lesson: A couple of performance improvements
- Improve memory usage on db drivers not able to use recordsets
  properly
- !array_key_exists replaced by empty calls
2015-09-16 13:32:49 +08:00
David Monllao
48cec36dfb Merge branch 'MDL-48881_m30v5' of git://github.com/sbourget/moodle 2015-09-16 13:20:52 +08:00
David Monllao
742548e251 Merge branch 'wip-mdl-51101' of git://github.com/rajeshtaneja/moodle 2015-09-14 16:18:01 +08:00
Rajesh Taneja
1a5a476b03 MDL-51101 behat: Fixed wrong hover step usage
Hover step was being mis-used for checking activity completion
This is replaced with proper step which check for img element
2015-09-10 14:46:12 +08:00
rajesh Taneja
cd3a6a78b6 MDL-50516 behat: Back/next button reloads page
When next/back button is pressed in phantomjs/browserkit
it reload page, so adding a bug_phantomjs, so that we can
test the lesson re-attempt scenario
2015-09-10 14:30:28 +08:00
Mark Nelson
ab2d8946cd MDL-50516 mod_lesson: changes to existing behat tests 2015-09-09 15:27:24 +08:00
Mark Nelson
ecaff8f042 MDL-50516 mod_lesson: added behat tests 2015-09-09 15:27:23 +08:00
Mark Nelson
139645d4a7 MDL-50516 mod_lesson: fixed issue with grade not using minquestions
It's possible to reach the end of the lesson, get your result,
click back until you get to the last question, answer it correctly
and then be awarded a result of 100%. This was because the grade
calculation would only include the questions answered, rather than
all of them in the lesson. However, you can not fix this by always
grading by the amount of questions in the lesson as some lessons
bypass certain questions depending on the answer to previous ones.
The minquestion setting can now successfully be used to prevent this
behaviour by rewording the misleading string and adding logic.
2015-09-09 15:27:23 +08:00
Mark Nelson
d60350ddac MDL-50516 mod_lesson: prevented deletion of previous attempts
The 'startlastseen' flag was removing any previous attempts
the user had from the DB. This meant that the user could
simply re-answer the question, regardless of the number
of attempts allowed.
2015-09-09 15:27:23 +08:00
Mark Nelson
0dea8ed76a MDL-50516 mod_lesson: prevented user from repeating question
It was possible in the lesson module for a user to
answer a question, get the result, then click back
in the browser and re-answer it, even if they exceeded
the number of attempts allowed per question.
2015-09-09 15:27:23 +08:00
Stephen Bourget
0a3c1f79ca MDL-48881 Lesson: Show all attempts on reports. 2015-09-08 21:09:09 -04:00
Eloy Lafuente (stronk7)
1b5034025b Merge branch 'MDL-51148-master-enfix' of git://github.com/mudrd8mz/moodle 2015-08-27 12:46:11 +02:00
Helen Foster
ce2c0f3a74 MDL-51148 lang: Merge English strings from the en_fix language pack 2015-08-26 16:46:43 +02:00
Dan Poltawski
ee9b9ffd51 Merge branch 'MDL-49701' of git://github.com/jmvedrine/moodle 2015-08-24 15:14:15 +01:00
Andrew Nicols
711b1d6b3e MDL-51100 behat: Remove javascript tag from usermenu steps
These tests only needed the javascript tag because of the user menu.
Now that issue has been resolved, they do not need it.

Note: Some were also not using the singleselect feature, so would fail
without changes to use this too as they were not handling proper selection
of the singleselect element.
2015-08-14 08:52:29 +08:00
Eloy Lafuente (stronk7)
6d2ccd352f Merge branch 'MDL-44840-master' of git://github.com/lameze/moodle 2015-08-05 20:46:59 +02:00
Jean-Michel Vedrine
66cf47a045 MDL-49701 mod_lesson: open time should be before close time 2015-08-02 10:33:04 +02:00
Jean-Michel Vedrine
297b32905c MDL-50515 mod_lesson: Can't remove content buttons from content page 2015-08-02 09:32:34 +02:00
Jean-Michel Vedrine
239e9eb8f6 MDL-44840 mod_lesson: fix import of truefalse questions 2015-07-29 11:04:55 +08:00
Andrew Nicols
ad913a2d97 Merge branch 'MDL-49581_m30v4' of https://github.com/sbourget/moodle 2015-07-29 09:32:11 +08:00
Stephen Bourget
58459ff0f0 MDL-49581 Lesson: Remove high score unit tests. 2015-07-28 17:06:02 -04:00
Dan Poltawski
099dd967aa Merge branch 'MDL-49581_m30v3' of https://github.com/sbourget/moodle 2015-07-28 10:48:11 +01:00
Stephen Bourget
bb685cf3fa MDL-49581 Lesson: Remove broken high score function 2015-07-20 20:06:44 -04:00
Paul Nicholls
a673650477 MDL-50699 Lesson: "Link to next activity" empty until Lesson saved
Due to a logic bug, the "Link to next activity" dropdown was empty (only
contains the "None" option) until the Lesson had been saved.  This minor
change allows a "next activity" to be specified when initially creating
the Lesson whilst still preventing the user from choosing the Lesson as its
own next activity.
2015-06-26 16:16:23 +12:00
Eloy Lafuente (stronk7)
22214c22d1 Merge branch 'MDL-49882' of git://github.com/jmvedrine/moodle 2015-06-10 01:39:17 +02:00
Eloy Lafuente (stronk7)
db91aae8f4 Merge branch 'MDL-50145_master' of git://github.com/markn86/moodle 2015-06-09 20:40:56 +02:00
Mark Nelson
1254e48f26 MDL-50145 mod_lesson: added behat test for multiple dashboard lessons 2015-06-09 00:49:04 -07:00
Mark Nelson
2c4b43d9b2 MDL-50145 mod_lesson: fixed issue with duplicate values 2015-06-08 22:09:25 -07:00
Rajesh Taneja
2835eee63b MDL-50179 lesson: Get student/attempts only when showing overview 2015-06-09 09:34:10 +08:00
Jean-Michel Vedrine
5d33ec9c7e MDL-49882 mod_lesson: Essay questions not imported into lessons 2015-05-31 07:24:11 +02:00
Dan Poltawski
c1b9c3d10d Merge branch 'wip-mdl-50203' of https://github.com/rajeshtaneja/moodle 2015-05-19 12:38:56 +01:00
Rajesh Taneja
e9eaf94226 MDL-50203 behat: Click on link in student 1 row 2015-05-13 15:19:59 +08:00
David Monllao
88d127d37c Merge branch 'MDL-34102' of git://github.com/jmvedrine/moodle 2015-05-12 12:08:30 +08:00
Eloy Lafuente (stronk7)
b758ab3053 MDL-50183 upgrade: add 2.9.0 separation line to all upgrade scripts 2015-05-12 00:21:05 +02:00
Eloy Lafuente (stronk7)
26ea380d24 MDL-50102 versions: bump all versions and requires near release
version = planned 2015051100 release version
requires= current 2015050500 rc1 version

Note: On purpose, the course format social wrong version (2015102100)
has been kept unmodified. Looking forward a solution right now.
2015-05-05 17:43:19 +02:00
John Okely
4887d15228 MDL-49983 navigation: Remove 'my' from user context navigation 2015-05-04 12:38:50 +08:00
Jean-Michel Vedrine
2107531f3c MDL-34102 mod_lesson: display feedback
Feedback for incorrect answer was not diplayed when
Provide option to try a question again was set to Yes.
2015-05-02 15:01:17 +02:00
Rajesh Taneja
ceeab15019 MDL-49948 lesson: Answer and response format should be known for each form 2015-04-27 14:35:20 +01:00
Jean-Michel Vedrine
c914c92da0 MDL-49913 mod_lesson: studentanswer format should be HTML 2015-04-24 19:19:32 +02:00
Jean-Michel Vedrine
cb9d259dcd MDL-49913 mod_lesson: fix import scores and jumps 2015-04-24 19:19:31 +02:00
Jean-Michel Vedrine
9fb9aa9c91 MDL-49913 mod_lesson: defaultanswer to avoid duplication 2015-04-24 19:19:31 +02:00
Jean-Michel Vedrine
35cec798c2 MDL-49913 mod_lesson: round question grades on import 2015-04-24 19:19:30 +02:00
Jean-Michel Vedrine
6197497393 MDL-49946 mod_lesson: improve qformat_default::defaultquestion 2015-04-22 19:40:19 +02:00
Rajesh Taneja
0fe86bbdbb MDL-49799 behat: replaced asd.com with example.com
asd.com is a valid domain, we should use reserved domain names for testing
2015-04-20 11:21:20 +08:00
Dan Poltawski
9ac0001bf0 MDL-45774 fix trailing whitespace 2015-04-14 15:32:15 +08:00
Damyon Wiese
46a2fbc4b7 MDL-49412 Navigation: Remaining behat fixed for nav branch
Behat is passing after this change.

Part of MDL-45774.
2015-04-10 17:19:28 +08:00
Damyon Wiese
221210e9b2 MDL-49412 Behat: Fix behat tests for all of @mod
This is after the navigation changes for 2.9.

Part of MDL-45774.
2015-04-10 17:18:23 +08:00
Dave Cooper
81d7de1aa1 MDL-48936 lang: Changed "My Home" to "Dashboard".
Part of MDL-45774
2015-04-10 17:16:27 +08:00
Jean-Michel Vedrine
716dfb630d MDL-49642 mod_lesson: fix restore of overrides 2015-04-09 15:26:40 +08:00
Dan Poltawski
f5d9f19013 Merge branch 'MDL-49642' of git://github.com/jmvedrine/moodle 2015-04-08 08:57:15 +01:00