107378 Commits

Author SHA1 Message Date
Ilya Tregubov
7e7628b806 Merge branch 'MDL-77058-401' of https://github.com/dravek/moodle into MOODLE_401_STABLE 2023-02-02 10:04:58 +08:00
Jun Pataleta
920ac6dbe5 Merge branch 'MDL-77092-m401' of https://github.com/sammarshallou/moodle into MOODLE_401_STABLE 2023-02-02 09:57:06 +08:00
Andrew Nicols
662d2e1f0f Merge branch 'MDL-75912-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-02-02 09:49:25 +08:00
Ilya Tregubov
e247320845 Merge branch 'MDL-77079-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-02-02 09:16:50 +08:00
Andrew Nicols
4bd7c57be5 Merge branch 'MDL-77100-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-02 08:32:38 +08:00
Andrew Nicols
6f073ebe6d Merge branch 'MDL-77001-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-02 08:27:21 +08:00
Andrew Nicols
885d191df2 Merge branch 'MDL-77003-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-02 08:20:51 +08:00
Andrew Nicols
3ef9c4c5d0 Merge branch 'MDL-75345-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-02 08:17:54 +08:00
Paul Holden
a3c9194bef Merge branch 'MDL-76658-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-02-01 16:34:39 +00:00
Paul Holden
c125d5f3f2 MDL-75345 reportbuilder: improve course/user custom report tests.
Ensure column and filters provided by each source have sufficient
coverage. Re-factor individual entity/helper class tests to test
their own specific implementation only.

Remove now-defunct test fixtures.
2023-02-01 15:41:28 +00:00
Paul Holden
858b26feb2 Merge branch 'MDL-76311-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-02-01 14:16:15 +00:00
Meirza
a6a6fbc5ec MDL-76311 user: redirect to proper URL if a new user creation cancelled 2023-02-01 20:14:01 +07:00
Paul Holden
b59bb37819 Merge branch 'MDL-73847_401' of https://github.com/jonof/moodle into MOODLE_401_STABLE 2023-02-01 10:00:27 +00:00
Jun Pataleta
e3dd47671c Merge branch 'MDL-76985-MOODLE_401_STABLE' of https://github.com/sh-csg/moodle into MOODLE_401_STABLE 2023-02-01 14:11:53 +08:00
Ilya Tregubov
fc2a1536f7 Merge branch 'MDL-76587-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-02-01 13:25:54 +08:00
Angelia Dela Cruz
725af41225 MDL-75912 behat: Wiki Behat tests optimised
Behat cleanup and optimisation
2023-02-01 11:11:03 +08:00
Angelia Dela Cruz
5a6481006d MDL-75912 behat: Wiki Behat tests now use generators
Replace steps that manually add Wiki instances via the UI and use
Behat generators. This improves the speed of the Behat test runs.
2023-02-01 11:03:20 +08:00
Simey Lameze
d350fcc040 MDL-77079 behat: use different step to validate presets table data 2023-02-01 09:03:50 +08:00
Paul Holden
2ea379e0b0 MDL-77100 mod_data: replace calls to str_ends_with, fix assertions.
Calls to `str_ends_with` are polyfilled currently, as the method is
not present in PHP7.4 or earlier. We should avoid uses of it so as
to not trip up compatibility standard checkers.
2023-01-31 21:36:32 +00:00
Andrew Nicols
421ae9cb83 Merge branch 'MDL-75945-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-01-31 22:12:28 +08:00
sam marshall
f5dc8c4f9f MDL-77092 Behat: Expand all fieldsets fails with single fieldset
The Behat step to expand all fieldsets did not work if the page
contains only one fieldset.
2023-01-31 13:58:08 +00:00
Andrew Nicols
7dfb4c229c Merge branch 'MDL-77081-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-31 21:45:05 +08:00
Angelia Dela Cruz
df1d34bea8 MDL-76658 Behat: Coverage for course cohort enrolment groups
Co-authored-by: Simey Lameze <simey@moodle.com>
2023-01-31 21:24:12 +08:00
Paul Holden
6acc34a097 MDL-77081 forms: PHP8.1 compatibility for group/textarea elements.
See related changes in b0a83aa7, we can no longer pass null values
to some string related methods.
2023-01-31 10:51:20 +00:00
Ilya Tregubov
0338a74dfb Merge branch 'MDL-77077-401' of https://github.com/snake/moodle into MOODLE_401_STABLE 2023-01-31 18:13:49 +08:00
Simey Lameze
ed544dd0f3 MDL-76587 behat: make grading page wider to avoid 'out of bounds' fail
This is because on classic theme the navigation block pushes the content
to the right and once behat changes the grades the 'Save changes' button
is no longer visible.
2023-01-31 11:18:09 +08:00
Jake Dallimore
a6bd5ae245 MDL-77077 mod_lti: Fix JWT signature verify when alg missing from JWKS
Infer the algorithm, where necessary, using a combination of JWT
headers and known valid LTI algorithms.
2023-01-30 16:44:58 +08:00
Andrew Nicols
cd0935a33e Merge branch 'MDL-77040-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-30 12:28:01 +08:00
David Matamoros
2307060239 MDL-77058 reportbuilder: Fix for cohort null idnumber column 2023-01-27 14:09:03 +01:00
Andrew Nicols
62118364f2 Merge branch 'MDL-76562-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-01-27 14:24:26 +08:00
Andrew Nicols
0a4f551fff Merge branch 'MDL-75978-401' of https://github.com/JBThong/moodle into MOODLE_401_STABLE 2023-01-27 12:34:04 +08:00
Paul Holden
d8f7fb803f MDL-77040 core: assert types of returned Geoplugin data, not values.
The results we get from these tests are beyond our control, and are
unreliable for use in testing.

See also previous change 215cd2d8 in similar tests.
2023-01-26 13:24:06 +00:00
Sara Arjona
67bbf6c416 weekly release 4.1.1+ 2023-01-26 09:59:12 +01:00
Jun Pataleta
a360fd0601 Merge branch 'MDL-76977-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-25 16:10:18 +08:00
Jun Pataleta
5e75da7598 Merge branch 'MDL-77036-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-01-25 16:02:23 +08:00
Stefan Hanauska
928633a33e MDL-76985 course: Redirect to moved section 2023-01-25 09:00:06 +01:00
Simey Lameze
6bf5c32402 MDL-77036 core_iplookup: update test_ipv4 test expectations 2023-01-25 15:15:07 +08:00
Jun Pataleta
6d90fc7c5b Merge branch 'MDL-76967-401' of https://github.com/lucaboesch/moodle into MOODLE_401_STABLE 2023-01-25 08:57:16 +08:00
Paul Holden
0a86c6a123 MDL-77003 javascript: improve string helper JSON detection.
Changes in fbc2732d made the JS template string helper method
too strict in regards to what it considers a valid JSON object.

Co-authored-by: Mike Churchward <mike@brickfieldlabs.ie>
2023-01-24 22:16:21 +00:00
Jun Pataleta
addbbfdaae Merge branch 'MDL-76639-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-01-24 18:59:29 +08:00
Jun Pataleta
0006557b59 Merge branch 'MDL-76652-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-01-24 18:45:24 +08:00
Jun Pataleta
0813b938a3 Merge branch 'MDL-76655-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-01-24 18:27:00 +08:00
Andrew Nicols
710d0ef8f2 MDL-75945 core: Convert a floating value to an integer.
In PHP 8.1, any implicit conversion of float to int, which leads to a loss in precision, is now deprecated.
To avoid the error warning, the code must explicitly convert a floating value to an integer.
2023-01-24 16:53:34 +07:00
Jun Pataleta
fa51e1a149 Merge branch 'MDL-76362-401-extra' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-01-24 10:38:49 +08:00
Angelia Dela Cruz
066740a127 MDL-76655 behat: Coverage for workshop grading strategies 2023-01-24 09:09:26 +08:00
Paul Holden
e0358d2eca MDL-77001 tiny_autosave: use valid lang string during privacy export. 2023-01-23 22:06:33 +00:00
Eloy Lafuente (stronk7)
36b4f13e9b MDL-76362 workshop: check for empty (null included) feedbackreviewer
As far as feedbackreviewer can be null, we cannot, since PHP 8.1
apply any string operation (trim, strlen...) on it, hence, checking
before applying.
2023-01-23 09:19:32 +08:00
Eloy Lafuente (stronk7)
03bc275093 MDL-76362 enrol_lti: Prevent calling to DataConnector with null keys
While it could have been fixed in DataConnector (3rd part lib), better
prevent in our code to call to it with null keys.

Covered by unit tests.
2023-01-23 09:17:48 +08:00
Eloy Lafuente (stronk7)
e6dfa9ff3c MDL-76362 output: Preserve original behaviour for PHP 8.1
Whenever the page_requirements_manager::js_fix_url()
is called with null url, it must throw an exception and emit 0 warnings.

It's covered by an explicit test:

test_js_fix_url_coding_exception with data set "Provide a null argument"
2023-01-23 09:17:48 +08:00
Andrew Nicols
8f4bd4ce11 MDL-76362 core: Coding style fixes 2023-01-23 09:16:08 +08:00