mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-21 08:00:37 +01:00
Code Issues Projects Releases Wiki Activity
107,378 Commits 36 Branches 527 Tags
Commit Graph

23968 Commits

Author SHA1 Message Date
Andrew Nicols
662d2e1f0f Merge branch 'MDL-75912-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-02-02 09:49:25 +08:00
Andrew Nicols
4bd7c57be5 Merge branch 'MDL-77100-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-02 08:32:38 +08:00
Paul Holden
b59bb37819 Merge branch 'MDL-73847_401' of https://github.com/jonof/moodle into MOODLE_401_STABLE 2023-02-01 10:00:27 +00:00
Angelia Dela Cruz
725af41225 MDL-75912 behat: Wiki Behat tests optimised 
Behat cleanup and optimisation
 2023-02-01 11:11:03 +08:00
Paul Holden
2ea379e0b0 MDL-77100 mod_data: replace calls to str_ends_with, fix assertions. 
Calls to `str_ends_with` are polyfilled currently, as the method is
not present in PHP7.4 or earlier. We should avoid uses of it so as
to not trip up compatibility standard checkers.
 2023-01-31 21:36:32 +00:00
Jake Dallimore
a6bd5ae245 MDL-77077 mod_lti: Fix JWT signature verify when alg missing from JWKS 
Infer the algorithm, where necessary, using a combination of JWT
headers and known valid LTI algorithms.
 2023-01-30 16:44:58 +08:00
Jun Pataleta
6d90fc7c5b Merge branch 'MDL-76967-401' of https://github.com/lucaboesch/moodle into MOODLE_401_STABLE 2023-01-25 08:57:16 +08:00
Jun Pataleta
addbbfdaae Merge branch 'MDL-76639-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-01-24 18:59:29 +08:00
Jun Pataleta
0006557b59 Merge branch 'MDL-76652-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-01-24 18:45:24 +08:00
Jun Pataleta
0813b938a3 Merge branch 'MDL-76655-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-01-24 18:27:00 +08:00
Angelia Dela Cruz
066740a127 MDL-76655 behat: Coverage for workshop grading strategies 2023-01-24 09:09:26 +08:00
Eloy Lafuente (stronk7)
36b4f13e9b MDL-76362 workshop: check for empty (null included) feedbackreviewer 
As far as feedbackreviewer can be null, we cannot, since PHP 8.1
apply any string operation (trim, strlen...) on it, hence, checking
before applying.
 2023-01-23 09:19:32 +08:00
Andrew Nicols
8f4bd4ce11 MDL-76362 core: Coding style fixes 2023-01-23 09:16:08 +08:00
Marina Glancy
2dd7290ccb MDL-76362 various: Avoid passing nulls to functions that don't allow nulls 
PHP 8.1 is more strict on the parameter type. Functions such as trim(), strlen(), str_replace(), etc
show notice when null is passed as an argument
 2023-01-23 09:16:06 +08:00
Luca Bösch
8bb813e461 MDL-76967 questions: Questions last used line height 2023-01-20 09:57:21 +01:00
Jun Pataleta
0f28e2b02c Merge branch 'MDL-76725-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-19 12:05:06 +08:00
Ilya Tregubov
69fbf97923 Merge branch 'MDL-76766-401' of https://github.com/aanabit/moodle into MOODLE_401_STABLE 2023-01-19 11:04:23 +08:00
Andrew Nicols
3309157233 Merge branch 'MDL-70070-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-19 08:50:37 +08:00
Philipp Memmel
888ed072c0 MDL-76525 mod_data: Add param validation for data fields 2023-01-18 12:10:45 +01:00
Paul Holden
70a5e38b2c MDL-70070 phpunit: correct data provider method names. 
They should not be prefixed `test_` because that's how actual
test methods containing assertions are identified by PHPUnit.
 2023-01-16 08:28:31 +00:00
Angelia Dela Cruz
6bd3f18949 MDL-76639 behat: Add Behat test coverage for quiz with limited attempts 2023-01-13 16:11:22 +08:00
Jonathon Fowler
cc290a84e4 MDL-73847 lti: fetch keyset URLs using configured proxy settings 2023-01-13 14:30:05 +10:00
Jun Pataleta
217a32f033 Merge branch 'MDL-76649_401' of https://github.com/timhunt/moodle into MOODLE_401_STABLE 2023-01-12 12:06:45 +08:00
Andrew Nicols
5eb91a54c3 Merge branch 'MDL-76839-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-12 10:57:01 +08:00
Jun Pataleta
28ccae3b7a Merge branch 'MDL-76739-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-01-12 10:17:37 +08:00
Jun Pataleta
f06b222aa8 MDL-76739 behat: Replace occurrences of "surname" in Behat tests 
Replace occurrences of "surname" in Behat tests with "last name"
 2023-01-12 09:52:48 +08:00
Amaia Anabitarte
959c34de04 MDL-76766 mod_quiz: Allow shuffling quizes with no questions 2023-01-11 11:16:09 +01:00
Andrew Nicols
b50964d2e2 Merge branch '66924-view-own-private-reply-401' of https://github.com/DSI-Universite-Rennes2/moodle into MOODLE_401_STABLE 2023-01-11 15:53:27 +08:00
Tim Hunt
2ea89b98a7 MDL-76810 redirect handling: ensure return URLs are properly sanitised 2023-01-11 11:43:12 +08:00
Andrew Nicols
833bc53bbb Merge branch 'MDL-76356_401' of https://github.com/stronk7/moodle into MOODLE_401_STABLE 2023-01-11 10:30:25 +08:00
Jake Dallimore
5123d2bf53 Merge branch 'MDL-76597-401-2' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-01-11 10:12:08 +08:00
David Mudrák
acd82d3a86 MDL-76739 lang: Use the fixed strings in the tests, too 2023-01-10 21:15:06 +01:00
Helen Foster
152bbd76c5 MDL-76739 lang: Import fixed English strings (en_fix) 2023-01-10 21:13:14 +01:00
Paul Holden
02df248fbd Merge branch 'MDL-76811-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-01-10 16:40:06 +00:00
Paul Holden
a789bf5b24 Merge branch 'MDL-76653-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-01-10 15:29:16 +00:00
Marina Glancy
ff5fc3820a MDL-76356 various: avoid implicit conversion to int 
PHP before version 8.1 automatically converted to int if the function
parameter (or array key) is expected to be int. PHP 8.1 shows notice in
this case
 2023-01-10 15:25:57 +01:00
Paul Holden
9cdafb6cad MDL-76839 mod_data: correct external test class coverage notation. 2023-01-10 13:02:29 +00:00
Andrew Nicols
d9ae9e51cd MDL-76811 mod_data: Remove duplicate tests 2023-01-10 11:39:40 +08:00
Andrew Nicols
cd42aa554f MDL-76811 mod_data: Stop testing template creation on field creation 
The default template is no longer created when creating the fields with
the generator, so we should stop testing that it is.
 2023-01-10 11:39:40 +08:00
Andrew Nicols
e8ea4916e9 MDL-76811 mod_data: Generator test cleanup 2023-01-10 11:39:40 +08:00
Simey Lameze
d1f75e4dce MDL-76653 behat: add coverage for SCORM availability 2023-01-10 10:26:04 +08:00
Julien Boulen
4ea254faf2 MDL-66924 mod_forum: Allow users to see their own private messages 
Allow users to see their own private messages even if they don't have
mod/forum:readprivatereplies capability

Add behat test to avoid MDL-67109 issue.

Co-authored-by: Martin Putzlocher <mputzi@users.noreply.github.com>
 2023-01-09 14:43:51 +01:00
Tim Hunt
d71ada1952 MDL-76649 quiz statistics task: output more useful trace info 
At the moment, quiz_statistics\task\recalculate gives no useful
information about what it is doing, which makes it hard to investigate
if the task fails. This commit makes it more usefully verbose.

Also, following this change, one instance of this task will not
run for more than one hour at a time.

As part of this commit, I have added a new helper mtrace_exception.
to consistently log exceptions in scheduled tasks. It is sad to
add a new function to moodlelib.php, but that seemed the logical place.
Looking at other tasks, this method is badly needed. Many are just
logging the ->getMessage() which is normaly insufficient for proper
debugging. However, swiching all existing tasks to use the new function
will need to wait for a future MDL.
 2023-01-09 13:34:14 +00:00
Jun Pataleta
934d8a2866 MDL-76597 mod_quiz: Add a default heading name for Behat tests 2023-01-09 15:41:59 +08:00
Jun Pataleta
6a7668e350 MDL-76597 mod_quiz: Set presentation role for the question list 
Since the <ul> and <li> elements for listing the quiz questions and
elements are mainly used for layout purposes, it is better to set the
role of these elements to presentation only.
The aria-label for the <li> element is inappropriate and can also cause
confusion to screen reader users. Better to remove this. Though this is
being used in the confirmation modal so better to just change it to a
data attribute.
 2023-01-09 15:41:59 +08:00
Jun Pataleta
d2bacb04ff MDL-76597 mod_quiz: Set presentation role for the question list 
Since the <ul> and <li> elements for listing the quiz questions and
elements are mainly used for layout purposes, it is better to set the
role of these elements to presentation only.
 2023-01-09 15:41:59 +08:00
Jun Pataleta
77a0f1b129 MDL-76597 mod_quiz: Add label for question checkboxes 2023-01-09 15:41:59 +08:00
Jun Pataleta
ca841d1489 MDL-76597 mod_quiz: Darken section heading on quiz questions page 2023-01-09 15:41:59 +08:00
Jun Pataleta
c2216eefa6 MDL-76597 mod_quiz: Add label for version selector 2023-01-09 15:41:59 +08:00
Jun Pataleta
241da816db MDL-76597 mod_quiz: Add a default sr-only section heading 
Add a default sr-only section heading in order to prevent having an
empty heading for the quiz section which is not good for accessibility.

Plus:
- There's also an existing issue where filters are never applied to
section headings on load. This has been fixed in this commit as well.
- Button role added for the edit section button which enables it to
take advantage of the theme highlighting when it receives focus.
 2023-01-09 15:41:59 +08:00