2054 Commits

Author SHA1 Message Date
Sam Hemelryk
3211569a6a Revert "MDL-30843 and MDL-30842 - accessibility compliance: Add <label> for form input text and select tag"
This reverts commit f9f281b8fee75c2416d71bae7583fd026b9ccabb.
2012-04-11 17:18:58 +12:00
Dan Poltawski
7a1ed64587 Merge branch 'w15_MDL-32323_m23_phpunit3' of git://github.com/skodak/moodle 2012-04-11 09:32:58 +08:00
Dan Poltawski
4a59665b9f Merge branch 'MDL-32217' of git://github.com/ppichet/moodle 2012-04-11 09:27:29 +08:00
Petr Skoda
a4d53e4b26 MDL-32323 make base test case classes abstract to prevent empty testcase warnings, fix property access 2012-04-10 18:51:34 +02:00
Petr Skoda
603bd00112 MDL-32323 convert question tests
1/ type/match/tests/walkthrough_test.php - tests are failing randomly, looks like some weird randomisation is going on there - see TODOs

2/ type/multianswer/tests/upgradelibnewqe_test.php contains invalid expected value - see TODO
2012-04-10 15:27:11 +02:00
Dan Poltawski
f4bd3cd6c9 Merge branch 'MDL-32347' of git://github.com/timhunt/moodle 2012-04-10 11:34:12 +08:00
Dan Poltawski
2d74d8a612 Merge branch 'MDL-32318' of git://github.com/timhunt/moodle 2012-04-10 10:26:49 +08:00
Sam Hemelryk
5bfeb5ffd3 Merge branch 'MDL-30843_b' of git://github.com/rwijaya/moodle 2012-04-10 12:34:37 +12:00
ppichet
57239949ac MDL-32217 Setting options->unitgradingtype 2012-04-06 11:02:13 -04:00
Tim Hunt
a031b0f334 MDL-32347 questions: API improvement for the benefit of strict syntax. 2012-04-05 17:26:44 +01:00
Tim Hunt
b9832f2b87 MDL-32318 question preview: fix php stric syntax error
Also, cheating, and committing a whitespace fix in the same commit.

Conflicts:

	question/engine/questionusage.php
2012-04-05 16:42:23 +01:00
Dan Poltawski
86cfd9966a MDL-32220 question import: readquestions arguments change
Removed the context parameter for blackboard and blackboard_six formats.

This parameter was removed in 4d188926
2012-04-04 14:46:54 +08:00
Eloy Lafuente (stronk7)
959a709ebe Merge branch 'MDL-32240' of git://github.com/timhunt/moodle 2012-04-04 00:10:37 +02:00
Eloy Lafuente (stronk7)
46ed2f8b7f Merge branch 'w14_MDL-32251_m23_strict3' of git://github.com/skodak/moodle 2012-04-03 21:17:58 +02:00
Dan Poltawski
1d40f283ce Merge branch 'MDL-32220' of git://github.com/timhunt/moodle 2012-04-03 11:09:31 +08:00
Dan Poltawski
aefc7e28ff Merge branch 'MDL-32213_manual_grade_question_upgrade' of git://github.com/davosmith/moodle 2012-04-02 16:59:10 +08:00
Dan Poltawski
8408d23c99 Merge branch 'w14_MDL-32250_m23_simpletest110' of git://github.com/skodak/moodle 2012-04-02 16:15:35 +08:00
Petr Skoda
97621c33c9 MDL-32250 fixed case typo
Thanks Dan!
2012-04-02 09:21:14 +02:00
Sam Hemelryk
530eecc0f9 Merge branch 'MDL-32239' of git://github.com/timhunt/moodle 2012-04-02 14:31:30 +12:00
Dan Poltawski
6e83ae36a8 Merge branch 'MDL-32246' of git://github.com/timhunt/moodle 2012-04-02 10:03:10 +08:00
Rossiani Wijaya
f9f281b8fe MDL-30843 and MDL-30842 - accessibility compliance: Add <label> for form input text and select tag 2012-03-30 16:26:58 +08:00
Petr Skoda
9aa09d8fed MDL-32251 more E_STRCT fixes 2012-03-29 16:29:29 +02:00
Petr Skoda
caee6e6c26 MDL-32251 E_STRICT fixes part 3 2012-03-29 15:24:30 +02:00
Tim Hunt
87b564df81 MDL-32246 question export: should cope with unrecognised qtypes.
If a question is of an unrecognised type, then we just omit it from the export.
2012-03-29 14:14:32 +01:00
Tim Hunt
76cf77e4d3 MDL-32240 quiz editing: check permissions questions are added.
We also check permissions when removing questions from the quiz, so that
we do not let users make mistakes they cannot immediately undo.
2012-03-29 14:14:12 +01:00
Tim Hunt
51c5e6057c MDL-32239 question bank: wrong cap checks editing/viewing quesitions
None of these problems affect the default roles. They only occur when
the permissions have been edited to allow restricted subsets of the
question capabilities.

In some cases, things that the restriced subset of capabilities should
have allowed were blocked by errors. In other cases, users were allowed
to do more than they should bave been due to failures to check the
right capabilities in the right places.

For full details, see the bug report.

Two of the bugs were previously reported separately as MDL-26395 and
MDL-27232.
2012-03-29 14:14:10 +01:00
Tim Hunt
4d18892676 MDL-32220 question import: files sometimes stored in the wrong context.
Sadly, this involves a small API change, but I don't believe anyone was
using the argument I had to remove (because we were sometimes passing a
wrong value, and there is not way to compute the right value at that
point in the code.)

Also sadly, the code to compute the context we are importing into is now
rather spaghetti-like, but it works.
2012-03-29 14:13:28 +01:00
Tim Hunt
04fcd1f5a8 MDL-32201 question export: use qformat_xml::write_answer in base class
Without this, images in answers were not being written to the export
file for questions using extra_answer_fields.
2012-03-29 14:12:58 +01:00
Petr Skoda
0bb48cc2a1 MDL-32250 import latest SimpleTest 1.1.0 2012-03-29 15:07:53 +02:00
Davo Smith
1892a35625 MDL-32213 Question upgrade now correctly handles non-core manually-graded question types 2012-03-27 13:44:07 +01:00
Tim Hunt
1a2de1c7ce MDL-32177 questions: allow default questiontext in the editing form. 2012-03-23 15:36:17 +00:00
Sam Hemelryk
ef844d0a15 Merge branch 'w12_MDL-32094_m23_phpstrict' of git://github.com/skodak/moodle 2012-03-20 16:47:17 +13:00
M Kassaei
e6208ec604 MDL-32053 question: Question bank table displayed inconsistently 2012-03-20 11:00:16 +13:00
M Kassaei
d1a80dd2b2 MDL-32048 mod_quiz: Question bank select/deselect all shows strange behaviour in IE 2012-03-20 10:55:01 +13:00
Petr Skoda
e2bb3c9275 MDL-32094 some more E_STRICT fixes 2012-03-18 20:40:20 +01:00
Petr Skoda
072db71c90 MDL-32094 fix question related E_STRICT problems 2012-03-18 18:33:54 +01:00
Tim Hunt
8cb7a6d512 MDL-31594 question manual grading: did not handle comma as decimal. 2012-03-15 18:46:43 +00:00
Eloy Lafuente (stronk7)
9b89dc4f7d Merge branch 'MDL-31981' of git://github.com/timhunt/moodle 2012-03-13 18:08:40 +01:00
Eloy Lafuente (stronk7)
b20bb8454a Merge branch 'w11_MDL-31985_m23_lobsizes' of git://github.com/skodak/moodle 2012-03-13 00:15:59 +01:00
Eloy Lafuente (stronk7)
649fd88d8f MDL-31805 html2text - change tests acordingly with the new version
With the new version in place, both <th> and <a> contents are
being handled by the conversion. Accomodate existing tests to
that change.
2012-03-12 21:17:22 +01:00
Petr Skoda
bb88a54d06 MDL-31985 remove text sizes from all install.xml files 2012-03-11 15:55:37 +01:00
Tim Hunt
9eb62b33b9 MDL-31981 shortanswer qtype does not handle \* in correct response. 2012-03-09 18:54:20 +00:00
Eloy Lafuente (stronk7)
a1ef8c6d3c MDL-28364 whitespace fixes 2012-03-07 04:00:39 +01:00
Eloy Lafuente (stronk7)
12c5685a50 Merge branch 'MDL-28364' of git://github.com/jonof/moodle 2012-03-07 03:55:53 +01:00
Eloy Lafuente (stronk7)
f1fbdbea33 Merge branch 'MDL-31829' of git://github.com/timhunt/moodle 2012-03-06 21:18:04 +01:00
Petr Skoda
c3dd6b01fe MDL-27982 drop UNSIGNED attributes from all install.xml files 2012-03-06 12:01:10 +01:00
Tim Hunt
296e1e9782 MDL-31829 question engine SQL typo breaks some regrades.
Also, some MySQL-only code had not been updated.

This problem only affected a small minority of question attempts, like
this:
1. Suppose you have a shortanswer question with correct answer 'Toad'
and some hints.
2. Suppose a student attempts this using the interactive behaviour and
on the first try responds 'Frog', and on the second try responds 'Toad'.
3. Then suppose the teacher edits the question to make 'Frog' correct.
4. Then, when the quiz is regraded, the question_attempt_step for the
second try will need to be deleted. That is where the buggy code was.
2012-03-01 12:33:14 +00:00
Tim Hunt
7a26403fc9 MDL-31828 attachements to essay questions do not work on Oracle. 2012-03-01 12:10:39 +00:00
Eloy Lafuente (stronk7)
4ab641eeaa MDL-30973 Files API: Whitespace fixes 2012-03-01 00:56:23 +01:00
Eloy Lafuente (stronk7)
d8c9ff403b Merge branch 's17_MDL-30973_file_docblock_master' of git://github.com/dongsheng/moodle 2012-03-01 00:25:18 +01:00