203 Commits

Author SHA1 Message Date
Jake Dallimore
0c3eaf9ee6 MDL-64588 core_comment: fix unnecessary type check in add_comments
We should rely on the return type, else an exception with be thrown.
2019-10-02 09:23:43 +08:00
Jake Dallimore
93ea6612bd MDL-64588 core_comment: make external test code use helper method
Instead of using setUp to create testing objects, use a helper.
2019-10-02 09:23:43 +08:00
Jake Dallimore
ae94d477a6 MDL-64588 core_comment: fix get_comment ordering when timestamps match
Include id in the sorting, to be sure that we always get the correct
record in cases where the comment timestamps are the same.
2019-10-02 09:23:43 +08:00
Jake Dallimore
6cd3d398a9 MDL-64588 core_comment: use comment structure in external get_comments
Other minor changes include:
- added the since tag to newly added external functions
- Changed 'web service' to 'external function' in comment/upgrade.txt
2019-10-02 09:23:33 +08:00
Juan Leyva
09899abc55 MDL-64588 comment: New WebService core_comment_delete_comment 2019-10-01 09:26:01 +08:00
Juan Leyva
8e4a9ed854 MDL-64588 comment: New WebService core_comment_add_comment 2019-10-01 09:26:01 +08:00
Juan Leyva
2234b6c9dc MDL-64588 comment: Return whether the user can post in a comments area 2019-10-01 09:25:36 +08:00
Juan Leyva
48f5ca7bee MDL-66061 comments: Support pagination and sorting in get_comments WS 2019-08-19 10:42:25 +01:00
Mathew May
5cac5fa428 MDL-64506 templates: BS2 m-x-x to BS4 mx-x 2019-04-03 19:47:11 +08:00
Damyon Wiese
5d87464bc6 MDL-64651 comments: Do not send referrer
Use blanktarget option on all comments to prevent malicious links.
2019-03-05 04:24:53 +01:00
Adrian Greeve
a1b0ac60fe MDL-64339 core_comment: Update comment display to link to profile. 2018-12-07 11:13:16 +01:00
Andrew Nicols
c96cd71102 MDL-63924 privacy: Add shared user providers to subsytsems 2018-11-08 21:26:18 +08:00
Adrian Greeve
d2148f32ca MDL-63531 privacy: Update to comments provider to simplfy sql.
This updates the get_users_in_context_from_sql query to include
the context id to simplify the calls made from other components.
2018-10-30 09:47:14 +08:00
Michael Hawkins
cea5338780 MDL-63495 comment: Added provider::get_users_in_context_from_sql
This issue is part of the MDL-62560 Epic.
2018-10-22 12:48:13 +02:00
Michael Hawkins
d744b15bc6 MDL-63495 comment: Added provider::delete_comments_for_users
This issue is a part of the MDL-62560 Epic.
2018-10-17 13:12:18 +08:00
Charles YVANES
458453cee0 MDL-29895 core: removed require_login() when not needed 2018-09-10 11:22:50 +02:00
Mihail Geshoski
329a84b489 MDL-35977 comments: Missing label in blog and assignment comment area 2018-07-23 08:55:14 +08:00
Marina Glancy
70703d4c51 MDL-61937 comment: do not use API in provider
When exporting comments we can not use comments API because:
- we don't need to call component validate, comments may be disabled right now but
  are still stored
- we don't need to call display callback
- we need to export all comments and not only first 15 of them
2018-05-04 11:22:14 +08:00
Adrian Greeve
1b33e410b5 MDL-62035 core_comment: Update to deletion methods.
Also clarification with the export method to clarify that it
is only for one context.
2018-04-20 10:42:24 +08:00
Andrew Nicols
fa983cfcc0 MDL-61836 comment: Add missing require 2018-04-20 08:17:15 +08:00
Luca Bösch
a07249826a MDL-38099 comments: year in comments date 2018-04-17 22:40:36 +02:00
Andrew Nicols
e98f0cf7ff MDL-61307 privacy: Rename deletion functions 2018-03-13 08:48:13 +08:00
Andrew Nicols
70f0923499 MDL-61307 core: Remove deletion_criteria 2018-03-13 08:48:12 +08:00
Adrian Greeve
5be028ab82 MDL-61307 core_comment: Add implementation of privacy API 2018-03-09 12:24:38 +08:00
John Okely
672f483670 MDL-42834 admin: Removal of httpswwwroot 2017-10-23 12:25:36 +08:00
Juan Leyva
e71687baf9 MDL-60198 webservice: Add missing MOODLE_INTERNAL checks 2017-09-21 13:01:28 +02:00
Damyon Wiese
dc633a24b9 MDL-40759 fontawesome: lang strings comments 2017-03-21 11:13:43 +08:00
Damyon Wiese
07171e831e MDL-40759 fontawesome: Fix bugs from rebase 2017-03-17 15:52:46 +08:00
Damyon Wiese
b9b409cfc3 MDL-40759 icons: Peer review fixes (all minor) 2017-03-17 15:52:46 +08:00
Damyon Wiese
8857c715d1 MDL-40759 icons: Behat fixes for font-awesome 2017-03-17 15:52:18 +08:00
Damyon Wiese
663640f5b3 MDL-40759 icons: convert uses of pix_url to pix_icon
Also change filepicker to use scaled svgs instead of sets of custom pngs. The svgs are taken from font-awesome.
2017-03-17 15:52:17 +08:00
Jake Dallimore
86f1d1bb86 MDL-35980 comment: add comment info to delete button for screen readers
For each delete button in the comments widget, make the spoken text a
string containing the name of the poster and the datetime.
2017-02-24 08:15:40 +08:00
Jake Dallimore
bb80768558 MDL-35978 comments: fix for comments block which has no toggler 2017-01-31 11:24:42 +08:00
Jake Dallimore
af65270e87 MDL-35978 comments: expandable comments announce change when toggled
Added role and aria-expanded attributes to the toggler link and added
a key handler for the space and enter keys.
2017-01-27 13:03:53 +08:00
Frederic Massart
f5f02ac0d3 MDL-57273 core: Migrating some exporters from tool_lp & core_competency 2017-01-20 12:56:18 +08:00
Simey Lameze
1f8d39893f MDL-57125 comment: prevent js execution if there are no comments 2016-12-12 11:34:42 +08:00
Simey Lameze
270b2e443c MDL-56988 report: review and apply boosty styles to all reports 2016-11-23 15:30:32 +08:00
Juan Leyva
1896b8009a MDL-56307 course: API changes to support retrieve by time 2016-10-25 10:10:52 +01:00
Pau Ferrer Ocaña
6f26fcd7e0 MDL-54894 comments: Get course from context if not informed 2016-06-20 08:58:05 +02:00
Marina Glancy
c0e3e9da37 MDL-54116 block_comments: warnings when commenting outside of a course 2016-05-26 10:19:31 +08:00
Frederic Massart
23381ab803 MDL-51036 tool_lp: Making comments work inside templates 2016-04-18 10:58:49 +08:00
David Monllao
9b27c8840d Merge branch 'MDL-47773-master-commentui' of git://github.com/mudrd8mz/moodle 2015-04-07 11:34:23 +08:00
Eloy Lafuente (stronk7)
0a2224b961 Merge branch 'MDL-49203-master' of git://github.com/jleyva/moodle 2015-04-02 13:19:35 +02:00
Juan Leyva
e7f4cf2ab7 MDL-49203 webservices: Fix unit tests for avoid random order issues
This problem usually happens in Postgres where a set of records is
ordered by a timestamp column and there are two or more records with
the same value
2015-04-02 12:57:22 +02:00
David Mudrák
3e4f5e6591 MDL-47773 comment: Indicate comment being saved via AJAX
This should be considered as quick & dirty usability fix as the whole JS
should ideally be rewritten and this behaviour should use CSS classes.
2015-03-31 13:59:59 +02:00
Dan Poltawski
90748dfb52 Merge branch 'MDL-49674-master-commentformat' of git://github.com/mudrd8mz/moodle 2015-03-31 12:16:58 +01:00
Juan Leyva
2016c7d4d0 MDL-49203 webservices: Unit tests for the new external function 2015-03-26 15:59:15 +01:00
Juan Leyva
e77a0f368f MDL-49203 webservices: Coding style fixes, ws added to the app service 2015-03-26 15:57:58 +01:00
Costantino Cito
be9854162f MDL-49203 webservices: New WS core_comment_get_comments 2015-03-26 15:57:21 +01:00
David Mudrák
2b6f97fded MDL-49674 comment: Use correct format when displaying the comment
The plugin callback executed above can eventually change the format. We
need to use that one to have the formatting of the first AJAX response
consistent with following displays.
2015-03-26 12:55:18 +01:00