99367 Commits

Author SHA1 Message Date
Andrew Nicols
8d8443411d Merge branch 'MDL-70065' of https://github.com/timhunt/moodle 2020-11-11 09:49:26 +08:00
Sara Arjona
16af4ae4db Merge branch 'MDL-70106-icon-cache' of https://github.com/Peterburnett/moodle 2020-11-10 16:53:27 +01:00
Jun Pataleta
84b7d23334 Merge branch 'MDL-69930-master' of https://github.com/HuongNV13/moodle
# Conflicts:
#	question/type/ddimageortext/amd/build/question.min.js
#	question/type/ddimageortext/amd/build/question.min.js.map
#	question/type/ddimageortext/amd/src/question.js
2020-11-10 14:11:54 +08:00
Jun Pataleta
62fcc8d22a Merge branch 'MDL-68349-master' of git://github.com/marinaglancy/moodle 2020-11-10 10:14:57 +08:00
Jake Dallimore
5365057493 Merge branch 'MDL-69841-master' of https://github.com/HuongNV13/moodle 2020-11-10 09:32:34 +08:00
Víctor Déniz
27ef489443 Merge branch 'MDL-69955-master' of https://github.com/HuongNV13/moodle 2020-11-09 21:46:53 +00:00
Eloy Lafuente (stronk7)
d330035f11 weekly release 4.0dev 2020-11-06 22:55:37 +01:00
Eloy Lafuente (stronk7)
7db6bb2343 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install into master 2020-11-06 22:55:34 +01:00
Víctor Déniz
4aa279956f Merge branch 'MDL-70137-master-2' of git://github.com/andrewnicols/moodle 2020-11-06 19:15:44 +00:00
Andrew Nicols
b8bf6f9c42 MDL-70137 cache: Write config to temp file and move into place 2020-11-06 19:15:43 +00:00
Andrew Nicols
db8377b53e MDL-70137 cache: Use sensible default when reading MUC config
When we read the MUC configuration, a file which exists but is empty
will not error, but will cause all configuration to be empty.

We already perform an {{is_array()}} check on the {{$configuration}}
variable, but the default value for {{$configuration}} is an empty
array. In the case where the file exists, but is empty, no errors occur
when the file is loaded, and the initial {{$configuration}} value is
not overwritten, leading to the file being replaced with an empty copy.
2020-11-06 19:15:34 +00:00
Eloy Lafuente (stronk7)
114102d37d Merge branch 'MDL-70143-master' of git://github.com/marinaglancy/moodle into master 2020-11-06 19:52:03 +01:00
Marina Glancy
c2aa5a29f1 MDL-70143 tool_uploaduser: fix wrong cache reference 2020-11-06 19:31:25 +01:00
Eloy Lafuente (stronk7)
1c3871e25a Merge branch 'MDL-70139-master' of git://github.com/sarjona/moodle into master 2020-11-06 19:27:10 +01:00
Sara Arjona
e85c7179b2 MDL-70139 core_badges: fix invalid request when sending to backpack
Having mixed $data in badge exporters is causing some issues.
As all these exporters are using $data as an object, $data can be
converted to object in the constructor, to avoid errors and get
the expected behaviour always.
2020-11-06 16:05:44 +01:00
Jun Pataleta
48e4dbea7c Merge branch 'MDL-70130-master' of git://github.com/andrewnicols/moodle 2020-11-06 11:28:02 +08:00
Andrew Nicols
c42c08793b MDL-70130 core: Compare realpaths for file attachment checks
Rather than using the provided path, the `realpath` must be used to
ensure that the use of symlinks in paths is normalised.
2020-11-06 10:54:09 +08:00
Andrew Nicols
4f22fad9ac MDL-70130 core: Simplify attachment handling in email_to_suer 2020-11-06 10:54:09 +08:00
Marina Glancy
e30716a16e MDL-70130 core: allow to attach files from localrequestdir to emails
Co-authored-by: Paul Holden <paulh@moodle.com>
2020-11-06 10:02:04 +08:00
Marina Glancy
8a9a4ee4f3 MDL-70131 cli: only allow to negate existing keys 2020-11-06 09:30:08 +08:00
Andrew Nicols
6d138e3675 Merge branch 'MDL-70120-assign-stamp-expires' of https://github.com/brendanheywood/moodle 2020-11-06 09:04:06 +08:00
AMOS bot
aa403760a0 Automatically generated installer lang files 2020-11-06 00:09:51 +00:00
Eloy Lafuente (stronk7)
ea32d651e9 weekly release 4.0dev 2020-11-05 12:15:57 +01:00
Jun Pataleta
2927457dbf Merge branch 'MDL-70075-master-2' of git://github.com/andrewnicols/moodle 2020-11-05 12:51:31 +08:00
Andrew Nicols
7d713f6060 Merge branch 'MDL-70066-master' of git://github.com/lameze/moodle 2020-11-05 10:00:33 +08:00
Andrew Nicols
7d786c7968 MDL-70075 core: Autocomplete selection should always have an active item
Ensure that there is always one active element in the list of selected
autocomplete elements.

Without this we have issues beacuse clicking on the link makes the first
one active if one is not already active, and this turns a click event
into a drag event, which means that it is not deleted.
2020-11-05 08:55:50 +08:00
Eloy Lafuente (stronk7)
b27a4e4573 Merge branch 'MDL-70100-master' of git://github.com/bmbrands/moodle into master 2020-11-04 22:39:24 +01:00
Víctor Déniz
65bb82c7c8 Merge branch 'MDL-70112' of https://github.com/timhunt/moodle 2020-11-04 19:17:04 +00:00
Sara Arjona
73758fc4d9 Merge branch 'MDL-70114-master' of git://github.com/bmbrands/moodle 2020-11-04 20:14:50 +01:00
Víctor Déniz
d8c9475572 Merge branch 'MDL-68749-master-2' of git://github.com/mickhawkins/moodle 2020-11-04 15:17:03 +00:00
Sara Arjona
e0a5d313e4 Merge branch 'MDL-70119-master' of git://github.com/ferranrecio/moodle 2020-11-04 15:19:28 +01:00
Bas Brands
4f9f4b2af5 MDL-70114 mod_data: add border for to textarea 2020-11-04 13:29:31 +00:00
Ferran Recio
9ca1707f5a MDL-70119 core_badges: fix tab names 2020-11-04 12:49:12 +01:00
Brendan Heywood
8e7ec10968 MDL-70120 assignfeedback_editpdf: Stamp files should be cached 2020-11-04 22:42:21 +11:00
Simey Lameze
edf2df07fe MDL-70066 badges: change usages of array_key_exists to isset 2020-11-04 15:50:15 +08:00
Peter Burnett
7fe1554c21 MDL-70106 cache: Set icon localstorage cache to use theme localisation 2020-11-04 13:29:53 +10:00
Andrew Nicols
a88838c25f MDL-70075 core: Do not return a value in an event handler
Returning a value of `false` in an event handler has the effect of
calling event.preventDefault() and event.stopPropagation().

This is neither obvious, nor desirable in this situation.
2020-11-04 11:27:55 +08:00
Andrew Nicols
5d16bfcf7c MDL-70075 core: jQuery.attr() does not accept a bool value
The documented values that jQuery.attr() accepts are String, Number, or
null. For some reason, when we pass a Boolean value, the subsequent
click handler does not work in some situations.

Changing this to take a Number, and unsetting it when empty, resolves
this issue.
2020-11-04 11:27:55 +08:00
Andrew Nicols
189a4c8f8e MDL-70075 core: Listen for change in accessibleChange event
The accessibleChange custom interaction event was only listening for
blur and focus, however some OS/browser combinations do not emit these
events until the element is explicitly blurred. This is notably
different on Firefox on some Operating Systems.

Recent changes in MDL-68167 explicitly moved the user participants page
filter module to use the accessibleChange event, which means that the
selections are now only triggered on an explicit blur when using
Firefox. This highlight a bug whereby, when the mouse is used to make a
selection, the event is not triggered until the element is blurred.

This change modifies the accessibleChange event to ignore the `change`
event where it was triggered by the keyboard and where that keybaord
event was not a [return] or [escape] keypress, but to otherwise respect
the native change event.
2020-11-04 11:27:55 +08:00
Andrew Nicols
3caa6bfbe1 MDL-70075 core: Listen for the focus and blur events again
The `blur` event does not bubble, but the `focusout` events are not
available in all supported versions of Firefox.

Rather than switching event, this patch using event capture to
effectively achieve the same result and bubble the event up through the
DOM to the delegated listener.

There should be no functional change with this patch, except to support
Firefox fully.
2020-11-04 11:27:55 +08:00
Huong Nguyen
d67bcd6b9a MDL-69955 qtype_ddimageortext: drop zone disappear in special case 2020-11-04 09:51:00 +07:00
Jake Dallimore
3ab2d0010b Merge branch 'MDL-70093-master' of https://github.com/golenkovm/moodle 2020-11-04 09:00:05 +08:00
Tim Hunt
a26c04c34a MDL-70112 drag-drop qtypes: fix form preview 2020-11-03 21:25:51 +00:00
Mihail Geshoski
253af8711d MDL-67837 backup: Add unit tests 2020-11-03 12:34:28 +01:00
Mihail Geshoski
c8ac07fb50 MDL-67837 backup: Verify caps before unenrolling users on course restore 2020-11-03 12:34:28 +01:00
andreasschenkel
85994027bd MDL-69844 user: Fix no email in download_participants_table
Only include eMail in download_participants_table 
if selected in showuseridentity 
($identityfieldsselect)
2020-11-03 12:34:28 +01:00
Juan Leyva
8169aeff59 MDL-67015 mod_data: Prevent users adding entries to other groups 2020-11-03 12:34:28 +01:00
Amaia Anabitarte
66be08216e MDL-69046 core_contentbank: Escape quotes when showing name 2020-11-03 12:34:28 +01:00
Ferran Recio
b8e1eec4c7 MDL-69378 tool_uploadcourse: fix enrolment methods uploads 2020-11-03 12:34:28 +01:00
Peter Dias
828caaac70 MDL-56310 restore: Confirm user has permission to change capabilities 2020-11-03 12:34:28 +01:00