This adds the following changes when viewing a list of discussions and
forum_enabletimedposts is turned on.
* Discussions a student wouldnt see right now are dimmed (timestart in
future or timeend in the past).
* A icon appears next to the discussion subject, the tooltip for this
icon displays the display start and/or end time. This only appears for
the user that made the discussion or has permission to
viewhiddentimedposts.
These two changes achieve a couple of important things, namely, teachers
will not mistakenly think their students can see a discussion when
viewing the list if they've later forgot that they set a time limit on
it (or indeed if someone else put it on their discussion without them
realising). Additionally it makes it easy to see from the list when
different discussions are set to be released without having to go in and
edit them to find out.
Change-Id: Ia1818b33c00adae0dad72df8e170a078fb66cd76
The YUI notification dialogues will now set the appropriate
aria attributes when they are shown/hidden to allow screen
readers to navigate them correctly.
When the dialogue is shown all background elements will be marked
as hidden while the dialogue is marked as visible to a screen reader.
When the dialogue is closed the modified elements will be reverted
to their previous state and the dialogue will be marked as hidden to
a screen reader.
The change in MDL-51090 broke manually commenting on questions for which
no mark is given (max mark == 0). This fixes it, with unit tests.
Thanks to Nick Phillips for the original suggestion of the fix.
The upgrade key can be defined in the main config.php as
$CFG->upgradekey. If it is defined there, then its value must be
provided every time the site is being upgraded, regardless the
administrator is logged in or not.
Not directly related to the issue but spotted while developing it and it
is not worth of submitting in a separate issue.
At the Plugins check page, when the "Display the full list of installed
plugins" link was followed, the heading at the next page read something
like "Number of plugins requiring your attention: 357". That is
misleading as this is actually not the number of displayed plugins, not
the number of plugins requiring attention.
