20488 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
95f82860d5 Merge branch 'MDL-62610-master' of git://github.com/lameze/moodle 2018-10-03 18:00:08 +02:00
Jun Pataleta
850707a0bb Merge branch 'MDL-35788-master' of git://github.com/andrewnicols/moodle 2018-10-03 10:13:40 +08:00
Eloy Lafuente (stronk7)
682357004f Merge branch 'MDL-60685-master' of git://github.com/damyon/moodle 2018-10-03 00:23:10 +02:00
Simey Lameze
484b179d06 MDL-62610 mod_quiz: fix behat failure 2018-10-01 09:53:34 +08:00
Simey Lameze
73aefa6bfc MDL-62610 mod_quiz: fix CiBoT issues 2018-10-01 08:27:28 +08:00
Andrew Nicols
424920f8fb MDL-35788 forum: Show post creation time not modified 2018-10-01 08:16:42 +08:00
Shamim Rezaie
422d78648c MDL-63390 quiz_statistics: Make the summary row more distinguishable 2018-10-01 07:52:59 +08:00
Shamim Rezaie
24c28f3c9b MDL-63390 Quiz: Use lang rules to format quiz summark as a percentage
Part of MDL-62610
2018-10-01 07:52:50 +08:00
Shamim Rezaie
bef224c6e4 MDL-63390 quiz_statistics: Added formating functions
Refactored quiz_statistics_table class to remove some duplications by defining and using
format_range(), format_percentage() and format_percentage_range() methods.

Part of MDL-62610
2018-10-01 07:52:42 +08:00
Shamim Rezaie
84140b9137 MDL-63390 quiz_statistics, question: Handling variants as well
Variants should also be treated like random questions in the sense that
a summary row
should be displayed for them as well.
This commit deals with handling variants.
Also the name of the calculated_random_question_summary class has
changed to
calculated_question_summary to be more generic as the summary row is not
specific to random questions only.
Also removed the protected function too_many_subq_and_or_variant_rows
and the const SUBQ_AND_VARIANT_ROW_LIMIT as they were not being used
anymore.

Part of MDL-62610
2018-10-01 07:52:31 +08:00
Tim Hunt
c5499edaef MDL-63185 mod_quiz: more fixes to new behat code
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
9b1fc262d8 MDL-63185 mod_quiz: make CiBoT happy again
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
bd92cfc6f9 MDL-63185 mod_quiz: add behat coverage for statistics report
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
df48d3cc71 MDL-63185 mod_quiz: replace user session handling to use set_user()
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
6e4fe9afe0 MDL-63185 mod_quiz: convert responses report behat to use new step
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
90ef250d52 MDL-63185 mod_quiz: create steps to handle diferent behaviours
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
3c4ff02e41 MDL-63185 mod_quiz: replace existing tests to use new step
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
5c0654d7ff MDL-63185 mod_quiz: change APIs to handle attempts on behat
Thanks to Tim Hunt for all the help.

Part of MDL-62610
2018-09-28 11:07:21 +08:00
Simey Lameze
35aa9ade76 MDL-63185 mod_quiz: add custom behat step to create user attempts
Thanks to Tim Hunt for all the help.

Part of MDL-62610
2018-09-28 11:07:21 +08:00
Shamim Rezaie
b5fff70bdd MDL-63186 quiz_statistics: Highlight the summary row if is dubious
The summary row should be highlighted if any of the summarised rows are dubious.

Part of MDL-62610
2018-09-28 11:07:21 +08:00
Shamim Rezaie
666889f0f8 MDL-63186 quiz_statistics: Show each columns min,max in the summary row
The statistics table have been modified so that the summary row shows the minimum and maximum
values of each column for the set of questions that are being summarised.

Part of MDL-62610
2018-09-28 11:07:21 +08:00
Shamim Rezaie
6a966ea8d4 MDL-63186 workshopform_numerrors: Move percents lang string to core
Moved 'percents' lang string from workshopform_numerrors to core_moodle.

AMOS BEGIN
 MOV [percents,workshopform_numerrors],[percents,core_moodle]
AMOS END

Part of MDL-62610
2018-09-28 11:07:21 +08:00
Shamim Rezaie
6ee2b972c9 MDL-63186 quiz_statistics: Remove q number from the summary row
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Ryan Wyllie
29cc55079a MDL-63186 question: include random questions in statistics calculator
Part of MDL-62610
2018-09-28 11:07:21 +08:00
Eloy Lafuente (stronk7)
51181541ab Merge branch 'MDL-62279-master' of git://github.com/damyon/moodle 2018-09-25 23:25:10 +02:00
Eloy Lafuente (stronk7)
fc008d6769 MDL-57610 assignfeedback_editpdf: add missing UK to install.xml 2018-09-25 15:21:42 +02:00
Eloy Lafuente (stronk7)
4f06a97702 Merge branch 'MDL-57610' of git://github.com/aolley/moodle 2018-09-25 14:46:09 +02:00
David Monllao
9d4c8d45ef Merge branch 'MDL-62717-master' of https://github.com/lucaboesch/moodle 2018-09-25 12:18:36 +02:00
Adam Olley
1afbb97b6b MDL-57610 assignfeedback_editpdf: integration cleanup
* Add a note to upgrade.php to notify devs/admins of the new setting.
* Replace update_record with set_field.
* Add missing phpdoc.
2018-09-25 09:54:39 +09:30
Jonathan Champ
b2f349a433 MDL-54035 accesslib: separate role definition cache clear
Thanks to MDL-49398, we can separate the combined user session and role
definition cache clearing function into two separate functions. At the
same time, we want to identify and remove mark_dirty() calls that were
added for role definition changes but were incorrectly left behind.

Change highlights:
 - Remove unnecessary mark_dirty() calls performed after
   assign_capability(), unassign_capability(), delete_role(),
   deleted contexts, brand new contexts
 - Move role definition cache clear from the user-centric
   accesslib_clear_all_caches() to the newly created,
   role-dedicated accesslib_reset_role_cache()
2018-09-21 09:17:42 -04:00
Luca Bösch
490476a118 MDL-62717 forum: Create announcements forum with HTML format intro. 2018-09-20 17:47:35 +02:00
David Monllao
4453613767 Merge branch 'MDL-63140-master' of git://github.com/rezaies/moodle 2018-09-19 13:30:43 +02:00
David Monllao
25561b3751 Merge branch 'MDL-63135-master' of git://github.com/rezaies/moodle 2018-09-19 13:12:40 +02:00
David Monllao
542201d547 Merge branch 'MDL-63138-master' of git://github.com/rezaies/moodle 2018-09-18 16:39:58 +02:00
David Monllao
11decdb19c Merge branch 'MDL-63139-master' of git://github.com/rezaies/moodle 2018-09-18 16:36:55 +02:00
David Monllao
6302d4cf64 Merge branch 'MDL-63117-master' of git://github.com/rezaies/moodle 2018-09-18 16:32:58 +02:00
Adam Olley
bc32547da9 MDL-57610 assignfeedback_editpdf: Add test coverage for conversion task
Without this, we have no coverage of the convert_submissions task. This test
validates it both works normally, and that it also skips queued items that have
exceeded the conversion attempt limit introduced in this improvement.
2018-09-18 14:14:24 +09:30
Adam Olley
b722a457ad MDL-57610 assignfeedback_editpdf: remove queued jobs that keep failing
Without this, its possible to get a document in the editpdf conversion queue
that keeps failing - and in some cases completely crashing the PHP script
despite exception handling - which ends up blocking the processing of the queue
entirely.

This change allows for a configurable number of attempts the conversion
task will perform before removing the item from the queue.
2018-09-17 09:30:43 +09:30
Amaia Anabitarte
b0af7093cf MDL-58781 mod_feedback: Inconsistency in analysis exported to excel 2018-09-14 12:47:56 +02:00
Shamim Rezaie
50f347214e MDL-63140 mod_glossary: Check if the module is visible to the user 2018-09-14 17:43:23 +10:00
Jun Pataleta
82585098f8 Merge branch 'MDL-50314_master' of git://github.com/do-you-even-curl/moodle 2018-09-12 09:44:36 +08:00
Eloy Lafuente (stronk7)
6625cff604 Merge branch 'MDL-63136-master' of git://github.com/rezaies/moodle 2018-09-11 23:52:02 +02:00
Tim Schroeder
3a33d51497 MDL-50314 mod_quiz: removed hardcoded export columns
* The columns 'institution', 'department' and 'email' are no longer
  automatically included in all quiz result exports.
* These columns can still be used, but have to be configured under
  'showuseridentity'.
2018-09-07 14:18:25 +02:00
Shamim Rezaie
00aa8d3f32 MDL-63140 mod_glossary: Add userid param to glossary calendar callbacks 2018-09-07 18:20:03 +10:00
Shamim Rezaie
eb4c801cef MDL-63136 mod_data: Check if the module is visible to the user 2018-09-07 17:40:29 +10:00
Shamim Rezaie
362f9e7c61 MDL-63136 mod_data: Add userid param to mod_data calendar callbacks 2018-09-07 17:40:16 +10:00
Shamim Rezaie
46b29219e3 MDL-63139 mod_forum: Check if the module is visible to the user 2018-09-07 16:55:19 +10:00
Shamim Rezaie
d46da4aadc MDL-63139 mod_forum: Add userid param to mod_forum calendar callbacks 2018-09-07 16:47:56 +10:00
Shamim Rezaie
ac0f38b1d8 MDL-63138 mod_folder: Check if the module is visible to the user 2018-09-07 14:58:35 +10:00
Shamim Rezaie
a0e19ccf32 MDL-63138 mod_folder: Add userid param to mod_folder calendar callback 2018-09-07 14:58:16 +10:00