20488 Commits

Author SHA1 Message Date
Damyon Wiese
8cee90e3bf MDL-61650 assign: More consistent empty text
Consistently check for empty submissions with count_words(trim($text)).
2018-08-03 16:52:31 +08:00
Damyon Wiese
cc9384f121 MDL-62279 assign: Properly set the defaults
Before an assignment has been created, we need to use the site defaults,
not the per instance defaults for the settings.
2018-08-03 15:03:53 +08:00
Damyon Wiese
851b5c7f2a MDL-60685 assign: Do not falsely use admin user
When an assign_grades record is automatically populated, do not use the admin user as the default grader.

This would generate false information on the assignment summary screen and send false notifications from
the admin user.
2018-08-02 14:19:34 +08:00
Damyon Wiese
192e48bb90 MDL-61870 mod_assign: Conditionally backup groups
When group info is not backed up, do not backup assignment submissions or overrides that related to a specific group.
We are already correctly not restoring them, but it is more robust not to include them in the backup file at all.
2018-08-02 12:55:13 +08:00
Zig Tan
8ea4df50c9 MDL-61870 mod_assign: Fix/clean up imported group override duedates
Applying patch supplied from Damyon Wiese to address the root-cause
of this issue in the backup/restore logic.
2018-08-02 12:55:13 +08:00
Zig Tan
6bcc6f877a MDL-61870 mod_assign: Fix/clean up imported group override duedates
- Prevent group override duedate events from being imported when groups are excluded
- Clean up any existing group override duedate events when editing assignment in upgradelib.php
- Updated lib.php unit tests
2018-08-02 12:55:12 +08:00
Adrian Greeve
eb8dfd5bf8 MDL-57244 lib: Update to upgrade.txt files about renamed classes. 2018-08-02 10:34:18 +08:00
Eloy Lafuente (stronk7)
20c7822f6d Merge branch 'MDL-57244-master' of git://github.com/abgreeve/moodle 2018-08-02 00:24:14 +02:00
Eloy Lafuente (stronk7)
d2ba6eea3b Merge branch 'MDL-62977_master' of git://github.com/markn86/moodle 2018-08-01 16:36:25 +02:00
Eloy Lafuente (stronk7)
1ffa22bbc7 Merge branch 'MDL-61041-master' of git://github.com/damyon/moodle 2018-08-01 16:36:12 +02:00
Eloy Lafuente (stronk7)
8c76cf65e8 Merge branch 'MDL-62344-master-final' of https://github.com/Tsheke/moodle 2018-07-31 23:53:52 +02:00
David Monllao
77f9983189 Merge branch 'MDL-61290_master' of https://github.com/aanabit/moodle 2018-07-31 17:18:17 +02:00
Amaia Anabitarte
4a6cd05ae1 MDL-61290 mod_feedback: adding groups to csv download
Thanks Christine LEGEMBLE for your proposal
2018-07-31 15:32:43 +01:00
David Monllao
834ee94fe3 Merge branch 'master_MDL-58015' of https://github.com/danmarsden/moodle 2018-07-31 13:36:21 +02:00
David Monllao
f3e240e7e0 Merge branch 'MDL-59611-master' of git://github.com/damyon/moodle 2018-07-31 13:30:41 +02:00
Jun Pataleta
77b6d458e5 Merge branch 'MDL-58768-master-2' of git://github.com/rezaies/moodle 2018-07-31 16:18:44 +08:00
David Monllao
627d9aa6c8 Merge branch 'MDL-55188-master' of git://github.com/abgreeve/moodle 2018-07-30 17:33:21 +02:00
Mark Nelson
8bfe908209 MDL-63002 core: fixed incorrect calls to non-existent delete_record() 2018-07-30 20:59:42 +08:00
Claude Vervoort
29acede1f0 MDL-62993 ltiservice_memberships: make message an array per spec
Also added resultSourcedId to member for BC.
2018-07-30 10:05:46 +08:00
Mark Nelson
4d67fe6161 MDL-50225 core: replace usages of print_textarea() 2018-07-30 09:57:01 +08:00
Mark Nelson
c1f7cf67f4 MDL-50225 mod_wiki: removed unused file wiki/editors/html.php 2018-07-30 09:55:12 +08:00
Adrian Greeve
5454e72c21 MDL-55188 events: First deprecation of eventslib.php 2018-07-30 09:23:54 +08:00
Shamim Rezaie
fda4374a67 MDL-58768 mod_assign: Added userid param to calendar callbacks
The mod_assign_core_calendar_is_event_visible and mod_assign_core_calendar_provide_event_action
functions now accept a new parameter ($userid) so they are not always dependet to the logged in user.
2018-07-28 07:51:33 +10:00
Shamim Rezaie
907b175c05 MDL-58768 core: Fix a typo for callback name 2018-07-28 07:51:33 +10:00
Shamim Rezaie
faa5d173cc MDL-58768 mod_assign: Add $user param to assign::can_grade 2018-07-28 07:51:32 +10:00
Shamim Rezaie
95ae74a7bc MDL-58768 calendar: Add $requestinguser to the container class
The requesting user is not always the same as the current user. The container class now allows a different user
to be set as the requesting user. All capability checks are done against the requesting user.

Also, the $requestinguser is passed to core_calendar_provide_event_action and core_calendar_is_event_visible
callback functions. These callback functions need to be updated in all activity modules to accept a $user parameter.
2018-07-28 07:51:32 +10:00
Johnny Tsheke
155bf1dd2f MDL-62344 mod_label: ID number feature support 2018-07-27 06:03:24 -04:00
Mark Nelson
1b722e3c31 MDL-62977 mod_wiki: style buttons appropriately 2018-07-27 10:46:35 +08:00
Dan Marsden
7c75e02730 MDL-58015 mod_scorm: set orgidentifier correctly for popup. 2018-07-27 10:36:09 +12:00
Vadim Tabunshchik
d5f47f8f39 MDL-62871 quiz: incorrect foreign key declaration 2018-07-26 11:36:43 +02:00
Eloy Lafuente (stronk7)
e270bf92a1 Merge branch 'MDL-62771-master_move_plag_disclosure' of https://github.com/jmcgettrick/moodle 2018-07-26 00:34:37 +02:00
Damyon Wiese
3412b12c22 MDL-61041 assign: Remove assignment 2.2 upgrader 2018-07-25 14:11:10 +08:00
Tony Butler
9ed5b0c1f6 MDL-59611 mod_assign: Move help icons for subplugin types out of labels 2018-07-25 12:23:08 +08:00
Cory Buecker
520c5e080b MDL-62969 mod_lti: fix parsed value for LtiLink.memberships.url
Fixes a typo in the function that replaces the LTI placeholder variable
LtiLink.memberships.url with the actual endpoint. Without this change,
the placeholder variable, "$LtiLink.memberships.url" is not replaced in
the LTI launch parameters.
2018-07-25 11:59:36 +08:00
Eloy Lafuente (stronk7)
193a3aa9d7 Merge branch 'MDL-62961_master' of git://github.com/markn86/moodle 2018-07-25 01:24:34 +02:00
cescobedo
605354de50 MDL-53297 core_course: Final deprecation of xxx_delete_course callback 2018-07-24 23:09:47 +02:00
Eloy Lafuente (stronk7)
402d1c538a Merge branch 'MDL-62925_master' of git://github.com/markn86/moodle 2018-07-24 18:31:48 +02:00
Adrian Greeve
3714fe7e6e MDL-57244 general: Remove old class renames. 2018-07-23 15:54:13 +08:00
Mark Nelson
0089fc929e MDL-62961 mod_feedback: style buttons appropriately 2018-07-23 15:47:38 +08:00
Mihail Geshoski
10bd37fabd MDL-54742 general: Remove strings deprecated in 3.2 2018-07-23 14:25:14 +08:00
Jun Pataleta
432e755f2b Merge branch 'MDL-62769' of https://github.com/timhunt/moodle 2018-07-19 08:46:50 +08:00
David Monllao
810f12c25b Merge branch 'MDL-53972-master' of git://github.com/mihailges/moodle 2018-07-19 08:46:48 +08:00
David Monllao
98b5b9d8a5 Merge branch 'MDL-61355' of git://github.com/danmarsden/moodle 2018-07-19 08:46:46 +08:00
Andrew Nicols
affd85ce24 Merge branch 'MDL-53697-master' of git://github.com/abgreeve/moodle 2018-07-17 11:36:44 +08:00
Mark Nelson
94a1861c84 MDL-62925 mod_wiki: style 'Search wikis' button 2018-07-17 11:31:20 +08:00
David Monllao
aa59fb2ea2 Merge branch 'MDL-49025' of https://github.com/NeillM/moodle 2018-07-16 13:34:57 +02:00
David Monllao
011c1a4291 Merge branch 'MDL-61019-master' of https://github.com/lucaboesch/moodle 2018-07-16 13:25:06 +02:00
Mihail Geshoski
98f9db0d63 MDL-53972 feedback: Final deprecation in mod/feedback/lib.php 2018-07-16 14:21:18 +08:00
Neill Magill
650779d609 MDL-49025 assign: Submissions of an empty directory should not save
Before this change if only a folder was submitted the submission_is_empty
check would return true. This meant that the draft area would be saved.
The is_empty check would then be called which would return false. This
caused the submission form to indicate to the user that the submission
had failed.

Now is_empty and submission_is_empty should both return false if only
folders are submitted.
2018-07-13 14:03:42 +01:00
Neill Magill
3ebfab9810 MDL-49025 assign: Test than an empty directory will not submit 2018-07-13 14:03:41 +01:00