113046 Commits

Author SHA1 Message Date
Paul Holden
97a5b89317
Merge branch 'MDL-81163-main' of https://github.com/sarjona/moodle into main 2024-03-21 14:41:41 +00:00
Sara Arjona
3e2b8eed3c
Merge branch 'MDL-80636-main' of https://github.com/laurentdavid/moodle 2024-03-21 15:40:24 +01:00
Sara Arjona
f54c1b9293
Merge branch 'MDL-69688' of https://github.com/stronk7/moodle 2024-03-21 15:29:47 +01:00
Sara Arjona
484e52f6ae
Merge branch 'MDL-80245' of https://github.com/paulholden/moodle 2024-03-21 15:01:18 +01:00
Paul Holden
fbfcb6733d
MDL-80245 reportbuilder: implement interface elements for report tags.
Allow them to be edited during report creation/updating, display in
report listings table with filtering, and implement tag callback to
allow them to be discoverable across the site.
2024-03-21 13:11:22 +00:00
Sara Arjona
2291df7225
Merge branch 'MDL-81294-main' of https://github.com/roland04/moodle 2024-03-21 13:21:42 +01:00
Huong Nguyen
0342c13053 Merge branch 'MDL-81276-main' of https://github.com/aanabit/moodle 2024-03-21 15:27:39 +07:00
Huong Nguyen
ccefde0f53 Merge branch 'MDL-81289-main' of https://github.com/ferranrecio/moodle 2024-03-21 15:12:01 +07:00
Huong Nguyen
d1b1d9d771 Merge branch 'MDL-80835-main' of https://github.com/snake/moodle 2024-03-21 14:53:07 +07:00
Jake Dallimore
7e56b46abc
MDL-80835 auth_lti: fix bad cast breaking samesite LTI usage 2024-03-21 15:35:48 +08:00
Jake Dallimore
35e82b9fad
MDL-80835 enrol_lti: add partitioning support for OIDC state cookie
Adds the property that is required by Chrome to opt-in to its 3rd party
cookie partitioning solution, CHIPS. This specific change ensures the
'state' cookie, used in the OIDC handshake, has partitioning support.
This cookie can be partitioned unconditionally, since it's a cookie
controlled by the library and one we don't expect to be set without
partitioning elsewhere.
2024-03-21 15:35:48 +08:00
Jake Dallimore
18e26b5abe
MDL-80835 auth_lti: add partitioning to post-auth MoodleSession cookie
Adds the property that is required by Chrome to opt-in to its 3rd party
cookie partitioning solution, CHIPS. This specific change to auth_lti is
to ensure the MoodleSession Set-Cookie header resulting from
complete_user_login() calls (in auth.php) have this property set.
2024-03-21 15:35:48 +08:00
Jake Dallimore
aea624fcb0
MDL-80835 enrol_lti: add cookies required notice to auth login endpoint
This will be displayed if the cookie checks fail, which currently occurs
in Safari only.
2024-03-21 15:35:48 +08:00
Jake Dallimore
b293cb5da6
MDL-80835 enrol_lti: add partitioning support to MoodleSession cookie
Adds the property that is required by Chrome to opt-in to its 3rd party
cookie partitioning solution, CHIPS. This specific change deals with the
cookie that is set when the user is not yet auth'd with the site and is
necessary to facilitate OIDC nonce retrieval and validation.
2024-03-21 15:35:48 +08:00
Jake Dallimore
a92f780b23
MDL-80835 auth_lti: add cookie helper facilitating CHIPS opt-in
To opt a cookie in to Chrome's 3rd party cookie partitioning solution,
CHIPS, the property 'Partitioned;' needs to be set. This adds a helper
class supporting this, for a given cookie(s).

Note also, PHP's native
cookie APIs (setcookie, etc) don't support this cookie property yet -
(https://github.com/php/php-src/issues/12646).

Since this class is intended to allow existing Set-Cookie headers to be
modified before being sent (e.g. allowing clients to set a property on a
cookie set elsewhere in code), it deals with the headers directly anyway
but it means that new cookies must also use this helper to opt-in,
instead of relying on setcookie(). E.g. where the intent is to add
partitioning support to a new cookie, that cookie must first be set
(setcookie) and then it may opt-in to partitioning via this helper;
partitioning support cannot be achieved directly through setcookie and
friends yet.
2024-03-21 15:35:48 +08:00
Eloy Lafuente (stronk7)
0f3775088f
MDL-69688 phpunit: Improve test_context_not_used
This adds a few changes to the old test_context_not_used test:

- Move it to become an advanced_test, because its mission
  is to verify that the assertEventContextNotUsed() assertion
  works as expected.
- For consistency, also move the fixtures to own phpunit fixtures.
- Add proper coverage tags, to verify that the assertion is being
  covered.
- Add a data provider to provide all the current cases and ease
  any future case that may be needed in the future. One by one
  because previously there was code never executed with the
  warning expectation causing the test to stop.
- Run them in isolation, while this is not strictly required, it's
  including external fixtures and, we'll need that isolation soon
  (for changes coming when moving the test to PHPUnit 9.6 in MDL-81266).
2024-03-21 08:31:08 +01:00
Ilya Tregubov
1e13aa23b6 Merge branch 'MDL-80850-main' of https://github.com/HuongNV13/moodle 2024-03-21 14:24:42 +08:00
Huong Nguyen
b0220f27cb MDL-80850 Javascript: Add new core/dropzone module 2024-03-21 12:45:55 +07:00
Ilya Tregubov
cd2fb2fe78 Merge branch 'MDL-79668-main' of https://github.com/kevpercy/moodle 2024-03-21 12:22:58 +08:00
Huong Nguyen
6b09a619e5 Merge branch 'MDL-80923-main' of https://github.com/sarjona/moodle 2024-03-21 11:20:33 +07:00
Huong Nguyen
c8d78c8476 Merge branch 'MDL-80949-main' of https://github.com/sarjona/moodle 2024-03-21 10:58:59 +07:00
Ilya Tregubov
45750b413e Merge branch 'MDL-81050-main' of https://github.com/roland04/moodle 2024-03-21 10:52:39 +08:00
Sara Arjona
be1bb3dfc3
Merge branch 'MDL-80290-task-ui' of https://github.com/brendanheywood/moodle 2024-03-20 17:12:13 +01:00
Sara Arjona
92cceb7b5f
Merge branch 'MDL-80560' of https://github.com/marinaglancy/moodle 2024-03-20 17:08:19 +01:00
Sara Arjona
9d7ab10f29
MDL-81163 course: Use component_callback for is_branded 2024-03-20 17:04:55 +01:00
Sara Arjona
5e5f06ba68
MDL-80923 course: Replace custom element with placeholder
In the section settings page, replace the custom checkbox element
used for renaming with a standard input text field featuring a
placeholder.
This adjustment aims to enhance user experience by simplifying the
interaction and aligning with modern design standards.
2024-03-20 12:02:38 +01:00
Mikel Martín
1248fa7537 MDL-81294 core: Fix sticky footer height
In MDL-81184 a regression was generated by changing the height property
with min-height in the sticky footer. That caused unexpended behaviour
of the sticky footer being partially displayed in the course page
for small devices.
Replacing min-height with height as the original design.
2024-03-20 11:38:22 +01:00
Jun Pataleta
20a7f5a180
Merge branch 'MDL-81110-main' of https://github.com/roland04/moodle 2024-03-20 11:10:25 +08:00
Jun Pataleta
9573a6f9c1
Merge branch 'MDL-79007_main' of https://github.com/marxjohnson/moodle 2024-03-20 10:45:14 +08:00
Ilya Tregubov
39b8e198ff on-demand release 4.4dev+ 2024-03-20 08:54:40 +08:00
Ilya Tregubov
a04bd247be Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2024-03-20 08:54:36 +08:00
Amaia Anabitarte
0cf88daffd MDL-81276 mod_scorm: Fix minimum score validation 2024-03-19 22:43:22 +01:00
ferranrecio
19af72f6ca MDL-81289 core_courseformat: fix get_format_string params 2024-03-19 17:27:03 +01:00
Paul Holden
399be61cb9
Merge branch 'MDL-78438-main' of https://github.com/ilyatregubov/moodle into main 2024-03-19 23:18:13 +07:00
Sara Arjona
a399be5f01
Merge branch 'MDL-81073' of https://github.com/paulholden/moodle 2024-03-19 23:18:13 +07:00
Ilya Tregubov
8189d3b2f5
MDL-78438 gradereport_grader: Fix Behat test
Seems Oracle is too slow on pressing buttons :))
2024-03-19 23:18:13 +07:00
Huong Nguyen
5db6238c5b
Merge branch 'MDL-81156-main' of https://github.com/lameze/moodle 2024-03-19 23:18:13 +07:00
Andrew Nicols
3fb159a815
Merge branch 'MDL-77255-main' of https://github.com/HuongNV13/moodle 2024-03-19 23:18:12 +07:00
Mikel Martín
10f378a7a4 MDL-81050 course: Add behat scenarios for inline section renaming 2024-03-19 15:19:34 +01:00
Marina Glancy
c3db339f07 MDL-80560 admin: user list - show picture, download, fix identity fields 2024-03-19 12:20:35 +00:00
Mikel Martín
60a4bf5bcc MDL-81110 theme_boost: Fix scroll-margin-top in #maincontent
- Fix scroll-margin-top in #maincontent element
- Add scroll-margin-top for focused elements too
2024-03-19 10:21:19 +01:00
Mikel Martín
dba1efa28e MDL-81050 navigation: Add data attributes to sections in breadcrumbs
- Add a new method 'add_attribute' to navigation nodes to add HTML attributes to nodes.
- Add data-attribute to section nodes and include them in breadcrumb mustache to automatically update section titles
 when sections are renamed.
2024-03-19 08:53:49 +01:00
Mikel Martín
de9c2393b2 MDL-81050 course: Propagate section name change in the content
Add a new feature to propagate the section name change through the
course content. Any element with data-section-name-for=<sectionid>
will automatically update the section name.
2024-03-19 08:53:49 +01:00
Mikel Martín
34ab1582cb MDL-81050 course: Fix section renaming in section page
Fix section page heading title update when the section name has been
modified using inplace editable.
2024-03-19 08:53:49 +01:00
Mikel Martín
b73a685ef7 MDL-81050 output: Add new 'attributes' parameter to container 2024-03-19 08:53:49 +01:00
Huong Nguyen
52c481318a MDL-77255 block_tag_flickr: Update to match with the new API
Flickr dropped php_serial format, we need to change to JSON format
2024-03-19 10:14:18 +07:00
Ilya Tregubov
ef34a20e06 Merge branch 'MDL-79669' of https://github.com/Chocolate-lightning/moodle 2024-03-19 11:09:38 +08:00
Ilya Tregubov
eda139f3a0 Merge branch 'MDL-80240' of https://github.com/paulholden/moodle 2024-03-19 10:27:54 +08:00
Ilya Tregubov
d567ba9a81 Merge branch 'MDL-80919' of https://github.com/paulholden/moodle 2024-03-19 10:14:07 +08:00
Brendan Heywood
51a752fae2 MDL-80290 task: Refactor styles to be consistent 2024-03-19 13:02:39 +11:00