3140 Commits

Author SHA1 Message Date
Jun Pataleta
a2ddc55f69
MDL-80043 grade: Add upgrade.txt notes 2023-12-01 09:15:04 +08:00
Jun Pataleta
cc6b3c161f
MDL-80043 gradereport_grader: Define editingmode_title lang string 2023-12-01 09:15:04 +08:00
Jun Pataleta
18e5768332
MDL-80043 grade: editingmode_title support for grade report plugins
* Add support for grade report plugins that define an
`editingmode_title` lang string. If the grade report plugin defines this
 language string, it will be used for the page title's unique
 identifying information when editing mode is turned on.
2023-12-01 09:15:04 +08:00
Jun Pataleta
fe3ff7dd69
MDL-80043 gradereport_singleview: Improve heading wordings
* Make the headings for the single view easier to read and understand
* When on editing mode, update the heading for the grade and user
screens to convey to the user that the page is currently on editing
mode. This is helpful for screen reader users as they can immediately
know the current display mode of the single view report page when this
gets read via the page title.
2023-12-01 09:15:03 +08:00
Jun Pataleta
816fadfcd7
MDL-80043 grade: Use heading parameter for the page title if provided 2023-12-01 09:15:03 +08:00
Jun Pataleta
ed48b54542
MDL-80121 gradereport_singleview: Increase zero-state heading level
With the h2 heading not being rendered on the zero-state pages of the
Single view report, we need to increase the heading level of the
"Search for a user to view all their grades" and
"Select a grade item above" headings from h3 to h2.
2023-11-15 19:30:26 +08:00
Jun Pataleta
d8dbfe5d25
MDL-80121 grade: Trim heading
In order to prevent rendering an empty heading <h2>, we need to make
sure that the $heading parameter passed to print_grade_page_head() is
not an empty string.
2023-11-15 19:30:26 +08:00
Jun Pataleta
ad4736b5ec
MDL-79062 grade: Behat test fixes
* Feature: We can use a minimum grade different than zero
  - Use correct minimum input values.
  - Use data generators for faster test execution.
* Scenario: Disable category overriding
  - Use the field name to ensure that the correct field is being tested.
2023-11-02 21:45:26 +08:00
Jun Pataleta
6637197d97
MDL-79062 gradereport_grader: Set numeric type for grade value inputs
* Set grade inputs for grade items with type set to GRADE_VALUE to
number and add min and max input attributes, where necessary.
2023-11-02 21:45:26 +08:00
Jun Pataleta
15409cfa41
MDL-79062 gradereport_grader: Remove setting of tabindex >= 1
Tab indices that are greater than or equal to 1 break the natural
tab order of the document and may cause problems for keyboard users.
2023-11-02 09:51:39 +08:00
David Woloszyn
1652b5281e MDL-42189 gradereport_overview: Report hidden from suspended enrolments 2023-10-23 09:47:19 +11:00
Angelia Dela Cruz
1f602aabec MDL-79653 gradingform_guide: Behat coverage for deleting marking guide 2023-10-13 11:11:08 +08:00
Paul Holden
369c5407ab MDL-79426 gradeimport_csv: safely preview CSV content during import. 2023-10-04 02:10:16 +02:00
Jake Dallimore
925c36fb1d
Merge branch 'MDL-79056-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-10-03 12:03:58 +08:00
Jun Pataleta
adc138d1f1
MDL-79056 gradereport_user: Make column heading IDs unique
Associate column headings of user report tables to the user ID that the
report is being generated for. This will prevent duplicate IDs for the
report columns when multiple user report tables are displayed on the
User report page.
2023-09-29 11:03:36 +08:00
Jun Pataleta
aff1f3a400
MDL-79056 gradereport_user: Set grade category and item names as th
* The table cells mentioned in the `headers` attribute of other table
cells need to be using the table header <th> tag. Otherwise, HTML
validation fails.
2023-09-29 11:03:36 +08:00
Mihail Geshoski
ebf12946d6 MDL-78813 gradereport_grader: Revert border-top-width css change
Revert the modification of the border-top-width css attribute
to the grader table and the table header. This change seems to
be unnecessary.
2023-09-26 13:32:02 +02:00
Kevin Percy
00bd11b539 MDL-78813 gradereport_grader: Fixed help icon covering course average 2023-09-26 11:21:00 +02:00
Jun Pataleta
8ebf873b65
MDL-79047 grade: Use the gradebook plugin name for the page title
* Use the appropriate gradebook plugin string for the page title.
* Improve gradebook page titles set by grade_get_plugin_info() by
listing the unique identifying information for the page first
(e.g. the gradebook plugin name), followed by broader information
(Grades + Course name), separating these bits of information using the
pipe `|` character.

For more information, check out
https://www.w3.org/WAI/WCAG21/Techniques/general/G88
2023-09-18 03:47:24 +02:00
Jun Pataleta
c0ec027149
MDL-79057 grade: Remove block-level elements within buttons
Replace <div> tags within <button> tags for the selector
buttons in the grade pages.
2023-09-15 17:37:20 +08:00
Huong Nguyen
978fb4f1fe
Merge branch 'MDL-79057-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-09-15 17:32:44 +08:00
Jun Pataleta
51655f3485
MDL-79057 gradereport_singleview: Use proper hidden attribute value
HTML attribute hidden="1" is invalid. It either needs to be set to an
empty string or use the keyword "hidden" for its value.
2023-09-06 18:39:15 +08:00
Jun Pataleta
bf9a2f43ad
MDL-79057 gradereport_singleview: Remove tabindex > 0 for elements
A tab index with a non-zero value messes up with the logical tab order
of a page.
2023-09-06 18:39:15 +08:00
Andrew Nicols
62648c74d8
MDL-79246 gradingform_rubric: Use i_click_on for behat clicks 2023-09-04 09:13:02 +08:00
Andrew Nicols
d474c049d1
Merge branch 'MDL-79045-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-09-01 10:47:34 +08:00
Jun Pataleta
489a9fc818
MDL-79045 grade: Don't enclose grade user_heading in $OUTPUT->heading()
Do not enclose \core_grades_renderer::user_heading() in
$OUTPUT->heading() and enclose the user's name in the user heading in
<h2> tags instead.
- Having <div> inside <h2> results in errors in HTML validation.
- Enclosing the whole user heading in <h2> results in the other
elements in the user heading (Message, Add to contacts) to be announced
to screen readers which can result in confusion.
2023-08-31 09:24:08 +08:00
Huong Nguyen
de8180935f
Merge branch 'MDL-78533-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-08-24 15:36:33 +07:00
Paul Holden
e4ba5d276d
MDL-78533 grade: relax param type of itemname in external structures.
Ensure it conforms to the same format as allowed for course modules.
2023-08-21 10:54:24 +01:00
Paul Holden
79e12570d9
MDL-78502 grade: consider only those export formats user can access. 2023-08-21 10:47:06 +01:00
Simey Lameze
fd046bf6d6 MDL-78684 behat: fix behat failures 2023-08-17 21:01:05 +08:00
Andrew Nicols
d6a9f01cc9
Merge branch 'MDL-78684-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-08-16 22:44:35 +08:00
Jun Pataleta
4de338f002
Merge branch 'MDL-78872-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-08-09 12:10:16 +08:00
Paul Holden
58836d7143
MDL-78872 grade: fix external class execute method visibility. 2023-08-02 02:18:51 +01:00
Angelia Dela Cruz
efb38571e5 MDL-78684 Behat: Replace gradebook navigation to use page resolvers
This commit also does other things such as:
- Replace manual steps to setup gradebook by data generators
- Added support for outcomes and scales page resolvers
- Behat clean up
2023-08-01 15:55:33 +08:00
Jun Pataleta
27f453d6e9
MDL-78550 grade: Hide empty fillers from the accessibility tree
* And remove the title attribute for the filler as it is unnecessary.
2023-07-28 17:28:58 +08:00
Jun Pataleta
b98fb9032c
MDL-78550 grade: Avoid rendering an empty <h2> heading 2023-07-28 17:28:57 +08:00
Jun Pataleta
e953e71c54
MDL-78550 grade: Fix HTML validator errors
* Remove invalid "text" attribute in <td> elements
* Use proper id value for grade category checkboxes.
2023-07-28 17:28:56 +08:00
Sara Arjona
07ef1c6aa5
Merge branch 'MDL-78673-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-07-12 18:18:13 +02:00
Julien Boulen
231577e4b0 MDL-76319 gradebook: add continue button after csv grades import error 2023-07-10 10:18:14 +02:00
Andrew Nicols
43d00eaeba
MDL-78673 grade: Switch test to use generators 2023-07-10 11:30:14 +08:00
Andrew Nicols
23c2c5d08e
MDL-78673 grade: Switch to behat navigation steps 2023-07-10 11:30:14 +08:00
Andrew Nicols
7961e169b1
MDL-78673 grade: Address random failure due to toast 2023-07-10 11:30:09 +08:00
Shamim Rezaie
2d8c924d71 MDL-77375 core_grades: set boundary of the dropdowns in grade setup page 2023-07-02 00:40:15 +10:00
Shamim Rezaie
ddb1b56f36 MDL-77375 gradereport_singleview: set boundary of the dropdowns 2023-07-02 00:06:14 +10:00
Andrew Nicols
196ed7530b
Merge branch 'MDL-69231-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-06-15 10:56:53 +08:00
Ilya Tregubov
beb0328060
Merge branch 'MDL-70152-401' of https://github.com/andelacruz/moodle into MOODLE_401_STABLE 2023-06-14 13:25:03 +08:00
Ilya Tregubov
c162f90445
MDL-76445 gradereport_singleview: Fix Behat test
When you unenrol a user, the notification blocks some tertiary
navigation links.
2023-06-14 11:38:04 +08:00
Ilya Tregubov
b699da1461
MDL-76445 core_grades: Use group select instead of group search
On Moodle 4.1 we don't have group search on grader report.
That is only available in 4.2+
2023-06-14 09:34:22 +08:00
Mihail Geshoski
6ceb137f04 MDL-76445 gradereport_singleview: Usability fixes 2023-06-13 15:20:03 +08:00
Mihail Geshoski
e60edbf0cb MDL-76445 gradereport_user: Usability fixes 2023-06-13 15:20:03 +08:00