5136 Commits

Author SHA1 Message Date
Jun Pataleta
a180dba314
MDL-81549 versions: bump all versions and requires near release 2024-04-17 00:03:29 +08:00
Shamim Rezaie
b32617e346 MDL-80426 qtype_ordering: An announcement region to announce reorders 2024-04-15 20:07:11 +10:00
Shamim Rezaie
eccfb73839 MDL-80426 qtype_ordering: Remove the unintuitive keyboard handling code
Users can now rearrange options using the move buttons that each option
have, therefore there is no need for the current unintuitive keyboard
interaction implementation in the ordering question type plugin.
2024-04-15 20:07:11 +10:00
Shamim Rezaie
84034c62f0 MDL-80426 qtype_ordering: Move options by single pointer
Each option has a couple of buttons to move the option's position. This
allows moving options by single pointer without dragging to address WCAG
 Success Criterion 2.5.7.
Having the buttons also addresses WCAG Success Criterion 2.1.1 as it
provides an intuitive way to move options using keyboard.
2024-04-15 20:07:11 +10:00
Andrew Nicols
1d25d54e2c
Merge branch 'MDL-74610-mysql-fix' of https://github.com/timhunt/moodle 2024-04-12 08:57:17 +08:00
Andrew Nicols
d26c40db26
Merge branch 'MDL-81114' of https://github.com/timhunt/moodle 2024-04-11 23:25:22 +08:00
Tim Hunt
ee80a41dd5 MDL-74610 quiz: fix grade items query for MySQL 2024-04-11 13:55:19 +01:00
Sara Arjona
54960f8e15
Merge branch 'MDL-81383' of https://github.com/timhunt/moodle 2024-04-11 12:49:29 +02:00
Tim Hunt
0b8c6bd64d MDL-81383 questions: get_filtered_questions order should be predictable
This method supports $limit and $offset paramters. The query must have
a predictable ORDER BY for that to make sense.
2024-04-11 10:25:50 +01:00
Andrew Nicols
4c4594e2ac
Merge branch 'MDL-81227' of https://github.com/timhunt/moodle 2024-04-11 12:49:31 +08:00
Sara Arjona
0ea5aee08a
Merge branch 'MDL-81458-main-1' of https://github.com/mihailges/moodle 2024-04-10 12:12:55 +02:00
Mihail Geshoski
4b1dfe6a40 MDL-81458 qtype_ordering: Address failing unit tests
Fixes the failing unit tests in the ordering question type by
implementing the following adjustments and corrections:
- Ensure the missing required files are imported in
  questionhint_test.php and questiontype_test.php.
- Modify the expected fraction values in testexport.moodle.xml to
  accurately reflect the recent changes, specifically the type
  casting of the fraction value stored for each answer into the
  question object.
- Reorder the items in the answers array within the failing scenario
  in specific_grade_detail_feedback_test.php to guarantee that, in
  accordance with the randomly generated subset of correct answers,
  the question attempt will consistently be incorrect as required.
- Pass the answer codes in the order of the defined response when
  calling the process_submission() function in feedback_test.php
  to ensure the response in the current question attempt is properly
  set, rather than relying on random generation of the response which
  may result in random test failures.
2024-04-09 23:18:14 +08:00
Mihail Geshoski
72e9a1bbd9 MDL-81458 question: Cast the fraction value to a float
When retrieving the answer data from the database, it's essential to
cast the value of the answer's fraction to a float before storing it
into the question object. This step is crucial for ensuring consistency,
as some database engines return floats as strings like '1.0000000'.
2024-04-09 23:18:14 +08:00
Sara Arjona
c26797f315
Merge branch 'MDL-81451-main' of https://github.com/lucaboesch/moodle 2024-04-09 15:31:05 +02:00
Luca Bösch
775e4ae79f MDL-81451 qtype_missingtype: adopt icon size to other. 2024-04-08 17:26:41 +02:00
Luca Bösch
d3c4345d81 MDL-81451 qtype_gapfill: adopt icon size to other. 2024-04-05 16:00:29 +02:00
Luca Bösch
f6b396012f MDL-81449 qtype_ordering: adopt icon size to other. 2024-04-05 15:35:03 +02:00
Sara Arjona
852ef9cbfc
NOBUG: Fixed SVG browser compatibility 2024-04-05 13:23:32 +02:00
Ilya Tregubov
4243d21377 MDL-79863 qtype_ordering: Fix Behat test for backup and restore
We recently started to turn on async backup by default.
2024-04-05 16:00:11 +08:00
Andrew Nicols
27c42aad0f
MDL-79863 qtype_ordering: Correctly order langstrings 2024-04-05 10:47:04 +08:00
Mathew May
135ed5b145 MDL-79863 qtype_ordering: Include required qtype function 2024-04-05 09:47:58 +08:00
Mathew May
178bed033a MDL-79863 qtype_ordering: Remove PHPDocs from overridden blocks 2024-04-05 09:47:58 +08:00
Mathew May
460e3b5a61 MDL-79863 question: Update docblocks 2024-04-05 09:47:58 +08:00
Mathew May
7dda680e06 MDL-79863 qtype_ordering: Update comments and remove unused functions 2024-04-05 09:24:02 +08:00
Mihail Geshoski
d0a9505cee MDL-79863 qtype_ordering: Fix access control to files
The implementation of the check_file_access() method needs to be added
in the qtype_ordering_question class in order to ensure the users have
the appropriate access rights to a particular file.
2024-04-05 09:24:02 +08:00
Mathew May
881107a977 MDL-79863 qtype_ordering: Unit test updates 2024-04-05 09:24:02 +08:00
Mathew May
fbfbb7272a MDL-79863 format_gift: Set ID & tags from comment
Previously, third party imports could not add tags or the self defined ID numbers.
This is because if the plugin defines an import it just returns after completing skipping this non specific function.
2024-04-05 09:24:02 +08:00
Mathew May
385d40dfe1 MDL-79863 qtype_ordering: Remove third party files 2024-04-05 09:24:02 +08:00
Mathew May
db7abb51cb MDL-79863 qtype_ordering: Code checker & behat
Part of: MDL-79863
2024-04-05 09:24:02 +08:00
Mathew May
aa2ef1fe9c MDL-80416 qtype_ordering: Tests for reuse functionality
Part of: MDL-79863
2024-04-05 09:24:02 +08:00
Mihail Geshoski
6631b37eca MDL-79879 qtype_ordering: Improve the settings page
Part of: MDL-79863
2024-04-05 09:23:59 +08:00
Ilya Tregubov
272c8976fe MDL-79863 qtype_ordering: Ensure qtype_ordering is compatible with PHP 8.2
Co-authored by: Mathew May <mathewm@hotmail.co.nz>
2024-04-04 16:21:07 +08:00
Mathew May
63ed08c050 MDL-79905 qtype_ordering: Improve test coverage for question ordering
Part of: MDL-79863
2024-04-04 16:21:07 +08:00
Ilya Tregubov
ec320c2e49 MDL-79873 qtype_ordering: Template to output formulation and controls.
Part of: MDL-79863
2024-04-04 16:21:07 +08:00
Mathew May
9d060922ae MDL-79874 qtype_ordering: Move feedback into exporter
Part of: MDL-79863
2024-04-04 16:21:07 +08:00
Kevin Percy
e1357ee51c MDL-79863 qtype_ordering: Coding style improvements part 2
Co-authored by: Tim Hunt <T.J.Hunt@open.ac.uk>
2024-04-04 16:20:50 +08:00
Ilya Tregubov
d00061da26 MDL-79877 qtype_ordering: Template to output correct parts
Part of: MDL-79863
Creates an exporter class and a template to output the correct
part  to a given question attempt.
2024-04-04 16:00:52 +08:00
Mathew May
36822f0c0a MDL-79870 qtype_ordering: Remove unused code
Part of: MDL-79863
2024-04-04 16:00:51 +08:00
Mathew May
cf1bcfce18 MDL-79884 qtype_ordering: Add unit coverage and exemptions
Part of: MDL-79863
2024-04-04 16:00:51 +08:00
Ilya Tregubov
de5fc46b41 MDL-79875 qtype_ordering: Template to output grade detail
Part of: MDL-79863
Creates an exporter class and a template to output the grade
detail to a given question attempt.
2024-04-04 16:00:51 +08:00
Shamim Rezaie
31fc5161c9 MDL-79863 qtype_ordering: Coding style improvements part 1
Co-authored by: Ilya Tregubov <ilya@moodle.com>
Co-authored by: Mihail Geshoski <mihail@moodle.com>
Co-authored by: Shamim Rezaie <shamim@moodle.com>
2024-04-04 16:00:51 +08:00
Mathew May
18182c30e6 MDL-79871 qtype_ordering: Further changes for readability
Part of: MDL-79863
- Reduce usage of jQuery to only a couple of variables. These are left as is due to how heavy the usage is and how the base dnd seems to assume jQuery objects here and there.
- Templated the proxy string so we dont have to pull it in and replace tokens on the fly.
- Moved around functionality a bit to make for more concise reading and obvious delegation of responsibility
2024-04-04 15:26:44 +08:00
Mathew May
646f1c75d1 MDL-79871 qtype_ordering: Improve typing and documentation
Part of: MDL-79863
2024-04-04 15:26:44 +08:00
Mathew May
0136414cd8 MDL-79871 qtype_ordering: Move functions out of constructor
Part of: MDL-79863
- Alot of functionality was bound to the constructor, this has been picked out into various methods for easier debug.
2024-04-04 15:26:44 +08:00
Mathew May
d70277d050 MDL-79871 qtype_ordering: Move existing modules into class
Part of: MDL-79863
- Taken the existing module and done the bare minimum to make it work within one class that gets called.
2024-04-04 15:26:44 +08:00
Mathew May
416ffeed36 MDL-79871 qtype_ordering: Remove shipped core libs
Part of: MDL-79863
2024-04-04 15:26:44 +08:00
Mihail Geshoski
bc2bfead5c MDL-79876 qtype_ordering: Template to output the correct response
Part of: MDL-79863
Creates an exporter class and a template to output the correct
response to a given question attempt.
2024-04-04 15:26:44 +08:00
Mihail Geshoski
6531fa70d7 MDL-79876 qtype_ordering: Create an abstract class for the renderables
Part of: MDL-79863
Creates an abstract class in qtype_ordering/output that implements the
renderable interface. Each renderable that is used to output a given
component of the ordering question should extend this abstract class.
2024-04-04 15:26:43 +08:00
Mihail Geshoski
532c361386 MDL-79876 qtype_ordering: get_response() in qtype_ordering_test_helper
Part of: MDL-79863

Previously, get_response() was implemented in almost every PHPUnit
testing class in qtype_ordering and these implementations were
idenical. In order to avoid code duplication a new static method
get_response() has been created within the qtype_ordering_test_helper
class.
Also, each individual implementation within the PHPUnit testing
classes has been removed/modified and all related calls had been
replaced by qtype_ordering_test_helper::get_response().
2024-04-04 15:26:43 +08:00
Mathew May
377dc97590 MDL-79863 qtype_ordering: Version bump for core 2024-04-04 15:26:41 +08:00