352 Commits

Author SHA1 Message Date
Petr Skoda
64f93798d4 MDL-22950 adding new component column to the files table, unfortunately this change requires changes in all 2.0dev code, please review all custom code that was already upgraded to 2.0; fixing multiple problems and regressions in mod/assignment 2010-07-03 13:37:13 +00:00
Andrew Davis
79b260cc88 gradebook MDL-21596 altered grade_category::set_properties() to try to intelligently set a default for weight and extra credit as a work around for those two properties sharing a single column 2010-06-08 02:10:21 +00:00
David Mudrak
f829c8d07f MDL-22062 Grade item's idnumber can be added from the calculation form
Before this patch, if activity module used multiply grade items (as
workshop does), the method add_idnumber() returned false because it
required empty idnumber in course_modules. The patch makes this check
only for grade_items with itemnumber 0.
2010-06-05 19:53:29 +00:00
Andrew Davis
992cfb1101 gradebook MDL-22139 fixed a typo in a comment 2010-06-01 09:27:47 +00:00
Petr Skoda
f7d515b6d3 fixed silly comment typos 2010-05-21 18:57:05 +00:00
David Mudrak
3869ab1ac6 MDL-21695 gradebook: Extra credit help strings
String aggregationcoefextraweight is used when editing an item which is
aggregated by Mean of grades (with extra credit) and was reworded to
Extra credit weight (because in fact it is the weight of the extra
credit - if it equals zero, the grade is not extra)

String aggregationcoefextrasum is used for Sum of grades and Simple
weighted mean of grades, meaning a checkbox extra credit yes/no

String aggregationcoefextra is used in the header of table Categories
and items (either Simple view or Full view). It must contain the information
about both meanings of aggregation.

AMOS BEGIN
 HLP grade/aggregationcoefcombo.html,[aggregationcoefextra_help,core_grades]
 HLP grade/aggregationcoefextra.html,[aggregationcoefextraweight_help,core_grades]
 HLP grade/aggregationcoefextrasum.html,[aggregationcoefextrasum_help,core_grades]
AMOS END
2010-05-21 13:46:28 +00:00
Tim Hunt
79312a06e4 grades: MDL-22098 silly bug that leads to bad performance problems in the grader report. 2010-04-15 16:37:05 +00:00
Tim Hunt
26e3ae92f2 grade import: MDL-21987 Problem with repeated imports of the same grade.
The thanks to Petr (skodak).

Here is what I learned while working on this:

1. when explicitly setting the final grade (manual edit or import),
   it is important that ->overridden gets set, and it should get set
   to the time when the override was done.

2. but only on certainly sorts of grade item, and the condition for
   setting the flag is different when it is the feedback being changed
   or the grade being changed, hence the two different tests
   is_overridable_item and is_overridable_item_feedback.

3. but, if the grade and feedback is not actually changed, then the ->overridden
   timestamp should not be changed. (That was the bit that was buggy.)
2010-03-31 13:50:56 +00:00
Petr Skoda
b16b5857f0 MDL-21790 fixed dml conversion regression - credit goes to Evan Irving-Pease for the patch and discovery, thanks 2010-03-10 08:42:44 +00:00
Andrew Davis
1762a2642a gradebook MDL-21514 Ironed out a bug with hiding course totals 2010-02-12 03:39:40 +00:00
Andrew Davis
61541a5a46 gradebook MDL-21218 Improved the hiding/displaying of category and course totals when they contain hidden items 2010-02-08 06:27:04 +00:00
Andrew Davis
d90aa63419 grader report MDL-21367 when an item is unhidden its category should unhide to 2010-02-03 02:31:46 +00:00
Andrew Davis
a25bb902f0 grader report MDL-19704 Added ability to hide course and category totals without hiding anything else 2010-01-11 07:35:40 +00:00
David Mudrak
f5a726feb3 MDL-21191 Fixing another regression in dependency calculation
This is not easy to spot as $params may just contain one more item than $sql
would expect. However, $sql and $params should be well paired.
2009-12-25 23:31:59 +00:00
David Mudrak
1b6ab8924f MDL-21190 Re-fixing a regression in dependency calculation
Sorry for the last commit. This should be the proper way. The problem
was with the question mark within quotes - it was not considered as a
placeholder.
2009-12-25 17:18:52 +00:00
David Mudrak
8b9f980a2b MDL-21190 Fixing a regression in dependency calculation 2009-12-25 16:46:46 +00:00
Tim Hunt
e785b784f1 Grade item: MDL-21161 timemodified never gets set on calculated gradebook columns 2009-12-18 18:19:46 +00:00
Eloy Lafuente
de3940e794 MDL-21015 copy/paste typo spreaded over various grade classes fixed 2009-12-01 18:32:53 +00:00
Eloy Lafuente
7401a7cd25 MDL-21015 - typo detected when working on grade tests... 2009-12-01 14:47:14 +00:00
Sam Hemelryk
8bdc9cacad files MDL-20601 Conversion of many of the uses of print_textarea, and the mforms htmleditor to the new editor
Please forgive me if I have missed converting any output statements. If you do find an output statement that is not formatting correctly please refere to the table I added to this bug in regards to how it should be formatted.
2009-11-04 06:14:06 +00:00
Petr Skoda
4a0e2e632f MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 11:42:23 +00:00
Sam Hemelryk
26f0525fa5 NOBUG: Testing CVS mailout for Jordan 2009-10-30 06:31:17 +00:00
nicolasconnault
bb55642327 MDL-19407 Defaulting all grade items to non-extra-credit when moving to a SWM category, except if they originally come from a SWM category and were set as extra credit there. Merged from MOODLE_19_STABLE 2009-09-17 07:16:51 +00:00
skodak
2a7eff41ad MDL-18293 $DB->something is using exceptions, no need for ifs there, removing useless strings 2009-06-03 20:37:28 +00:00
nicolasconnault
b79fe1899c MDL-19247 Few minor adjustments and cleanup of grade_category 2009-05-21 13:30:02 +00:00
skodak
793253ae05 MDL-19218 fixed missing method grade_category::is_extracredit_used() - not merged to HEAD 2009-05-17 19:19:33 +00:00
skodak
a9e38ac8a7 MDL-19008 extra credis should not be dropped when drop low or keep high specified (including unit tests) 2009-04-29 13:42:03 +00:00
skodak
b9b199beba MDL-18993 implemented frull support for droplow and keephigh in sum aggregation type 2009-04-29 10:05:55 +00:00
skodak
59080eee21 MDL-18993 implemented frull support for droplow and keephigh in sum aggregation type 2009-04-29 08:55:25 +00:00
skodak
b3d965212e MDL-17248 fixed incorrect sum when scales involved; merged from MOODLE_19_STABLE (regrading will be forced later) 2009-04-27 15:21:09 +00:00
skodak
d9ae2ab53b MDL-12942 new extra credit option for simple mean agg; merged from MOODLE_19_STABLE 2009-04-24 16:24:49 +00:00
skodak
121d8006e4 MDL-18927 fixed performance regression 2009-04-22 19:40:21 +00:00
nicolasconnault
653a86489e MDL-18083 Committing gradebook improvements to head 2009-04-16 07:16:44 +00:00
skodak
3a03653edf MDL-18772 fixed aut oupdating of grademax for SUM aggregation type 2009-04-05 20:17:04 +00:00
nicolasconnault
9fb1634910 MDL-18402 Merged from MOODLE_19_STABLE 2009-03-23 08:35:06 +00:00
skodak
cb551e3625 MDL-18550 fixed DML typo and bad coding style - yes sam, whitespace is part of the official coding style! thanks nigel daley for spotting of the typo 2009-03-15 13:29:40 +00:00
nicolasconnault
54c4a2cb4f MDL-18004 Separated gradebook course settings from report preferences 2009-02-17 09:01:48 +00:00
nicolasconnault
de0300ea3c MDL-12631 Fixed breadcrumbs 2009-02-13 08:07:27 +00:00
nicolasconnault
70aaa10f25 MDL-18004 Combined the two admin settings into one dropdown 2009-02-12 11:00:16 +00:00
nicolasconnault
0198929cdb MDL-17825 Converting float grades to string when counting values using the Mode of Grades aggregation. Merging from MOODLE_19_STABLE 2009-01-08 16:02:11 +00:00
nicolasconnault
7d10995c86 MDL-13778 Added 6 "composite" grade display types for the grader report Merged from MOODLE_19_STABLE 2009-01-08 08:53:20 +00:00
sam_marshall
82bd6a5ea9 MDL-15499: Conditional availability of activities 2008-12-17 16:37:35 +00:00
skodak
f53db007f6 MDL-16785 bogus grades inserted when formulas used - credit Michael Spall and Ann Adamcik; merged from MOODLE_19_STABLE 2008-10-24 17:53:15 +00:00
nicolasconnault
4dc81cc70d MDL-15680 Added grade category aggregation settings and weights, plus correct handling of 3 types of weights. 2008-10-10 07:18:19 +00:00
nicolasconnault
c7d306e168 MDL-15666 MDL-16486 2008-09-17 14:31:30 +00:00
sam_marshall
49f6e5f476 MDL-15498: Fixes to problems Petr identified with completion system checkin 2008-07-28 15:58:50 +00:00
sam_marshall
4e781c7b50 MDL-15498: Completion system 2008-07-28 12:31:29 +00:00
Francois Marier
6800d78e06 Drift between CVS and git
- large deletions
- lucene updates
- error() => print_error()
- NO_MOODLE_COOKIES define
- various other things
2008-06-25 17:31:23 +00:00
skodak
294ce9870f MDL-15189 magic quotes finally removed 2008-06-09 16:53:30 +00:00
skodak
f67cab32ec MDL-15094 some forgotten conversions 2008-06-05 18:01:22 +00:00