Commit Graph

251 Commits

Author SHA1 Message Date
tjhunt
b221dc6f23 question bank: MDL-17302 refactor question bank display code into a class.
Step 3. Start working ot the code to initialise things from a list of columns, and build the corresponding SQL query.
2009-01-21 08:49:15 +00:00
tjhunt
5bd22790c4 question bank: MDL-17871 refactor the code that displays particular information about each question into classes.
More work in progress. Print column headers, and improve sorting. These classes are still not used.
2009-01-21 07:21:43 +00:00
tjhunt
46795afcbd question bank: MDL-17871 refactor the code that displays particular information about each question into classes.
Work in progress. Most required classes are writted, but nothing uses them yet, and I have not dealt with column headers yet.
2009-01-20 10:11:23 +00:00
tjhunt
5b5e5ab20c question bank: MDL-17302 refactor question bank display code into a class.
Step 2. Remove as many as possbile of the differences between the two classes. This is mostly whitespace and irrelevant code formatting issues, but there are also a few changes to the generated output, taking the best of both views.
2009-01-19 08:50:48 +00:00
tjhunt
f4b879ddea question bank: MDL-17302 refactor question bank display code into a class.
Step 1. Just convert the existing functions quiz_question_showbank and question_showbank and friends into methods of a class and subclass.

More to come.
2009-01-19 05:30:01 +00:00
tjhunt
b4a2e41313 quiz editing: MDL-17284 fix infinite redirect bug. 2009-01-07 07:12:37 +00:00
skodak
973d2660e6 MDL-16613 sesskey cleanup 2009-01-02 10:51:26 +00:00
skodak
d4a1fcaf11 MDL-16613 sesskey cleanup 2009-01-02 10:36:25 +00:00
tjhunt
df4e224454 question bank: MDL-14434 Cannot edit the only question category in a context. 2008-11-27 11:50:29 +00:00
tjhunt
fa583f5f6e quiz editing: MDL-17285 This is Olli Savolainen's new interface for editing quizzes.
This was started and usability tested as a Finnish Summer of Code project, and then Olli did further work on it in his own time to get it in shape for inclusion in Moodle 2.0. I reviewed all the code. There are a number of minor outstanding issues that will be fixed soon. See the subtasks of MDL-17284 for a list.

The goal of these changes is to:
* help teachers new to Moodle, so when they first see the quiz editing page, they don't go "Huh! What on earth am I supposed to do here?"
* help novice Moodle users understand and learn to use some of the more advanced quiz feature;
* but, without slowing down more experienced quiz users.

Naturally, with ambitous goals like that, we won't have managed to satisy everybody, but I think this change is a big step in the right direction.

There is extensive documentation on this project at http://docs.moodle.org/en/Development:Quiz_UI_redesign.
2008-11-20 06:59:11 +00:00
tjhunt
a856c14ed6 Whitespace fix. 2008-09-10 05:26:35 +00:00
tjhunt
fec2094ee6 moodle_database conversion error. 2008-09-09 07:00:16 +00:00
tjhunt
bc59cef302 Comment update. 2008-09-08 06:59:11 +00:00
skodak
1eda520124 MDL-16223, MDL-16222 - error string improvements 2008-08-27 16:34:23 +00:00
dongsheng
ac93d63d2a MDL-14129, remove error() in question module 2008-07-24 04:20:44 +00:00
nicolasconnault
f34488b2e6 MDL-15102 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing. 2008-06-06 14:43:15 +00:00
tjhunt
5412cd289a MDL-14593 - delete icons in the question bank do not work. This was a regression caused by part of the fix for MDL-13982. I hvae reverted that bit for now, pending a better solution. 2008-05-27 10:35:13 +00:00
dongsheng
0be2c85848 "MDL-14129, fix print_error call" 2008-05-21 07:53:23 +00:00
tjhunt
7fb1b88dc7 MDL-10899 - There is some data associated with some questons that needs to be udpated when moving questions between categories. This commit deals with subquestions, and lays the foundation for fixing the other problem - datasets - which is files as bug 14767. 2008-05-09 15:05:36 +00:00
tjhunt
8e77884c4e MDL-13982 - Performance problem when deleting questions from large question banks. Thanks to Michael Spall for this fix. Merged from MOODLE_18_STABLE.
At the same time, remove direct references to $_REQUEST and $_POST in this code.
2008-04-23 13:45:38 +00:00
tjhunt
92a95034ff Revert bogus error -> print_error changes that were stopping my patch from merging. 2008-04-23 13:42:50 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
tjhunt
e2ae84a298 MDL-13189 - replace the $QTYPE_MENU global with a function call, so that we can set up the language strings later, after $COURSE is initialised. This ensures that the quesion names appear in the right language. 2008-02-28 12:53:02 +00:00
jamiesensei
a18fbcfb50 MDL-13298 "Question bank displays always page 1 after adding new question" this was caused because the question creation page was redirecting back to the question back edit page and telling it to change to the category of the question that was just saved. This was causing the edit page to go back to page 0 of the new category. Now we only go back to page 0 if the category has actually changed. Merged from MOODLE_19_STABLE 2008-02-05 12:14:46 +00:00
tjhunt
987c5893ac MDL-12280 - Question bank forgets sort order when adding multiple questions to a quiz. Merged from MOODLE_19_STABLE. 2007-11-20 15:54:34 +00:00
tjhunt
ea16c547ee Remove a developer debug notice and save a database query. Merged from MOODLE_19_STABLE. 2007-11-20 14:46:50 +00:00
jamiesensei
be801b8b3a MDL-11139 "Need to pass courseid or cmid to this script when moving questions between categories " added COURSE to globals in function that redirects browser to contextmoveq page. 2007-10-03 04:42:57 +00:00
tjhunt
314fc083d9 MDL-10824 - spaces in javascript URLs are not strictly valid. Merged from MOODLE_18_STABLE. 2007-09-19 17:44:52 +00:00
jamiesensei
8f0f605ddf moved question_make_default_categories function to questionlib.php since it is needed by other modules outside the question bank editing interface. 2007-09-18 11:23:29 +00:00
jamiesensei
e7e62d45be Fix for MDL-10823 Access to question edit page denied from quiz preview screen. 2007-08-14 04:22:05 +00:00
moodler
871ab9a3e2 Removed usage of table aliases with "as" as per MDL-10808 2007-08-11 14:28:36 +00:00
jamiesensei
271e6decda merging MOODLE_19_QUESTIONS with HEAD 2007-08-09 21:51:09 +00:00
tjhunt
d0e88092e9 MDL-10130 - Thanks to Adriane Boyd. 2007-06-15 10:25:09 +00:00
tjhunt
da1cc34073 MDL-10089 - Cannot delete questions from question bank - Thanks to Adriane Boyd for the fix. 2007-06-12 11:13:49 +00:00
moodler
335768f419 Removed some RQP code no longer needed MDL-9600 2007-05-24 07:10:22 +00:00
tjhunt
214f6330f9 MDL-9881 - Attempting to delete large number of questions fails due to long URL - Merged from MOODLE_18_STABLE. 2007-05-22 14:04:06 +00:00
tjhunt
d1f2b9e130 Switch a form from post to get, since that is more appropriate. 2007-05-22 13:24:51 +00:00
jamiesensei
85c375c3f8 added function callbacks for module specific controls to question bank. 2007-05-07 16:57:23 +00:00
jamiesensei
64eeaf4753 removed all session fromurl and returnurl stuff from question bank editing code. Returnurls are now passed as get/post params. 2007-05-07 07:13:14 +00:00
jamiesensei
561fe61df3 return to the proper page after editing a question in the question bank. 2007-05-07 06:35:33 +00:00
jamiesensei
986effb653 pass the category list page param from page to page in question bank editing pages. 2007-05-07 05:53:20 +00:00
jamiesensei
7bc26c8f6d changes to pass category id from page to page in question bank editing. 2007-05-07 04:55:55 +00:00
jamiesensei
36e298bc58 removed more session stuff from question list and category form in question bank display code 2007-05-04 10:46:33 +00:00
jamiesensei
9ab3847595 tightening up reg expressions used for submitted data a bit 2007-05-04 08:33:28 +00:00
jamiesensei
9ab75b2bcc passing cmid to question.php and removed use of session modform var. Question.php now independent of quiz module. Small improvement to displayed breadcrumbs. 2007-05-04 05:47:59 +00:00
jamiesensei
b72ff47685 moved question sort order and paging params to be passed from page to page as get params instead of being saved in session var. 2007-05-03 10:10:01 +00:00
jamiesensei
86909ce047 small fix to get question code to return to correct place after creating a new question. 2007-05-03 05:17:07 +00:00
jamiesensei
efe839dc12 Removed 'edit category' redundant button 2007-04-27 11:27:57 +00:00
tjhunt
e3aea79afe MDL-9565 - Fix error in previous commit. Merged from MOODLE_18_STABLE. 2007-04-25 17:59:53 +00:00
tjhunt
7d87171ba9 MDL-9565 - Question preview links don't work in developer debug mode, and not XHTML strict. Merged from OU Moodle. 2007-04-24 16:59:32 +00:00