because everyone was using the same values for them!
Also renamed the function to simply forum_search_form, because in the end
noone was using it to PRINT html, it was just put into a variable.
(While I was at it I also turned the autologinguests off for most module pages, except on the index.php pages and the view.php pages for those modules that allow guests)
Many thanks to Mike Churchward for his work on this and persevering
with sending updated versions to me. :-)
Shane and I have polished it up, rewritten a few parts (display-related)
and here it is, finally in CVS!
I think there will still need to be some optimisation for the SQL,
since it's still pretty intensive. Perhaps some sort of caching in
the session that gets modified along with the database whenever
something gets read.
However if there are problems the whole thing can be switched off
in the forum module config so this is not crucially urgent.
Logs now include a field called modid which contains the coursemodule id.
This makes it now possible to
- see complete logs per-activity
- do backup/restore of logs
The upgrade process will currently try to scan all the old logs and
rebuild this field based on available data (especially forums).
STILL TO DO: alter all the non-forum modules to send the coursemodule id
Still needs plenty of testing. There is no GUI yet for turning on
the groupmode just for the forum (this will be on the course page)
but you can put a 1 (visible) or 2 (separate) in the course_modules table.
OK, this is a big check-in with some big changes, and needs work still.
It seems relatively stable, but I need help identifying the rough patches.
1) First grading scales support. There is a now a new table called "scale"
that contains grading scales. There can be site scales (course=0) and
custom course scales. These can be used in modules - I've only done
forums for now but that was the hard one. Scales can be edited via
the new item in the course admin menu.
There is one default scale - the connected/separate knowing one that used
to be in forum. To build this I pull data from the language packs
to create one during the upgrade, or anytime a scales menu is called
and no scales are found.
2) New roles for course creator and teachers. I've fixed up the course
menus and some other things but there's a lot left to do on this to
make it all smooth. The idea is that teachers no longer can edit courses
unless they are also course creators. The interface for this needs to
be smoothed out a fair bit and I need help with this.
The upgrade will upgrade all teachers to be creators, but will default
the new site config "creatornewcourses" to "no", so that effectively
these new teachers have the same privileges.
3) Simplified teacher management. There is no longer an "assign teachers"
and a "teacher roles" page - it's all on one page in course/teacher.html.
Phew ... time for a shower and then back into it.
ensure that the order they are displayed in is always the same as the
order they have been defined in. See bug 553.
This involved API changes to the function get_all_instances_in_course()
servers that have register_globals turned off (this is the
default setting on newer version of PHP).
In fact it's partly a hack that globalises all GET, POST, FILES
AND COOKIE variables. Unfortunately though the SESSION and
USER global session variables are only available as $_SESSION["USER"]
and $_SESSION["SESSION"], which is cumbersome to use.
So, for every request I now make a copy of these two session variables
into $USER and $SESSION. Whenever I update them thoughout Moodle I
now have to call save_session("USER") which copies them back to the
session variable. This seems to be working well now.
Because I'm using $_SESSION etc now this will raise
the required minimum version of PHP to 4.1.0
