23873 Commits

Author SHA1 Message Date
Jun Pataleta
9b85d7db7c MDL-76213 mod_assign: Pass correct parameters to override query 2022-11-11 16:09:02 +08:00
Michael Hawkins
46a81cc8fc MDL-68550 mod_workshop: Update behat test to avoid incorrect selector 2022-11-11 07:25:50 +01:00
Jake Dallimore
96e9f7c03e Merge branch 'MDL-74638-master-test' of https://github.com/rezaies/moodle 2022-11-11 13:02:52 +08:00
Shamim Rezaie
6225af4106 MDL-74638 mod_bigbluebuttonbn: Allow logged-in users to join as guest
Logged in users should also be able to join as guest. They may not
normally have access to the meeting maybe because not enrolled to the
course.
2022-11-11 15:27:26 +11:00
Mihail Geshoski
48d5d9e07f MDL-76192 mod_glossary: Export all entry aliases to the portfolio 2022-11-11 12:03:05 +08:00
Shamim Rezaie
dcbf1deb20 MDL-74638 mod_bigbluebuttonbn: document ws change in upgrade.txt 2022-11-11 15:02:25 +11:00
Laurent David
315f4f2bd4 MDL-74638 mod_bigbluebuttonbn: Guest access for meetings
* Provide a way for external participants to be invited to a meeting by giving them an url/password
  for external users (not registered in Moodle)
* Add guest access page with username and password prompt
* Add form and modify API calls to take into account guest login
* Add a form modal to add guest users emails
* Allow copy of link and password in both popup form and module form
* The guest should be approved by default. It should be intentional to let them
in without checks.
* Guest access URL and password should not be copied when duplicating or backing
up the activity.
* The mod_bigbluebuttonbn_meeting_info web service function now
returns guestjoinurl and guestpassword only for moderators.
* Redirect if user already logged in

Note: this will allow guest to connect to an existing and running meeting. The moderator will then
be able to adjust the guest user's right. For security reasons we do not yet allow moderators
to join the meeting directly (or start a meeting)
2022-11-11 14:56:24 +11:00
Jake Dallimore
e10ecfc434 Merge branch 'MDL-75872' of https://github.com/paulholden/moodle 2022-11-11 11:45:26 +08:00
Jun Pataleta
f6e75e952d Merge branch 'MDL-76213' of https://github.com/Chocolate-lightning/moodle 2022-11-11 11:34:07 +08:00
Jake Dallimore
c5c85cce43 Merge branch 'MDL-73853-master' of https://github.com/sarjona/moodle 2022-11-11 11:29:08 +08:00
Mathew May
1d23a15069 MDL-76213 mod_assign: Improve group override info for teachers 2022-11-11 11:18:50 +08:00
Amaia Anabitarte
e1c14b251c MDL-76268 mod_data: Fix the border differences on Fields table 2022-11-11 00:22:43 +01:00
Jun Pataleta
76a942e8b0 Merge branch 'MDL-74996-master-1' of https://github.com/HuongNV13/moodle 2022-11-10 23:18:32 +08:00
Sara Arjona
0e7103dc6c Merge branch 'MDL-74606-master-support-multilang-group-names-in-mod_assign' of https://github.com/krostas1983/moodle 2022-11-10 16:04:33 +01:00
Jun Pataleta
c404193823 Merge branch 'MDL-75966-master' of https://github.com/andrewnicols/moodle 2022-11-10 20:28:14 +08:00
Sara Arjona
2ada61c243 Merge branch 'MDL-75448-master' of https://github.com/golenkovm/moodle 2022-11-10 13:19:38 +01:00
Simey Lameze
a512ba0b3c MDL-75282 behat: Use more precise step definitions
Note: This should possibly be broken out into its own issue and applied
to stables.

Part of MDL-75966.
2022-11-10 19:54:31 +08:00
Andrew Nicols
66d1651023 MDL-75282 assign_onlineoption: Use correct step for checking editor content
Note: This should possibly be broken out into its own issue applied to
stables.

Part of MDL-75966.
2022-11-10 19:54:28 +08:00
Paul Holden
38c83b53ee Merge branch 'MDL-76224-master' of https://github.com/justusdieckmann/moodle 2022-11-10 08:52:17 +00:00
Jun Pataleta
1c9856b527 Merge branch 'MDL-76252-master' of https://github.com/sarjona/moodle 2022-11-10 13:49:12 +08:00
Paul Holden
a7425a2255 MDL-75872 mod_lesson: allow unlimited attempts default value.
Related change in 252e85be added a similar value per activity, we
should also allow it to be chosen as a default for the site.
2022-11-09 18:53:54 +00:00
Laurent David
7de01c97c2 MDL-74638 mod_bigbluebutton: Multiple fixes to room layout
* In preparation for the guest access trigger button, move the join session
button to the right
* Fix id in the templates to be more consistent
* Fix issue with room refreshing process so it replaces the node instead of node content.
2022-11-09 16:31:00 +01:00
Jun Pataleta
5548743ece Merge branch 'MDL-76185-master' of https://github.com/mihailges/moodle 2022-11-09 21:51:17 +08:00
Sara Arjona
f23fe5195a MDL-73853 core_h5p: Improve behat tests, to avoid random errors
An improvement has been added to the H5P tests to avoid random errors
due to the fact that H5P content needs a while to be displayed.

Co-author: Ferran Recio <ferran@moodle.com>
2022-11-09 14:04:41 +01:00
Sara Arjona
c04f0e298d MDL-76252 mod_data: Remove space at the end of datemodified 2022-11-09 12:56:59 +01:00
Ferran Recio
c8e73da314 MDL-76220 mod_wiki: fix extend_navigation
The wiki_extend_navigation is using $PAGE->url when it is not allowed
to. Extending navigation can be invoked in an Ajax request so it should
not use $PAGE global.
2022-11-08 14:37:54 +01:00
Jake Dallimore
ad666b7b15 Merge branch 'MDL-76071-master' of https://github.com/laurentdavid/moodle 2022-11-08 11:44:01 +08:00
Justus Dieckmann
d0abf88ccd MDL-76224 Resource: Set correct page url in /mod/label/view.php 2022-11-07 18:45:27 +01:00
Andrew Nicols
2f74405d6c MDL-74468 mod_bigbluebuttonbn: Coding style violation fix 2022-11-07 12:14:04 +08:00
Andrew Nicols
dc2a6ea8f8 Merge branch 'MDL-74468-master' of https://github.com/call-learning/moodle 2022-11-07 12:14:00 +08:00
Huong Nguyen
2a74b873d7 MDL-74996 Quiz: Convert submission confirmation to saveCancelPromise 2022-11-07 09:40:06 +07:00
Huong Nguyen
c55d8aca6a MDL-74996 Quiz: Unanswered question warning for submission confirmations
Including in this commit:
 - New method called get_number_of_unanswered_questions() for getting the unanswered questions
 - PHPUnit and Behat tests for the new dialogue
2022-11-07 09:40:06 +07:00
Huong Nguyen
d4d666cdf4 MDL-74996 Quiz: Change the submission confirmation dialogue content
- Changed the title from "Confirm" to "Submit all your answers and finish?"
 - Changed the content from "Once you submit, you will no longer be able to change your answers for this attempt."
   to "You will no longer be able to change your answers for this attempt."
 - Changed some Behat scenarios to match with the new dialogue content
2022-11-07 09:40:04 +07:00
Huong Nguyen
783a5c8ce7 MDL-74996 Quiz: Convert submission confirmation to core/modal_factory 2022-11-07 09:37:56 +07:00
Shamim Rezaie
a803fa8ee4 Merge branch 'MDL-74545-master' of https://github.com/call-learning/moodle 2022-11-07 12:42:22 +11:00
Víctor Déniz
6cee9752b8 Merge branch 'MDL-70071-master' of https://github.com/Chocolate-lightning/moodle 2022-11-04 12:06:37 +03:00
Sara Arjona
34f43bce81 MDL-75289 mod_data: Fix JS error when importing 2022-11-04 12:06:36 +03:00
Sara Arjona
add46e3112 Merge branch 'MDL-76169-master' of https://github.com/andrewnicols/moodle 2022-11-04 12:06:36 +03:00
Laurent David
c4b37ea393 MDL-74468 mod_bigbluebuttonbn: Fix logger count method
* The logger::count_callback_events was confusing and needs clarification
and small refactoring.
2022-11-04 09:03:58 +01:00
Sara Arjona
caf139a47d Merge branch 'MDL-76177-master' of https://github.com/aanabit/moodle 2022-11-04 11:01:42 +08:00
Laurent David
0dcc799d8f MDL-74468 mod_bigbluebuttonbn: Remove getallheader
* getallheader is only fully compatible with Apache servers. Replace it
with a polyfill.
2022-11-03 22:16:15 +01:00
Shamiso.Jaravaza
16656917a7 MDL-74468 mod_bigbluebuttonbn: Fix custom completion for BBB
* BBB has specific completion indicator that need to be taken into account
* Fix mock requests so we can send participant id and then attach events to them
* Refactor slightly the broker to split meeting logic from request (decoding)
* Fix update completion state cron
2022-11-03 22:16:15 +01:00
Shamiso.Jaravaza
3bd76aea67 MDL-75415 mod_bigbluebuttonbn: Fix session times 2022-11-03 11:25:02 -06:00
Mihail Geshoski
7acc7cd0cc MDL-76185 mod_glossary: Remove separator in continuous display format 2022-11-03 23:53:36 +08:00
Andrew Nicols
3d70f457cb MDL-76169 mod_quiz: Add quiz question bank behat resolver 2022-11-03 21:39:15 +08:00
Andrew Nicols
232ebac338 MDL-76169 behat: Add improved steps for using action menus
This commit adds new steps related to action menus to support:
* Choosing an item in a named action menu
* Choosing an item in a named action menu within a container
* Confirming that an action menu item does or does not exist in a named
  action menu
* Confirming that an action menu item does or does not exist in a named
  action menu within a container

The existing action menu steps were insufficient as they assume that
there is only one action menu within he container, which is not
necessarily the case.

The existing action menu steps are not non-JS friendly and will error if
JS is disabled, without providing any fallback when one is easily
available.

Unfortunately these steps cannot be used to replace the existing steps
without manual intervention.
2022-11-03 21:39:15 +08:00
Jun Pataleta
8b12ca7d1b Merge branch 'MDL-75289-master' of https://github.com/andrewnicols/moodle 2022-11-03 12:44:40 +03:00
Jun Pataleta
486645f487 Merge branch 'MDL-75513-master-3' of https://github.com/mihailges/moodle 2022-11-03 12:44:40 +03:00
Andrew Nicols
eecbc3ce15 MDL-70071 forum: Convert post threshold warnings to info 2022-11-03 13:10:22 +08:00
Andrew Nicols
8f37e6ecff MDL-75289 mod_data: Make JS more resilient
This change makes the JS in for preset management more resilient.

Previously, if the button was not on the page then an error was thrown.

Instead this code changes the listener to listen to the document and
filters the clicked element based on the same selector. This is a much
safer approach as it will not error if the selector was not found on the
page.

In this case the behat test introduced elsewhere in this issue is
testing a scenario where the Save as preset button is not present
because there are no fields to store as a preset.
2022-11-03 10:02:23 +08:00