98118 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
b764343e5a MDL-69044 upgrade: add 3.9.0 separation line to all upgrade scripts 2020-06-14 13:08:09 +02:00
Eloy Lafuente (stronk7)
a2b286ce17 weekly back-to-dev release 4.0dev 2020-06-13 20:11:29 +02:00
Eloy Lafuente (stronk7)
7be8da04cd NOBUG: Change travis.yml back to master 2020-06-13 20:04:50 +02:00
Eloy Lafuente (stronk7)
500c131eb4 Moodle release 3.9 v3.9.0 2020-06-13 20:04:49 +02:00
Eloy Lafuente (stronk7)
ea24bef18a NOBUG: Change travis.yml to MOODLE_39_STABLE 2020-06-13 20:04:49 +02:00
Eloy Lafuente (stronk7)
698e225d61 Merge branch 'MDL-68632' of git://github.com/aolley/moodle 2020-06-12 19:59:55 +02:00
Victor Deniz Falcon
8dbc6ebbe3 Moodle release 3.9rc3 v3.9.0-rc3 2020-06-12 12:32:06 +01:00
Jun Pataleta
2b263bf837 Merge branch 'MDL-69026-master' of git://github.com/andrewnicols/moodle 2020-06-12 11:58:59 +08:00
Adam Olley
9db6c361fd MDL-68632 quizaccess_seb: Limit privacy queriyes to the quiz module
Without this, joins are performed against the course_modules table purely on
the instance id - other modules can share this ID, resulting in incorrect
contexts being pulled in.
2020-06-12 12:31:01 +09:30
Andrew Nicols
8d5926bead MDL-69026 user: Correct statuses => status in test 2020-06-12 10:03:06 +08:00
Andrew Nicols
8bcf74e9bc MDL-69026 user: Wrap sub-query in brackets
It is perfectly valid to have a query like:

Match None of the following:
- Role is ANY of the following:
-- 'Teacher'
-- 'Editing teacher'
-- 'Manager'; AND
- Keyword is NONE of the following:
-- 'Kevin'

However, due to the way in which the query is constructed, this leads to
a query which includes

    WHERE NOT ef.id IS NOT NULL
    AND NOT
        u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...))
    AND NOT
        NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%')

The use of NOT NOT is valid in Postgres, MariaDB, MySQL, and MSSQL, but
not in Oracle.

To counter this when the outer jointype is of type NONE, we must wrap
each of the inner WHERE clauses in a set of brackets, which makes the
query:

    WHERE NOT ef.id IS NOT NULL
    AND NOT
        (u.id IN (SELECT userid FROM {role_assignments} WHERE roleid IN (...) AND contextid IN (...)))
    AND NOT
        (NOT (u.firstname || ' ' || u.lastname LIKE '%Kevin%'))

Whilst Oracle does not support the use of `AND NOT NOT ...`, it does support
`AND NOT (NOT ...)`
2020-06-12 10:03:06 +08:00
Sara Arjona
aa6830ef99 Moodle release 3.9rc2 v3.9.0-rc2 2020-06-11 18:05:14 +02:00
Sara Arjona
4234dc31cb Merge branch 'MDL-69022' of https://github.com/Chocolate-lightning/moodle 2020-06-11 12:50:49 +02:00
Mathew May
ddb34e56d3 MDL-69022 tool_moodlenet: Disable integration by default 2020-06-11 17:25:54 +08:00
Jun Pataleta
02b7fac93d Merge branch 'MDL-69017-master' of git://github.com/andrewnicols/moodle 2020-06-11 16:59:04 +08:00
Sara Arjona
057db49265 Merge branch 'MDL-69004-master' of git://github.com/rezaies/moodle 2020-06-11 10:22:38 +02:00
Jake Dallimore
28bcf61281 Merge branch 'MDL-69020-master' of git://github.com/mihailges/moodle 2020-06-11 16:18:08 +08:00
Mihail Geshoski
cca4ba26c9 MDL-69020 tool_moodlenet: Modify defaultmoodlenet_desc string 2020-06-11 16:13:19 +08:00
Andrew Nicols
d3bfae8fcc MDL-69017 user: Show all links should work for students 2020-06-11 15:51:41 +08:00
Jun Pataleta
f2dc6313f0 Merge branch 'MDL-67070-master' of git://github.com/andrewnicols/moodle 2020-06-11 14:22:48 +08:00
Andrew Nicols
01f6be2cff Merge branch 'MDL-69006-master' of git://github.com/bmbrands/moodle 2020-06-11 12:59:26 +08:00
Jake Dallimore
c53b9c9a6f Merge branch 'MDL-68991-master' of git://github.com/rezaies/moodle 2020-06-11 12:27:16 +08:00
Jake Dallimore
8aa901e7c3 Merge branch 'MDL-69010' of https://github.com/Chocolate-lightning/moodle 2020-06-11 12:01:22 +08:00
Jun Pataleta
a04f9e8bf4 Merge branch 'MDL-69013-master' of git://github.com/andrewnicols/moodle 2020-06-11 11:28:31 +08:00
Andrew Nicols
4dae4b1429 Merge branch 'MDL-69002-master' of git://github.com/sarjona/moodle 2020-06-11 11:08:14 +08:00
Andrew Nicols
fc99ffa1aa MDL-67070 tool_usertours: Fix assumption that tours exist 2020-06-11 11:05:27 +08:00
Jun Pataleta
49a34f1593 Merge branch 'MDL-68912' of https://github.com/rlorenzo/moodle 2020-06-11 11:01:05 +08:00
Adrian Greeve
fcae8cd3cf MDL-66601 atto_image: Removing bad js build files. 2020-06-11 10:43:13 +08:00
Mathew May
e5daf9c7fc MDL-69010 tool_moodlenet: Migrate default MoodleNet instance setting 2020-06-11 10:32:27 +08:00
Andrew Nicols
6414edf1f9 MDL-69013 core: Add quizaccess_safebrowser to deleted plugins 2020-06-11 09:43:38 +08:00
Adrian Greeve
0f4a9aa531 Merge branch 'MDL-66601-master' of git://github.com/mihailges/moodle 2020-06-11 09:43:07 +08:00
Andrew Nicols
f938dfcae8 MDL-67070 tool_usertours: Remove old tour JSON files 2020-06-11 09:32:31 +08:00
Andrew Nicols
b9310489ab MDL-67070 tool_usertours: Disable old tours 2020-06-11 09:32:31 +08:00
Shamim Rezaie
06bbbbff27 MDL-69004 core: Encourage admins to enable user feedback
As part of this commit, the default for the user feedback feature
has changed to disable.
2020-06-11 11:24:30 +10:00
Rex Lorenzo
330c871c3f MDL-68912 user: "Send a message" select all not working 2020-06-10 17:53:53 -07:00
Eloy Lafuente (stronk7)
39885e35f4 Merge branch 'MDL-68954-master' of git://github.com/mihailges/moodle 2020-06-10 23:53:35 +02:00
Eloy Lafuente (stronk7)
5364577065 Merge branch 'MDL-68994-master' of git://github.com/andrewnicols/moodle 2020-06-10 23:31:11 +02:00
Victor Deniz Falcon
034ba327d0 Merge branch 'MDL-68980-master' of git://github.com/andrewnicols/moodle 2020-06-10 21:41:56 +01:00
Jun Pataleta
15823a94c1 Merge branch 'MDL-68989-master' of git://github.com/mickhawkins/moodle 2020-06-11 00:03:54 +08:00
Sara Arjona
1826ac971a Merge branch 'MDL-68902-master' of git://github.com/ferranrecio/moodle 2020-06-10 17:57:40 +02:00
Eloy Lafuente (stronk7)
489b82b22a Merge branch 'MDL-69005' of https://github.com/paulholden/moodle 2020-06-10 17:52:53 +02:00
Ferran Recio
56d9b5f8d5 MDL-68902 mod_h5pactivity: fix result report output 2020-06-10 17:50:55 +02:00
Bas Brands
b8ee31a0ce MDL-69006 repository_flickr: flickr authentication fails
- Flickr does not like useragents including the word "Bot"
2020-06-10 15:46:13 +02:00
Víctor Déniz Falcón
69184789b5 Merge branch 'MDL-68986-master' of git://github.com/merrill-oakland/moodle 2020-06-10 13:12:58 +01:00
Peter Dias
5c0d795bce MDL-69002 core_badges: performance update to set default sitebackpack 2020-06-10 13:02:44 +02:00
Sara Arjona
92219c8ffd MDL-69002 core_badges: move backpack validation to a separate page
Instead of running the site backpack validation every time badges/backpacks.php
page is loaded, an action button has been added to the backpacks with OB set
to 2.0 to let admins running manually this verification when needed.
2020-06-10 13:02:44 +02:00
Sara Arjona
3e567085a8 MDL-69002 core_badges: add methods to support backpack validation
A more generic method has been added to the API to validate the
backpack connection (for now, there was only one method for
validating current backpack).
Besides, a renderer has been added to display this information
depending on the backpackid.
2020-06-10 12:26:47 +02:00
Sara Arjona
15db4a762a MDL-69002 core_badges: remove site backpack verification from settings
This site backpack verification is not required so, instead of
running it always here, it will be moved to a separate page to let
admins decide when to check it.
2020-06-10 12:06:59 +02:00
Paul Holden
2d70187ade MDL-69005 cache: fix private $store access in loader. 2020-06-10 10:31:47 +01:00
Andrew Nicols
9a7bd66b4e MDL-68980 user: Add additional groupmode participants tests 2020-06-10 16:23:58 +08:00