209 Commits

Author SHA1 Message Date
Sam Chaffee
87a26cc402 MDL-42065 core_grade: Modified some grade_item queries for improved performance
* Modified 2 queries in grade_item::depends_on to improve performance
* Added additional unit tests to cover those queries better
2013-10-09 12:16:54 -06:00
Tim Hunt
3987312883 MDL-31487 fix FEATURE_CONTROLS_GRADE_VISIBILITY for quiz.
This is a followup to MDL-18301. That fix missed the following points:

1. On the edit categories and items screens, all items had an eye-con to
control the visibility, even if the visibility was controlled by the
module.

2. Changing the visibility of a grade category change the visibility of
all items within it, even if the visibility was controlled by the
module.

3. The quiz ingored $cm->visible when controlling whether its grade item
was visible.
2013-08-08 10:03:47 +01:00
Petr Škoda
1c74b26090 MDL-40220 use new core_component::get_plugin_directory() 2013-07-16 22:38:38 +02:00
Andrew Davis
ea11496d0b MDL-31713 core_grade: added updating of grade min and max to update_final_grade() 2013-05-07 12:21:07 +08:00
Andrew Davis
415b15ccd6 MDL-29733 grade: SQL and comment cleanup 2012-12-11 09:15:31 +08:00
Jonathan Champ
8a592bd551 MDL-29733 grade: Query for Identifying Grade Grades to Precreate is SLOW 2012-12-11 09:15:31 +08:00
Andrew Davis
69bcca5e9c MDL-36061 core_grade: added some unit tests related to refresh_grades() 2012-11-15 11:14:21 +08:00
Matt Switlik
0a757cf033 MDL-36061 gradebook: grade_item->refresh_grades doesn't propagate $userid 2012-11-12 11:19:20 +08:00
Rajesh Taneja
dea75f643d MDL-32759 Assignment: Grades will not be scaled for new assignment module, and added warning message for user 2012-08-14 11:23:33 +08:00
Frederic Massart
455dc0de61 MDL-18301 Gradebook: Added feature for components to control grade visibility 2012-07-06 09:52:46 +08:00
Andrew Davis
a153c9f2fe MDL-30999 grade: updated Grade API phpdocs 2012-02-14 14:04:19 +07:00
Eloy Lafuente (stronk7)
1b42e67747 MDL-25708 recordsets - fix lib/grade/xxx stuff 2011-01-25 19:59:00 +01:00
Petr Skoda
365a594107 MDL-24321 switching to stdClass in /lib/ 2010-09-21 08:07:44 +00:00
Petr Skoda
22a9b6d873 fixed phpdocs and marked methods as static 2010-09-18 10:43:50 +00:00
Petr Skoda
f685e83030 MDL-14679 fixed remaining old style set_field()s 2010-09-03 18:14:55 +00:00
Andrew Davis
59ee314414 gradebook MDL-24045 added a guard for when the user report is accessed outside of a course context 2010-09-02 02:38:29 +00:00
Petr Skoda
7ad5a62727 MDL-21249 improved php docs and adding direct access prevention in editors 2010-07-25 13:56:54 +00:00
Andrew Davis
e40eabb5d9 gradebook MDL-23181 committing grade item patch 2010-07-14 08:51:19 +00:00
David Mudrak
f829c8d07f MDL-22062 Grade item's idnumber can be added from the calculation form
Before this patch, if activity module used multiply grade items (as
workshop does), the method add_idnumber() returned false because it
required empty idnumber in course_modules. The patch makes this check
only for grade_items with itemnumber 0.
2010-06-05 19:53:29 +00:00
Andrew Davis
992cfb1101 gradebook MDL-22139 fixed a typo in a comment 2010-06-01 09:27:47 +00:00
Petr Skoda
f7d515b6d3 fixed silly comment typos 2010-05-21 18:57:05 +00:00
Tim Hunt
79312a06e4 grades: MDL-22098 silly bug that leads to bad performance problems in the grader report. 2010-04-15 16:37:05 +00:00
Tim Hunt
26e3ae92f2 grade import: MDL-21987 Problem with repeated imports of the same grade.
The thanks to Petr (skodak).

Here is what I learned while working on this:

1. when explicitly setting the final grade (manual edit or import),
   it is important that ->overridden gets set, and it should get set
   to the time when the override was done.

2. but only on certainly sorts of grade item, and the condition for
   setting the flag is different when it is the feedback being changed
   or the grade being changed, hence the two different tests
   is_overridable_item and is_overridable_item_feedback.

3. but, if the grade and feedback is not actually changed, then the ->overridden
   timestamp should not be changed. (That was the bit that was buggy.)
2010-03-31 13:50:56 +00:00
Andrew Davis
d90aa63419 grader report MDL-21367 when an item is unhidden its category should unhide to 2010-02-03 02:31:46 +00:00
Andrew Davis
a25bb902f0 grader report MDL-19704 Added ability to hide course and category totals without hiding anything else 2010-01-11 07:35:40 +00:00
David Mudrak
f5a726feb3 MDL-21191 Fixing another regression in dependency calculation
This is not easy to spot as $params may just contain one more item than $sql
would expect. However, $sql and $params should be well paired.
2009-12-25 23:31:59 +00:00
David Mudrak
1b6ab8924f MDL-21190 Re-fixing a regression in dependency calculation
Sorry for the last commit. This should be the proper way. The problem
was with the question mark within quotes - it was not considered as a
placeholder.
2009-12-25 17:18:52 +00:00
David Mudrak
8b9f980a2b MDL-21190 Fixing a regression in dependency calculation 2009-12-25 16:46:46 +00:00
Tim Hunt
e785b784f1 Grade item: MDL-21161 timemodified never gets set on calculated gradebook columns 2009-12-18 18:19:46 +00:00
Petr Skoda
4a0e2e632f MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 11:42:23 +00:00
nicolasconnault
bb55642327 MDL-19407 Defaulting all grade items to non-extra-credit when moving to a SWM category, except if they originally come from a SWM category and were set as extra credit there. Merged from MOODLE_19_STABLE 2009-09-17 07:16:51 +00:00
skodak
121d8006e4 MDL-18927 fixed performance regression 2009-04-22 19:40:21 +00:00
nicolasconnault
653a86489e MDL-18083 Committing gradebook improvements to head 2009-04-16 07:16:44 +00:00
nicolasconnault
9fb1634910 MDL-18402 Merged from MOODLE_19_STABLE 2009-03-23 08:35:06 +00:00
skodak
f53db007f6 MDL-16785 bogus grades inserted when formulas used - credit Michael Spall and Ann Adamcik; merged from MOODLE_19_STABLE 2008-10-24 17:53:15 +00:00
nicolasconnault
4dc81cc70d MDL-15680 Added grade category aggregation settings and weights, plus correct handling of 3 types of weights. 2008-10-10 07:18:19 +00:00
skodak
9718765e92 MDL-14679 finished gradelib conversion 2008-05-30 17:43:00 +00:00
nicolasconnault
5b0af8c5e3 MDL-14967 More upgrades 2008-05-26 05:06:01 +00:00
nicolasconnault
da3801e84b MDL-14967 Upgraded gradebook code and unit tests. 4 failing tests in grade_item to fix. 2008-05-23 14:52:50 +00:00
dongsheng
2f137aa130 "MDL-14129, fix print_error" 2008-05-20 02:53:46 +00:00
skodak
f33e1ed4ae MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs 2008-05-15 21:40:00 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
nicolasconnault
477eec40b7 MDL-14065 Fixed gradebook unit tests, including a bug fix in grade_item class 2008-03-27 12:08:36 +00:00
skodak
9eeb49b24e MDL-13899 improved submission and grading date hack; merged from MOODLE_19_STABLE 2008-03-19 22:39:19 +00:00
skodak
c55c9d73df MDL-13899 feedback itself is a type of grading - date graded is now affected by feedback too; merged from MOODLE_19_STABLE 2008-03-18 23:21:23 +00:00
skodak
55231be044 MDL-13943 improved perf when sending multiple grades into grade_update(); merged from MOODLE_19_STABLE 2008-03-16 23:22:47 +00:00
skodak
5048575d7e MDL-13920 assignment without grades now sets text grade type, fixed overriding of feedback and overriding logic in general on grade edit page; merged from MOODLE_19_STABLE 2008-03-15 14:54:43 +00:00
skodak
25bcd90821 MDL-13845 rewritten rounding in grades classes again - rounding done also before storage into db so that we can compare the values properly and skip db updates if possible + some more optimisations; merged from MOODLE_19_STABLE 2008-03-12 19:45:17 +00:00
skodak
9c9a3259ee MDL-13863 detect missing idnumbers in formulas after restore; merged from MOODLE_19_STABLE 2008-03-10 09:35:42 +00:00
skodak
076aeb01a6 MDL-13850 fix automatic creation of course grade item; merge dfrom MOODLE_19_STABLE 2008-03-08 15:34:39 +00:00