90298 Commits

Author SHA1 Message Date
Jonathan Champ
d2a98f89bd MDL-54035 course: Test reset roles in reset_course_userdata()
Previously, reset_course_userdata() was deleting the role_capabilities
directly, but has_capability() checks the local capabilities cache
which was still returning the previous value.
2018-09-21 09:17:43 -04:00
Jonathan Champ
1113e34675 MDL-54035 accesslib: Add context->get_parent_context_paths()
Returns full context paths for parent contexts. Useful for exact
matches, such as when checking dirtycontexts.
2018-09-21 09:17:43 -04:00
Jonathan Champ
1d049e08e5 MDL-54035 accesslib: add mark_user_dirty helper
Instead of marking an entire context dirty and affecting all users
of those contexts, mark the user as dirty when the change only
affects that user.
2018-09-21 09:17:43 -04:00
Jonathan Champ
34dd57053d MDL-54035 accesslib: only modify role_capabilities in accesslib
Whenever the role_capabilities table is changed, we need to remember
to clear the cache for the role(s) being modified. This is far simpler
when all of those changes happen in a single file, i.e. accesslib.php,
allowing other parts of the application to use the public functions
without requiring knowledge of the cache internals.
2018-09-21 09:17:43 -04:00
Jonathan Champ
b2f349a433 MDL-54035 accesslib: separate role definition cache clear
Thanks to MDL-49398, we can separate the combined user session and role
definition cache clearing function into two separate functions. At the
same time, we want to identify and remove mark_dirty() calls that were
added for role definition changes but were incorrectly left behind.

Change highlights:
 - Remove unnecessary mark_dirty() calls performed after
   assign_capability(), unassign_capability(), delete_role(),
   deleted contexts, brand new contexts
 - Move role definition cache clear from the user-centric
   accesslib_clear_all_caches() to the newly created,
   role-dedicated accesslib_reset_role_cache()
2018-09-21 09:17:42 -04:00
Eloy Lafuente (stronk7)
6902f39141 weekly release 3.6dev 2018-09-20 12:11:53 +02:00
Eloy Lafuente (stronk7)
5bd0dc6483 MDL-23545 question: fix remaining sizes leading to failures 2018-09-19 23:07:20 +02:00
Eloy Lafuente (stronk7)
881f451bf0 Merge branch 'MDL-23545-phpunit-fixes' of https://github.com/timhunt/moodle 2018-09-19 18:10:37 +02:00
Eloy Lafuente (stronk7)
dd3508df5b MDL-59227 course: Use low level early renaming to avoid dupes
Instead of using set_coursemodule_name() to proceed with the name
change we perform the change earlier in the process, both to avoid
duplicate events caused by the renaming function and also to get the new
name used by all proper generated events.
2018-09-19 17:20:23 +02:00
David Monllao
4453613767 Merge branch 'MDL-63140-master' of git://github.com/rezaies/moodle 2018-09-19 13:30:43 +02:00
Tim Hunt
59ffae414c MDL-23545 qformat_xml: fix another Behat test 2018-09-19 12:18:59 +01:00
David Monllao
25561b3751 Merge branch 'MDL-63135-master' of git://github.com/rezaies/moodle 2018-09-19 13:12:40 +02:00
Eloy Lafuente (stronk7)
61367994bd Merge branch 'MDL-23545-phpunit-fixes' of https://github.com/timhunt/moodle 2018-09-19 00:26:25 +02:00
Eloy Lafuente (stronk7)
4cde0a5212 Merge branch 'MDL-63116-master-1' of git://github.com/mihailges/moodle 2018-09-18 23:26:51 +02:00
Eloy Lafuente (stronk7)
ead7a5393e Merge branch 'MDL-59227' of https://github.com/rlorenzo/moodle 2018-09-18 23:11:34 +02:00
Mihail Geshoski
457047de6c MDL-61908 privacy: Fix heading in data privacy pages 2018-09-18 18:49:04 +02:00
Eloy Lafuente (stronk7)
ddf86f9930 Merge branch 'MDL-63109-master' of git://github.com/mihailges/moodle 2018-09-18 17:50:13 +02:00
David Monllao
542201d547 Merge branch 'MDL-63138-master' of git://github.com/rezaies/moodle 2018-09-18 16:39:58 +02:00
David Monllao
11decdb19c Merge branch 'MDL-63139-master' of git://github.com/rezaies/moodle 2018-09-18 16:36:55 +02:00
David Monllao
6302d4cf64 Merge branch 'MDL-63117-master' of git://github.com/rezaies/moodle 2018-09-18 16:32:58 +02:00
Tim Hunt
f19c6f60cd MDL-23545 qformat_xml: don't allow irrelevant DB differences to break tests
Also slightly improve formatting of the exported file.
2018-09-18 13:52:51 +01:00
David Monllao
0e5144fe24 Merge branch 'MDL-63333_master' of git://github.com/markn86/moodle 2018-09-18 12:17:46 +02:00
Mihail Geshoski
85de6d525d MDL-63109 privacy: Add behat tests 2018-09-18 15:06:23 +08:00
Jun Pataleta
58e529e0c0 Merge branch 'm36_MDL-63319_MySQL_MSSQL_Rename_Field_Reserved_Word' of https://github.com/scara/moodle 2018-09-18 14:10:11 +08:00
Mihail Geshoski
2b85015b83 MDL-63109 privacy: Fix the initialisation of the policy acceptance modal 2018-09-18 12:55:35 +08:00
Jun Pataleta
902ec3d0f8 Merge branch 'MDL-23545-master-fix' of git://github.com/junpataleta/moodle 2018-09-18 10:07:56 +08:00
Jun Pataleta
73311d3157 MDL-23545 question_format: Replace tabs with spaces in upgrade.txt 2018-09-18 10:04:03 +08:00
Jun Pataleta
3d2659097e Merge branch 'wip-MDL-23545-master' of https://github.com/Beedell/moodle 2018-09-18 09:47:38 +08:00
Rohan Khajuria
e372389251 MDL-59227 course: add (copy) to duplicated modules 2018-09-17 15:14:12 -07:00
Eloy Lafuente (stronk7)
044e343bbd Merge branch 'MDL-63279_master' of https://github.com/aanabit/moodle 2018-09-17 23:56:37 +02:00
Eloy Lafuente (stronk7)
d20250ab3e Merge branch 'MDL-58781_master' of https://github.com/aanabit/moodle 2018-09-17 23:39:35 +02:00
Eloy Lafuente (stronk7)
4ab33be074 Merge branch 'MDL-63009-master' of git://github.com/mickhawkins/moodle 2018-09-17 23:30:13 +02:00
Eloy Lafuente (stronk7)
01d7b4b6dd Merge branch 'MDL-63184-master-2' of git://github.com/junpataleta/moodle 2018-09-17 23:10:39 +02:00
Eloy Lafuente (stronk7)
8d6892167b Merge branch 'MDL-63371' of git://github.com/timhunt/moodle 2018-09-17 23:09:20 +02:00
Eloy Lafuente (stronk7)
7c5a9faf41 Merge branch 'MDL-63354-master' of https://github.com/HuongNV13/moodle 2018-09-17 23:05:31 +02:00
Jun Pataleta
302089f52b MDL-63184 tool_dataprivacy: Ensure PO roles have correct capability 2018-09-17 22:12:34 +08:00
David Monllao
79e321cbc4 Merge branch 'MDL-62554-master' of git://github.com/junpataleta/moodle 2018-09-17 13:44:49 +02:00
Eloy Lafuente (stronk7)
771665a2a0 Merge branch 'MDL-63215-master' of https://github.com/lucaboesch/moodle 2018-09-17 10:40:41 +02:00
Eloy Lafuente (stronk7)
ba03ff5d32 Merge branch 'MDL-63379-master' of git://github.com/junpataleta/moodle 2018-09-17 09:54:31 +02:00
Jun Pataleta
8420b61c25 MDL-63379 user: Fix Behat tests for participants filtering 2018-09-17 11:25:37 +08:00
Mark Nelson
cbc3833d27 MDL-63333 core: removed unused setting 'messaginghidereadnotifications' 2018-09-17 10:02:37 +08:00
Mihail Geshoski
19bad13a55 MDL-63116 privacy: Add bulk actions to the privacy request table 2018-09-17 08:13:06 +08:00
Mihail Geshoski
99496e35ae MDL-63116 privacy: Add behat tests 2018-09-17 08:13:06 +08:00
Mihail Geshoski
598160ef4c MDL-63116 privacy: Add unit tests 2018-09-17 08:13:06 +08:00
Michelle Melton
29ec0d5543 MDL-63215 block_rss_client: Escaping tags in RSS entries 2018-09-16 23:49:15 +02:00
Matteo Scaramuccia
211d04f43e MDL-63319 ddl: Added getRenameFieldSQL() coverage 2018-09-14 22:41:18 +02:00
Matteo Scaramuccia
66c34d3578 MDL-63319 ddl: Improved rename_field() coverage
DB API should allow to rename fields, including renaming
those columns named using a reserved word.
2018-09-14 22:41:18 +02:00
Matteo Scaramuccia
12b6041aac MDL-63319 ddl: MSSQL should rename reserved words 2018-09-14 22:31:39 +02:00
Matteo Scaramuccia
0fb34e9108 MDL-63319 ddl: MySQL should rename reserved words 2018-09-14 22:31:39 +02:00
John Beedell
1dab8faafd MDL-23545 question: XML import/export add category description 2018-09-14 16:54:25 +01:00