63 Commits

Author SHA1 Message Date
Petr Skoda
812dbaf7d5 MDL-21198 improved/simplified $OUTPUT->user_picture() + regression fixes, performance fixes and detected performance problems when printing user avatars 2009-12-27 19:47:21 +00:00
Petr Skoda
aeb15530b8 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-04 11:57:52 +00:00
samhemelryk
458eb0d10c overlib MDL-19735 Overlib is now included only where it is used
At the same time I have converted the calendar block to use YUI instead of overlib, this introduces one regression in that the panel is shown immediatly but should really have a minimal delay for usability.
This will be fixed once the theme changes for 2.0 have been commited
2009-09-17 07:46:20 +00:00
nicolasconnault
39e3701904 MDL-19813 upgraded calls to print_table, print_single_button, print_user_picture, print_container* and notice_yesno 2009-08-20 08:45:47 +00:00
nicolasconnault
825116fb22 MDL-19813 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:16:08 +00:00
nicolasconnault
7b1f2c829f MDL-19756 Renamed moodle_select to html_select for better API consistency 2009-08-10 08:38:45 +00:00
nicolasconnault
066f1c7afe MDL-19813 Converted calls to popup_form() 2009-08-10 03:37:44 +00:00
nicolasconnault
90cd54cb2a MDL-19813 Migrated calls to print_heading 2009-08-06 08:23:24 +00:00
tjhunt
b933475898 quiz manual grading: Remove todo that was already done! 2009-07-17 07:00:16 +00:00
tjhunt
dab9be1ad1 quiz manual grading: MDL-17586 'Grade all 4 ungraded attempts' acutally does the opposite' 2009-03-26 01:50:22 +00:00
tjhunt
96c7d771df quiz: MDL-14926 New capability mod/quiz:reviewmyattempts, separate from mod/quiz:attempt. Merged from MOODLE_19_STABLE. 2009-01-14 07:08:02 +00:00
tjhunt
e8f99abc68 quiz manual grading: MDL-5517 manual grading pop-up is too small. HTML editor does not fit. Merged from MOODLE_19_STABLE.
Also MDL-17585 Improve layout of manual grading forms to make them look more like formslib forms. The standard trick of stealing the HTML and class names that formslib works, so the standard style rules apply to your form.
2008-12-10 09:11:30 +00:00
tjhunt
aafdb447bf quiz: MDL-6085 when editing a question from various places like a preview attempt or review screen, don't use a popup, instead take advantage of the fact that question.php now takes a returnurl. Merged from MOODLE_19_STABLE.
And MDL-17568 minor niggles with new queston navigation:
* The bit that scrolls down to the question you just submitted in adaptive mode was not working with random questions.
* Teachers reviewing an open attempt were shown the qusetions as editable, not read only!
2008-12-10 06:26:47 +00:00
tjhunt
f24493ec9b random essay questions: MDL-8648 Allow essay questions to be selected by random question.
In the 1.9 branch this is controlled by a new option under Admin -> Experimental. In Moodle 2.0 dev it is not optional, it just works.

The main change is letting the manual grading report know which random questions might need manual grading. MDL-4004 - this depends on the random question under consideration, which requires a new questiontype method.

I also changed the random question code so that I could remove some global variables.
2008-11-28 06:07:11 +00:00
jamiesensei
a832c5e151 MDL-5241 edited comments that had not been updated. 2008-11-21 10:02:49 +00:00
dongsheng
a6344df49a "MDL-14129, fixed hardcoded print_header in quiz module" 2008-09-25 08:21:59 +00:00
jamiesensei
8b92c1e3f6 MDL-16529 "Only include closed attempts in manual grade counts" 2008-09-23 09:52:55 +00:00
tjhunt
766df8f72b MDL-16334 Convert mod/quiz/comment.php to use attemptlib.php - final part of the work on the quiz navigtion, I hope.
MDL-16559 Remove question/comment.html template, and instead just have a function in questionlib.php
MDL-16562 Regression from MDL-16263, notices when regrading.
Sorry, the three got tangled together (coupled through questionlib) while I was fixing bugs in preparation for a demo.
2008-09-18 07:39:10 +00:00
tjhunt
8033d8423f Minor bug fixes. 2008-09-18 04:33:38 +00:00
jamiesensei
a3668b25c0 MDL-16121 "Manual Grading Doesn't Work" grades where not getting saved. Fixed that now. 2008-08-25 07:44:20 +00:00
tjhunt
92718f4c44 No manually graded questions found is not an error contidion, so return true, not false. 2008-07-25 14:11:22 +00:00
jamiesensei
6559096f2c MDL-15728 "quiz_report_load_questions should alias qqi.grade to maxgrade so that questions array has the required fields expected by much of the question code." 2008-07-21 09:06:46 +00:00
jamiesensei
c386eaa3df MDL-15384 'change name of quiz report classes to "quiz_{reportname}_report"' easy to do, changed class name of all reports and changed the code in report.php which instantiates the correct class. 2008-06-24 08:59:29 +00:00
jamiesensei
0b8953aec3 MDL-15165 "Essay quiz Manual grading "these are no attempts to show" when there are actually attempts" - not resolved. But while reviewing the query I found a LIMIT clause in sql that I've replace with params to the get_records_sql function. Also made the logic in attempt_sql method more robust.
Merged from 1.9
2008-06-19 15:24:27 +00:00
jamiesensei
8673a56615 MDL-15113 "quiz dml conversion" - fixing some sql broken during the conversion and removing unnecessary comma seperated list of ids where there are arrays of ids that can be used instead. 2008-06-09 13:27:31 +00:00
nicolasconnault
9cf4a18b41 MDL-15113 Upgrade to DMLLIB 2.0. Needs further testing and bug-fixing.
MDL-15100 Fixed a bug in gradelib.php
Plus edited tablelib.php for table_sql upgrade to dmllib 2.0
2008-06-09 10:00:35 +00:00
jamiesensei
f17a34b5ef MDL-15011 "grading report : allow user to select to grade next 10 ungraded attempts" added a new link and options to the grading report page to display only the next 10 ungraded attempts to grade. Also some fixes for faulty sql for ungraded option which was not respecting the users groups selection. 2008-05-29 14:14:27 +00:00
jamiesensei
ee5163b051 MDL-15002 "grading report : notice from quiz_num_attempt_summary about how many total attempts there are on the quiz and how many in this group would make UI clearer" added call to function and fixed centering of notice on overview and grading report by adding a clear:left to stop the centering being affected by the groups menu.
merged from 1.9 branch
2008-05-26 14:26:24 +00:00
jamiesensei
a76a131ab5 MDL-12824 "Essay type of quiz questions needs to color mark which students have been graded and which have NOT"
Fixing notices introduced by the changes for this bug in grading report when no question is selected.
2008-05-26 13:18:46 +00:00
jamiesensei
686e602047 MDL-12824 "Essay type of quiz questions needs to color mark which students have been graded and which have NOT"
As well as highlighting graded questions with a new CSS class highlightgraded which is a yellow bg in the standard theme, have also added the option to grade all ungraded attempts for a question.
2008-05-26 12:47:42 +00:00
jamiesensei
720be6f2c3 MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name"
Also added a drop down box to select question to mark instead of the viewquestions table. The drop down box is available at the top of every page, but only if there is more than one manually gradeable question in the quiz. If there is only one question it is automatically selected for marking.

Also added a new constant QUESTION_EVENTS_GRADED during a general refactoring of UI code in grading report and some improvements to efficiency of SQL in report.

Merged from Moodle 1.9 branch
2008-05-26 11:39:51 +00:00
jamiesensei
a59eb2b6a8 MDL-12547 "allow manual quiz grading to sort by groups" added code to select which group to grade.
Merged from Moodle 1.9 branch
2008-05-23 13:14:00 +00:00
skodak
f33e1ed4ae MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs 2008-05-15 21:40:00 +00:00
tjhunt
994c8c3509 MDL-14835 - Grade not checked against valid range when manua grading 2008-05-15 16:02:12 +00:00
scyrma
59fa45d0f1 MDL-11113: simplify the code - use only one function to check for html editor availability 2008-05-07 07:40:50 +00:00
jamiesensei
f33c438e5c MDL-13678 "Change default number of rows per page on quiz reports" Made a new constant to say how many attempts / questions to list per page by default. 2008-05-01 07:08:28 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
tjhunt
f4850b7e52 MDL-12635 - Manual grading report does not check capabilites - also, only show the tabs for the reports people can access. Merged from MOODLE_19_STABLE. 2007-12-18 16:12:11 +00:00
tjhunt
260812ba06 MDL-10972 - The lang string 'fullname', which is normally used for course fullnames, was being used for a person's full name in some quiz reports. This dual usage is not translatable into all languages. Merged from MOODLE_18_STABLE. 2007-09-19 15:52:27 +00:00
tjhunt
fca490bca0 MDL-6315 - When processing a manul grading action, if both the comment and the score are blank - as might be the case on the 'Grade all' page of the manual grading when the teacher uses it to grade some, but not all of the students - then do not record the question as graded. Merged from MOODLE_18_STABLE. 2007-09-19 10:56:24 +00:00
tjhunt
6c554fc9b8 XHTML Strictness. Merged from MOODLE_18_STABLE. 2007-09-19 10:32:09 +00:00
jamiesensei
1f21cc88f7 removed global vars declaration for var not used in method. 2007-04-27 05:55:57 +00:00
tjhunt
b3396fe91d MDL-9183 - yet another invisiblefieldset causing layout problems. Merged from MOODLE_18_STABLE. 2007-04-04 15:30:41 +00:00
tjhunt
bc67d9b3bd MDL-7241 - Manual grading report, sort by completed time didn't. Merged from MOODLE_16_STABLE. 2007-03-22 21:31:39 +00:00
vyshane
0927589412 Xhtml fixes for MDL-7861. 2007-01-09 09:07:16 +00:00
skodak
60af27037b MDL-7861 xhtml transient fixes for not closed input fields - I hope all of them except imported libs are now fixed 2007-01-08 19:34:16 +00:00
martinlanghoff
1ad5c6380f mod/quiz: remove deprecated sql_paging_limit(), use offset, limit parameters 2006-09-26 05:11:05 +00:00
martinlanghoff
27176468fe mod/quiz: replace $db->Concat() with sql_concat() 2006-09-26 05:05:10 +00:00
tjhunt
cd06115fa7 Convert mod/quiz/view.php to roles, and further tidy up the code flow in there. This touches other files because I had to change a function in locallib that had an $isteacher parameter.
I have not converted the rest of the quiz, and I don't intend to. I am hoping Moodle.com will do it.

I hope this does not introduce any bugs, but view.php is so complicate (at least it is less complicated than it was) and the quiz has so many options, that it is hard to be sure. This needs lots of testing before 1.7 is released.
2006-08-25 16:03:54 +00:00
tjhunt
3e3e5a4030 Renamed column question_sessions->comment at Eloy's request since comment is a DB reserved word.
I have not been able to test this fully, because I cannot assign roles (e.g. Student and Teacher) in 1.7dev at the moment to test a student answering an essay question then a teacher grading it. However, I have tested as much as possible as admin and cannot get any errors.
2006-08-24 16:44:15 +00:00