108299 Commits

Author SHA1 Message Date
Angelia Dela Cruz
e7d32b89ac MDL-75961 behat: IMSCP behat generators use UI
Replace steps that manually add IMSCP instances via the UI and use
Behat generators. This improves the speed of the Behat test runs.
2023-05-24 10:41:41 +08:00
Sara Arjona
22705fa4fb Merge branch 'MDL-78176_401' of https://github.com/AnupamaSarjoshi/moodle into MOODLE_401_STABLE 2023-05-23 17:45:57 +02:00
Sara Arjona
7c0954ccd1 Merge branch 'MDL-78242-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-23 17:37:00 +02:00
Jun Pataleta
0479c711c2 Merge branch 'MDL-76688/401' of https://github.com/skodak/moodle into MOODLE_401_STABLE 2023-05-23 15:22:04 +08:00
Angelia Dela Cruz
de6c14ee71 MDL-77547 Behat: Coverage to check for bad multichoice questions 2023-05-23 15:17:43 +08:00
Simey Lameze
1936b30c88 MDL-76065 behat: Review and enhance mod_lti Behat tests
In this commit, the following improvements were made to the mod_lti Behat tests:

* Replaced manual steps with data generators to set completion.
* Eliminated unnecessary user and course enrolments data generation as some tests can be performed as an admin.
* Removed the @javascript tag from non-JS tests.
* Updated the LTI data generator to generate an internal Moodle URL in the toolurl field, enabling the use of XML files.
2023-05-23 12:23:26 +08:00
Angelia Dela Cruz
f19f31736a MDL-76065 behat: LTI behat generators use UI
Replace steps that manually add LTI instances via the UI and use
Behat generators. This improves the speed of the Behat test runs.
2023-05-23 12:15:25 +08:00
Andrew Nicols
2b01af17be
Merge branch 'MDL-78170-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-23 10:28:33 +08:00
AMOS bot
439f75e6e1 Automatically generated installer lang files 2023-05-23 00:10:27 +00:00
Paul Holden
dec3d56032
MDL-76838 backup: remove invalid utf8 code sequences writing XML.
The surrogate blocks FFFE and FFFF are non-characters, specifically
disallowed in the character range for XML documents.
2023-05-22 21:04:12 +01:00
Paul Holden
452c7c72e0
MDL-78322 tool_cohortroles: don't assign roles to deleted users. 2023-05-22 20:14:39 +01:00
Tim Hunt
0d0868ee97 MDL-78008 qtype_multianswer: random guess score with missing subqs
Sometimes, due to other bugs, subquestions can get lost, so the code
needs to be robust to this.
2023-05-22 17:02:22 +01:00
Sara Arjona
c98e7e7dbf Merge branch 'MDL-78211-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-22 17:41:48 +02:00
Sara Arjona
90e18e28a2 Merge branch 'MDL-78226-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-22 17:29:27 +02:00
Sara Arjona
db7c650f8c Merge branch 'MDL-78225-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-22 12:04:19 +02:00
sam marshall
79d0e63b18 MDL-78092 Cache: Modinfo locking with Redis store does not work
The feature added in 4.1 to lock the modinfo cache does not work when
using Redis, because:

* The API to acquire a cache lock is confusing, and the code did not
  check that it successfully acquired a lock before going on to build
  the cache anyway.

* Unlike the other types of cache lock, the Redis store did not retry
  the lock for a timeout period before giving up and failing.

This change fixes both points.
2023-05-22 10:45:13 +01:00
Jun Pataleta
962c8ef477 Merge branch 'MDL-78157-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-05-22 15:29:30 +08:00
Andrew Nicols
2036f2439e
MDL-78157 js: Be more careful about inserting missing module names
It is perfectly legitimate to create and/or use a method named `define`
in JS outside of RequireJS.

Unfortunately our requirejs.php wrapper is dumb and does not understand
this.

In the long term we need to stop doing this at all. We really should be
able to already, but every time I try to something prevents it.

In the interim, this change adds a secondary check to see if there is an
existing define which _does_ have the right name in it already.
2023-05-22 14:40:41 +08:00
Luca Bösch
6bb4351e8b MDL-78229 quiz: quiz editing page less narrow.
This is a backport of MDL-77872.
2023-05-19 18:13:07 +02:00
Anupama Sarjoshi
80fa181a26 MDL-78176 Question: Fix D&D onto image and D&D markers theme issue 2023-05-19 16:28:53 +01:00
Jun Pataleta
6ca70dd59f weekly release 4.1.3+ 2023-05-19 21:13:57 +08:00
Jun Pataleta
712737e955 Merge branch 'install_401_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_401_STABLE 2023-05-19 21:13:54 +08:00
Andrew Nicols
5e32d574c6 MDL-77733 behat: Remove extraneous no-axe option
There is no need for no-axe if we make axe a boolean value. We already
have automatic support for negated boolean flags.
2023-05-19 11:28:08 +08:00
Mark Johnson
5620e0059a MDL-75696 quiz: Fix restoring pre-4.0 quizzes with random questions
Restoring multiple quizzes from a pre-4.0 backup was broken when
the quizzes shared a random question. This is because after the
first quiz created a set reference in place of the random question,
it deleted the question record so it was not there for the second
quiz to use. This change tracks the IDs of random questions so
they can be deleted at the end.
2023-05-18 15:59:53 +01:00
Mark Johnson
85b1e992e9 MDL-75696 quiz: Set default value for includingsubcategories on restore 2023-05-18 15:56:02 +01:00
Mark Johnson
8d50911af5 MDL-75696 backup: Fix backup version checks
Several version checks were incorrectly using
restore_controller::info::moodle_release instead of moodle_version as a
version number. This replaces all of those checks with a common pair of
methods to make the checks clearer and more maintainable.
2023-05-18 15:56:02 +01:00
Paul Holden
5c871bff29
MDL-78308 output: better parsing of custom menu item configuration.
Previously certain values would cause deprecation notices in PHP8.1.
2023-05-18 10:19:18 +01:00
Jun Pataleta
096f1e67c8 Merge branch 'MDL-78116-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-05-18 12:11:31 +08:00
Andrew Nicols
21cc09fa2d
Merge branch 'MDL-77451-401' of https://github.com/rezaies/moodle into MOODLE_401_STABLE 2023-05-18 11:56:33 +08:00
Jun Pataleta
e2a7a44d3e Merge branch 'MDL-78135-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-18 11:54:46 +08:00
Andrew Nicols
b28a28ef0f
Merge branch 'MDL-78260_401' of https://github.com/timhunt/moodle into MOODLE_401_STABLE 2023-05-18 11:51:47 +08:00
Andrew Nicols
30e9810589
Merge branch 'MDL-78151-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-18 11:48:39 +08:00
Andrew Nicols
cf83791269
Merge branch 'MDL-77733-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-05-18 11:44:18 +08:00
David Woloszyn
3f07fc246f MDL-78005 editor_tiny: Declared vars to supress error logging 2023-05-18 13:03:04 +10:00
Tim Hunt
3d023db5b0 MDL-78260 quiz stats: fix View details for random questions 2023-05-17 09:04:49 +01:00
Rajneel Totaram
13b48a0ae8 MDL-77983 core_user: Avoid passing nulls to base64_decode 2023-05-17 19:39:52 +12:00
Ilya Tregubov
87223abc7a
Merge branch 'MDL-78152-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-05-17 15:07:38 +08:00
AMOS bot
e7458d017a Automatically generated installer lang files 2023-05-17 00:10:58 +00:00
Jun Pataleta
d2b81dd116 Merge branch 'MDL-77439-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-05-16 20:39:09 +08:00
Peter Mayer
361f0fa524 MDL-77439 lib_filebrowser: Splitup query to speedup get_courses 2023-05-16 20:37:57 +08:00
Paul Holden
7a23da59ce
MDL-78026 group: format retrieved group names from external methods. 2023-05-16 10:10:06 +01:00
Paul Holden
01ae473823
MDL-77264 grade: define fallback name of abstract export event. 2023-05-16 09:54:40 +01:00
Paul Holden
0aff5ccd01
MDL-77259 tool_monitor: use core component API for event list.
The previous method of hardcoded filepaths, specifically for events
belonging to core, meant that any events belongs to core subsystems
were omitted (core_customfield, core_h5p, core_payment, etc).
2023-05-16 09:50:22 +01:00
Angelia Dela Cruz
7a511874b8 MDL-77907 Behat: Coverage for duplicating competency framework 2023-05-16 16:11:58 +08:00
Andrew Nicols
a1b37845a8
MDL-78072 core: Skip mobile encryption if Sodium is not available 2023-05-16 12:51:14 +08:00
Jake Dallimore
071adb2fb1
Merge branch 'MDL-77930-401' of https://github.com/rjnl/moodle into MOODLE_401_STABLE 2023-05-16 10:50:04 +08:00
Jake Dallimore
aa39ebbb99
Merge branch 'MDL-78120-401' of https://github.com/lucaboesch/moodle into MOODLE_401_STABLE 2023-05-16 10:45:27 +08:00
Jun Pataleta
4818dae2fc Merge branch 'MDL-75576_401' of https://github.com/timhunt/moodle into MOODLE_401_STABLE 2023-05-16 09:59:01 +08:00
Ilya Tregubov
dc38a92ec6
Merge branch 'MDL-77840-401' of https://github.com/davewoloszyn/moodle into MOODLE_401_STABLE 2023-05-16 09:47:48 +08:00
Andrew Nicols
946405d44b
Merge branch 'MDL-77432-401' of https://github.com/lucaboesch/moodle into MOODLE_401_STABLE 2023-05-15 22:12:44 +08:00