20436 Commits

Author SHA1 Message Date
Zig Tan
0061a6ae67 MDL-62444 mod_assignment: Fix missing lang string. 2018-05-15 09:50:11 +08:00
Jun Pataleta
d060e0b80f Merge branch 'MDL-62432-master' of git://github.com/andrewnicols/moodle 2018-05-15 09:34:18 +08:00
Andrew Nicols
63b0f6276c MDL-62432 quiz: Check contexts more carefully 2018-05-15 09:25:51 +08:00
Eloy Lafuente (stronk7)
05c87e7bb4 Merge branch 'MDL-62430_master' of git://github.com/dmonllao/moodle 2018-05-15 02:56:00 +02:00
David Monllao
641d878d08 MDL-62430 block_html: Check that block instances are block_html 2018-05-14 17:06:57 +02:00
Mark Nelson
df1714f25a MDL-62228 core: remove unnecessary context check in privacy providers 2018-05-14 18:33:29 +08:00
Marina Glancy
3960ad53a7 MDL-62430 privacy: validate context when deleting all user data 2018-05-14 18:13:27 +08:00
Mark Nelson
8e24041287 MDL-62428 core: fix incorrect early return in privacy providers 2018-05-14 13:06:29 +08:00
Jun Pataleta
cea21312f9 Merge branch 'MDL-62153-master' of git://github.com/bmbrands/moodle 2018-05-14 11:57:01 +08:00
Eloy Lafuente (stronk7)
1906a73574 MDL-61973 editor_atto: apply string changes to behat tests 2018-05-12 01:24:26 +02:00
Bas Brands
526491f2f7 MDL-62153 Theme boost: lesson display issues on detailed statistics 2018-05-11 20:11:43 +02:00
Eloy Lafuente (stronk7)
4f510bea17 Merge branch 'MDL-62384-master' of git://github.com/andrewnicols/moodle 2018-05-11 18:12:45 +02:00
Jun Pataleta
44d89dfa7a Merge branch 'MDL-62382-master' of git://github.com/ryanwyllie/moodle 2018-05-11 12:06:03 +08:00
Ryan Wyllie
ebe7417f94 MDL-62382 quiz: include subcategories when previewing top categories
Include the subcategories when loading the list of questions for
a top level question in the add random question modal.
2018-05-11 11:51:50 +08:00
Andrew Nicols
f6021ae0af MDL-62384 mod_lesson: Move WHERE clause to JOIN 2018-05-11 09:15:29 +08:00
Andrew Nicols
037027230a MDL-62384 mod_quiz: Improve performancy of privacy queries 2018-05-11 09:15:29 +08:00
Adrian Greeve
d04b8d74a7 MDL-62384 mod_data: Update sql to improve performance. 2018-05-11 09:15:28 +08:00
Adrian Greeve
8a5b84cf8b MDL-62384 mod_assign: Update to sql query for performance. 2018-05-11 09:15:27 +08:00
David Monllao
1f000f071e Merge branch 'MDL-62366-master' of git://github.com/zig-moodle/moodle 2018-05-10 18:13:44 +02:00
David Monllao
7b6c74431b Merge branch 'MDL-61949-master-privacy-upgrade-txt' of git://github.com/mudrd8mz/moodle 2018-05-10 17:53:05 +02:00
Andrew Nicols
51e53b9f40 MDL-61905 mod_workshop: Adjust privacy SQL queries
This change moves the content of WHERE to the JOIN, thus filtering the
results before they are returned. This reduces the number of joined rows
which gives a big performance benefit.
2018-05-10 13:03:11 +02:00
Eloy Lafuente (stronk7)
8e8ae80550 Merge branch 'MDL-62354-master-enfix' of git://github.com/mudrd8mz/moodle 2018-05-10 11:37:55 +02:00
David Mudrák
4f41ae2763 MDL-61949 privacy: Add mention of the new API in upgrade.txt files
The notice is explicitly repeated for activity modules because they
usually process user data heavily.
2018-05-10 11:35:12 +02:00
David Monllao
782b242ccb Merge branch 'MDL-61309-master' of git://github.com/andrewnicols/moodle 2018-05-10 08:46:32 +02:00
Andrew Nicols
f662082974 MDL-61309 mod_forum: Improve privacy query performance 2018-05-10 14:05:53 +08:00
Adam Olley
efc508c39c MDL-62210 mod_assign: limit file lookup to the target assign 2018-05-10 11:21:44 +08:00
Brendan Cox
1be5d6f4fe MDL-62210 mod_assign: improved validation in portfolio caller class 2018-05-10 11:21:44 +08:00
Eloy Lafuente (stronk7)
c3da16f13d Merge branch 'MDL-61309-master' of git://github.com/andrewnicols/moodle 2018-05-10 09:17:31 +08:00
Eloy Lafuente (stronk7)
9d56e7925b Merge branch 'MDL-61976_master-fix' of git://github.com/dmonllao/moodle 2018-05-10 09:17:30 +08:00
David Monllao
7140f67a98 MDL-61976 mod_wiki: Trim returned value to avoid EOF-related failures 2018-05-10 09:17:29 +08:00
Andrew Nicols
06ede94f07 Merge branch 'wip-MDL-62351-master' of git://github.com/marinaglancy/moodle 2018-05-10 09:17:28 +08:00
David Monllao
99a080f12a Merge branch 'MDL-62361' of git://github.com/stronk7/moodle 2018-05-10 09:17:25 +08:00
Zig Tan
0139b8828f MDL-62366 mod_assign: Followup fix for attemptnumber in exported JSON 2018-05-10 09:16:41 +08:00
David Monllao
6fe7510ae0 Merge branch 'wip-MDL-61976-master' of git://github.com/marinaglancy/moodle 2018-05-10 09:15:59 +08:00
David Monllao
8a4b725f6d MDL-61994 mod_glossary: Fixing wrong subsystem name 2018-05-10 09:15:59 +08:00
David Monllao
aea028ff29 Merge branch 'MDL-61994-master' of git://github.com/lameze/moodle 2018-05-10 09:15:58 +08:00
David Monllao
f60b216de0 Merge branch 'MDL-61309-master' of git://github.com/andrewnicols/moodle 2018-05-10 09:15:57 +08:00
Brendan Cox
d8609cb545 MDL-62232 mod_forum: Additional tests for portfolio file export 2018-05-10 09:15:57 +08:00
Adam Olley
5b89ff626d MDL-62232 mod_forum: Limit portfolio to files belonging to the post 2018-05-10 09:15:57 +08:00
Andrew Nicols
4191032993 Merge branch 'MDL-61905-master-privacyworkshop' of git://github.com/mudrd8mz/moodle 2018-05-10 09:15:56 +08:00
Andrew Nicols
db4754e98c MDL-61309 mod_forum: Remove unnecessary deletion check 2018-05-10 07:45:27 +08:00
Helen Foster
a5591614d5 MDL-62354 lang: Merge English strings from the en_fix language pack
Significant string changes:

* publishstate_help, core_notes - including GDPR guidance
* contactdataprotectionofficer_desc, tool_dataprivacy - removing mention
  of link on privacy policy page as it is not yet implemented
2018-05-09 22:39:21 +02:00
Marina Glancy
468c8d39c3 MDL-62351 privacy: check that subsystem/plugintype exist 2018-05-09 17:37:31 +08:00
Marina Glancy
7cc21cb7bd MDL-61976 mod_wiki: implement privacy API 2018-05-09 17:26:52 +08:00
David Mudrák
59a8a5c0b8 MDL-61905 workshop: Implement privacy API in grading evaluators
Standard workshop ships with only one evaluation method and that one
holds no personal data.
2018-05-09 10:01:50 +02:00
David Mudrák
4b8d462ee6 MDL-61905 workshop: Implement privacy API in assessment allocators
Assessment allocation methods normally do not store any personal data.
Their duty is to create assessment records that are then exported by the
workshop core itself.

Still, some allocators (such as the Manual allocation) can store certain
personal data such as user preferences.
2018-05-09 10:01:50 +02:00
David Mudrák
fe745a0a84 MDL-61905 workshop: Implement privacy API in grading strategies
On low level, standard grading strategies subplugins do not store
personal themselves.  They make use of the grades storage provided by
the workshop itself.  What they do contain though is the information
about how the assessment forms were defined. And they are also
responsible for correctly interpreting the values in the central grades
table.

Grading strategies fulfil the contract with the parent workshop module
by implementing the workshopform_provider interface. That gives them a
chance to export data about the assessment form to each of exported
assessment.
2018-05-09 10:01:50 +02:00
David Mudrák
84a57322c2 MDL-61905 workshop: Implement the privacy API in the workshop core
Workshop module stores personal data in its tables, via user
preference and via core_files and core_plagiarism subsystems.

When exporting the data, we export not only data created by users
themselves (such as their submissions and provided peer-assessments) but
also all relevant data that can (or must) be used to interpret created
content and evaluate the user's performance and skills.

On the other hand, when deleting data at user's request, we delete only
those data that do not affect other users' performance evaluation. The
reasoning is that one's right for privacy does not overweight someone
else's right for fair assessment. For that reason, we can't fully delete
whole provided peer-assessments, for example. Because they are used in
cross-comparison and grading evaluation of all other peers who assessed
the same submission. So instead, we replace provided texts but still
keep the original record.

Workshop defines the interface for its grading strategy subplugins to
allow them attach personal data under their control to the exported
structures.
2018-05-09 10:01:50 +02:00
Andrew Nicols
3e95e09b67 MDL-61309 mod_forum: Implement privacy deletion 2018-05-09 14:04:13 +08:00
Andrew Nicols
caef6489ae MDL-61309 mod_forum: Implement the Privacy API 2018-05-09 14:04:12 +08:00