606 Commits

Author SHA1 Message Date
Damyon Wiese
eafab79941 MDL-47503 Grades: Display the notice about upgraded grades on all grade report pages.
Moved this to the print_grade_page_head function and added an access check so it only
displays for teachers.
2014-10-20 16:15:51 +08:00
Damyon Wiese
47d6e6a7d3 MDL-47503 Grades: Completely remove aggregationsubcats
This setting is not compatible with combinations of aggregation methods
and the ways in which it does and does not work are not documented. It
was voted to remove it completely by the gradebook workshop, so I have
completely removed it and added a warning for all affected courses + restored
backups.
2014-10-20 12:03:18 +08:00
Dan Poltawski
d65eefdbf1 Merge branch 'MDL-18229-master' of git://github.com/zbdd/moodle 2014-10-16 13:44:48 +01:00
John Okely
3087835ae3 MDL-47243 core_grades: Add behat tests for outcomes in Natural 2014-10-15 14:33:31 +08:00
Frederic Massart
09171b955e MDL-38732 gradereport_grader: Handle simultaneous graders 2014-10-14 13:52:42 +08:00
Damyon Wiese
57fac09a40 MDL-18229 Grades: singleview report mega cleanup.
Fix all the things, including:
* Fix $PAGE->url
* Fix coding style.
* Add event for reportviewed
* Removed broken callback  gradereport_singleview_profilereport
* Removed vertical-align-middle
* Changed prefixes in css
* phpcs fixes
* moodlecheck fixes including phpdocs
* Move classes to use autoloading
* Remove all smelly code tricks like func_get_args, scandir etc (lots).
2014-10-14 10:26:46 +08:00
Zachary Durber
5f3decb5cb MDL-18229 gradebook: Additional fixes.
Random foo left in options. (test code)
Allowed editing link for Course total.
Fixes based on Apu's review.
2014-10-14 10:26:46 +08:00
Aparup Banerjee
0a55da571a MDL-18229 gradereport: updated index.php test to calculate navigation based on new class name 'gradereport_selectable_items' 2014-10-14 10:26:46 +08:00
Zachary Durber
92c61fee64 MDL-18229 gradebook: Links to Single view via icons on Grade Report. 2014-10-14 10:26:45 +08:00
Andrew Nicols
72ece42858 MDL-46658 gradereport_grader: Remove max-width for RTL
For some reason, Safari behaves incorrectly when dealing with RTL content
where the table has a max-width of 100%.

This issue is a part of the MDL-25544 Epic.
2014-10-10 12:24:03 +08:00
Andrew Nicols
1bd4817ada MDL-46658 gradereport_grader: Fix minor RTL style issues
This issue is a part of the MDL-25544 Epic.
2014-10-10 11:20:44 +08:00
Andrew Nicols
b55d37f08b MDL-46658 gradereport_grader: Style the ajax editing error
This issue is a part of the MDL-25544 Epic.
2014-10-10 10:29:16 +08:00
Andrew Nicols
1e646afd3c MDL-47353 gradereport_grader: Only respect fixed headers
Even if the navbar is in a static header, it should only be respected if it
is fixed still.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-10 09:02:57 +08:00
Dan Poltawski
66689366a0 Merge branch 'wip-MDL-47543-master' of git://github.com/marinaglancy/moodle
Conflicts:
	theme/bootstrapbase/less/moodle/grade.less
	theme/bootstrapbase/style/moodle.css
2014-10-08 15:49:58 +01:00
Dan Poltawski
e462093201 Merge branch 'MDL-46658-master' of git://github.com/andrewnicols/moodle
Conflicts:
	theme/bootstrapbase/less/moodle/grade.less
	theme/bootstrapbase/style/moodle.css
2014-10-08 10:26:13 +01:00
Marina Glancy
eb84b77923 MDL-47543 core_grades: improve navigation menu in grade administration 2014-10-08 15:03:36 +08:00
Mark Nelson
c09e6fa3e3 MDL-40697 core_grades: removed existing user_graded event triggers 2014-10-07 19:04:10 -07:00
Damyon Wiese
a9937aec06 MDL-47062 Grades: Add an upgrade step to warn about changes in upgrade.
Puts a notice on the grader report about the change in aggregation method
from "Sum of grades" to "Natural".

Part of: MDL-46576
2014-10-03 17:06:41 +08:00
Dave Cooper
3d8ef7c65d MDL-47353 gradereport_grader: Fix header offset logic for floating headers
This is necessary for themes with non-fixed navbars to work with the
grader report, otherwise headers will be hidden.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:46:02 +08:00
Andrew Nicols
6821f7310c MDL-46658 gradereport_grader: Make page CSS more specific 2014-10-03 15:44:41 +08:00
Andrew Nicols
325e81d309 MDL-47124 gradereport_grader: Update row/column sizes when showing/hiding quickedit fields
This makes use of Global YUI events to trigger the resized event handler.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:39 +08:00
Zachary Durber
eede44b54e MDL-46936 gradereport_grader: Restore AJAX editing to gradereport
Removed id argument from AJAX code, no longer supplied.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:31 +08:00
Andrew Nicols
33bc816e89 MDL-47028 gradereport_grader: Add floating headers for other cells.
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:28 +08:00
Frederic Massart
457a113e5e MDL-47063 gradereport_grader: Styles applied for overridden grades 2014-10-03 15:44:24 +08:00
Frederic Massart
78ec0bb3af MDL-47026 gradereport_grader: Removing the tooltips
They are not serving the same purpose as the one they had before,
and they were overlapping with the content of the cell. Positioning
them somewhere else made them more confusing than helpful.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:23 +08:00
Frederic Massart
43998ad11c MDL-47025 gradereport_grader: Removing highlight feature
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:17 +08:00
Andrew Nicols
bc782f1f4c MDL-47053 gradereport_grader: Add a floating Footer Title cell
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:13 +08:00
Frederic Massart
8a9335075e MDL-47027 gradereport_grader: Removed floating save changes button
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:07 +08:00
Frederic Massart
d688ee6d33 MDL-47027 gradereport_grader: Styling when editing is turned on
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:04 +08:00
Frederic Massart
b0cade1103 MDL-46988 gradereport_grader: Fix styling issues for RTL
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:04 +08:00
Frederic Massart
62e11d37c2 MDL-46950 gradereport_grader: Prettier styling for base and clean
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:04 +08:00
Frederic Massart
31819e8961 MDL-46950 gradereport_grader: Consolidate styling of the elements
The grader table has been made entirely standalone from core or
theme styling. The floating divs have to share the exact same
rules, and so it was a lot easier and more maintainable to just
style them both using the same selectors, entirely ignoring the
table default styles.

And because the selectors are unique for both the floating elements
and the table cells, a themer can easily re-use them to style both,
without having to dig around to find all the selectors to overwrite.

Working on this highlighted some issues with the positioning. Those
have been fixed within the same patch. And even though it is still
not 100% correct on IE, the result is pretty decent.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:44:01 +08:00
Frederic Massart
7dc48b4629 MDL-46962 gradereport_grader: Correct positioning when using RTL languages
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:49 +08:00
Frederic Massart
10ce95aae3 MDL-46951 gradereport_grader: Giving some love to IE
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:46 +08:00
Frederic Massart
1da29869aa MDL-46951 gradereport_grader: Handling of user cells when resizing
For some reason, the max-width/min-width/width of the table cell containing
the name of the users did not work, leading to very large columns but a very
narrow floating one. Handling the size of those columsn upon resize was
also necessary after with this fix.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:42 +08:00
Frederic Massart
b6ad809581 MDL-46951 gradereport_grader: Disable floating behaviour when table is empty
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:37 +08:00
Frederic Massart
f79776cb7f MDL-46951 gradereport_grader: Compatibility with base themes
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:32 +08:00
Frederic Massart
569c77e623 MDL-46951 gradereport_grader: Removing broken spinner logic
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:28 +08:00
Andrew Nicols
8c037a917b MDL-46663 gradereport_grader: Remove fixed column support
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:19 +08:00
Andrew Nicols
99b119c166 MDL-46663 gradereport_grader: Remove old scrollview code
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:18 +08:00
Andrew Nicols
feb0014b84 MDL-46731 gradereport_grader: Move tooltips to YUI module
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:16 +08:00
Andrew Nicols
d3eec1584a MDL-46774 gradereport_grader: Move row/column highlight code to YUI module
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:43:05 +08:00
Andrew Nicols
6ad1af094e MDL-47046 gradereport_grader: Update JS to meet coding style guidelines
This also moves the code into a set of separate files to allow for
additional components of the report to be migrated to the same YUI module,
adjusts some UI components, improves JS performance, and adds appropriate
documentation.

This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:42:03 +08:00
Alfonso Roman
2c4a3f7525 MDL-47045 gradereport_grader: Improve Grader report user interface
This issue is a part of the MDL-46658 Task.
This issue is a part of the MDL-25544 Epic.
2014-10-03 15:12:36 +08:00
Marina Glancy
165cdabacb MDL-47146 core_grades: fix class names (contd)
Part of: MDL-46576
2014-10-03 13:55:25 +08:00
Damyon Wiese
5a59aeb14e MDL-47078 Grades: Allow users to have different max grades due to exclusions etc.
This is about making this work with natural weightings.

Part of: MDL-46576
2014-10-03 13:53:01 +08:00
Andrew Davis
0e99979638 MDL-20250 core_grade: added some settings to disable or hide gradebook functionality 2014-09-26 10:19:00 +08:00
Frederic Massart
981c2ee51c MDL-46812 gradereport_grader: Hide vertical scrollbar of scroller 2014-08-27 10:40:56 +08:00
Eloy Lafuente (stronk7)
f438b03fdc Merge branch 'wip-MDL-46874-master' of git://github.com/marinaglancy/moodle 2014-08-25 22:10:09 +02:00
Mary Evans
8c97393ce5 MDL-46812 grade/report/grader: Need to tie up loose ends in Gradebook after MDL-43824
Squashed commit of the following:

commit 5881cccc95c135e1440ce0c5441a84b462941758
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date:   Thu Aug 21 02:15:05 2014 +0100

    MDL-46812 grade/report/grader: Reset previous commit for left scroller.

commit 5abeb60470f02ab4c79c27b2a6f6187e75891e0b
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date:   Thu Aug 21 01:29:41 2014 +0100

    MDL-46812 grade/report/grader: Added jsenabled css body class to rtl style.

commit a95d23d8b753a590d980e5427e8c74ba597c2b91
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date:   Thu Aug 21 00:59:06 2014 +0100

    MDL-46812 theme_base; Removed more redundent CSS.

commit 3fb326e5b39738343e0b7c0d9c8da17adf5a09bb
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date:   Wed Aug 20 13:24:59 2014 +0100

    MDL-46812 theme_base: Removed redundent grade/report/grader CSS in style/grade.css

commit c602e7e277f9ce1fed6d0eccf72c547432e130b6
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date:   Thu Aug 14 12:50:14 2014 +0100

    MDL-46812 grade/report/grader: Need to tie up loose ends in Gradebook after MDL-43824

        1. fixed gradebook layout when JS is disabled
        2. added height and background color to scroller when JS is enabled
        3. removed redundent top margin in user-grades table
2014-08-21 11:13:56 +01:00