109012 Commits

Author SHA1 Message Date
Tim Hunt
f6e7eb2ebd MDL-79747 quiz stats: task should run as admin the right way
The correct way to get an ad-hoc task to run as the main admin account
is to leave userid as null.

Setting it causes fatal errors if the main admin account is set to
auth: nologin.
2023-10-17 16:43:48 +01:00
Ilya Tregubov
d188d58ce9
weekly release 4.1.6+ 2023-10-13 13:39:33 +08:00
Huong Nguyen
0257e1696f
Merge branch 'MDL-79638-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-10-12 11:08:05 +07:00
Ilya Tregubov
891b6f796c
Merge branch 'MDL-79160-401' of https://github.com/danghieu1407/moodle into MOODLE_401_STABLE 2023-10-12 09:44:23 +08:00
Ilya Tregubov
9fbdf21341
Merge branch 'MDL-79422-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-10-12 09:10:23 +08:00
Jun Pataleta
7e39cee0f6
Merge branch 'MDL-79633-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-10-11 13:41:36 +08:00
Huong Nguyen
82488f901d
Merge branch 'MDL-78103-401' of https://github.com/HuongNV13/moodle into MOODLE_401_STABLE 2023-10-11 11:26:02 +07:00
chen levy
7744cf2f28 MDL-78103 theme: Fixed dropdown menu size by the content 2023-10-11 11:15:44 +07:00
Andrew Nicols
e7263580b9
MDL-79638 phpunit: Add unit test for increment resets 2023-10-11 00:10:33 +08:00
Andrew Nicols
a74443a342
MDL-79638 phpunit: Adjust version checks for mysql/mariadb hack
This hack was introduced to work around a bug in MySQL 5.6.14 and
MariaDB at the time.

https://bugs.mysql.com/bug.php?id=69882

It was addressed a few months later in 5.6.16, and 5.7.4.
MariaDB merged version 5.6.16 of MySQL's InnoDB engine in MariaDB
10.0.11 and got the patch from there.

Moodle has required MySQL 5.7, and MariaDB 10.2.29 since Moodle 3.11 and
it is therefore safe to remove these hacks for these versions.
2023-10-11 00:02:12 +08:00
Sara Arjona
7ff2d18b93
Merge branch 'MDL-79623-MOODLE_401_STABLE' of https://github.com/PhMemmel/moodle into MOODLE_401_STABLE 2023-10-10 16:19:30 +02:00
Sara Arjona
66ff0a871f
Merge branch 'MDL-77816-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-10-10 09:21:39 +02:00
Ilya Tregubov
11fe89c08e
Merge branch 'MDL-79501-MOODLE_401_STABLE' of https://github.com/geichelberger/moodle into MOODLE_401_STABLE 2023-10-10 15:07:24 +08:00
Ilya Tregubov
76bd425474
Merge branch 'MDL-79279_401' of https://github.com/timhunt/moodle into MOODLE_401_STABLE 2023-10-10 11:24:47 +08:00
Ilya Tregubov
aeeaea6840
Merge branch 'MDL-71414-401' of https://github.com/laurentdavid/moodle into MOODLE_401_STABLE 2023-10-10 10:19:44 +08:00
Paul Holden
5c30074d99
MDL-79633 mod_data: correct timemodified tag replacement attribute. 2023-10-09 19:41:12 +01:00
Laurent David
8e53ef0162 MDL-71414 mod_h5pactivity: Add a new "None" message
* In matching types of questions, sometimes the user does not answer all
questions. We now display "None" in the result report. The answer can
be either correct or incorrect.
* Fix "unknown" answer constant name.
2023-10-09 11:45:11 +02:00
Laurent David
2a2d3c85bb MDL-71414 mod_h5pactivity: Fix issue with drop down report
* Drag and Drop report were missing answers when target could be dropped on multiple
drop zones.
2023-10-09 11:45:10 +02:00
Philipp Memmel
805577664b MDL-79623 tool_componentlibrary: Fix correct modal content attribute 2023-10-09 09:14:48 +00:00
Jun Pataleta
b0a7bc3f42
Moodle release 4.1.6 v4.1.6 2023-10-07 11:30:22 +08:00
Sara Arjona
fcd50e4722
weekly release 4.1.5+ 2023-10-06 14:02:25 +02:00
danghieu1407
cf9373c4dd MDL-79160 Question: Answer field overflows parent width with large size 2023-10-05 11:06:21 +07:00
Paul Holden
52ada82da2
MDL-77816 mod_bigbluebuttonbn: feedback when validating completion. 2023-10-04 21:07:31 +01:00
Yannick Schillinger
fca2456e1f
MDL-77816 mod_bigbluebuttonbn: Fix completionValidate argument format 2023-10-04 20:27:34 +01:00
Paul Holden
70a83735f3
MDL-79310 enrol: restrict searched users to those user can view. 2023-10-04 14:31:31 +08:00
Paul Holden
a067663a63
MDL-79310 forumreport_summary: report only on users who can be viewed. 2023-10-04 14:31:31 +08:00
Paul Holden
a55e18fb81
MDL-79310 mod_forum: ensure only visible users can be exported. 2023-10-04 14:31:30 +08:00
Sara Arjona
bd18e026bb
Merge branch 'MDL-69119-M401_angle_bracket_character_in_answers_not_escaped_in_moodle_xml_export_of_multiple_choice_calculated_questions' of https://github.com/ziegenberg/moodle into MOODLE_401_STABLE 2023-10-04 07:51:42 +02:00
Huong Nguyen
c15cb5586c
Merge branch 'MDL-79539-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-10-04 10:56:09 +07:00
Mikel Martín
fce36ecf4f MDL-79509 mod_wiki: Improve comment editing 2023-10-04 02:10:16 +02:00
Paul Holden
8f8c4e3153 MDL-72249 message: stricter cleaning of processor type parameter. 2023-10-04 02:10:16 +02:00
Paul Holden
369c5407ab MDL-79426 gradeimport_csv: safely preview CSV content during import. 2023-10-04 02:10:16 +02:00
Paul Holden
04db4a3e54 MDL-79455 tool_uploadcourse: clean course data fields individually. 2023-10-04 02:10:16 +02:00
Paul Holden
23466dd6d1 MDL-79455 tool_uploadcourse: safe preview of uploaded course data. 2023-10-04 02:10:16 +02:00
Paul Holden
74b62601d0 MDL-79409 mod_imscp: appropriate unserialization of package structure. 2023-10-04 02:10:16 +02:00
Paul Holden
f428d58df6 MDL-79408 mod_lesson: safer unserializing/comparison of properties. 2023-10-04 02:10:16 +02:00
David Woloszyn
6f2fa6011e MDL-77846 core: Make endpoint revision number checks stricter
In some places we prevented cache poisoning, in others we did not. We
also did not place any restriction on the minimum value for a revision.

This change introduces a new set of functions for configonly endpoints
which validates the revision numbers passed in. If the revision is
either too old, or too new, it is rejected and the file content is not
cached. The content is still served, but caching headers are not sent,
and any local storage caching is prevented.

The current time is used as the maximum version, with 60 seconds added
to allow for any clock skew between cluster nodes. Previously some
locations used one hour, but there should never be such a large clock
skew on a correctly configured system.

Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
2023-10-04 02:10:16 +02:00
Huong Nguyen
e2452a4b3c MDL-66730 core_course: Improve permission check for category moving
Co-authored-by: Erica Bithell <egb10@cam.ac.uk>
2023-10-04 02:10:16 +02:00
Laurent David
fc26693229 MDL-77795 mod_bigbluebuttonbn: Change meetingID on duplicate
* We need to set a different meetingID when duplicating or importing a
BigBlueButtonBN activity to prevent unwanted sharing of recordings between
meetings.
2023-10-04 02:10:16 +02:00
Paul Holden
1eda3a392b MDL-78820 h5p: use fullname of current user as the xAPI actor name. 2023-10-04 02:10:16 +02:00
meirzamoodle
c3c18bbb20 MDL-78969 oauth2: remove auto-login after successful confirmation
With the new flow, users can go to the login page from the confirmed page,
and if the user successfully logs in, the user will be directed to the confirmed page.
To avoid that, the confirmed page can only be seen by users who are not logged in.
2023-10-04 02:10:16 +02:00
Paul Holden
c25092b232 MDL-78971 quiz_grading: escape user identity fields on display. 2023-10-04 02:10:16 +02:00
Jun Pataleta
a7bdd7a007
weekly release 4.1.5+ 2023-10-04 07:49:17 +08:00
Jun Pataleta
99f4f6894f
Merge branch 'install_401_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_401_STABLE 2023-10-04 07:49:15 +08:00
Tim Hunt
848fd484d5 MDL-79279 qformat_xml: multianswer import should support idnumber
Fix suggested by Georg Maißer.
2023-10-03 20:43:15 +01:00
Daniel Ziegenberg
0839431f16
MDL-69119 qformat_xml: fix mc calculated export
The Moodle XML export of multiple choice calculated questions was
missing proper escaping of answers. Also the indentation of the
generated xml was off.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
2023-10-03 12:23:20 +02:00
Jun Pataleta
cf98238fdf
Merge branch 'MDL-79557-401' of https://github.com/jleyva/moodle into MOODLE_401_STABLE 2023-10-03 12:18:00 +08:00
Jake Dallimore
925c36fb1d
Merge branch 'MDL-79056-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-10-03 12:03:58 +08:00
Andrew Nicols
d78dda7754
MDL-78580 mod_quiz: Do not concatenate lang strings 2023-10-03 12:03:55 +08:00
Andrew Nicols
2f6519d2de
Merge branch 'MDL-78580_401_STABLE' of https://github.com/marxjohnson/moodle into MOODLE_401_STABLE 2023-10-03 11:23:54 +08:00