mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-22 16:40:07 +01:00
Code Issues Projects Releases Wiki Activity
107,325 Commits 36 Branches 527 Tags
Commit Graph

107325 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jun Pataleta
fa51e1a149 Merge branch 'MDL-76362-401-extra' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-01-24 10:38:49 +08:00
Eloy Lafuente (stronk7)
36b4f13e9b MDL-76362 workshop: check for empty (null included) feedbackreviewer 
As far as feedbackreviewer can be null, we cannot, since PHP 8.1
apply any string operation (trim, strlen...) on it, hence, checking
before applying.
 2023-01-23 09:19:32 +08:00
Eloy Lafuente (stronk7)
03bc275093 MDL-76362 enrol_lti: Prevent calling to DataConnector with null keys 
While it could have been fixed in DataConnector (3rd part lib), better
prevent in our code to call to it with null keys.

Covered by unit tests.
 2023-01-23 09:17:48 +08:00
Eloy Lafuente (stronk7)
e6dfa9ff3c MDL-76362 output: Preserve original behaviour for PHP 8.1 
Whenever the page_requirements_manager::js_fix_url()
is called with null url, it must throw an exception and emit 0 warnings.

It's covered by an explicit test:

test_js_fix_url_coding_exception with data set "Provide a null argument"
 2023-01-23 09:17:48 +08:00
Andrew Nicols
8f4bd4ce11 MDL-76362 core: Coding style fixes 2023-01-23 09:16:08 +08:00
Andrew Nicols
77a0a535b3 MDL-76362 core_privacy: Shortcircuit URL rewriting on empty content 2023-01-23 09:16:08 +08:00
Andrew Nicols
a4ea607c24 MDL-76362 core: Short circuit s() on empty values 2023-01-23 09:16:08 +08:00
Andrew Nicols
dbfb5eaa45 MDL-76362 core: Short-circuit strip_querystring on empty values 2023-01-23 09:16:08 +08:00
Andrew Nicols
788d86d7a3 MDL-76362 core_file: Check prefix exists before checking length 2023-01-23 09:16:07 +08:00
Andrew Nicols
a1f4f7bac5 MDL-76362 core: plugin names must be strings to be valid 2023-01-23 09:16:07 +08:00
Andrew Nicols
d08319ddf7 MDL-76362 core: Update core_component plugin name tests 2023-01-23 09:16:07 +08:00
Andrew Nicols
de4de9cec5 MDL-76362 core: Test coursealias before using 2023-01-23 09:16:07 +08:00
Andrew Nicols
ddf0f08cc9 MDL-76362 h5p: Use string as default lang param 2023-01-23 09:16:07 +08:00
Andrew Nicols
2250ab07e6 MDL-76362 qtype_numerical: Fix bug in phpdoc 2023-01-23 09:16:07 +08:00
Andrew Nicols
71c1fa0d8e MDL-76362 qtype_calculated*: Address issues with null strings 2023-01-23 09:16:07 +08:00
Andrew Nicols
5fbd2eac32 MDL-76362 qtype: Update formatting of qtype_calculated* upgradelib 2023-01-23 09:16:07 +08:00
Andrew Nicols
12b36d2a32 MDL-76362 qtype_numerical: Support empty units for apply_units 2023-01-23 09:16:07 +08:00
Andrew Nicols
5f412b3301 MDL-76362 qtype_numeric: Refactor answer tests 2023-01-23 09:16:07 +08:00
Andrew Nicols
4ff3447c8c MDL-76362 question: Add test for number(null) 2023-01-23 09:16:07 +08:00
Andrew Nicols
745080671b MDL-76362 question: Refactor question number unit tests 2023-01-23 09:16:07 +08:00
Andrew Nicols
5fbbb51882 MDL-76362 core: Use empty default string when getting prefs 
The json_decode function does not accept a null, which is the
traditional default for get_user_preferences. By passing a default of
am empty string we avoid issues in PHP 8.1.
 2023-01-23 09:16:06 +08:00
Marina Glancy
2dd7290ccb MDL-76362 various: Avoid passing nulls to functions that don't allow nulls 
PHP 8.1 is more strict on the parameter type. Functions such as trim(), strlen(), str_replace(), etc
show notice when null is passed as an argument
 2023-01-23 09:16:06 +08:00
Marina Glancy
d83368a475 MDL-76362 mustache: Override parent method to avoid PHP notices 
Parent method checks baseDir that is null in this case. This shows notices under PHP 8.1
 2023-01-23 09:16:06 +08:00
Ilya Tregubov
8de12b7997 weekly release 4.1.1+ 2023-01-20 09:41:41 +08:00
Jun Pataleta
0f28e2b02c Merge branch 'MDL-76725-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-19 12:05:06 +08:00
Jun Pataleta
396fff3d0b Merge branch 'MDL-76537_401' of https://github.com/stronk7/moodle into MOODLE_401_STABLE 2023-01-19 11:23:51 +08:00
Ilya Tregubov
e98b3fe183 Merge branch 'MDL-76870-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-01-19 11:15:14 +08:00
Ilya Tregubov
69fbf97923 Merge branch 'MDL-76766-401' of https://github.com/aanabit/moodle into MOODLE_401_STABLE 2023-01-19 11:04:23 +08:00
Ilya Tregubov
c4df4906bc Merge branch 'MDL-74756-MOODLE_401_STABLE' of https://github.com/sh-csg/moodle into MOODLE_401_STABLE 2023-01-19 10:30:32 +08:00
Andrew Nicols
dd1efc4312 Merge branch 'MDL-76841-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-19 08:55:09 +08:00
Andrew Nicols
3309157233 Merge branch 'MDL-70070-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-19 08:50:37 +08:00
Jun Pataleta
abd969cb50 Merge branch 'MDL-76525-MOODLE_401_STABLE' of https://github.com/PhMemmel/moodle into MOODLE_401_STABLE 2023-01-18 22:55:51 +08:00
Philipp Memmel
888ed072c0 MDL-76525 mod_data: Add param validation for data fields 2023-01-18 12:10:45 +01:00
Jake Dallimore
17659466cc Merge branch 'MDL-66221-401' of https://github.com/raortegar/moodle into MOODLE_401_STABLE 2023-01-17 11:28:53 +08:00
Stefan Hanauska
61b77b3bb6 MDL-74756 availability_completion: Prev activity (completion n/enabled) 2023-01-16 22:20:45 +01:00
Paul Holden
a74c5f0073 MDL-76841 tool_mobile: improve potential config issues test. 
Avoid certificate checking of the default test site (`example.com`),
and update the assertion so we get clearer failures in the future.
 2023-01-16 08:30:43 +00:00
Paul Holden
70a5e38b2c MDL-70070 phpunit: correct data provider method names. 
They should not be prefixed `test_` because that's how actual
test methods containing assertions are identified by PHPUnit.
 2023-01-16 08:28:31 +00:00
Eloy Lafuente (stronk7)
2c7773b365 MDL-76537 behat: Month and day names are lang-dependent correct utf-8 
Just verify that calendars are always displayed with correct UTF-8
and in the language the user is currently using.
 2023-01-14 12:16:48 +01:00
Eloy Lafuente (stronk7)
7c66344323 MDL-76537 core: Fix date_format_string() to work with php-intl 
With Moodle 4.1 and up, we have stopped to work with strftime(),
because it's deprecated for PHP 8.1 and up and, instead we are
using core_date::strftime() that performs the conversions using
the php-intl extension.

The original strftime() had a lot of OS-specific dependencies,
both about locale names and charsets used to provide the information.

Instead, the php-intl gets rid of all those OS-specific nightmares
and only uses ICU/Unicode locales and UTF-8.

Because of that, the old utf-8 => windows charset => utf-8
conversions aren't needed anymore. Hence, removing them.
 2023-01-14 12:16:48 +01:00
Jun Pataleta
4b69c11978 Moodle release 4.1.1 v4.1.1 2023-01-14 14:17:03 +08:00
raortegar
c812f450bb MDL-66221 tool_recyclebin: Fix recycle bin with activity settings 
If backup_auto_activities setting from Automated backup is disabled
the activities will not be stored for the recycle bin
 2023-01-13 11:31:33 +01:00
Simey Lameze
4b2834439e MDL-76870 question: change assertion to assertEqualsCanonicalizing 
By using that assertion the arrays will be sorted before comparison
preventing any Oracle sorting related failures.

Credits for the solution go to Tim Hunt!
 2023-01-13 18:13:12 +08:00
Jun Pataleta
2d628ba8d6 weekly release 4.1+ 2023-01-13 10:52:14 +08:00
Andrew Nicols
3528887bb6 Merge branch 'MDL-76820-401' of https://github.com/cameron1729/moodle into MOODLE_401_STABLE 2023-01-12 12:09:35 +08:00
Jun Pataleta
217a32f033 Merge branch 'MDL-76649_401' of https://github.com/timhunt/moodle into MOODLE_401_STABLE 2023-01-12 12:06:45 +08:00
Jun Pataleta
d24c201b6d Merge branch 'MDL-76474-401-2' of https://github.com/HuongNV13/moodle into MOODLE_401_STABLE 2023-01-12 11:55:41 +08:00
Huong Nguyen
4d9960ace2 MDL-76474 tiny_h5p: Prevent H5P Formatter placeholder to be assessed 2023-01-12 10:53:06 +07:00
Huong Nguyen
4e1c4f4483 MDL-76474 tiny_accessibilitychecker: Prevent placeholders to be assessed 2023-01-12 10:53:04 +07:00
Huong Nguyen
b4e7d5300a MDL-76474 editor_tiny: Implement placeholder selector list 
We created a list of placeholder selectors in placeholderSelectors option.
The purpose of this list is to indicate the contents that are only shown
in the editor and not to the users, by that way, we can decide to apply or
not to apply rules, styles, etc... to these contents
 2023-01-12 10:52:39 +07:00
Michael Hawkins
313d44f83a MDL-76861 blog: Ensure correct escaping applied to search string 2023-01-12 11:43:11 +08:00