mirror of
https://github.com/moodle/moodle.git
synced 2025-01-18 05:58:34 +01:00
Jake Dallimore
c96c9601af
MDL-62947 mod_feedback: fix feedback so it correctly uses forms API
Feedback code was doing the following, which is incompatible with the sec-patched quickforms lib: - appending '[0]' to non-group element names, meaning type checks in getCleanType() were falling back to PARAM_RAW instead of PARAM_INT, and meaning _findValue() was comparing elements it thought to be arrays with scalar submit values (worked with eval() implementation as the 0th element of a string was the character, but not working when patched). - external unit tests incorrectly testing multichoice questions in the process_page tests - patched lib highlighted failures. It was also doing the following: - actively setting null as default element values instead of 0 for radio buttons and dropdowns (for 'not selected'). This is incompatible with more recent quickforms lib (see MDL-63070). - creating groups using addElement instead of addGroup - not recommended This patch addresses the above.
.-..-. _____ | || | /____/-.---_ .---. .---. .-.| || | .---. | | _ _ |/ _ \/ _ \/ _ || |/ __ \ * | | | | | || |_| || |_| || |_| || || |___/ |_| |_| |_|\_____/\_____/\_____||_|\_____) Moodle - the world's open source learning platform Moodle <https://moodle.org> is a learning platform designed to provide educators, administrators and learners with a single robust, secure and integrated system to create personalised learning environments. You can download Moodle <https://download.moodle.org> and run it on your own web server, ask one of our Moodle Partners <https://moodle.com/partners/> to assist you, or have a MoodleCloud site <https://moodle.com/cloud/> set up for you. Moodle is widely used around the world by universities, schools, companies and all manner of organisations and individuals. Moodle is provided freely as open source software, under the GNU General Public License <https://docs.moodle.org/dev/License>. Moodle is written in PHP and JavaScript and uses an SQL database for storing the data. See <https://docs.moodle.org> for details of Moodle's many features.
Description
Languages
PHP
78.1%
JavaScript
14.6%
Gherkin
3.5%
CSS
1.7%
Mustache
1.6%
Other
0.4%