mirror_php/php-debugbar
1
0
Fork 0
mirror of https://github.com/maximebf/php-debugbar.git synced 2025-07-25 02:31:25 +02:00
Code Issues Releases Wiki Activity

Add initial values to traceable PDO array_reduce() (#523)

Browse Source 
If the PDOTraceableDataCollector is enabled and no database calls
happen to be made in a request, PHP 8.1 emits a fatal error, e.g.,

```
<b>Fatal error</b>: Uncaught TypeError:
DebugBar\DataCollector\PDO\TraceablePDO::getAccumulatedStatementsDuration():
Return value must be of type float, null returned in
vendor/maximebf/debugbar/src/DebugBar/DataCollector/PDO/TraceablePDO.php:251
```

The same error occurs in getMemoryUsage() and getPeakMemoryUsage().

Adding an initial value of 0 to `array_reduce()` corrects the problem.

Corrects bug #522.
This commit is contained in:
kstephensop
2023-02-06 17:35:37 +02:00
committed by GitHub
parent 17dcf3f6ed
commit ea5bfc41e5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/DebugBar/DataCollector/PDO/TraceablePDO.php
View File

@@ -248,7 +248,7 @@ class TraceablePDO extends PDO
*/
public function getAccumulatedStatementsDuration() : float
{
return array_reduce($this->executedStatements, function ($v, $s) { return $v + $s->getDuration(); });
return array_reduce($this->executedStatements, function ($v, $s) { return $v + $s->getDuration(); }, 0.0);
}
/**
@@ -258,7 +258,7 @@ class TraceablePDO extends PDO
*/
public function getMemoryUsage() : int
{
return array_reduce($this->executedStatements, function ($v, $s) { return $v + $s->getMemoryUsage(); });
return array_reduce($this->executedStatements, function ($v, $s) { return $v + $s->getMemoryUsage(); }, 0);
}
/**
@@ -268,7 +268,7 @@ class TraceablePDO extends PDO
*/
public function getPeakMemoryUsage() : int
{
return array_reduce($this->executedStatements, function ($v, $s) { $m = $s->getEndMemory(); return $m > $v ? $m : $v; });
return array_reduce($this->executedStatements, function ($v, $s) { $m = $s->getEndMemory(); return $m > $v ? $m : $v; }, 0);
}
/**