mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-23 03:02:33 +01:00
Code Issues Projects Releases Wiki Activity

Fix not provided --output-file argument translated into string instead of null (#4480)

Browse Source 
* Fix not provided --output-file argument translated into string instead of null
Fixes #4456

* [rector] Fix not provided --output-file argument translated into string instead of null Fixes #4456

* [cs] Fix not provided --output-file argument translated into string instead of null Fixes #4456

Co-authored-by: rector-bot <tomas@getrector.org>
This commit is contained in:
Jan Mikeš 2020-10-25 15:26:01 +01:00 committed by GitHub
parent bdf9464d25
commit d864005904
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Configuration/Configuration.php
View File

@ -125,9 +125,9 @@ final class Configuration
$this->showProgressBar = $this->canShowProgressBar($input);
$this->isCacheDebug = (bool) $input->getOption(Option::CACHE_DEBUG);
/** @var string $outputFileOption */
/** @var string|null $outputFileOption */
$outputFileOption = $input->getOption(Option::OPTION_OUTPUT_FILE);
$this->outputFile = $outputFileOption !== '' ? (string) $outputFileOption : null;
$this->outputFile = $this->sanitizeOutputFileValue($outputFileOption);
$this->outputFormat = (string) $input->getOption(Option::OPTION_OUTPUT_FORMAT);
@ -308,6 +308,15 @@ final class Configuration
return $input->getOption(Option::OPTION_OUTPUT_FORMAT) !== CheckstyleOutputFormatter::NAME;
}
private function sanitizeOutputFileValue(?string $outputFileOption): ?string
{
if ($outputFileOption === '') {
return null;
}
return $outputFileOption;
}
private function setOnlyRector(string $rector): void
{
$this->onlyRector = $this->onlyRuleResolver->resolve($rector);