10350 Commits

Author SHA1 Message Date
Abdul Malik Ikhsan
3d2c7c30bd
[CodingStyle] Failing test case for cannot change this to self (#4590)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-12 21:50:36 +01:00
Tomas Votruba
7e3f8bdafc
[Laravel] Add AddMockConsoleOutputFalseToConsoleTestsRector (#4589)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-12 21:47:25 +01:00
Abdul Malik Ikhsan
657a21ba54
[Doctrine] Fixes #4566 Rename ServiceEntityRepositoryConstructorToDependencyInjectionWithRepositoryPropertyRector to ServiceEntityRepositoryParentCallToDIRector (#4587) 2020-11-12 16:53:11 +01:00
Tomas Votruba
aa91f11a3f
[Laravel 5.7] Add ChangeQueryWhereDateValueWithCarbonRector (#4586)
* [Laravel] Add ChangeQueryWhereDateValueWithCarbonRector

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-12 15:28:50 +00:00
Abdul Malik Ikhsan
c88811f816
[BetterStandardPrinter] Fixes #4476 @ORM Constraint should not be changed (#4585) 2020-11-12 15:47:24 +01:00
Abdul Malik Ikhsan
31397c1cf8
[BetterStandardPrinter] Fixes #4581 @Orm\Column should not be changed (#4584)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-12 11:25:25 +01:00
Tomas Votruba
4c6da2c4bf
[Laravel 5.7] Add parent boot rule (#4580)
* move file to templates, to remove confusion in the root

* use stable symplify

* [Laravel] Add AddParentBootToModelClassMethodRector

* [ci-review] Generate Rector & Nodes documentation

* [ci-review] propagate monorepo dependencies

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-11 17:09:57 +00:00
Abdul Malik Ikhsan
75714bb3d6
[CodeQuality] Fixes #4578 Skip ForToForeachRector on complex init (#4579) 2020-11-11 17:08:28 +00:00
Abdul Malik Ikhsan
0e5386c5d8
[BetterStandardPrinter] Fixes #3673 Doctrine Annotation comment should not be changed (#4577) 0.8.49 2020-11-11 16:14:31 +01:00
Abdul Malik Ikhsan
11fbc4c1c9
[BetterStandardPrinter] Fixes #4274 #4573 Annotation callback and Route values should not be changed (#4576)
* [BetterStandardPrinter] Fixes #4274 Annotation callback value should not changed to const

* backtrack fix

* update regex link

* namespace fix

* [ci-review] Apply coding standards

* [ci-review] Rector Rectify

* php 7.2 syntax

* Fixes #4573

* regex fix

* rework, need to one by one step

* handle route annotation

* phpstan

* [ci-review] Apply coding standards

* move content patch functionalities to new service : ContentPatcher

* [ci-review] Rector Rectify

* clean up phpstan

Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-11 13:06:46 +00:00
Abdul Malik Ikhsan
db18c7de19
[PHP 8.0] Improve NullsafeOperatorRector : Check against !== null (#4572)
* [PHP 8.0] Improve NullsafeOperatorRector : Check against !== null

* [ci-review] Apply coding standards

* [ci-review] Rector Rectify

* phpstan

* try process next only

* not identical process only direct if after assign

* phpstan

* [ci-review] Rector Rectify

* not identical with non-null check

* not identical with non-null check

* add yoda condition

* phpstan

* [ci-review] Apply coding standards

* move check if cond using assign identical/not identical to IfManipulator service

* cs fix

* [ci-review] Rector Rectify

* [ci-review] Apply coding standards

* move NullSafe process to NullsafeManipulator service

* phpstan

* [ci-review] Apply coding standards

* use instanceof check

Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-11 11:48:47 +00:00
Abdul Malik Ikhsan
ef442dca03
[PHP 8.0] Improve NullsafeOperatorRector : No need ?-> on very first call (#4571)
* [PHP 8.0] Improve NullsafeOperatorRector : No need ?-> on very first call

* use bool check is start if

* phpstan

* phpstan and code example update

* [ci-review] Generate Rector & Nodes documentation

* [ci-review] Apply coding standards

* using $isStartIf = true default

* clean up

Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-10 10:09:39 +00:00
Abdul Malik Ikhsan
b4fd52021d
[PHP 8.0] Improve NullsafeOperatorRector : Skip no direct usage after if in next statement at last (#4565)
* [PHP 8.0] Improve NullsafeOperatorRector : Skip no direct usage after if

* [ci-review] Apply coding standards

Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-09 13:14:57 +00:00
Tomas Votruba
44063910e6 remove unused config 2020-11-08 22:37:03 +00:00
Tomas Votruba
abb3c18570 remove unused config 2020-11-08 22:36:39 +00:00
Ronny López
531275df5b
Fix StrStartsWithRector to allow strpos not identical operation (#4562) 2020-11-08 23:35:05 +01:00
Tomas Votruba
b39caa53cc [CI] try to fix ref on forks 2020-11-08 22:27:13 +00:00
Abdul Malik Ikhsan
660f51019a
[PHP 8.0] Fixes #4527 Add NullsafeOperatorRector (#4557)
Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
2020-11-08 23:15:16 +01:00
Abdul Malik Ikhsan
4764fd1ac3
[DeadCode] Fixes #4561 Skip RemoveUnusedPrivatePropertyRector removes used Parameter (#4564)
* Add test case for not removing used constructor parameter

* Fixes #4561 Closes #4563

* [ci-review] Generate Rector & Nodes documentation

* [ci-review] Apply coding standards

* phpstan

* reduce complexity

* [ci-review] Rector Rectify

Co-authored-by: Tim Siebels <siebels.tim@gmail.com>
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-08 18:22:24 +00:00
David Meert
eff32d7f76
fix: PHP_Parser T_Match issue with php 7 (#4560) 2020-11-06 00:02:58 +01:00
Tomas Votruba
3940e42d25 rector update 2020-11-05 02:01:47 +01:00
Tomas Votruba
f841c8c470 fix cs 2020-11-05 01:50:43 +01:00
Krystian Marcisz
a92f4c1e2d
[DoctrineCodeQuality] Remove redundant default values from annotations (#4542)
* Move duplicated getAttributableItems() method to abstract parent

* Add removeItem() method to AbstractTagValueNode class

* Add RemoveRedundantDefaultAnnotationValuesRector rule with tests

* Link second test case of RemoveRedundantDefaultAnnotationValuesRector

* Add to set and docs

* Rename variable in DoctrineClassAnalyzer::matchDoctrineEntityTagValueNode()

* Remove redundant docblocks in RemoveRedundantDefaultAnnotationValuesRector

* Extract hasItemWithDefaultValue method in RemoveRedundantDefaultAnnotationValuesRector

* Optimize RemoveRedundantDefaultAnnotationValuesRector

* Split rule into two separate: one for Property and one for Class_

* PHP CS Fixer

* PHPStan
2020-11-04 22:51:11 +01:00
Abdul Malik Ikhsan
600334eafa
Fixes #4499 Code duplication on interface_exists and trait_exists inside if condition (#4553)
* debug content forat interface_exists

* add link to the post about format preserving

* Fixes #4499 Closes #4548

* [ci-review] Rector Rectify

* allow 0 space

* ensure matches[0] = matches[1] . matches[1]

* ensure count matches is 2

* phpstan

* [ci-review] Rector Rectify

* add test

* phpstan

* handle no {}

* clean up

* [ci-review] Rector Rectify

* fixture fix

* phpstan

* add @see https://github.com/rectorphp/rector/issues/4499 reference issue

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-04 22:32:49 +01:00
Abdul Malik Ikhsan
0cc7b66a1e
[FileSystem] Improve MovedFileWithNodesFactory : SKip if desiredGroupName already inside oldClassName (#4554) 2020-11-04 15:55:22 +01:00
Abdul Malik Ikhsan
44864580a0
[Nette 3.0] Register ConvertAddUploadWithThirdArgumentTrueToAddMultiUploadRector to nette-30 config set (#4552) 2020-11-04 05:27:33 +00:00
Abdul Malik Ikhsan
01092de6bb
[Nette 3.0] Fixes #4387 : Add ConvertAddUploadWithThirdArgumentTrueToAddMultiUploadRector (#4551)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-04 05:45:10 +01:00
Tomas Votruba
11031629d6 prevent spamming with long file contents of added files 2020-11-04 05:26:31 +01:00
Abdul Malik Ikhsan
5b1ae0b613
add empty file test case (#4549)
* add empty file test case

* [ci-review] Rector Rectify

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-04 03:50:35 +01:00
Tomas Votruba
c1c52920fd typo name 2020-11-04 00:45:49 +01:00
Tomas Votruba
2cca77d376 [ci] try split of monorepo packages 2020-11-04 00:43:23 +01:00
Tomas Votruba
93b601cef0
merge AstractGenericRectorTestCase and AbstractRectorTestCase (#4550)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-03 21:39:57 +01:00
Abdul Malik Ikhsan
f3885a15e5
Fixes #4543 Skip Rector check on empty files (#4547) 2020-11-03 10:30:32 +01:00
Tomas Votruba
d204364e39 [ci] add conditional if on forks 2020-11-03 01:14:18 +01:00
Rod Elias
9af4223bd6
Fix Xdebug spelling (#4546) 2020-11-02 21:50:07 +01:00
Tomas Votruba
84d2cc41d2
[DeadCode] Fix removal of class under (#4545)
* [DeadCode] Fix removal of class under

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
0.8.48
2020-11-02 19:01:31 +00:00
Tomas Votruba
7f05247192 fix typo 0.8.47 2020-11-02 02:13:55 +01:00
Tomas Votruba
0233a4d086 [ci] add github.head_ref 2020-11-02 00:06:52 +01:00
Tomas Votruba
7ce55d6686
move step count to own method (#4541) 0.8.46 2020-11-01 21:41:07 +01:00
Tomas Votruba
42fcff97e3 remove unused file 2020-11-01 21:33:03 +01:00
Tomas Votruba
297ec316af
move suffix filesystem 3 (#4540) 2020-11-01 21:31:13 +01:00
Tomas Votruba
bb9aec10da space bug 2020-11-01 19:20:35 +01:00
Tomas Votruba
084805774b [ci] try head ref slug 2020-11-01 18:32:57 +01:00
Tomas Votruba
5c90d522e9 [ci] allow ci-review on master to show results 2020-11-01 18:05:37 +01:00
Tomas Votruba
b4d8f40b32 [ci] add branch location to pull 2020-11-01 18:01:43 +01:00
Tomas Votruba
3cc067997b [ci] try to fix pull on forks 2020-11-01 17:58:55 +01:00
Tomas Votruba
cf48b2ea83
decouple (#4534)
* decouple

* [ci-review] Rector Rectify

* fix static

Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-01 16:03:30 +00:00
Tomas Votruba
e7c1ded364
fix linter (#4537) 2020-11-01 16:57:12 +01:00
Tomas Votruba
c03b66f7cd
move suffix filesystem 2 (#4529)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-11-01 16:39:04 +01:00
Krystian Marcisz
3d4762b3b5
Bump EndBug/add-and-commit version to 5.1.0 (#4536) 2020-11-01 16:26:53 +01:00