it got error:
```
The workflow is not valid. .github/workflows/weekly_code_coverage.yaml (Line: 34, Col: 51): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN
```
The `secrets` seems only needed for automatic PR.
* composer: bump to symfony/dependency-injection 5.1, required as minimum by other deps anyway
* use service() over deprecated ref()
* skip empty files
* skip just created props
* Add failing test fixture for ExplicitBoolCompareRector
# Failing Test for ExplicitBoolCompareRector
Based on https://getrector.org/demo/3cb57eee-954d-4f12-9d0f-7ce703672f60
* Update and rename demo_file.php.inc to UnknownPropertyType.php.inc
* Closes#5100
* fixture
Co-authored-by: Jan Kuchař <honza@kucharovi.cz>
* Add failing test fixture for RemoveParentAndNameFromComponentConstructorRector
# Failing Test for RemoveParentAndNameFromComponentConstructorRector
Based on https://getrector.org/demo/12f10dc7-7ffb-4fe1-8004-7bf82e7aa9ce
There are multiple problems in this rule:
1) only $name is removed ($parent should be also removed)
2) $name (and if it would work also $parent) is removed also when there is some future use of it (e.g. assigning to private property $this->name = $name)
* Failing fixtures
* Closes#5052
* cs fix
* rename fixture
* rename fixture
* reduce complexity
* refactor
* use Assign
Co-authored-by: Michal Lulco <michal.lulco@gmail.com>
Co-authored-by: Michal Lulco <lulco@efabrica.sk>
* [DeadCode] Failing fixture for not removing method parameter used on RemoveUnusedPrivatePropertyRector
* Fixes#5088
* return type
* fixture rename
* use findFirstParentInstanceOf as it may inside another, eg: assign
* phpstan
* clean up
* clean up
* skip construct
* instanceof New_ check
* fix
* final touch
* identifier check
* reduce complexity
* use toString()
* final touch
* php 7.3 syntax
* Fixed typo in docs "lenght" to "length"
* Fixed typo in class constant "lenght" to "length"
* Changed "lenght" instead of "length", fixing bug in class_exists using incorrect classname
* [fixtures] Enable validate-fixture-skip-naming check
* full path vendor vendor/symplify/easy-testing/bin/easy-testing validate-fixture-skip-naming rules tests
* 21 files
* more fixture
* various fix
* various fix
* more fixtures
* apply to packages rules tests utils
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* fixture fix
* done
* fixture fix
* Add failing test fixture for EncapsedStringsToSprintfRector
# Failing Test for EncapsedStringsToSprintfRector
Based on https://getrector.org/demo/1b647b4f-dde9-4f90-b05e-74744045a3d1
* Fix for prefixed_eol.php.inc
* Check against PHP_EOL
* allowing newline to be prefixed as well
* [CodingStyle] Closes#5060Fixes#5032 Add %s for pass PHP_EOL constant
* skip multiple eol
* use PHP_EOL const
* [ci-review] Rector Rectify
Co-authored-by: bruce aldridge <bruce@incode.co.nz>
Co-authored-by: rector-bot <tomas@getrector.org>
* UnSpreadOperatorRector: Should be kept on dynamic method calls
# Failing Test for UnSpreadOperatorRector
Based on https://getrector.org/demo/72c7df1d-01a2-4f1b-923f-2c5dedd7b636
* Closes#5069 Skip dynamic args on UnSpreadOperatorRector
* fixture update
* reduce complexity
Co-authored-by: Jan Kuchař <honza@kucharovi.cz>
* Add failing test fixture for GetClassToInstanceOfRector
# Failing Test for GetClassToInstanceOfRector
Based on https://getrector.org/demo/c605ea4b-824c-4fb6-8357-2b71a87098b6
* [CodeQuality] Closes#5064 Do not namespacing "static" on GetClassToInstanceOfRector
Co-authored-by: Jan Kuchař <honza@kucharovi.cz>
* Add failing test fixture for AddArrayReturnDocTypeRector
Return php doc should not be overriden when is more specific then one inferred by rector.
# Failing Test for AddArrayReturnDocTypeRector
Based on https://getrector.org/demo/5dc16502-4bb7-4f34-9922-35f56111ae9c
* Create return_php_doc_should_not_be_replaced_by_less_specific_type_2.php.inc
* Update and rename return_php_doc_should_not_be_replaced_by_less_specific_type.php.inc to skip_return_php_doc1.php.inc
* Update and rename return_php_doc_should_not_be_replaced_by_less_specific_type_2.php.inc to skip_return_php_doc2.php.inc
* [Type Declaration] Closes#5028 Skip AddArrayReturnDocTypeRector on return php doc
* add nested case fixture
Co-authored-by: Jan Kuchař <honza@kucharovi.cz>
