968 Commits

Author SHA1 Message Date
Tomas Votruba
7da338b953
[CodingStyle] Make ConsistentPregDelimiterRector configurable (#3924) 2020-08-06 23:55:56 +02:00
Tomas Votruba
38d13b480a
make ConsistentPregDelimiterRector configurable (#3922) 2020-08-06 19:13:59 +02:00
Tomas Votruba
0f25a84740
[CodeQuality] Add argument support to ArrayThisCallToThisMethodCallRector (#3921)
* make array method call to closure

* [CodeQuality] Add ArrayThisCallToThisMethodCallRector
2020-08-06 10:32:51 +00:00
Tomas Votruba
42caae413d
drop SimpleArrayCallableToStringRector, as it makes code magical and harder to proces (#3920) 2020-08-06 09:48:34 +00:00
Tomas Votruba
6b0249a025
drop slevomat cs to prevent breaking build for last months (#3917) 2020-08-05 22:57:39 +00:00
dobryy
411d76f9a9
[Order] Make OrderPrivateMethodsByUseRector process file in one run u… (#3889)
* [Order] Make OrderPrivateMethodsByUseRector process file in one run using while loop

* [Order] Enable rule in CI

* [rector] [Order] Enable rule in CI

* [cs] [Order] Enable rule in CI

* [Order] Use constant for number of max attempts and throw exception when exceeded.

* [rector] [Order] Use constant for number of max attempts and throw exception when exceeded.

* [cs] [Order] Use constant for number of max attempts and throw exception when exceeded.

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-05 22:45:36 +02:00
Tomas Votruba
5e0dfbd77a
re-use param in constructor (#3913) 2020-08-05 13:37:40 +00:00
Tomas Votruba
93905cb64c
cleanup (#3912)
* skip duplicated test

* assert for object configuration in StaticCallToMethodCallRectorů

* [rector] assert for object configuration in StaticCallToMethodCallRectorů

* [cs] assert for object configuration in StaticCallToMethodCallRectorů

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-05 07:58:27 +00:00
dobryy
056e50018c
[Order] Add test for StmtOrder (#3884)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-05 09:47:09 +02:00
Tomas Votruba
d467876da4
add parent-property test (#3910) 2020-08-05 01:47:31 +02:00
Tomas Votruba
4c05dcd9d0
Rename StaticCallToAnotherServiceConstructorInjectionRector to StaticCallToMethodCall (#3909) 2020-08-05 00:56:59 +02:00
Tomas Votruba
7212366606
[Naming] Decouple RenameParamToMatchTypeRector (#3906)
* [Naming] Decouple RenameParamToMatchTypeRector

* remove overrlaping useless test fixtures

* [rector] remove overrlaping useless test fixtures

* [cs] remove overrlaping useless test fixtures

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-04 18:30:31 +00:00
Marek Šimeček
d23ccc9038
method call remover fix (#3905)
Co-authored-by: Marek Šimeček <marek.simecek@footshop.cz>
2020-08-04 19:42:23 +02:00
Tomas Votruba
f322e4110c
[Generic] skip static method in FuncCallToMethodCallRector (#3901) 2020-08-04 13:37:29 +00:00
Tomas Votruba
b2054a32fc
Provide existing expression to get type (#3899)
* add support to provide existing expression instead of addgin a property with type

* [rector] add support to provide existing expression instead of addgin a property with type

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-04 13:12:43 +00:00
Tomas Votruba
484185aa8d
[SOLID] Skip property that is being changed by func call (#3898)
* add skip end function test case

* skip conversion of end() property
2020-08-04 13:02:12 +00:00
Tomas Votruba
3ddf965146
FunctionTo* correction renames, add PHPStan rule to check correct category of rule (#3896)
* rename Function* to Func* rector rule

* [Utils] Add RequireRectorCategoryByGetNodeTypesRule

* [PHPUnit] Rename SpecificMethod to MethodCall category to respect subscriberd nodes

* [rector] [PHPUnit] Rename SpecificMethod to MethodCall category to respect subscriberd nodes

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-04 10:02:17 +00:00
Tomas Votruba
7cda57615c
rename FunctionToStaticCallRector to FuncCallToStaticCallRector (#3895)
* rename FunctionToStaticCallRector to FuncCallToStaticCallRector

* rename FunctionToNewRector to FuncCallToNewRector

* remove RenameFuncCallToStaticCallRector, duplicate of FuncCallToStaticCallRector
2020-08-04 08:25:41 +00:00
Tomas Votruba
97de8eb625
[Generic] FuncCallToMethodCall only in case of parent class (#3894)
* [Generic] Improve FuncCallToMethodCallRector

* [rector] [Generic] Improve FuncCallToMethodCallRector

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-03 23:58:03 +00:00
Tomas Votruba
c9bb13d7ae
[Architecture] fix repository property (#3888)
* [Architecture] Fix moving repository to constructor extra property

* [rector] [Architecture] Fix moving repository to constructor extra property

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-03 19:47:08 +00:00
Tomas Votruba
09f67341ee
Add set-path constant support (#3886) 2020-08-03 21:14:41 +02:00
Tomas Votruba
c7f8ff4344
[TypeDeclaration] Skip typed property for @var adding (#3885) 2020-08-03 18:34:15 +00:00
Tomas Votruba
b61d22d56e
[Naming] Allow uuid to have name id (#3883)
* [Naming] Allow uuid to have name id

* add REPOSITORY_AS_SERVICE set

* [rector] add REPOSITORY_AS_SERVICE set

Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-03 17:52:40 +00:00
Tomas Votruba
2bd1eac705
use dev nette deps to resolve form/application types (#3879) 2020-08-03 08:51:44 +00:00
TomasVotruba
3ff6a971b7 add sponsor 2020-08-03 09:38:45 +02:00
Tomas Votruba
e35131524c
[Nette 3.0] Various rules updates (#3878)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-03 09:26:01 +02:00
Tomas Votruba
39ec802963
[NetteCodeQuality] Fix unset, on purpose (#3877) 2020-08-02 19:54:15 +02:00
Tomas Votruba
552b97d90e
add param type test case (#3876) 2020-08-02 16:58:56 +00:00
Tomas Votruba
e7429d96a4
make use of constant (#3875) 2020-08-02 13:17:33 +00:00
Tomas Votruba
b99a3cbdb2
add case with type form (#3874) 2020-08-02 12:58:14 +00:00
Tomas Votruba
bb6a53fef0
[NetteCodeQuality] Skip isset on form input + multiplier check (#3872) 2020-08-02 12:57:05 +02:00
Tomas Votruba
ee957111c4
fix import slash (#3871) 2020-08-02 10:04:46 +00:00
Tomas Votruba
91bda1b75b
[NetteCodeQuality] Get component (#3870) 2020-08-02 11:39:52 +02:00
Tomas Votruba
6186cdeab7
skip form (#3869) 2020-08-02 01:24:58 +02:00
Tomas Votruba
62ac58e60d
add failing test case + add support for previous assign type dim fetch (#3868) 2020-08-02 00:57:35 +02:00
Tomas Votruba
fa2caf77ed
[NetteCodeQuality] Add ArrayAccessSetControlToAddComponentMethodCallRector (#3867) 2020-08-02 00:18:40 +02:00
Tomas Votruba
a84528af9e
[Docs] Show constants over values (#3866)
* [docs] decouple RectorCodeSamplePrinter

* decopule printers

* make sure constnat are used in docs

* update docs
2020-08-01 20:55:31 +00:00
Tomas Votruba
5f6d66d8c1
[ci] enable defluent set (#3865) 2020-08-01 21:36:47 +02:00
Tomas Votruba
324c2b2192
[MagicDisclosure] fixes (#3863) 2020-08-01 18:59:36 +02:00
Tomas Votruba
800abda3d2
[MagicDisclosure] Improve naming (#3862)
* add FluentChain keywords together, to make easier to find the classes

* decopule AbstractFluentChainMethodCallRector
2020-08-01 15:34:08 +00:00
Tomas Votruba
4624778cb0
[MagicDisclosure] Fluent refactoring (#3861)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-08-01 16:57:37 +02:00
Tomas Votruba
55acb3578a
[MagicDisclosure] Add SetterOnSetterMethodCallToStandaloneAssignRector (#3860)
* [MagicDisclosure] Add MethodCallOnSetterMethodCallToStandaloneAssignRector

* merge ChainMethodCallManipulator to ChainMethodCallNodeAnalyzer for better DX

* [MagicDisclosure] Add in arg defluent

* rebase
2020-08-01 11:41:16 +00:00
Marek Šimeček
ab8d290b14
method call remover rector (#3850)
Co-authored-by: Marek Šimeček <marek.simecek@footshop.cz>
2020-08-01 11:49:32 +02:00
Tomas Votruba
8c5fdca387
[MagicDisclosure] Add support for child parent class types (#3859) 2020-08-01 10:03:21 +02:00
Tomas Votruba
631fa9449f
[MagicDisclosure] Drop type scoping from ReturnThisRemoveRector, as always localy scope (#3858) 2020-08-01 09:06:10 +02:00
Tomas Votruba
8b42e67744
[MagicDisclosure] Skip getters (#3856) 2020-08-01 00:01:52 +00:00
Tomas Votruba
86c2958501
[MagicDisclosure] Add last method with differnt type support (#3854) 2020-07-31 23:36:13 +00:00
Tomas Votruba
76b4ab7586
[Defluent] New set + various improvements (#3853)
* remove dead-else branch

* add defluent set

* fix type to match

* use constants over strings

* fixup! use constants over strings

* Add fluent as arg support to DefluentMethodCallRector

Co-authored-by: rector-bot <tomas@getrector.org>
2020-07-31 23:08:16 +00:00
dobryy
3aa2fc8727
[Order] Order properties and constants with respect of complexity and position (#3826)
Co-authored-by: rector-bot <tomas@getrector.org>
2020-07-31 22:20:45 +02:00
TomasVotruba
ff8d6d265b [MagicDisclosure] fluent removal improvements 2020-07-31 19:04:51 +02:00