mirror_php/rector
1
0
Fork 0
mirror of https://github.com/rectorphp/rector.git synced 2025-02-24 19:53:14 +01:00
Code Issues Projects Releases Wiki Activity
10,682 Commits 1 Branch 477 Tags
Commit Graph

149 Commits

Author SHA1 Message Date
Tomas Votruba
ed475a2e3c
[static] no nullable node (#4995) 
* move phpstan.neon cusotm rules to rector-rules.neon, to cleanup main config

* enable forbidden rule on nullable nodes

* bump to Symplify 9.0.17

* make name non-nullable

* skip non-nullable

* skip null dim
 2020-12-25 20:50:50 +00:00
Tomas Votruba
db89b5eefa
[CodeQuality] Move MoveVariableDeclarationNearReferenceRector (#4989) 
* [CodeQuality] Move MoveVariableDeclarationNearReferenceRector

* move code-quality-strict rules to own namespace

* move MoveVariableDeclarationNearReferenceRector to CodeQualityStrict

* add ClassConstFetchFactory

* static fixes
 2020-12-25 16:22:19 +00:00
Abdul Malik Ikhsan
ec5daad132
[Util] Add StaticInstanceOf (#4979) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-25 12:53:26 +01:00
Tomas Votruba
d465ec83e2
[DeadCode] Move RecastingRemovalRector from PHPStan set (#4983) 
* [DeadCode] Move RecastingRemovalRector from PHPStan set

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-25 00:22:45 +00:00
Tomas Votruba
319d6bfca1
add phpstan-for-rector config path, consolidate return type extensions - re-use from Symplify (#4973) 
* add phpstan-for-rector config path, to separate phpstan and extensions that help Rector with precise types

* move type value object to value object

* moving

* remove KernelGetContainerAfterBootReturnTypeExtension, use one from symplify

* remove ContainerGetDynamicMethodReturnTypeExtension to ContainerGetReturnTypeExtension

* remove nette extension

* add nette-extension

* removed delegated rule

* delegate implmenets + code sample PHPStan rule to symplify
 2020-12-24 16:31:24 +00:00
Abdul Malik Ikhsan
ca0b4cfdc7
[EarlyReturn] Register ChangeOrIfReturnToEarlyReturnRector to early-return set (#4975) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-24 17:28:56 +01:00
Abdul Malik Ikhsan
48eaa5c950
[CodeQuality] Fixes #4950 Skip IssetOnPropertyObjectToPropertyExistsRector on property as variable (#4953) 2020-12-22 23:21:12 +01:00
Abdul Malik Ikhsan
24e17588c1
[Utils] Run validate-fixture-namespace/classname to rules/ directories (#4935) 2020-12-22 18:12:20 +01:00
Abdul Malik Ikhsan
003314b958
[CodeQuality] Add SwitchNegatedTernaryRector (#4940) 
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-22 18:10:01 +01:00
Tomas Votruba
a759f1ffbc
Static fixes 3 (#4930) 
* cleanpu baseline

* static fixes

* staitc fixes

* [Naming] Remove dead classes UnderscoreCamelCaseParamRenamer and MatchTypeParamRenamer

* static fixes

* value object fixes

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-21 02:12:42 +00:00
Tomas Votruba
2c8a76ef12
[Naming] add failing test case for type property collection name (#4863) 
* add failing test case for type property collection name

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-20 15:10:06 +00:00
Abdul Malik Ikhsan
7f674d7c8b
Using $this->mirrorComments() from AbstractRector to keep comment (#4923) 
* Using $this->mirrorComments() from AbstractRector to keep comment

* fix

* fix

* clean up

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
 2020-12-20 13:56:43 +01:00
Tomas Votruba
574c7cd174
[static] Narrow param types, remove duplicated methods (#4921) 
* narrow types and other static fixes

* duplicates static fixes

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-20 13:50:55 +01:00
Abdul Malik Ikhsan
720b2c34eb
[EarlyReturn] Enable ReturnBinaryAndToEarlyReturnRector in early-return config set (#4915) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-19 16:24:53 +01:00
Tomas Votruba
d131d804d9
Bump min PHP version to 7.3 (#4838) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-09 23:25:53 +01:00
Abdul Malik Ikhsan
143164504e
[CodeQuality] Add UnwrapSprintfOneArgumentRector (#4827) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-09 12:29:01 +01:00
Tomas Votruba
bfd1953f97
move string downgrade types to object classes (#4801) 
* move string downgrade types to object classes

* fix nullable type unwrap

* remove uneeded open tags from samples

* remove uneeded union type check
 2020-12-06 00:27:00 +00:00
Tomas Votruba
8bfb36d0b2
[Downgrade] [PHP 7.3] Downgrade trailing commas in function calls (#4796) 
Co-authored-by: Tommy Quissens <tommy.quissens@storefront.be>
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-05 22:40:10 +01:00
Krystian Marcisz
c85ee2df8d
[DX] Use MethodName const instead of string for __set_state (#4797) 2020-12-05 22:39:06 +01:00
TomasVotruba
25908c27f8 fix cs 2020-12-05 22:19:10 +01:00
Krystian Marcisz
47a9a52ffd
[CodeQuality] Add DateTimeToDateTimeInterfaceRector (#4791) 
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
 2020-12-05 21:21:22 +01:00
Tomas Votruba
1f56646989
PHPStan rule decouple to Symplify (#4786) 
* use ForbiddenMethodCallOnTypeRule from symplify

* fixup! use ForbiddenMethodCallOnTypeRule from symplify

* merge CommentCombiner to CommentsMerger
 2020-12-05 11:41:55 +00:00
github-actions[bot]
c7d2af6966
[automated] Apply Coding Standard (#4784) 
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
 2020-12-05 11:07:25 +01:00
Tomas Votruba
5201e949a1
[PHPStanExtensions] Add ForbiddenMethodCallOnTypeRule + move from docComment and Comments to PhpDocInfo (#4780) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-05 00:22:12 +01:00
Tomas Votruba
09f17a7b64
[Downgrade] [PHP 8.0] Add DowngradePropertyPromotionToConstructorPropertyAssignRector (#4762) 
* [Downgrade] [PHP 8.0] Add DowngradePropertyPromotionToConstructorPropertyAssignRector

* fix parent

* various fixes for PHP 8.0 tests

* [ci-review] Rector Rectify

* Update rules/downgrade-php80/tests/Rector/Class_/DowngradePropertyPromotionToConstructorPropertyAssignRector/DowngradePropertyPromotionToConstructorPropertyAssignRectorTest.php

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-12-03 13:27:24 +00:00
Krystian Marcisz
2eba542760
Fix UnusedForeachValueToArrayKeysRector on objects (#4750) 2020-12-02 14:09:35 +01:00
Markus Staab
74a17fde01
ArrayThisCallToThisMethodCallRector: use betterNodeFinder->findFirstParentInstanceOf() (#4707) 2020-11-27 11:43:53 +00:00
Abdul Malik Ikhsan
a38debb672
[DX] Fixes #4205 Change phpversion from string to php constant int type (#4679) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-11-24 16:32:49 +01:00
Tomas Votruba
014985e943
[CodingStyle] Add static support to PreferThisOrSelfMethodCallRector (#4660) 
* [CodingStyle] Add static support to PreferThisOrSelfMethodCallRector

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-11-19 12:37:50 +00:00
github-actions[bot]
a791be06c0
[automated] Apply Coding Standard (#4657) 
Co-authored-by: kodiakhq <kodiakhq@users.noreply.github.com>
 2020-11-19 02:09:31 +01:00
Tomas Votruba
a7705ed0a5
[Symplify 9] First update + switch to RuleDocGenerator (#4616) 
* [composer] bump to Symplify 9

* [Symplify 9] Update phpstan rules

* bump to Symplify 9 BETA2

* update AbstractKernel from Tests to Testing namespace

* decoupling removing node trait

* remove fluent calls

* removing variadic

* [CodingStyle] Improve AnnotateThrowablesRector

* bump deps

* Make use of RuleDocGenerator

* first short

* [DocumentationGenerator] Drop deprecated package, RuleSetGenerator now handles it

* import namespace

* update docs
 2020-11-16 17:50:38 +00:00
Abdul Malik Ikhsan
7fcbac3230
[CodeQuality] ForToForeachRector improvement on ArrayDimFetch handling (#4613) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-11-15 17:12:48 +01:00
Abdul Malik Ikhsan
978087e846
[CodeQuality] Skip ForToForeachRector on assign count is used inside for statements (#4607) 
* Failing fixture for to foreach assign count is used inside for

* Fix skip assign count used inside for statements

* cs fix

* use areNodesEqual()

* phpstan

* method naming

* [ci-review] Rector Rectify

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-11-14 14:07:38 +00:00
Abdul Malik Ikhsan
75714bb3d6
[CodeQuality] Fixes #4578 Skip ForToForeachRector on complex init (#4579) 2020-11-11 17:08:28 +00:00
Abdul Malik Ikhsan
d876f5bf59
[CodeQuality] Fixes #4516 Skip Apply ArrayThisCallToThisMethodCallRector on array inside property (#4533) 2020-11-01 14:32:48 +01:00
Abdul Malik Ikhsan
55a0400a62
Typo Fix funciton -> function (#4532) 2020-11-01 09:51:52 +01:00
Tomas Votruba
0513315056
Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node (#4522) 
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node

* update DecoupleClassMethodToOwnClassRector

* [ci] add rebase jobp

* disable fail fast for unit tests

* misc
 2020-10-31 12:59:40 +00:00
Abdul Malik Ikhsan
a2ae659e0a
[CodeQualityStrict] Enable MoveOutMethodCallInsideIfConditionRector (#4502) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-10-29 21:47:12 +01:00
Abdul Malik Ikhsan
9e0b632e4e
[CodeQualityStrict] Add CountArrayToEmptyArrayComparisonRector to CodeQualityStrict (#4496) 
Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
 2020-10-29 09:59:39 +01:00
Tomas Votruba
35502016a6
Improve MoveOutMethodCallInsideIfConditionRector (#4492) 
* skip rename

* add method call and variable name for MoveOutMethodCallInsideIfConditionRector

* decouple MethodCallToVariableNameResolver

* use trick with Scope if variable is already defined

* fixup! use trick with Scope if variable is already defined

* cover case with variable name and method call

* add decopule note future

* [ci-review] Rector Rectify

* [ci] try re-trigger ci-review after push automatically

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-10-27 15:51:44 +00:00
Abdul Malik Ikhsan
7a1ea1328b
[CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set (#4477) 
* [CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set

* rename use string parameter

* phpstan

* fix false positive string param to be var === variable name

* fix false positive

* phpstan

* ensure not same variable

* phpstan

* add ucfirst after var

* add fixture failing test for variable exists to be skipped

* add fixture failing test for variable exists in previuos statement

* phpstan space

* add handling variable exists in previous statement and in ClassMethod/Functions args

* handle exists but inside if

* reduce complexity

* clean up

* clean up

* cs fix

* phpstan

* remove - in variable

* use fallback when first character is numeric

* using regex to check string start alpha for variable

* cs fix

* use ClassConstFetch name to set variable name

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* [ci-review] Rector Rectify

* clean up

* fix

* [ci-review] Rector Rectify

* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php

* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php

Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
 2020-10-26 14:03:26 +00:00
Tomas Votruba
0f2e6d407e
[DoctrineAnnotaitonGenerated] Update to doctrine/annotations 1.11 + fix static (#4479) 2020-10-25 14:43:05 +01:00
Abdul Malik Ikhsan
11c76808be
[CodeQuality] Add MoveOutMethodCallInsideIfConditionRector (#4457) 
* Add MoveOutMethodCallInsideIfConditionRector

* cs fix

* implemented handling pass constant to arg 0

* phpstan

* final touch: no need strtolower() before ucfirst on fallback var name
 2020-10-23 15:15:54 +02:00
Tomas Votruba
10ae0d687a
[CodeQuality] Add NewStaticToNewSelfRector (#4468) 
* [CodeQuality] Add NewStaticToNewSelfRector

* regenerated docs

* drop patches
 2020-10-20 22:01:47 +00:00
Tomas Votruba
aa98eb5d9e
[CodeQuality] Skip dynamic properties for bindTo() (#4467) 
* [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

* [rector] [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

* [cs] [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-10-20 22:43:05 +02:00
Tomas Votruba
75d25a1dcb
[CodeQuality] Decouple complete dynamic properties rector, add skip of Closure::bind() (#4466) 
* [ci] temporarily hide split monorepo

* [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

* [rector] [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

* [cs] [CodeQuality] Decouple complete dynamic properties rector, add skip of bind()

Co-authored-by: rector-bot <tomas@getrector.org>
 2020-10-20 20:27:12 +00:00
Tomas Votruba
5988584736
[CodeQuality] Improve missing property type resolution for array dim fetch (#4462) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-10-20 20:35:35 +02:00
Tomas Votruba
b9f45eab00
[CodeQuality] Skip nested foreach (#4461) 2020-10-20 17:07:01 +02:00
Tomas Votruba
8bdb879a55
[CodeQuality] Add nested foreach foreach that is required for assign (#4459) 2020-10-20 14:24:32 +00:00
Tomas Votruba
9d2757f80d
[CodeQuality] Support multi boolean and in isset on property (#4455) 
Co-authored-by: rector-bot <tomas@getrector.org>
 2020-10-20 12:50:21 +02:00