* Add failing test fixture for ExplicitBoolCompareRector
# Failing Test for ExplicitBoolCompareRector
Based on https://getrector.org/demo/3cb57eee-954d-4f12-9d0f-7ce703672f60
* Update and rename demo_file.php.inc to UnknownPropertyType.php.inc
* Closes#5100
* fixture
Co-authored-by: Jan Kuchař <honza@kucharovi.cz>
* [fixtures] Enable validate-fixture-skip-naming check
* full path vendor vendor/symplify/easy-testing/bin/easy-testing validate-fixture-skip-naming rules tests
* 21 files
* more fixture
* various fix
* various fix
* more fixtures
* apply to packages rules tests utils
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* more fixtures
* fixture fix
* done
* fixture fix
* Add failing test fixture for GetClassToInstanceOfRector
# Failing Test for GetClassToInstanceOfRector
Based on https://getrector.org/demo/c605ea4b-824c-4fb6-8357-2b71a87098b6
* [CodeQuality] Closes#5064 Do not namespacing "static" on GetClassToInstanceOfRector
Co-authored-by: Jan Kuchař <honza@kucharovi.cz>
* Failing fixture for to foreach assign count is used inside for
* Fix skip assign count used inside for statements
* cs fix
* use areNodesEqual()
* phpstan
* method naming
* [ci-review] Rector Rectify
Co-authored-by: rector-bot <tomas@getrector.org>
* Change file system approach of MultipleClassFileToPsr4ClassesRector to file without namespace node
* update DecoupleClassMethodToOwnClassRector
* [ci] add rebase jobp
* disable fail fast for unit tests
* misc
* skip rename
* add method call and variable name for MoveOutMethodCallInsideIfConditionRector
* decouple MethodCallToVariableNameResolver
* use trick with Scope if variable is already defined
* fixup! use trick with Scope if variable is already defined
* cover case with variable name and method call
* add decopule note future
* [ci-review] Rector Rectify
* [ci] try re-trigger ci-review after push automatically
Co-authored-by: rector-bot <tomas@getrector.org>
* [CodeQuality] Register MoveOutMethodCallInsideIfConditionRector to config code-quality set
* rename use string parameter
* phpstan
* fix false positive string param to be var === variable name
* fix false positive
* phpstan
* ensure not same variable
* phpstan
* add ucfirst after var
* add fixture failing test for variable exists to be skipped
* add fixture failing test for variable exists in previuos statement
* phpstan space
* add handling variable exists in previous statement and in ClassMethod/Functions args
* handle exists but inside if
* reduce complexity
* clean up
* clean up
* cs fix
* phpstan
* remove - in variable
* use fallback when first character is numeric
* using regex to check string start alpha for variable
* cs fix
* use ClassConstFetch name to set variable name
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* [ci-review] Rector Rectify
* clean up
* fix
* [ci-review] Rector Rectify
* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php
* Update rules/code-quality/src/Rector/If_/MoveOutMethodCallInsideIfConditionRector.php
Co-authored-by: rector-bot <tomas@getrector.org>
Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
* Add MoveOutMethodCallInsideIfConditionRector
* cs fix
* implemented handling pass constant to arg 0
* phpstan
* final touch: no need strtolower() before ucfirst on fallback var name
* [CakePHP] Promote AppUsesStaticCallToUseStatementRector to File
* [CakePHP] Change ImplicitShortClassNameUseStatementRector to FileWithoutNamespace approach
* [Renaming] Update PseudoNamespaceToNamespaceRector to use FileWithnoutNamespace
* [rector] [Renaming] Update PseudoNamespaceToNamespaceRector to use FileWithnoutNamespace
* [cs] [Renaming] Update PseudoNamespaceToNamespaceRector to use FileWithnoutNamespace
Co-authored-by: rector-bot <tomas@getrector.org>
* [CI] Add type-declaration set
* [rector] [CI] Add type-declaration set
* [cs] [CI] Add type-declaration set
* skip nullable void
* add anonymous parent/interface support
* refactor MultiExceptionCatchRector to use Catch_ over integers
* type fixes
* fix unoin array type override
* remove unused test cases
* drop overcomplicated InlineValidationRulesToArrayDefinitionRector
* skip assign on var
* [rector] skip assign on var
* [cs] skip assign on var
* [rector] [cs] skip assign on var
* skip assign on var
* fixes
* [rector] fixes
* [cs] fixes
Co-authored-by: rector-bot <tomas@getrector.org>
* [MagicDisclosure] Add MethodCallOnSetterMethodCallToStandaloneAssignRector
* merge ChainMethodCallManipulator to ChainMethodCallNodeAnalyzer for better DX
* [MagicDisclosure] Add in arg defluent
* rebase
