mirror_php/wordpress
1
0
Fork 0
mirror of git://develop.git.wordpress.org/ synced 2025-01-17 12:58:25 +01:00
Code Issues Actions 98 Packages Projects Releases Wiki Activity

Taxonomy: Make sure wp_list_categories() correctly outputs term name of 0.

Browse Source 
Props joyously, SergeyBiryukov.
Merges [43605] to the 4.9 branch.
Fixes #44872.

git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43620 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2018-09-03 21:23:26 +00:00
parent f8b390c4ff
commit 008a65d98d
2 changed files with 30 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/class-walker-category.php
View File

@ -99,7 +99,7 @@ class Walker_Category extends Walker {
);
// Don't generate an element if the category name is empty.
if ( ! $cat_name ) {
if ( '' === $cat_name ) {
return;
}

37
tests/phpunit/tests/category/wpListCategories.php
View File

@ -87,6 +87,35 @@ class Tests_Category_WpListCategories extends WP_UnitTestCase {
$this->assertNotContains( 'Test Cat 1', $found );
}
public function list_cats_callback( $cat ) {
if ( 'Test Cat 1' === $cat ) {
return '';
}
return $cat;
}
/**
* @ticket 44872
*/
public function test_should_create_element_when_cat_name_is_zero() {
$c = self::factory()->category->create(
array(
'name' => '0',
)
);
$found = wp_list_categories(
array(
'hide_empty' => false,
'echo' => false,
)
);
$this->assertContains( "cat-item-$c", $found );
$this->assertContains( '0', $found );
}
public function test_show_option_all_link_should_go_to_home_page_when_show_on_front_is_false() {
$cats = self::factory()->category->create_many( 2 );
@ -207,14 +236,6 @@ class Tests_Category_WpListCategories extends WP_UnitTestCase {
$this->assertContains( "<li class='cat-item-all'><a href='" . $url . "'>All</a></li>", $found );
}
public function list_cats_callback( $cat ) {
if ( 'Test Cat 1' === $cat ) {
return '';
}
return $cat;
}
/**
* @ticket 33460
*/