On pages and posts with featured images, the top level menu items have a slight transparency on hover, which was being inherited by their submenus. This update removes that inheritance, improving readability and consistency in the menu's appearance.
Props kjellr.
Merges [44368] to the 5.0 branch.
Fixes#45689.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44427 602fd350-edb4-49c9-b593-d223f7449a82
The menu's original markup included some non-semantic tags and an unnecessary tabindex attribute that made it difficult to navigate via keyboard.
Props allancole, anevins, kjellr.
Merges [44376] to the 5.0 branch.
Fixes#45713.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44426 602fd350-edb4-49c9-b593-d223f7449a82
Twenty Seventeen's original styles for the block editor custom colors had some issues: they weren't being applied to the button blocks due to lack of specificity, and when applied to paragraph blocks, there was no padding in the editor. This update makes sure the colors and related styles work as expected.
Props laurelfulford.
Merges [44402] to the 5.0 branch.
Fixes#45426.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44425 602fd350-edb4-49c9-b593-d223f7449a82
The outlined button block style was displaying white text on a white background on hover. This update makes sure the text remains legible on hover when this button style is applied.
Props rickalee, kjellr.
Merges [44370] to the 5.0 branch.
Fixes#45726.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44424 602fd350-edb4-49c9-b593-d223f7449a82
The button block in Twenty Fourteen was incorrectly inheriting a text underline from the theme's link styles.
Props bobbingwide.
Merges [44378] to the 5.0 branch.
Fixes#45732.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44423 602fd350-edb4-49c9-b593-d223f7449a82
The "Continue Reading" link that's generated by the More block is styled to include an arrow next to the text; that arrow shouldn't inherit the text underline style. This update removes it.
Props littlebigthing, kjellr.
Merges [44369] to the 5.0 branch.
Fixes#45715.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44422 602fd350-edb4-49c9-b593-d223f7449a82
A change to the MediaElement.js caused Twenty Fourteen's custom video play button to display in the top corner, rather than centered. This update returns it to its correct position.
Props mmaumio, celloexpressions.
Merges [44380] to the 5.0 branch.
Fixes#44664.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44421 602fd350-edb4-49c9-b593-d223f7449a82
Removes `file_exist()` checks before calling `load_script_translations()` to let the determined paths be passed to `load_script_translations()` which provides its own file check and the possibility to filter the path.
Merge of [44418] to the 5.0 branch.
Props swissspidy, johnbillion, ocean90.
Fixes#45769.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44419 602fd350-edb4-49c9-b593-d223f7449a82
A static variable contains an integer that is incremented with each call. This number is returned with the optional prefix.
As such the returned value is not universally unique, but it is unique across the life of the PHP process.
Props westonruter, dlh.
Merges [43658] and [44406] to the 5.0 branch.
See #44883.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44407 602fd350-edb4-49c9-b593-d223f7449a82
Avoids change the selected link when using the Shift + Up/Down arrow keys
to select text in the form fields.
Props afercia.
Merges [42807] to the 5.0 branch.
Fixes#43253.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44405 602fd350-edb4-49c9-b593-d223f7449a82
The inline JavaScript added by `WP_Scripts::print_translations()` should check whether `locale_data.$text_domain` exists and fall back to `locale_data.messages` otherwise.
Merge of [44403] to the 5.0 branch.
Props swissspidy.
Fixes#45441.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44404 602fd350-edb4-49c9-b593-d223f7449a82
In [42523], `trunk` was updated to use explicit context instead of a trailing space for the Edit string in TinyMCE plugins. [43472] later backported this change, but the string in `class-wp-editor.php` was missed. This fixes the `Edit` string so not display as `Edit|button` in the 5.0 branch.
Props dimadin.
See #42543, #44134.
Fixes#44919.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44401 602fd350-edb4-49c9-b593-d223f7449a82
In the Classic Editor, the “Add Media” button was outside of the TinyMCE editor. In the Block Editor, the “Add Media” button was moved into the TinyMCE toolbar in the Classic block, but the tooltip was not added to the list of translatable strings. This adds “Add Media” to that list.
The corresponding keyboard shortcut is also specified for the “Add Media” button.
Props afercia.
Merges [44398-44399] to the 5.0 branch.
Fixes#45788.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44400 602fd350-edb4-49c9-b593-d223f7449a82
The unminified package vendor scripts are bundled with the release package thus the value of the `SCRIPT_DEBUG` constant should be honored.
Merge of [44391] to the 5.0 branch.
Props earnjam.
Fixes#45535.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44393 602fd350-edb4-49c9-b593-d223f7449a82
While the filter is documented to only support a `WP_Error`, it has been a common practice to return true in a validation function if no errors have occurred. This was already caught when the same filter was executed in `WP_Customize_Setting`, it was however missing in `WP_Customize_Manager::validate_setting_values()`.
Props flixos90.
Merges [43578] to the 5.0 branch.
Fixes#44809.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44392 602fd350-edb4-49c9-b593-d223f7449a82
This prevents a potential fatal error from an `ArgumentCountError` exception in PHP 7.1 or greater
Props dlh.
Merges [43561] to the 5.0 branch.
Fixes#44770.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44387 602fd350-edb4-49c9-b593-d223f7449a82
The theme's original navigation JavaScript was making it so all links on a site were immediately followed on touchstart when using a touch-enabled device. This update makes sure links are followed at touchend, to improve usability and menu behavior.
Props anevins, panchen, kjellr.
Fixes#45510.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44357 602fd350-edb4-49c9-b593-d223f7449a82
In [44185], a bug was introduced where hierarchical post types would not display in the correct default order (hierarchically).
This was caused by a `! isset()` check, which returned `false` after [44185], causing the correct default value to not be applied. This switches that conditional to use an `empty()` check, ignoring the new empty string assignment that was added to prevent a PHP notice when `compact()` is called.
Merges [44338] to the 5.0 branch.
Props davidbinda.
Fixes#45711.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44339 602fd350-edb4-49c9-b593-d223f7449a82
Update the theme versions and release dates for the default themes, in time for WordPress 5.0.2.
The POT files for Twenty Ten and Eleven have also been updated.
Merges [44322] into the 5.0 branch.
Fixes#45681.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44323 602fd350-edb4-49c9-b593-d223f7449a82
This filter is superfluous here, the `load_script_textdomain_relative_path` should be used for customising the textdomain path.
See #45528.
Props dimadin.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44288 602fd350-edb4-49c9-b593-d223f7449a82
`determine_locale()` accesses the `$pagenow` global, but this is set after mu-plugins are loaded, so we need to check that it's been set.
Props swissspidy, azaozz.
See #45668.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44284 602fd350-edb4-49c9-b593-d223f7449a82
* Introduces `pre_load_script_translations` to short-circuit the function.
* Introduces `load_script_translation_file` to filter the file path for loading script translations.
* Introduces `load_script_translations` to filter the JSON-encoded translation data.
Props johnbillion, strategio, swissspidy, dimadin, ocean90.
See #45425.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44232 602fd350-edb4-49c9-b593-d223f7449a82
This update replaces the term “Gutenberg” in the themes code comments and classes with something more future-friendly.
Fixes#45452.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44213 602fd350-edb4-49c9-b593-d223f7449a82
The markup for the default block appender changed from a text input to a text area in the editor; this update makes the same change in the default theme styles.
Fixes#45450.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44212 602fd350-edb4-49c9-b593-d223f7449a82
A closing parenthesis was misplaced in the `$scripts->add( 'wp-tinymce-lists' )` call, causing the dependencies and version to be incorrectly passed to `includes_url()` instead.
Props volodymyrkolesnykov.
Fixes: #45506.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44211 602fd350-edb4-49c9-b593-d223f7449a82
When using the block-based editor in Twenty Sixteen, superscript is displaying below the baseline and subscript is displaying above the baseline. This is the opposite of what should occur. This reverses the two to display correctly.
Props greg-raven, torontodigits, JDTrower.
Fixes: #44776.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44210 602fd350-edb4-49c9-b593-d223f7449a82
Fixes the `load_script_textdomain` function not resolving the md5 hash based on the relative path for WordPress installations in a subdirectory. Also adds a filter to allow sites using CDNs or other alternative asset locations to filter the relative path resolution.
Props akirk, fierevere, swissspidy, mypacecreator, babaevan, tmatsuur, ocean90.
Fixes#45528.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44209 602fd350-edb4-49c9-b593-d223f7449a82
In `WP_REST_Attachments_Controller::create_item()`, `wp-admin/includes/image.php` was being `require_once()`-ed... twice. The superflous `require_once()` has been quietly removed.
Props david.binda.
See #45420.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44206 602fd350-edb4-49c9-b593-d223f7449a82
Twenty Seventeen’s editor styles contained an Internet Explorer 8 specific fix that stopped images from being scalable in the editor in other browsers. Since the editor no longer supports IE8, this fix can safely be removed.
Props audrasjb, mihaivalentin, subrataemfluence.
Fixes#39738.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44205 602fd350-edb4-49c9-b593-d223f7449a82
To improve accessibility, the cookies content checkbox in the comment form needed some visible indication when it’s in focus.
Props pratikthink, afercia.
Fixes#44699.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44204 602fd350-edb4-49c9-b593-d223f7449a82
Twenty Seventeen was designed with bolded numbers for its ordered list styles. This was removed from the theme prior to launch, but it was left in the editor styles, so it needed to be removed there, too.
Props mmaumio, edpittol.
Fixes#44775.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44203 602fd350-edb4-49c9-b593-d223f7449a82
This commit fixes the final differences between the version of Twenty Nineteen in core and the one in GitHub. The two are now identical.
See #45424.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44202 602fd350-edb4-49c9-b593-d223f7449a82
Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.
Fixes#45427.
git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44200 602fd350-edb4-49c9-b593-d223f7449a82
