This takes into account the changes from #47125 and updates the related Help Tabs content accordingly.
Follow-up to [56515].
Props johnbillion, renishsurani, faisal03, shailu25, sumitbagthariya16, Ankit-K-Gupta, oglekler, rajinsharwar, hmbashar, huzaifaalmesbah.
Fixes#61153.
git-svn-id: https://develop.svn.wordpress.org/trunk@58564 602fd350-edb4-49c9-b593-d223f7449a82
This updates the npm `devDependencies` for Core to their latest versions, with one exception. The latest version of `sinon` causes some test failures and requires more investigation.
Fixes#61498.
git-svn-id: https://develop.svn.wordpress.org/trunk@58563 602fd350-edb4-49c9-b593-d223f7449a82
This updates the npm dependencies for the Twenty Nineteen, Twenty Twenty, and Twenty Twenty-One themes. `npm audit fix` has also been run.
See #61498.
git-svn-id: https://develop.svn.wordpress.org/trunk@58562 602fd350-edb4-49c9-b593-d223f7449a82
This patch introduces two related changes:
- It adds missing subclass methods on the HTML Processor which needed
to be implemented since it started visiting virtual nodes. These
methods need to account for the fact that not all tokens truly exist.
- It adds a new concept and internal method, `is_virtual()`, indicating
if the currently-matched token comes from the raw text in the input
HTML document or if it was the byproduct of semantic parsing rules.
This internal method and new vocabulary around token provenance
considerably simplifies the logic spread throughout the rest of the
class and its subclass methods.
Developed in https://github.com/WordPress/wordpress-develop/pull/6860
Discussed in https://core.trac.wordpress.org/ticket/61348
Follow-up to [58304].
Props dmsnell, jonsurrell, gziolo.
See #61348.
git-svn-id: https://develop.svn.wordpress.org/trunk@58558 602fd350-edb4-49c9-b593-d223f7449a82
The code tag had a formatting issue where it was showing outside of the section area. This resolves it in both themes.
Props ravipatel, SergeyBiryukov, poena, sabernhardt, peterwilsoncc.
Fixes#52780.
git-svn-id: https://develop.svn.wordpress.org/trunk@58557 602fd350-edb4-49c9-b593-d223f7449a82
The button block padding was not the same in the editor and front. This resolves that issue with the font size having being resolved in a previous ticket.
Props pitamdey, sabernhardt.
Fixes#61235.
git-svn-id: https://develop.svn.wordpress.org/trunk@58556 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that not only the return values match the expected results, but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
Follow-up to [55959], [55986], [57547], [57716], [58244], [58422].
See #60706.
git-svn-id: https://develop.svn.wordpress.org/trunk@58478 602fd350-edb4-49c9-b593-d223f7449a82
When a border color and width was added to the pullquote block but no border style was chosen the border was not visible. The expectation is that the border has a solid style by default when a color is selected.
Props pranitdugad, poena, sabernhardt.
Fixes#61362.
git-svn-id: https://develop.svn.wordpress.org/trunk@58469 602fd350-edb4-49c9-b593-d223f7449a82
The aubergine header causes issues when a block can change the page height. This resolves that swapping to clamp.
Props annezazu, sabernhardt, mikachan.
Fixes#58475.
git-svn-id: https://develop.svn.wordpress.org/trunk@58467 602fd350-edb4-49c9-b593-d223f7449a82
These changes involve:
- Move shared variation definitions from styles.blocks.variations to styles.variations
- Remove blockTypes from styles.variations.
- Do not register shared variations from theme style variation or primary theme.json files.
- Move the merging of theme.json data into the WP_Theme_JSON_Resolver and WP_Theme_JSON classes.
These changes improve performance and are more future-proof API wise.
See conversation at https://github.com/WordPress/gutenberg/issues/62686
Props aaronrobertshaw, oandregal, andrewserong, joemcgill, talldanwp, andrewserong, ramonopoly, richtabor, youknowriad.
See #61312, #61451.
git-svn-id: https://develop.svn.wordpress.org/trunk@58466 602fd350-edb4-49c9-b593-d223f7449a82
The font size was different in the last comments block depending on if it was in the editor or front. This resolves that by checking block for special font size before applying default and using inherit for nested elements.
Props pitamdey, sabernhardt.
Fixes#61082.
git-svn-id: https://develop.svn.wordpress.org/trunk@58464 602fd350-edb4-49c9-b593-d223f7449a82
In the page list block the text decoration was not the same on the front as the editor. This adds underline to links when in the post editor classic or block. This does not resolve the font size issue that needs to be fixed in block editor reset styles.
Props viralsampat, sabernhardt.
Fixes#61441.
git-svn-id: https://develop.svn.wordpress.org/trunk@58463 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that not only the return values match the expected results, but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
Follow-up to [56058].
See #60705.
git-svn-id: https://develop.svn.wordpress.org/trunk@58462 602fd350-edb4-49c9-b593-d223f7449a82
The calendar header block cells were not centered. This resolves that both in front and back.
Props nkeller15, sabernhardt, shailu25.
Fixes#58547.
git-svn-id: https://develop.svn.wordpress.org/trunk@58461 602fd350-edb4-49c9-b593-d223f7449a82
This brings more consistency with the other files having the same pattern:
* `wp-admin/moderation.php`
* `wp-admin/ms-admin.php`
* `wp-admin/ms-edit.php`
* `wp-admin/ms-sites.php`
* `wp-admin/ms-themes.php`
* `wp-admin/ms-upgrade-network.php`
* `wp-admin/ms-users.php`
Follow-up to [15481], [16847].
Props jigar-bhanushali, jorbin, johnbillion, Presskopp, rajinsharwar, audrasjb, SergeyBiryukov.
Fixes#60926.
git-svn-id: https://develop.svn.wordpress.org/trunk@58460 602fd350-edb4-49c9-b593-d223f7449a82
This changeset removes text strings from the query pagination block that are not translatable without adding them to patterns.
This means that the texts now use the default translation for the block from WordPress, not the theme. The archive, search and home templates now match the text in the query pagination in the index template.
Props poena.
Fixes#60298.
git-svn-id: https://develop.svn.wordpress.org/trunk@58459 602fd350-edb4-49c9-b593-d223f7449a82
Cast crop values to integers to prevent PHP error caused by implicit conversion from `float` to `int` values when cropping images using ImageMagick.
Props skithund, mai21, nicomollet, amanias1977, joedolson.
Fixes#59782.
git-svn-id: https://develop.svn.wordpress.org/trunk@58457 602fd350-edb4-49c9-b593-d223f7449a82
The admin image editor crop function introduced rounding errors by using a scaled image to calculate values. Fix uses the image at 100% scale for calculations. Also avoid recalculating selection when the selection position is changed, and prevent incorrect values after scaling or restoration.
Props Jossnaz, johnillo, shailu25, rachelbaker, sudipatel007, joedolson.
Fixes#32282.
git-svn-id: https://develop.svn.wordpress.org/trunk@58456 602fd350-edb4-49c9-b593-d223f7449a82
Add the attribute `role="alert"` on 12 instances of admin notices that are injected into the DOM using JavaScript. The `role="alert"` attribute allows screen readers to recognize the addition to the DOM and announce the errors to users.
Props afercia, cyrus11, rcreators, joedolson.
Fixes#47111.
git-svn-id: https://develop.svn.wordpress.org/trunk@58455 602fd350-edb4-49c9-b593-d223f7449a82
Document each element within the filter parameter `$clauses` associative array structure for the `'comments_clauses'`, `'networks_clauses'`, and `'sites_clauses'` filters.
This change:
* Brings consistency amongst the `WP_[*_]Query` filters.
* Helps to improve understanding.
* Helps to avoid confusion of the purpose for `pieces` and `clauses`.
Follow-up to [53376], [53375], [52974].
Props david.binda, audrasjb, hellofromTonya, ironprogrammer, johnbillion, oglekler, SergeyBiryukov.
Fixes#61307.
git-svn-id: https://develop.svn.wordpress.org/trunk@58454 602fd350-edb4-49c9-b593-d223f7449a82
The pullquote block was ignoring font weight and style settings. This now brings in a fix using inherit.
Props nidhidhandhukiya, desrosj, sabernhardt.
Fixes#56695.
git-svn-id: https://develop.svn.wordpress.org/trunk@58453 602fd350-edb4-49c9-b593-d223f7449a82
Adds template and template_lock property of the post type to post types REST API endpoint.
This change allows us to fix a bug where the template of a page is not respected when creating a new page on the site editor.
Props jorgefilipecosta, oandregal, timothyblynjacobs, mukesh27.
Fixes#61477.
git-svn-id: https://develop.svn.wordpress.org/trunk@58452 602fd350-edb4-49c9-b593-d223f7449a82
This adds in a useful file to know how to compiled this theme. As there was previously a contributing file with instruction on this in the GitHub repo that was not brought into svn, this fixes that.
Props kjeller, nielslange, sabernahardt.
Fixes#46108.
git-svn-id: https://develop.svn.wordpress.org/trunk@58451 602fd350-edb4-49c9-b593-d223f7449a82
Set `aria-modal` and `aria-hidden` attributes when the Classic Editor link inserter modal is active, so that content behind the modal will be properly treated as inert when interacting with the modal.
Props lyonmuller, jwgoedert, sabernhardt, alexstine, afercia, rajinsharwar, rcreators, audrasjb, hmbashar, joedolson.
Fixes#60799.
git-svn-id: https://develop.svn.wordpress.org/trunk@58450 602fd350-edb4-49c9-b593-d223f7449a82
Update behavior of admin menu so that the `aria-haspopup` attribute is only applied in responsive mode, when there is a popup behavior present. Add `aria-expanded` attributes to report current popup state.
Props afercia, khokansardar, ryokuhi, joedolson.
Fixes#43095.
git-svn-id: https://develop.svn.wordpress.org/trunk@58449 602fd350-edb4-49c9-b593-d223f7449a82
Match the naming behavior for uploaded media in the REST API to the way media is named when uploading in the media library. Fix an issue where dashes were replacing spaces unnecessarily.
Props abitofmind, kadamwhite, spacedmonkey, adamsilverstein, audrasjb, hellofromTonya.
Fixes#57957.
git-svn-id: https://develop.svn.wordpress.org/trunk@58447 602fd350-edb4-49c9-b593-d223f7449a82
This replaces an erroneous `printf()` call with `sprintf()` that was missed when updating this fragment to use `wp_admin_notice()`.
Follow-up to [56571].
Props wojtekn, sabernhardt, rajinsharwar.
Fixes#61465.
git-svn-id: https://develop.svn.wordpress.org/trunk@58446 602fd350-edb4-49c9-b593-d223f7449a82
Updates the root padding CSS selectors so direct children of full width container blocks with flow layout receive padding.
Props isabel_brison, aaronrobertshaw.
Fixes#61464.
git-svn-id: https://develop.svn.wordpress.org/trunk@58444 602fd350-edb4-49c9-b593-d223f7449a82
This checks that objects returned from any of the `wp_theme_json_data_` filters are `WP_Theme_JSON_Data` objects in order to avoid incompatibilities. Otherwise, reprocess the theme.json data as new `WP_Theme_JSON` objects to ensure the data matches the expectations of code consuming that data.
Follow-up to [58185].
Props joemcgill, adamsilverstein, oandregal, ryelle, ocean90, pbearne.
See #61112.
git-svn-id: https://develop.svn.wordpress.org/trunk@58443 602fd350-edb4-49c9-b593-d223f7449a82
This further reduces image size by ~1.5 KB after running `npm run grunt precommit:image`.
Follow-up to [38833], [57322].
See #58996.
git-svn-id: https://develop.svn.wordpress.org/trunk@58442 602fd350-edb4-49c9-b593-d223f7449a82
Adds a `role="group"` to the WordPress admin bar menu list items to fix the following accessibility issue:
{{{
Elements with an ARIA [role] that require children to contain a specific [role] are missing some or all of those required children.
}}}
Reference:
* [https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/group_role ARIA: group role] via mdn web docs
Follow-up to [42128], [21193], [19558].
Props heinperu, joedolson, krupajnanda, rajinsharwar, rcreators, sabernhardt.
Fixes#60919.
git-svn-id: https://develop.svn.wordpress.org/trunk@58438 602fd350-edb4-49c9-b593-d223f7449a82
Fixes a PHP 8.1 and above "null to non-nullable" deprecation notice in `get_available_post_mime_types()`:
{{{
Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in ./wp-includes/post.php on line 3395
}}}
[https://developer.wordpress.org/reference/functions/get_available_post_mime_types/#return This function is documented] to:
* Return `An array of MIME types.`
* as an array of `string`s, i.e. `string[]`.
A `null` or empty element within the returned array is not a valid MIME type. If a `null` exists in the returned array, it is the root cause of PHP throwing the deprecation notice.
This commit removes the `null` and empty elements from the returned array of MIME types. It also adds a unit test.
Follow-up to [56623], [56452].
Props nosilver4u, jrf, ironprogrammer, antpb, antonvlasenko, rajinsharwar, hellofromTonya.
Fixes#59195.
git-svn-id: https://develop.svn.wordpress.org/trunk@58437 602fd350-edb4-49c9-b593-d223f7449a82
