33098 Commits

Author SHA1 Message Date
Jonathan Desrosiers
20605ba1f5 Build/Test Tools: Backport GitHub Action and build improvements to the 4.4 branch.
This backports several build and test tool improvements to the 4.4 branch. Most notably, this includes:

- The changes required to allow each workflow to be triggered by the `workflow_dispatch` event so that tests can be run on a schedule [50590].
- Splitting single site and multisite tests into parallel jobs [50379].
- Split slow tests into separate, parallel jobs for PHP <= 5.6 [50444].
- Better branch and path scoping for GitHub Action workflows when running on `pull_request` [50432,50479].
- Several `devDependency` updates.

Merges [50379,50387,50416,50432,50435,50436,50444,50446,50473,50474,50476,50479,50485,50486,50487,50545,50579,50590] to the 4.4 branch.
See #50401, #51801, #51802, #52548, #52612, #52624, #52625, #52645, #52653, #52658, #52660, #52667.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50639 602fd350-edb4-49c9-b593-d223f7449a82
2021-04-02 15:42:33 +00:00
Jonathan Desrosiers
2616b2a166 Build/Test Tools: Remove unused test groups from the 4.4 branch.
Follow up to [50314].

See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50328 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 21:06:08 +00:00
Jonathan Desrosiers
751caec44f Build/Test Tools: Add an object cache drop-in to the 4.4 branch.
This adds an object cache drop-in to the `tests/phpunit/includes` directory to avoid relying on and having to copy from an external repository.

It also removes a stray character that was mistakenly included in [50210].

Follow up to [50210], [50314].

Unprops desrosj.
See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50316 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 20:17:51 +00:00
Jonathan Desrosiers
fe3cd1b18e Build/Test Tools: Restore automated testing in the 4.4 branch.
This commit merges the workflow files required to run automated testing on GitHub Actions.

In addition, [49836] and [50285] have been included in order to keep the local Docker environment consistent across all branches.

Merges [49162,49168-49169,49175,49204,49227-49228,49244,49369,49371,49548,49781-49784,49786,49836,49938,50268,50285,50298] to the 4.4 branch.
See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50314 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 20:03:12 +00:00
Jonathan Desrosiers
3945f09461 Build/Test Tools: Backport the local Docker environment to the 4.4 branch.
This commit introduces the Docker-based local WordPress development environment to the 4.4 branch.

Merges [44176,45445,45745,45762,45783-45784,45800,45819,45885,46320,46999,47225,47912,48121,49267,49335,49358,49360,49362] to the 4.4 branch.
See #48301, #47767.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50244 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 20:51:48 +00:00
Jonathan Desrosiers
ee46d1a053 Build/Test Tools: Ignore patch related files, so they can't be accidentally committed.
Merges [39360-39361] to the 4.4 branch.
See #38727.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50211 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-05 04:23:31 +00:00
Jonathan Desrosiers
f2700994d7 Build/Test Tools: Support NodeJS 14.x in the 4.4 branch.
This updates the 4.4 branch to support the latest LTS version of NodeJS (currently 14.x), allowing the same version to be used across all WordPress branches that receive security updates as a courtesy.

Because older branches use (really) old versions of NodeJS, the local Docker environment cannot be backported since the needed dependencies will not run on these older versions (see #48301). This also blocks the ability to move automated testing over to GitHub Actions (see #50401).

This also replaces the `npm-shrinkwrap.json` with a `package-lock.json` file. Lock files were not supported in earlier versions of NPM, but can now be used.

In addition to backporting the package updates that happened after branching 4.4, dependencies that were removed in future releases have also been updated to their latest versions.

Props desrosj, dd32, netweb, jorbin.
Merges [35859,35862,36860-36865,36935,36978-36979,37017,37019-37020,37212,37612,38111,38688,39110,39113-39119,39478,42460-42461,42463,42887,43320,43323,43977,44219,44233,44728,45321,45765,46404,46408-46409,47404,47867-47869,47872-47873,48705,49636,49933,49937,49939,50017,50126,50176,50185,50192] to the 4.4 branch.
See #52341.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50210 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-05 04:22:23 +00:00
Sergey Biryukov
12bc77d2fb Tests: Move skipTestOnTimeout() to a more appropriate location, for consistency with other branches.
Follow-up to [50088].

Merges [50097] to the 4.4 branch.
See #51669.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50100 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-30 15:26:59 +00:00
Sergey Biryukov
6307192834 Tests: Use skipTestOnTimeout() in more HTTP tests.
Adjust it to handle more types of timeouts, e.g. "Resolving timed out", "Connection timed out".

Merges [38757], [43511], [43512], [46682], [46996] to the 4.4 branch.
See #51669.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50091 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-30 12:08:49 +00:00
Jonathan Desrosiers
32ef684c83 Build/Test Tools: Correct JavaScript files in the 4.4 branch.
In [46498], some JavaScript files were unintentionally changed. This restores those files to their correct state.

Partially reverts [46498].
See #52367.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@50018 602fd350-edb4-49c9-b593-d223f7449a82
2021-01-25 20:14:35 +00:00
Jonathan Desrosiers
2cf786fa3f Build/Test Tools: Remove the TravisCI configuration file.
In [49162], GitHub Action workflow configuration files were introduced to run all of Core’s automated testing with the intent to fully transition after some time was allowed for testing.

After two full months of testing, the time to finish this transition has come.

We thank TravisCI for testing the codebase through nearly 20 major and many more minor releases.

Merges [49876] to the 4.4 branch.
See #52161. See #50401.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@49889 602fd350-edb4-49c9-b593-d223f7449a82
2020-12-22 21:11:17 +00:00
Jake Spurlock
96b267f5de Build/Test Tools: Match .nvmrc with the declared node engine.
Let's match up the versions from package.json, .travis.yml and .nvmrc.

This brings the changes from [49653] to the 4.4 branch.

Fixes #51682.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@49659 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 23:04:45 +00:00
Jonathan Desrosiers
e9c5dad752 WordPress 4.4.24.
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@49420 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 19:34:08 +00:00
Jake Spurlock
5475e9efc5 General: WordPress updates
* XML-RPC: Improve error messages for unprivileged users.
* External Libraries: Disable deserialization in Requests_Utility_FilteredIterator
* Embeds: Disable embeds on deactivated Multisite sites.
* Coding standards: Modify escaping functions to avoid potential false positives.
* XML-RPC: Return error message if attachment ID is incorrect.
* Upgrade/install: Improve logic check when determining installation status.
* Meta: Sanitize meta key before checking protection status.
* Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.

Brings the changes from [49380,49382-49388] to the 4.4 branch.

Props xknown, zieladam, peterwilsoncc, whyisjake, desrosj, dd32.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@49402 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 19:04:00 +00:00
Sergey Biryukov
503e47fcd8 Administration: Pass the result of set-screen-option filter to the new set_screen_option_{$option} filter to ensure backward compatibility.
Rename the `$keep` parameter of both filters to `$screen_option` for clarity, update the documentation to better reflect its purpose.

Follow-up to [47951].

Props Chouby, sswells, SergeyBiryukov.
Merges [48241] to the 4.4 branch.
Fixes #50392.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@48254 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-01 09:49:59 +00:00
Sergey Biryukov
b73782c487 Build/Test Tools: Bump grunt-contrib-qunit ~0.7.0 → ~1.1.0.
Merges [37020] to the 4.4 branch.
Fixes #50371. See #35104.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@48030 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-12 10:53:09 +00:00
Jonathan Desrosiers
bce9bd3287 WordPress 4.4.23.
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@47999 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 21:32:44 +00:00
Jake Spurlock
b81697a8a9 General: Backport several commits for release.
- Embeds: Ensure that the title attribute is set correctly on embeds.
- Editor: Prevent HTML decoding on by setting the proper editor context.
- Formatting: Ensure that wp_validate_redirect() sanitizes a wider variety of characters.
- Themes: Ensure a broken theme name is returned properly.
- Administration: Add a new filter to extend set-screen-option.
Merges [47947-47951] to the 4.4 branch.
Props xknown, sstoqnov, vortfu, SergeyBiryukov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@47972 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 18:37:42 +00:00
Jonathan Desrosiers
37fc72342b Update the About page for WordPress 4.4.22
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@47694 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 18:30:26 +00:00
Jonathan Desrosiers
c9aa4002b5 WordPress 4.4.22
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@47676 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 17:56:38 +00:00
Jake Spurlock
63cc1a6ee9 User: Invalidate user_activation_key on password update.
Query: Ensure that only a single post can be returned on date/time based queries.
Cache API: Ensure proper escaping around the stats method in the cache API.
Formatting: Expand `sanitize_file_name` to have better support for utf8 characters.

Brings the changes in [47634], [47635], [47637], and [47638] to the 4.4 branch.

Props: batmoo, ehti, nickdaugherty, peterwilsoncc, sergeybiryukov, sstoqnov, westi, whyisjake, whyisjake, xknown.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@47653 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 16:38:31 +00:00
Sergey Biryukov
69cacb4930 Build/Test Tools: Remove unused ::assertPostHasTerms() method from tests/term.php.
The associated test was removed in [30241].

Merges [47341] to 3.7+ branches.
See #49485.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@47489 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 14:29:03 +00:00
Sergey Biryukov
6ee70aa119 Embeds: Remove the external oEmbed tests for YouTube.
These tests no longer test anything that WordPress core has control over. YouTube now serves everything
over HTTPS by default, so the tests for #23149 will always pass, and the tests for #32714 aren't testing
anything that core has control over.

Tests for the responses from oEmbed providers has been attempted and reverted in #32360.

Props johnbillion.
Merges [41712] to the 4.4 branch.
See #42076, #32714, #23149.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@47483 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 13:57:09 +00:00
Sergey Biryukov
bf7be91b55 WordPress 4.4.21
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@46929 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 20:30:15 +00:00
Sergey Biryukov
c8a62fa989 Update wp_kses_bad_protocol() to recognize &colon; on uri attributes,
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Brings r46895 to the 4.4 branch.

Props: xknown, nickdaugherty, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@46912 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 18:43:41 +00:00
Jonathan Desrosiers
643499167c WordPress 4.4.20.
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@46516 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 20:11:31 +00:00
Jake Spurlock
3f12403dc8 Backporting several bug fixes.
- Query: Remove the static query property.
- HTTP API: Protect against hex interpretation.
- Filesystem API: Prevent directory travelersals when creating new folders.
- Administration: Ensure that admin referer nonce is valid.
- REST API: Send a Vary: Origin header on GET requests.
- Customizer: Properly sanitize background images.

Backports [46474], [46475], [46476], [46477], [46478], [46483], [46485] to the 4.4 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@46498 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 19:08:52 +00:00
Jake Spurlock
8ea3a07039 Add .nvmrc files to older versions of WordPress
When jumping between branches, it would be nice to have the correct node version for the older versions of WordPress. Let's add .nvmrc files to these older branches for the supported versions.

Merges [46295] to the 4.4 branch.

Fixes #48140


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@46300 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-25 21:00:04 +00:00
Jonathan Desrosiers
91d2bb20ae WordPress 4.4.19.
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@46038 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 21:20:31 +00:00
Jonathan Desrosiers
06968503f3 Fix for URL sanitization in wp_kses_bad_protocol_once().
Merges [45997] to the 4.4 branch.

Props irsdl, sstoqnov, whyisjake.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@46010 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 18:23:17 +00:00
Sergey Biryukov
fcffda2869 Improve handling the existing rel attribute in wp_rel_nofollow_callback().
Merges [45990] to the 4.4 branch.
Props xknown, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@46001 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:56:42 +00:00
Sergey Biryukov
5182bb6ff0 Improve URL validation in wp_validate_redirect().
Merges [45971] to the 4.4 branch.
Props vortfu, whyisjake, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@45981 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:12:11 +00:00
Jake Spurlock
dc2184e9b2 Remove _convert_urlencoded_to_entities() from the get_the_content() callback.
Merges [45937] to the 4.4 branch.

Props vortfu, whyisjake, peterwilsoncc


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@45958 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:38:59 +00:00
Sergey Biryukov
c82c7fb8b6 Escape the output in wp_ajax_upload_attachment().
Merges [45936] to the 4.4 branch.
Props whyisjake, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@45951 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:36:13 +00:00
John Blackbourn
52eb3fbe3a Build/Test tools: Backport the fixed tests for wp_normalize_path() from the 4.5 branch into 4.4.
See #35996


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@45012 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-25 17:07:12 +00:00
John Blackbourn
25f1e5c54f Build/Test tools: Further trimming of CI jobs on the 4.4 branch.
This removes the PHP 5.6 job which runs without an object cache in place as the likelihood of a change being backported that only breaks 5.6 environments without an object cache is small.

Merges [45010] into the 4.4 branch.

See #42387


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@45011 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-25 16:30:14 +00:00
John Blackbourn
6df4a18fee Build/Test tools: Switch npm dependency caching strategy on Travis CI.
This switches to caching npm's local cache instead of `node_modules` in order to prevent issues caused by modules compiled using a different version of node.

Merges [44993] into the 4.4 branch.

See #46632


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@45001 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-25 00:58:34 +00:00
Gary Pendergast
5eac5cb951 WordPress 4.4.18
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@44878 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-13 01:30:17 +00:00
Sergey Biryukov
1600e3f6da Comments: Improve comment content filtering.
Merges [44842] to the 4.4 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@44850 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:39:12 +00:00
Sergey Biryukov
b7387dfa26 Formatting: Improve rel="nofollow" handling in comments.
Merges [44833] to the 4.4 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.4@44841 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:26:13 +00:00
Jeremy Felt
b9e2bd5a8b Bump 4.4 branch to version 4.4.17.
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@44083 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 02:12:52 +00:00
Gary Pendergast
c89bb38b9d Editor: Remove unwanted fields before saving posts.
The `meta_input`, `file`, and `guid` fields are not intended to be updated through user input.

Merges [44047] to the 4.4 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.4@44062 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:48:36 +00:00
Peter Wilson
d93e052b68 Multisite: Validate activation links.
Merges [44048] to the 4.4 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@44061 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:46:24 +00:00
Ian Dunn
0569f5592a KSES: Make the URI attributes DRY.
This commit introduces the `wp_kses_uri_attributes` function and filter. The function centralizes the list of attributes, in order to prevent inconsistency, and the filter provides a way for plugins to customize the attributes.

Merges [44014] and [44017] to the `4.4` branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@44035 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 00:58:21 +00:00
Peter Wilson
82651e0340 Multisite: Improve messaging for previously activated users.
Ensure activation of a site is not attempted multiple times and users are shown the correct message if they follow the link a second time.

Merges [44021] to the 4.4 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@44030 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 00:49:34 +00:00
Gary Pendergast
290e58884b KSES: Conditionally remove the <form> element from $allowedposttags.
To avoid backwards compatibility issues, `<form>` is re-added if a custom filter has added the `<input>` or `<select>` elements to `$allowedposttags`.

Merges [43994] to the 4.4 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.4@44003 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:35:11 +00:00
Jeremy Felt
5fa5872aa5 Media: Improve verification of MIME file types.
Merges [43988] to the 4.4 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@43995 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:13:21 +00:00
Aaron D. Campbell
e66ccb02cd Bump 4.4 branch to version 4.4.16
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@43412 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 16:10:39 +00:00
John Blackbourn
3c2dcf0021 Media: Limit thumbnail file deletions to the same directory as the original file.
Merges [43393] into the 4.4 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@43398 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 14:56:26 +00:00
Aaron D. Campbell
39ae3931f2 Bump 4.4 branch to version 4.4.15
git-svn-id: https://develop.svn.wordpress.org/branches/4.4@42938 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 20:27:28 +00:00