While `loading=“eager”` is a supported alternative to omitting the attribute entirely, browsers follow the value of this attribute explicitly when specified.
Specifying `eager` would prevent the user from receiving any additional potential benefits implemented at the browser level, such as further mechanisms to automatically decide which elements to lazy-load.
Props flixos90, ryelle, poena.
Merges [49860] to the 5.6 branch.
Fixes#52139.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49861 602fd350-edb4-49c9-b593-d223f7449a82
This adds some JavaScript to detect when an anchor link is clicked within the primary navigation on mobile devices and closes the menu before scrolling to the location on the page.
Props poena, macmanx, t-p.
Merges [49854] to the 5.6 branch.
Fixes#52006.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49855 602fd350-edb4-49c9-b593-d223f7449a82
This change ensures that the primary text color specific to Dark Mode is used instead of the one specified for normal mode. The latter is not legible in Dark Mode.
Props slaFFik, poena, mukesh27, justinahinon.
Merges [49825] to the 5.6 branch.
Fixes#51985.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49852 602fd350-edb4-49c9-b593-d223f7449a82
This fixes an issue where `<iframe>` embeds were being pushed to the side of the screen and compressed to the point of being unusable.
Props helen, mukesh27, poena, thorlentz.
Merges [49823] to the 5.6 branch.
Fixes#52004.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49851 602fd350-edb4-49c9-b593-d223f7449a82
Previously, `1.0.0` was used for the version. This is inconsistent with the versioning used in the other default themes, which use use X.X and not X.X.X.
This change corrects all `1.0.0` occurrences to `1.0`, and adds the additional context of `Twenty Twenty-One` to avoid confusion with `WordPress 1.0`.
Props SergeyBiryukov, poena.
Merges [49826] to the 5.6 branch.
Fixes#51958.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49829 602fd350-edb4-49c9-b593-d223f7449a82
The block patterns were added in #51099, but the images were not included in the commit. This adds the images to the expected folder.
Props transl8or, mukesh27, ryelle.
Merges [49793] to the 5.6 branch.
Fixes#51996.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49828 602fd350-edb4-49c9-b593-d223f7449a82
Twenty Twenty-One uses PostCSS to convert the custom properties for Internet Explorer. Without a config file, the postcss command does nothing, causing issues in IE. This brings back the config from GitHub, which replaces all custom properties with the default values.
Props t-p, poena, ryelle.
Merges [49800] to the 5.6 branch.
Fixes#52040.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49824 602fd350-edb4-49c9-b593-d223f7449a82
Make both instances of the link translatable, for consistency.
Props engahmeds3ed, justinahinon.
Merges [49798] to the 5.6 branch.
Fixes#52010.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49819 602fd350-edb4-49c9-b593-d223f7449a82
Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.
[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.
Props ayeshrajans.
Merges [49779] to the 5.6 branch.
See #51968.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49809 602fd350-edb4-49c9-b593-d223f7449a82
When SimplePie parses HTTP headers, it combines multiple values for the same header into a comma-separated string. `WP_SimplePie_File` overrides the parsing, but was leaving them as an array instead.
That lead to a fatal error in PHP 8, because other parts of the codebase ended up passing an array to a function that expected a string.
Props david.binda, litemotiv, inc2734, NicolasKulka, hellofromTonya, mbabker, skithund, SergeyBiryukov, desrosj, timothyblynjacobs.
Reviewed by SergeyBiryukov, iandunn.
Merges [49803] and [49805] to the 5.6 branch.
Fixes#51056. See #51956.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49806 602fd350-edb4-49c9-b593-d223f7449a82
Whether App Passwords are being used is a global featurel, not a per-network feature. This fixes issues on Multi Network installs if App Passwords are used on a different network from where they were created.
Props spacedmonkey.
Fixes#51939.
See [49752].
Merges [49764] to the 5.6 branch.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49765 602fd350-edb4-49c9-b593-d223f7449a82
The main element must not appear as a descendant of the section element. Correct markup is the first requirement to make user agents and assistive technologies work properly.
Changes the <section> element that was wrapping the <main> element to a <div>.
Follow-up to [45942] for Twenty Nineteen.
Props albertomake, poena.
Reviewed by SergeyBiryukov, peterwilsoncc.
Merges [49759] to the 5.6 branch.
Fixes#51944.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49760 602fd350-edb4-49c9-b593-d223f7449a82
Application Passwords uses Basic Authentication to transfer authentication details. If the site is already using Basic Auth, for instance to implement a private staging environment, then the REST API will treat this as an authentication attempt and would end up generating an error for any REST API request.
Now, Application Password authentication will only be attempted if Application Passwords is in use by a site. This is flagged by setting an option whenever an Application Password is created. An upgrade routine is added to set this option if any App Passwords already exist.
Lastly, creating an Application Password will be prevented if the site appears to already be using Basic Authentication.
Props chexwarrior, georgestephanis, adamsilverstein, helen, Clorith, marybaum, TimothyBlynJacobs.
Reviewed by TimothyBlynJacobs, helen.
Merges [49752] to the 5.6 branch.
Fixes#51939.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49754 602fd350-edb4-49c9-b593-d223f7449a82
This avoids an error on PHP 8 caused by calling `wp_imagecreatetruecolor()` with inputs that aren't numeric, or are less than 0.
Props hellofromtonya, Boniu91, metalandcoffee, SergeyBiryukov.
Reviewed by SergeyBiryukov, iandunn.
Merges [49751] to the 5.6 branch.
Fixes#51937.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49753 602fd350-edb4-49c9-b593-d223f7449a82
The `date_i18n` function is now used when formatting the dates in PHP instead of `gmdate` which doesn't handle localization properly.
Additionally, we now use a translation to get the date format to use instead of pulling from the `date_format` option which is only supposed to affect the front-end.
Lastly, when passing the date format to the Backbone JS template, we now use `wp_json_encode()` to format the value for JavaScript. This ensures that backslashes are properly preserved which are used by some locales to escape date formatting control characters.
Props pedromendonca, TimothyBlynJacobs, ocean90, hellofromtonya, SergeyBiryukov, antpb.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [49746] to the 5.6 branch.
Fixes#51918.
See [35811].
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49747 602fd350-edb4-49c9-b593-d223f7449a82
r49212 greatly improved the performance of `get_dirsize()`, but also changed the structure of the data stored in the `dirsize_cache` transient. It stored relative paths instead of absolute ones, and also removed the unnecessary `size` array.
That difference in data structures led to a fatal error in the following environment:
* PHP 8
* Multisite
* A custom `WP_CONTENT_DIR` which is not a child of WP's `ABSPATH` folder (e.g., [https://roots.io/bedrock/ Bedrock])
* The `upload_space_check_disabled` option set to `0`
After upgrading to WP 5.6, the `dirsize_cache` transient still had data in the old format. When `wp-admin.php/index.php` was visited, `get_space_used()` received an `array` instead of an `int`, and tried to divide it by another `int`. PHP 7 would silently cast the arguments to match data types, but [https://wiki.php.net/rfc/arithmetic_operator_type_checks PHP 8 throws a fatal error]:
`Uncaught TypeError: Unsupported operand types: array / int`
`recurse_dirsize()` was using `ABSPATH` to convert the absolute paths to relative ones, but some upload locations are not located under `ABSPATH`. In those cases, `$directory` and `$cache_path` were identical, and that triggered the early return of the old `array`, instead of the expected `int`.
In order to avoid that, this commit restores the absolute paths, but without the `size` array. It also adds a type check when returning cached values. Using absolute paths without `size` has the result of overwriting the old data, so that it matches the new format. The type check and upgrade routine are additional safety measures.
Props peterwilsoncc, janthiel, helen, hellofromtonya, francina, pbiron.
Reviewed by SergeyBiryukov, iandunn.
Merges [49744] to the 5.6 branch.
Fixes#51913. See #19879.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49745 602fd350-edb4-49c9-b593-d223f7449a82
This brings some consistency with the same check in `core_upgrade_preamble()` and avoids a PHP warning if `$cur->version` is not set.
Additionally, remove the check for `$cur->url` property, unused since [8595].
Follow-up to [49708], [49709].
Props pbiron, afragen, audrasjb.
Reviewed by azaozz, SergeyBiryukov.
Merges [49736] to the 5.6 branch.
Fixes#51892.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49743 602fd350-edb4-49c9-b593-d223f7449a82
Previously we returned a `WP_Error` instance saying that the password was not found which is inaccurate.
Props dlh.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [49739] to the 5.6 branch.
Fixes#51922.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49740 602fd350-edb4-49c9-b593-d223f7449a82
@wordpress/components: 11.1.2 -> 11.1.3
This fixes an accessibility regression with VoiceOver not announcing the input label or an existing selection in the parent page dropdown under "Page Attributes" in the sidebar.
See https://github.com/WordPress/gutenberg/pull/27431 for more details.
Props isabel_brison, sarahricker, alexstine, kevin940726, talldanwp.
Reviewed by isabel_brison, SergeyBiryukov.
Merges [49737] to the 5.6 branch.
Fixes#51923.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49738 602fd350-edb4-49c9-b593-d223f7449a82
This enables, for example, the previous post status to be used by this hook without the need to first capture it on an earlier hook.
This also fixes the value of the `$fire_after_hooks` parameter in `get_default_post_to_edit()` so the `wp_after_insert_post` action correctly fires just once on the new post screen.
This merges [45114] into the 5.6 branch
See #45114
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49732 602fd350-edb4-49c9-b593-d223f7449a82
This avoids a misleading failure due to Unix vs. Windows EOL style mismatches and allows the test to pass on Windows.
Follow-up to [46612], [49190].
Reviewed by desrosj, SergeyBiryukov.
Merges [49691] to the 5.6 branch.
Fixes#19278.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49730 602fd350-edb4-49c9-b593-d223f7449a82
This will be the final sync from GitHub before placing that repository into read-only mode. All further changes should now flow entirely through Trac.
For a full list of changes since [49633], see 1d5a895...53acd9b.
Props poena, luminuu, kjellr, ryelle, allancole, melchoyce, felipeelia, aljullu, kebbet, chaton666, Clorith, mkaz, ingereck, paaljoachim.
Reviewed by desrosj, SergeyBiryukov.
Merges [49726] to the 5.6 branch.
Fixes#51526.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49728 602fd350-edb4-49c9-b593-d223f7449a82
The REST API requests in Site Health and App Passwords now include `_locale=user` in the request URL to ensure the user's locale is used instead of the site locale. Additionally, the `apiRequest` library now sends a JSON `Accept` header which is required by `determine_locale()` to respect the `_locale` query parameter.
The Site Health REST API controllers now manually load the default admin textdomain if not `is_admin()`. This allows for the Site Health tests to be translated even though the translations are part of the administration project and the REST API is not.
Props oglekler, kebbet, Clorith, TimothyBlynJacobs, ocean90, SergeyBiryukov, adamsilverstein.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [49716] to the 5.6 branch.
Fixes#51871.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49724 602fd350-edb4-49c9-b593-d223f7449a82
As a best practice, strings available for translation should contain entire sentences whenever possible.
Splitting a sentence in two parts and putting them back together after translation should be avoided, as the word order in other languages can be different from English.
Props tobifjellner, kebbet, audrasjb, mukesh27, hellofromTonya, azaozz, SergeyBiryukov.
Reviewed by azaozz, SergeyBiryukov.
Merges [49722] to the 5.6 branch.
Fixes#51893.
git-svn-id: https://develop.svn.wordpress.org/branches/5.6@49723 602fd350-edb4-49c9-b593-d223f7449a82
