42899 Commits

Author SHA1 Message Date
Andrew Ozz
33c782abeb Upgrade/Install: Ensure the current user can update core when saving the auto-update options.
See #51742.

git-svn-id: https://develop.svn.wordpress.org/trunk@49593 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-13 16:55:48 +00:00
Sergey Biryukov
5fa6731441 Upgrade/Install: Account for the automatic_updater_disabled filter in core auto-update settings UI.
Follow-up to [49587].

Props markparnell, audrasjb.
See #51742.

git-svn-id: https://develop.svn.wordpress.org/trunk@49592 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-13 11:12:55 +00:00
Sergey Biryukov
0d27319c73 I18N: Remove HTML tags from translatable strings on WordPress Updates screen.
Follow-up to [49587].

Props fierevere.
See #51742.

git-svn-id: https://develop.svn.wordpress.org/trunk@49591 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-13 10:48:24 +00:00
Helen Hou-Sandi
3b1a27cfd1 Post-WordPress 5.6 Beta 4 bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@49590 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 23:43:40 +00:00
Helen Hou-Sandi
7f4a7ef5f7 WordPress 5.6 Beta 4, for real.
git-svn-id: https://develop.svn.wordpress.org/trunk@49589 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 23:06:31 +00:00
Helen Hou-Sandi
43a370a723 WordPress 5.6 Beta 4.
git-svn-id: https://develop.svn.wordpress.org/trunk@49588 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 23:00:38 +00:00
Helen Hou-Sandi
9fb87a2d24 Upgrade/Install: Better UI for auto-update settings on update screen.
This adds clearer messages about what your current settings mean for updates, uses a more compact link-based action instead of a checkbox to change the setting, and respects constants and filters.

Props audrasjb, karmatosed, helen, azaozz, hedgefield, marybaum.
Fixes #51742.


git-svn-id: https://develop.svn.wordpress.org/trunk@49587 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 22:35:54 +00:00
Sergey Biryukov
d6fa3df420 Customize: Exclude widget ID attributes from search.
Having search terms match the ID attributes leads to confusing results, specifically when the admin interface is set to a language other than English.

Follow-up to [27650].

Props afercia, dlh, noisysocks.
Fixes #46456.

git-svn-id: https://develop.svn.wordpress.org/trunk@49586 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 22:03:36 +00:00
Sergey Biryukov
e9e2e6fc2c Bundled Themes: Add block-patterns tag to Twenty Nineteen and Twenty Twenty.
Follow-up to [49347], [49348].

See #51098, #51099.

git-svn-id: https://develop.svn.wordpress.org/trunk@49585 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 21:54:59 +00:00
Sergey Biryukov
cb60fe2323 Bundled Themes: Introduce block patterns for Twenty Seventeen.
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena.
Fixes #51100.

git-svn-id: https://develop.svn.wordpress.org/trunk@49584 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 21:20:21 +00:00
Sergey Biryukov
ddc94bc982 Bundled Themes: Introduce block patterns for Twenty Sixteen.
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena, jffng.
Fixes #51101.

git-svn-id: https://develop.svn.wordpress.org/trunk@49583 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 21:12:32 +00:00
Sergey Biryukov
17f7e5fc98 Administration: Make sure auto-update counts properly update when bulk deleting plugins or themes.
Props pbiron, noisysocks, desrosj, audrasjb, hellofromTonya.
Fixes #50870.

git-svn-id: https://develop.svn.wordpress.org/trunk@49582 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:40:13 +00:00
Helen Hou-Sandi
f517634e28 Upgrade/Install: Enable all core autoupdates for new installs.
Likely needs more work for multisite installs.

Reference: https://make.wordpress.org/core/2020/11/10/wp5-6-auto-update-implementation-change/

Props audrasjb, azaozz.
See #51743.


git-svn-id: https://develop.svn.wordpress.org/trunk@49581 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:19:46 +00:00
John Blackbourn
0ad0c55a28 General: Convert wp_array_get() to a "private" function and add tests.
This function may be promoted in the future if it's deemed useful enough.

Props dd32, jorgefilipecosta, Hareesh Pillai

Fixes #51720


git-svn-id: https://develop.svn.wordpress.org/trunk@49580 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:18:08 +00:00
Sergey Biryukov
e0f55936d9 Editor: Update packages.
The following package versions were changed:

@wordpress/block-directory: 1.17.2 -> 1.17.3
@wordpress/block-editor: 5.1.2 -> 5.1.3
@wordpress/block-library: 2.26.2 -> 2.26.3
@wordpress/edit-post: 3.25.2 -> 3.25.3
@wordpress/editor: 9.24.2 -> 9.24.3
@wordpress/format-library: 1.25.2 -> 1.25.3
@wordpress/reusable-blocks: 1.0.2 -> 1.0.3

See https://github.com/WordPress/gutenberg/pull/26874 for the list of fixed bugs.

Props isabel_brison.
Fixes #51696.

git-svn-id: https://develop.svn.wordpress.org/trunk@49579 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 19:34:55 +00:00
Jonathan Desrosiers
4b10e110e0 Twenty Twenty-One: Use consistent casing in strings.
This converts strings using Title Case to sentence case, which is currently preferred for consistency (see discussions on #40244).

Also included is the replacement of an escaped apostrophe with `’`, which is also preferred per the Internationalization guidelines.

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49578 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 19:28:35 +00:00
Jonathan Desrosiers
571d2f0061 Twenty Twenty-One: Ignore the node_modules folder in SVN.
[49576] mistakenly partially reverted [49250].

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49577 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 19:05:40 +00:00
Jonathan Desrosiers
4d21077772 Twenty Twenty-One: Ignore .css.map files.
These are generated when Sass is compiled, but should never be committed.

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49576 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:58:54 +00:00
Jonathan Desrosiers
2d2e1dd4ae Twenty Twenty-One: Convert inline ESLint comments to JSHint.
WordPress Core currently uses JSHint instead of ESlint.

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49575 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:46:44 +00:00
Jonathan Desrosiers
db3ce8f32d Twenty Twenty-One: Merge the latest changes changes from GitHub for Beta 4.
In addition to syncing the latest changes, this change also merges the theme’s `.scss` files and other related build tool configurations required to compile the theme’s CSS.

This will allow development of the theme to continue on Trac after 5.6 is released and the GitHub repository is archived.

For a full list of changes since [], see e7d5991...aa284fd.

Props poena, luminuu kjellr, aristath, justinahinon.
See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49574 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:34:44 +00:00
Timothy Jacobs
1f07e76f46 App Passwords: MOAR accessibility improvements.
Corrects the "Application Name" field's aria-describedby attribute and makes the description visible.

Props alexstine, SergeyBiryukov.
Fixes #51580.


git-svn-id: https://develop.svn.wordpress.org/trunk@49573 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:12:14 +00:00
Sergey Biryukov
5f5c04d46b Database: Clean up the post_category column removed from DB schema for new installations in WordPress 2.8.
Its presence may conflict with `WP_Post::__get()`, which should generally fill the non-existent `post_category` property, but is not triggered if the column exists in the database.

Follow-up to [10895].

Props leogermani, davidbaumwald, hellofromTonya.
Fixes #51288.

git-svn-id: https://develop.svn.wordpress.org/trunk@49572 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 17:53:41 +00:00
Sergey Biryukov
9befeb00cc Build/Test Tools: Only enforce PHP extension requirements when running core tests.
This allows other users of the WordPress unit test suite framework to run their own unit tests without needing the GD extension, which should only be a requirement if running core tests.

Follow-up to [49535].

Props jamescollins.
Fixes #50640.

git-svn-id: https://develop.svn.wordpress.org/trunk@49571 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 17:23:44 +00:00
Sergey Biryukov
f717424287 Build/Tests Tools: Restore [49491], accidentally reverted in [49566].
See #39210.

git-svn-id: https://develop.svn.wordpress.org/trunk@49570 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 17:13:56 +00:00
Sergey Biryukov
fd3ef484ec Build/Tests Tools: Restore [49535], accidentally reverted in [49566].
See #39210.

git-svn-id: https://develop.svn.wordpress.org/trunk@49569 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 17:06:48 +00:00
Anthony Burchell
d70214528e Media: Allow users to switch from media grid to list mode in media library.
Fixes issue where media modal would open when switching from grid to list mode.

Props mista-flo, mukesh27.

Fixes #51396.


git-svn-id: https://develop.svn.wordpress.org/trunk@49568 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 15:44:58 +00:00
Anthony Burchell
4afa79feed Media: Improve count in Media Library pagination.
Deleting all visible items on the last page of the media library previously left a blank page with no media items available. Using `wp_count_attachements` instead of `found_posts` solves the problem.

Props donsony, karmatosed, desrosj, mista-flo, justinahinon.

Fixes #39968.


git-svn-id: https://develop.svn.wordpress.org/trunk@49567 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 15:38:32 +00:00
Dominik Schilling
4006c07417 I18N: Revert [49236] for now to investigate alternative implementations.
See #39210, #51678, #26511.

git-svn-id: https://develop.svn.wordpress.org/trunk@49566 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 14:41:19 +00:00
Sergey Biryukov
e8e031d2dd Feeds: Register transient feed cache handler using the recommended method for SimplePie 1.3 or later.
This fixes a "Non-static method cannot be called statically" fatal error when calling `fetch_feed()` on PHP 8.

Follow-up to [21644], [21652], [22366], [22599].

Props dd32, afragen, Senning, markoheijnen, ComputerGuru, useStrict, Ipstenu, nacin, l3rady, HoaSi, NathanAtmoz, fabifott, jfoulquier, thefarlilacfield, subscriptiongroup, rogerlos, Mte90, mopsyd, dossy, stulab, MadtownLems, roikles, justlevine, joostdevalk, OptimizingMatters, hellofromTonya, bph, ayeshrajans, SergeyBiryukov.
Fixes #29204.

git-svn-id: https://develop.svn.wordpress.org/trunk@49565 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 14:34:33 +00:00
Sergey Biryukov
ea136a3af6 Coding Standards: Pass an empty string instead of null as the $replacement parameter to _deprecated_file().
Follow-up to [48327].

See #50767.

git-svn-id: https://develop.svn.wordpress.org/trunk@49564 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 11:15:49 +00:00
Peter Wilson
8b2aa594e3 Canonical: Prevent ID enumeration of private post slugs.
Add check to `redirect_canonical()` to ensure the destination post is not using a private post status.

Props dd32, Denis-de-Bernardy, donmhico, helen, nacin, peterwilsoncc, pishmishy, TimothyBlynJacobs, tzafrir, Viper007Bond, whyisjake.
Fixes #5272.



git-svn-id: https://develop.svn.wordpress.org/trunk@49563 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 04:14:44 +00:00
Sergey Biryukov
fc29c9e623 I18N: Add trailing punctuation to some translator comments.
Follow-up to [49549].

See #51580.

git-svn-id: https://develop.svn.wordpress.org/trunk@49562 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-11 10:39:52 +00:00
Sergey Biryukov
98e774ee2e Docs: Clarify sprintf() usage for the before_widget argument of register_sidebar().
Follow-up to [49203], [49560].

See #19709.

git-svn-id: https://develop.svn.wordpress.org/trunk@49561 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-11 10:37:33 +00:00
Helen Hou-Sandi
9a14f55ace Widgets: Do not use wrapping container in the admin.
This is due to the new `before|after_sidebar` args, which are empty by default, but can introduce markup that causes admin JS to stop working.

Also adds documentation for the `sprintf()` on `before_sidebar`.

Props audrasjb, lpointet.
See #19709.


git-svn-id: https://develop.svn.wordpress.org/trunk@49560 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 20:38:59 +00:00
Helen Hou-Sandi
2a7d1e2394 Editor: Display short description from block directory in results.
Props dd32, ryelle.
Fixes #51212.


git-svn-id: https://develop.svn.wordpress.org/trunk@49559 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 20:24:38 +00:00
Sergey Biryukov
bde89301fd Help/About: Add Site Health Status dashboard widget to the Help → Content tab.
Reorder the items in the help tab to align with their default position on the Dashboard screen.

Follow-up to [47063], [47300].

Props nlpro.
Fixes #51745.

git-svn-id: https://develop.svn.wordpress.org/trunk@49558 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 19:03:12 +00:00
Sergey Biryukov
4a5c2857da TinyMCE: Update to 4.9.11.
Changelog:
https://www.tiny.cloud/docs-4x/changelog/#version4911july132020
https://github.com/tinymce/tinymce/blob/4.x/changelog.txt

A full list of changes in this update can be found on GitHub:
https://github.com/tinymce/tinymce/compare/4.9.10...4.9.11

See #51051.

git-svn-id: https://develop.svn.wordpress.org/trunk@49557 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 10:42:04 +00:00
Andrew Ozz
60516115ed Tests QUnit: Remove restriction on running the TinyMCE Textpattern WP plugin tests in PhantomJS.
Props @desrosj.
Fixes #42009.

git-svn-id: https://develop.svn.wordpress.org/trunk@49556 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 09:16:53 +00:00
Anthony Burchell
3d583b8c67 Media: Removes duplicate alignment fix for browser uploader.
See #41648


git-svn-id: https://develop.svn.wordpress.org/trunk@49555 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 23:41:01 +00:00
Jonathan Desrosiers
92c6723c24 Tests: Remove duplicate fields key in WP_Query test.
Introduced in [46188].

See #51344.

git-svn-id: https://develop.svn.wordpress.org/trunk@49554 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 23:39:25 +00:00
Anthony Burchell
98a0e0eeed Media: Adjusts alignment of file name text in browser uploader.
Sets a defined size for text alongside the media browser uploader button fixing alignment on popular browsers.

Props krupajnanda, mikeschroder, aaroncampbell, lucagrandicelli, andraganescu, samful, sabernhardt, andystitt829, kburgoine.
Fixes #41648


git-svn-id: https://develop.svn.wordpress.org/trunk@49553 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 23:32:21 +00:00
Helen Hou-Sandi
6411c0953c Feeds: Don't treat media URLs with fragments as unique for enclosures.
Props archduck, dshanske.
Fixes #47421.


git-svn-id: https://develop.svn.wordpress.org/trunk@49552 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 20:26:18 +00:00
Jonathan Desrosiers
a85803a7ba Build/Test Tools: Remove PHP >= 5.3 check.
WordPress no longer supports PHP < 5.6.20. This check is no longer necessary.

Fixes #51737.

git-svn-id: https://develop.svn.wordpress.org/trunk@49551 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 19:40:41 +00:00
Anthony Burchell
907936209a Media: Adjust box-sizing for audio players.
Fix cropped container around playhead time in audio player.

Props ravipatel, sabernhardt, audrasjb, SergeyBiryukov, 
Fixes #51685


git-svn-id: https://develop.svn.wordpress.org/trunk@49550 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 19:32:16 +00:00
Timothy Jacobs
d519284b5c App Passwords: Further accessibility improvements.
- Add a label to the readonly password input.
- Handle focus loss after revoking app passwords.
- Handle focus loss after dismissing notices.
- Mark app name as `aria-required`.
- Use `aria-label` for detailed revoke button text instead of `title`.
- Use `-1` for `tabindex` instead of `0`.

Props alexstine, afercia, sabernhardt, audrasjb, joedolson, TimothyBlynJacobs.
Fixes #51580.


git-svn-id: https://develop.svn.wordpress.org/trunk@49549 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 18:03:57 +00:00
Jonathan Desrosiers
63db886240 Build/Test Tools: Clean up the new contributor welcome message.
Props ocean90, jeffpaul.
See #50401.

git-svn-id: https://develop.svn.wordpress.org/trunk@49548 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 17:29:21 +00:00
Sergey Biryukov
4eee0d2fb7 Tests: Use assertSame() in some newly introduced tests.
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [48937], [48939], [48940], [48944].

See #38266.

git-svn-id: https://develop.svn.wordpress.org/trunk@49547 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 15:43:14 +00:00
Sergey Biryukov
2e01c76841 Coding Standards: Use consistent formatting for error messages in WP_Image_Editor_Imagick::write_image() and ::strip_meta().
See #50767.

git-svn-id: https://develop.svn.wordpress.org/trunk@49546 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 15:33:51 +00:00
Sergey Biryukov
1bba686ca0 General: Set svn:eol-style for some new files in phpunit/includes.
Follow-up to [48845], [49037], [49226], [49230].

See #51113.

git-svn-id: https://develop.svn.wordpress.org/trunk@49545 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 15:23:02 +00:00
John Blackbourn
8e25b92b63 Docs: Docblock corrections relating to WP_Post objects.
See #51373, #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49544 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 15:13:56 +00:00