50603 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Jb Audras	4210d50959	General: Stop direct loading of files in /wp-includes that should only be included. ... This changeset restricts direct access call in `/wp-includes` and its sub directories. Follow-up to [11768], [59678]. Props deepakrohilla. Fixes #61314. git-svn-id: https://develop.svn.wordpress.org/trunk@59688 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-22 19:46:16 +00:00
John Blackbourn	90b3a49b83	Build/Test Tools: Coerce the run_id input to a string before passing it to the "Failed Workflow" workflow. ... Follow-up to [59679]. See #62221 git-svn-id: https://develop.svn.wordpress.org/trunk@59687 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-22 19:24:48 +00:00
Jonathan Desrosiers	82de1691e4	Build/Test Tools: Update @playwright/test. ... This updates `@playwright/test` to the latest version, currently `1.49.1`. In older branches using Playwright, the E2E and Performance workflows have recently started failing. This is due to changes in the GitHub Actions runner images. Updating Playwright ensures more modern dependency trees are used when installing browsers for testing and fixes the issue. Props swissspidy. See #62843. git-svn-id: https://develop.svn.wordpress.org/trunk@59682 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-22 17:49:26 +00:00
Jonathan Desrosiers	5d65aee36a	Build/Test Tools: Fix Slack message payload generation. ... The JSON string set as an output for the Slack message payload needs to be one line to prevent causing errors. This ensures `jq` returns a compact JSON string. Follow up to [59679]. Props johnbillion. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59681 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-22 17:03:48 +00:00
Sergey Biryukov	003163f512	Coding Standards: Rename $thisEnclosure variable in wp_xmlrpc_server methods. ... This resolves a WPCS warning: {{{ Variable "$thisEnclosure" is not in valid snake_case format, try "$this_enclosure" }}} Follow-up to [16824], [19848]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59680 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-22 15:38:42 +00:00
John Blackbourn	8209135dfc	Build/Test Tools: Improve the security and correctness of the GitHub Actions workflows files. ... This includes removing use of dangerous inline GitHub Actions expressions, preventing word splitting, further tightening permissions, and generally improving many aspects of the workflows. This also introduces a new workflow that runs Actionlint to detect incorrect and insecure code and configuration in workflow files. Props johnbillion, swissspidy, flixos90, desrosj. See #62221 git-svn-id: https://develop.svn.wordpress.org/trunk@59679 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-22 15:13:21 +00:00
Jb Audras	c7cd04c7b7	General: Stop direct loading of files in /wp-admin that should only be included. ... This changeset restricts direct access call in `/wp-admin` and its sub directories. Follow-up to [11768]. Props deepakrohilla. See #61314. git-svn-id: https://develop.svn.wordpress.org/trunk@59678 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-22 14:04:34 +00:00
Jb Audras	0f2334da81	Formatting: Preserve target="_blank" in Biographical Info and Category Description. ... This changeset ensures the `target="_blank"` attribute is preserved when adding links in the Biographical Info and Category Description fields. Previously, this attribute was being stripped by the KSES sanitization process. Additionally, new unit tests have been added to verify the preservation of the `target="_blank"` attribute in these specific contexts. Props lovewpmu, miqrogroove, bsutcliffe, sjefen6, nofearinc, nacin, harmr, blogitsolutions, stefahn, nirajgirixd, martinkrcho, spacedmonkey, sukhendu2002, audrasjb, gaellebesson, nuryko, guillaumeturpin, maximemeganck, ranafge, azaozz, joedolson, rinkalpagdar, mikinc860. Fixes #12056. git-svn-id: https://develop.svn.wordpress.org/trunk@59677 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-21 22:57:04 +00:00
Jb Audras	eb50dd7cbf	Customize: Show sidebar's description below its name in Customizer Widgets sidebar list. ... This is part of an effort to reduce `title` attribute usage in WordPress Admin. This changeset updates the Customizer Widgets sidebar list to show sidebar name and description (as these informations may benefit to everyone), and remove the `title` attribute. Follow-up to [22439], [27548], [31513], [32991], [50804], [53414], [59675]. Props karlgroves, sabernhardt, mukesh27, joedolson. Fixes #62836. See #24766. git-svn-id: https://develop.svn.wordpress.org/trunk@59676 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-21 22:36:50 +00:00
Jb Audras	61b7b9713e	Themes: Remove title attributes from theme list tables. ... This changeset updates the old list tables for themes and theme installation to remove `title` attributes or replace them with a more acessible implementation: - Removes `title` attributes from `span` elements - Replaces `title` with `aria-label` for links whose visible text starts with the same word, consistently with links on the "Add Plugins" screen - Reuses the `$preview_title` variable to keep ARIA labels consistent for both Preview links Follow-up to [22439], [27548], [31513], [32991], [50804], [53414]. Props karlgroves, sabernhardt, audrasjb, alh0319. Fixes #62834. See #24766. git-svn-id: https://develop.svn.wordpress.org/trunk@59675 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-21 21:47:27 +00:00
Weston Ruter	396f6fbe43	Menus: Improve performance by calling get_privacy_policy_url() once per Walker_Nav_Menu instance rather than for every nav menu item. ... The `start_el()` method in `Walker_Nav_Menu` was calling `get_privacy_policy_url()` for every menu item when building menus. This resulted in redundant queries, particularly for menus with many items. This obtains the `get_privacy_policy_url()` value in the constructor for reuse in the `start_el()` method to improve performance. Redundant code to construct the privacy policy page is also refactored into the `set_up()` method during tests. Props arzola, swissspidy, westonruter, mukesh27. Fixes #62818. git-svn-id: https://develop.svn.wordpress.org/trunk@59674 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-21 21:24:59 +00:00
John Blackbourn	f2f13cbff0	Build/Test Tools: Switch to using local references for reusable workflows. ... The benefit of this is that when PRs are made to make changes to a reusable workflow, the references doesn't need to be updated to point to the fork in order for the changed workflow to run. A `npm run grunt replace:workflow-references-local-to-remote` command has also been introduced in order to convert these local references back to remote ones. This command can be used to switch release branches over to using remote workflows, as they are currently, so they continue to benefit from workflow changes in trunk without the need for continual backporting to all the branches. Props desrosj, johnbillion Fixes #62416 git-svn-id: https://develop.svn.wordpress.org/trunk@59673 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-21 15:40:51 +00:00
Sergey Biryukov	41e124ad55	Coding Standards: Rename the $errorString variable in wp_xmlrpc_server methods. ... This resolves a WPCS warning: {{{ Variable "$errorString" is not in valid snake_case format, try "$error_string" }}} Follow-up to [5054]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59672 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-21 15:32:31 +00:00
John Blackbourn	2adec312ef	Security: Set the HttpOnly flag for the test cookie and the wp_lang cookie on the login screen. ... These cookies are only accessed server-side and don't need to be exposed to JavaScript in the browser. Props earthman100, kevinlearynet Fixes #61322 git-svn-id: https://develop.svn.wordpress.org/trunk@59671 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-21 13:17:32 +00:00
Pascal Birchler	4b89ebe5be	I18N: Set textdomain registry information before loading plugins/theme. ... This way, warnings for early translation calls can be emitted that aren't attached to any hook. Follow-up to [59461]. Props swissspidy. Fixes #62244.See #44937. git-svn-id: https://develop.svn.wordpress.org/trunk@59670 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-21 11:42:19 +00:00
Pascal Birchler	7be10747ea	Build/Test Tools: Do not download extra browsers in performance tests. ... Props euthelup, johnbillion, mukesh27. Fixes #62822. git-svn-id: https://develop.svn.wordpress.org/trunk@59669 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-21 08:32:24 +00:00
John Blackbourn	0bb851ec95	Build/Test Tools: Pass the working directory path from the host to the dev environment containers. ... This allows development tools to read the host path information from the `HOST_PATH` environment variable in order to, for example, map a path in a stack trace from the path in the container to the path on the host machine. Fixes #62833 git-svn-id: https://develop.svn.wordpress.org/trunk@59668 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-20 22:06:53 +00:00
John Blackbourn	313e12323a	Administration: Clarify some references to "we" and "our" in the administration area. ... This changes some text to better match the guidelines and recommendations set forth in the make/core handbook, specifically: > the word “we” should be avoided (...) unless its made very clear which group is speaking Fixes #62295 git-svn-id: https://develop.svn.wordpress.org/trunk@59667 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-20 22:02:56 +00:00
John Blackbourn	2dd8ce2f0a	Build/Test Tools: Instruct git and svn to ignore SQLite files ... This prevents users of the SQLite Database Integration plugin from seeing untracked files in the `src/wp-content/database` directory. Props sukhendu2002, johnbillion Fixes #62813 git-svn-id: https://develop.svn.wordpress.org/trunk@59666 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-20 21:49:44 +00:00
Sergey Biryukov	29df2d591f	Coding Standards: Rename the $isPrimary variable in wp_xmlrpc_server methods. ... This resolves a few WPCS warnings: {{{ Variable "$isPrimary" is not in valid snake_case format, try "$is_primary" }}} Additionally, this commit renames `$catids` to `$cat_ids` for consistency. Follow-up to [1671]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59665 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-20 14:30:02 +00:00
Sergey Biryukov	7fe8f1cc6f	Coding Standards: Rename the $dateCreated variable in wp_xmlrpc_server methods. ... This resolves a few WPCS warnings: {{{ Variable "$dateCreated" is not in valid snake_case format, try "$date_created" }}} Follow-up to [1563], [1659], [5888], [6691], [8543], [19848]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59664 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-19 16:55:20 +00:00
Sergey Biryukov	f33ee44c8c	Coding Standards: Use strict comparison in wp_xmlrpc_server::pingback_ping(). ... Follow-up to [2983], [55365]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59663 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-18 23:41:46 +00:00
Joe McGill	2f654881e4	Editor: Improve consistency of render_block_context filter. ... This ensures that when block context is filtered via `render_block_context`, the filtered value is provided as available context to inner blocks. For backwards compatibility reasons, filtered context is added to inner block context regardless of whether that block has declared support via the `uses_context` property. Props mukesh27, flixos90, gziolo, dlh, joemcgill, santosguillamot. Fixes #62046. git-svn-id: https://develop.svn.wordpress.org/trunk@59662 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-17 21:35:50 +00:00
Jonathan Desrosiers	5e74d3416f	Build/Test Tools: Auto-close linked PRs on GitHub. ... There are currently ~2,000 open pull requests on GitHub for `wordpress-develop`. Many of these were for testing changes that have already been merged. To help prevent orphaned pull requests, this new workflow will search for any pull requests referencing the `Fixed` Trac tickets as noted in the commit message and close them out. For now, this only happens for `push` events. Props peterwilsoncc, swissspidy, johnbillion, davidbaumwald. Fixes #62817. git-svn-id: https://develop.svn.wordpress.org/trunk@59661 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-17 14:01:37 +00:00
Sergey Biryukov	6677425622	Coding Standards: Use strict comparison in wp_xmlrpc_server::wp_deleteCategory(). ... Follow-up to [20157], [32733]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59660 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-17 10:36:41 +00:00
John Blackbourn	f1dc1916a0	Build/Test Tools: Hide the Node.js error message when a Docker command produces a non-zero exit code. ... When running a command that goes via docker.js and produces a non-zero exit code, the error message and stack trace from node an safely be hidden because the stack trace only points to the `execSync()` call and is of no use. Fixes #62814 git-svn-id: https://develop.svn.wordpress.org/trunk@59659 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-17 10:35:41 +00:00
John Blackbourn	e8fc0d6ae5	Build/Test Tools: Use quiet pulls during local environment installation and WP-CLI commands. ... This reduces the noise of the output -- both locally and on CI -- when first pulling containers during local environment installation and the first time the cli container is pulled for WP-CLI commands. See #62280 git-svn-id: https://develop.svn.wordpress.org/trunk@59658 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-17 10:32:22 +00:00
Peter Wilson	bc3fdb4648	Options/Meta APIs: Document type juggling of meta data. ... Document that unserialised data types are stored as strings in the database and returned as such by the meta data functions. For example, setting meta data to the integer value `1` will be returned as `"1"` when subsequently queried via `get_metadata()` and the related functions. Props sukhendu2002, azaozz, jrf, rodrigosprimo. Fixes ticket:61950. git-svn-id: https://develop.svn.wordpress.org/trunk@59657 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-17 00:10:08 +00:00
Jonathan Desrosiers	ab4b4eb55d	Administration: Modernize admin color scheme SASS files. ... This updates the admin color scheme `.sass` files to address some deprecated notices caused by upstream changes. - `string` and `colors` are no longer globally available functions. - `@import` is deprecated in favor of `@use`. There are still a few notices that are output, however this will require an update to the `grunt-sass` package to resolve. Props MattyRob. Fixes #62323. git-svn-id: https://develop.svn.wordpress.org/trunk@59656 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-16 21:03:12 +00:00
Jonathan Desrosiers	fc9aabbc89	Build/Test Tools: Add input for disabling AppArmor. ... Old branches requiring outdated versions of Chromium to run JavaScript tests have recently started failing as a result of the `ubuntu-latest` container being updated to point to `ubuntu-24`. This introduces a new input to the reusable JavaScript testing workflow to allow a fix to be used without having to update Chromium or tests in these branches. Props swissspidy. See #62808. git-svn-id: https://develop.svn.wordpress.org/trunk@59635 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-16 20:19:28 +00:00
Sergey Biryukov	e114dfb79c	Upload: Remove redundant check for ABSPATH in wp-admin/async-upload.php. ... This aims to bring consistency with a similar fragment in other files, since relocating `wp-admin` or `wp-load.php` is not supported at this time. Follow-up to [6659], [7971], [8315]. Props hussain896, swissspidy, knutsp, SergeyBiryukov. Fixes #62809. git-svn-id: https://develop.svn.wordpress.org/trunk@59634 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-16 16:16:15 +00:00
John Blackbourn	964c5d3857	Users: Retain the current session when a user changes their password. ... Prior to this change a new session was unnecessarily created when a user changed their own password. Existing authentication cookies for the user will still be invalidated regardless of whether they share the same session token because session cookie keys contain a substring of the password hash. Props snicco, narenin, johnbillion Fixes #61366 git-svn-id: https://develop.svn.wordpress.org/trunk@59633 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-16 15:33:31 +00:00
Sergey Biryukov	8aea1ba5ee	Coding Standards: Use strict comparison in wp_xmlrpc_server::_multisite_getUsersBlogs(). ... Follow-up to [https://mu.trac.wordpress.org/changeset/1218 mu:1218], [12852]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59632 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-16 12:02:24 +00:00
Peter Wilson	5b01d24d8c	Options/Meta APIs: Optimize cache hits for non-existent options. ... Optimize the order of checking the various options caches in `get_option()` to prevent hitting external caches each time it is called for a known non-existent option. The caches are checked in the following order when getting an option: 1. Check the `alloptions` cache first to prioritize existing loaded options. 2. Check the `notoptions` cache before a cache lookup or DB hit. 3. Check the `options` cache prior to a DB hit. Follow up to [56595]. Props adamsilverstein, flixos90, ivankristianto, joemcgill, rmccue, siliconforks, spacedmonkey. Fixes #62692. See #58277. git-svn-id: https://develop.svn.wordpress.org/trunk@59631 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-15 22:11:15 +00:00
Felix Arntz	d2630e00cd	REST API: Fix PHP warning about undefined paged argument in various REST API endpoints. ... This bug could occur in `WP_REST_Posts_Controller`, `WP_REST_Global_Styles_Revisions_Controller`, `WP_REST_Revisions_Controller`, and any of their child classes. This changeset fixes it throughout. Props apermo, pbearne, hemant-ahir, flixos90. Fixes #62292. git-svn-id: https://develop.svn.wordpress.org/trunk@59630 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-15 18:34:35 +00:00
Pascal Birchler	aaf760cbdc	Undo accidental svn:mergeinfo property change in [59605]. ... See #61970. git-svn-id: https://develop.svn.wordpress.org/trunk@59607 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-15 12:53:30 +00:00
Sergey Biryukov	9342553d5e	Coding Standards: Use strict comparison in paginate_links(). ... Follow-up to [4275], [28785]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59606 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-15 12:50:48 +00:00
Pascal Birchler	48ba7a364d	REST API: Improve autosave and revision endpoints for templates and template parts. ... Fixes those endpoints for file-based templates and template parts, as templates based on theme files can't be revisioned or autosaved. Props antonvlasenko, swissspidy, spacedmonkey, kadamwhite. Fixes #61970. git-svn-id: https://develop.svn.wordpress.org/trunk@59605 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-15 12:44:43 +00:00
Sergey Biryukov	83718be685	Tests: Restore the environment before performing assertions in download_url() tests. ... This aims to avoid affecting other tests in case of failure. Follow-up to [42773], [51939]. See #62280. git-svn-id: https://develop.svn.wordpress.org/trunk@59604 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-14 15:35:18 +00:00
John Blackbourn	4777477611	Docs: Correct a translator comment that was added in [59578]. ... See #62005 git-svn-id: https://develop.svn.wordpress.org/trunk@59603 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-14 11:37:00 +00:00
Sergey Biryukov	9d9d73cd9e	Docs: Correct @return value for update_attached_file(). ... Follow-up to [4612], [21967], [24490], [47611], [48214]. Props arnoutblueshell, karthickmurugan, SergeyBiryukov. Fixes #62803. git-svn-id: https://develop.svn.wordpress.org/trunk@59602 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-13 22:20:03 +00:00
Jonathan Desrosiers	062df4cd88	Coding Standards: Add missing space for self-closing tags. ... Props laxman-prajapati, sabernhardt. Fixes #62799. git-svn-id: https://develop.svn.wordpress.org/trunk@59600 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-13 14:55:09 +00:00
Sergey Biryukov	88796678fd	Coding Standards: Use strict comparison in get_page_by_path(). ... Follow-up to [3511], [18541], [19075], [21845]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59599 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-12 18:12:14 +00:00
Pascal Birchler	c0d073d62d	Embeds: Add Canva to oEmbed provider allowlist. ... Props swissspidy. Fixes #58840. git-svn-id: https://develop.svn.wordpress.org/trunk@59598 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-11 13:42:46 +00:00
Sergey Biryukov	4051e31bec	Coding Standards: Use strict comparison in wp_check_post_hierarchy_for_loops(). ... Follow-up to [10129], [15806]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59597 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-11 00:35:45 +00:00
Sergey Biryukov	1dd2f28680	Coding Standards: Use strict comparison in get_posts_by_author_sql(). ... Follow-up to [13576], [25669]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59596 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-10 18:12:08 +00:00
Sergey Biryukov	a48e1806f7	Login and Registration: Check that the $_POST values are strings in wp_signon(). ... This prevents a fatal error from `trim()` via `wp_authenticate()` if an array is passed instead. Follow-up to [6643], [58093]. Props leedxw, audrasjb, SergeyBiryukov. Fixes #62794. git-svn-id: https://develop.svn.wordpress.org/trunk@59595 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-09 19:41:47 +00:00
Carolina Nymark	c53397d1f8	Twenty Twenty: Correct the font weight of the quote block in the editor. ... This change removes the font weight of the paragraph inside the quote block, so that the design in the editor and the front looks the same. Props sainathpoojary, ankitkumarshah, sabernhardt, krupajnanda. Fixes #62753. git-svn-id: https://develop.svn.wordpress.org/trunk@59594 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-09 09:21:33 +00:00
Sergey Biryukov	86f31c8166	Coding Standards: Use strict comparison in wp_check_for_changed_dates(). ... Follow-up to [42401]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59593 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-08 17:46:54 +00:00
Pascal Birchler	287b2f8c96	I18N: Mail: Make PHPMailer messages translatable. ... Adds a new `WP_PHPMailer` class to leverage the WordPress i18n system with PHPMailer, so that any user-visible error messages can be properly translated. Props sukhendu2002, swissspidy, audrasjb, iandunn, nacin, mark-k. Fixes #23311. git-svn-id: https://develop.svn.wordpress.org/trunk@59592 602fd350-edb4-49c9-b593-d223f7449a82	2025-01-08 12:52:04 +00:00