This backports a handful of test fixes related to generating code coverage reporting, as well as some `devDependency` updates.
Backports [50591-50595,50597-50598] to the 5.7 branch.
See #52624, #52786, #51734.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50601 602fd350-edb4-49c9-b593-d223f7449a82
Because the changes in Twenty Twelve did not impact site look or functionality, version 3.4 of Twenty Twelve was not released in coordination with WordPress 5.7.
This reverts the portion of [50508] relevant to Twenty Twelve, changing the version back to 3.3 so that version 3.4 is not skipped accidentally when there are changes that should be released.
Merges [50596] to the 5.7 branch.
See #52704.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50597 602fd350-edb4-49c9-b593-d223f7449a82
On TravisCI, old branches still receiving security updates were tested on a regular basis. This ensured tests continued to pass as time passed even if updates were not made to these branches.
On GitHub Actions, there is no interface to configure this (TravisCI had a UI), but there is a `schedule` event that can trigger workflow runs on cron that can be used to accomplish the same thing.
This introduces a workflow file that runs twice a month (on the 1st and 15th) to verify the tests within older branches.
Because the `schedule` event only runs within the primary branch, the appropriate workflows in each old branch will be triggered manually through the `workflow_dispatch` trigger using the GitHub REST API. `workflow_dispatch` will need to be added to all workflows in all old branches in order for the event to dispatch successfully.
Merges [50590] to the 5.7 branch.
See #52653.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50591 602fd350-edb4-49c9-b593-d223f7449a82
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.
Follow-up to [50465].
Props joseeyoast, audrasjb, SergeyBiryukov.
Merges [50534] to the 5.7 branch.
Fixes#52816.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50588 602fd350-edb4-49c9-b593-d223f7449a82
Removes the mutually exclusive directives check in `wp_robots()`, ie allow both `follow` and `nofollow` to be specified and for `archive` and `noarchive` to be specified.
This fixes a bug in which WordPress would defer to the most permissive over the least permissive. When contradictory instructions are included, WordPress will defer to the search engine's or archivist's resolution policy: generally this is to observe the least, not most permissive.
Props Cybr, flixos90, SergeyBiryukov.
Merges [50566] to the 5.7 branch.
Fixes#52713.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50587 602fd350-edb4-49c9-b593-d223f7449a82
Replace the CSS removed in [50569], which is used to align the login & register buttons.
Props mukesh27, audrasjb.
Reviewed by SergeyBiryukov.
Merges [50577] to the 5.7 branch.
Fixes#52834.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50580 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025], [50525].
Props sabernhardt, ryelle.
Merges [50571] to the 5.7 branch.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50578 602fd350-edb4-49c9-b593-d223f7449a82
On narrow screens allow the text to wrap in the copy buttons on the privacy policy guide screen to avoid horizontal overflow of the parent container.
Props audrasjb, davidbaumwald, jaymanpandya, paaljoachim, palmiak, sabernhardt, SergeyBiryukov, sumitsingh.
Merges [50568] to the 5.7 branch.
Fixes#52751.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50574 602fd350-edb4-49c9-b593-d223f7449a82
Add a check to `WP_REST_Meta_Fields::delete_meta_value()` ensuring meta data is set before attempting to delete it from the database. If the data does not exist, the delete is considered successful as the data matches the desired state.
Props BrechtVds, goaroundagain, TimothyBlynJacobs.
Merges [50567] to the 5.7 branch.
Fixes#52787.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50573 602fd350-edb4-49c9-b593-d223f7449a82
Prevent misalignment of "generate password" and "save password" buttons on the password reset screen on narrow screens and in languages requiring longer text than English.
Props audrasjb, grapplerulrich, ryelle.
Merges [50569] to the 5.7 branch.
Fixes#52834.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50572 602fd350-edb4-49c9-b593-d223f7449a82
With changes that were introduced in #49889 the second parameter for getimagesize() function is expecting a a reference.
Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.
This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.
For more see:
https://github.com/humanmade/S3-Uploads/issues/496https://github.com/aws/aws-sdk-php/issues/1923Fixes#52826.
Merges [50552] to the 5.7 branch.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50553 602fd350-edb4-49c9-b593-d223f7449a82
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.
Props vladytimy, joyously, sergeybiryukov.
Merges [50535] to the 5.7 branch.
Fixes#52758.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50536 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.
Follow-up to [50025].
Props sabernhardt, Otshelnik-Fm, audrasjb.
Merges [50525] to the 5.7 branch.
Fixes#52760.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50526 602fd350-edb4-49c9-b593-d223f7449a82
This ensures the images are loaded correctly from both single site and network About pages.
Props TobiasBg, audrasjb.
Merges [50523] to the 5.7 branch.
Fixes#52743.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50524 602fd350-edb4-49c9-b593-d223f7449a82
This avoids an "Undefined variable" PHP notice in the `::mt_supportedMethods()` and `::mt_supportedTextFilters()` methods.
Follow-up to [50353].
Props dd32.
Reviewed by dd32, SergeyBiryukov.
Merges [50499] to the 5.7 branch.
Fixes#52524.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50500 602fd350-edb4-49c9-b593-d223f7449a82
The intro text has been updated for accuracy and to make it easier for translation. The button text has been updated for accuracy.
Props jdy68, audrasjb, marybaum, davidbaumwald.
Reviewed by ryelle, SergeyBiryukov.
Merges [50495] to the 5.7 branch.
See #52347.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50498 602fd350-edb4-49c9-b593-d223f7449a82
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 RC 3.
See #52718.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50497 602fd350-edb4-49c9-b593-d223f7449a82
This change ensures that the text in the Media & Text block is readable when dark background colors are selected.
This is a regression that was introduced in [49987].
Props hellofromTonya, poena, paaljoachim, ryelle.
Merges [50493] to the 5.7 branch.
Fixes#52702.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50494 602fd350-edb4-49c9-b593-d223f7449a82
Changes wp_apply_colors_support to check for for color instead of
experimentalColor when determining block support for color.
Props nosolosw, rafhun, youknowriad.
See #52709.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50489 602fd350-edb4-49c9-b593-d223f7449a82
Adds a more obviously interactive comparison for viewing the color scheme differences. Improvements on RTL and IE11. Update strings to be more clear and consistent. Switch to the CDN for loading images.
Props sarahricker, desrosj, melchoyce, SergeyBiryukov, tikifez, clorith, marybaum, audrasjb, francina, hellofromTonya.
Reviewed by SergeyBiryukov.
Merges [50478] to the 5.7 branch.
Fixes#52693. See #52347.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50480 602fd350-edb4-49c9-b593-d223f7449a82
Invalidate OPcache for wp-content/version.php on update individually, since it's copied separately.
Props stodorovic, krstarica, cenay, desrosj, pbiron, sergeybiryukov, mikeschroder.
Reviewed by mikeschroder, SergeyBiryukov.
Merges [50460] and [50475] to the 5.7 branch.
Fixes#51686, #51281.
See #36455.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50477 602fd350-edb4-49c9-b593-d223f7449a82
This changes the logic in `update_https_detection_errors()` to never store error messages from the actual request since they could use a different encoding, which would make storing them in an option potentially fail, leading WordPress to then falsely assume that HTTPS is supported.
While this doesn't actually fix the encoding issue, it is not crucial to do so anyway, since these messages are not used anywhere. A simple differentiation between whether the overall HTTPS request or only the SSL verification failed should be sufficient for the purpose of this function.
Props flixos90, tmatsuur, lukecarbis.
Reviewed by flixos90, SergeyBiryukov.
Merges [50471] to the 5.7 branch.
Fixes#52484.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50472 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [50007].
Props TimothyBlynJacobs.
Reviewed by desrosj, SergeyBiryukov.
Merges [50461] to the 5.7 branch.
Fixes#52317.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50470 602fd350-edb4-49c9-b593-d223f7449a82
Adjust the background color palette rules so they don't show up on inner containers when they're not supposed to:
- When an inner container block is present, it only applies them to direct children of the block with the background color assigned.
- Since the background color should only be applied to the Cover block's overlay, not to the inner container, it opts that specific block out of this rule.
Props dianeco, kjellr, paaljoachim.
Reviewed by ryelle, SergeyBiryukov.
Merges [50466] to the 5.7 branch.
Fixes#52676.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50469 602fd350-edb4-49c9-b593-d223f7449a82
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.
Props antonlukin, paaljoachim, felipeelia.
Reviewed by ryelle, SergeyBiryukov.
Merges [50465] to the 5.7 branch.
Fixes#52646.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50468 602fd350-edb4-49c9-b593-d223f7449a82
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 RC 2.
Fixes#52680.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50467 602fd350-edb4-49c9-b593-d223f7449a82
* Switch back to running the PHPUnit test suite against the `src` directory instead of `build`
* Increase the reliability of backing up the `mu-plugins` directory during tests
* Split the PHPUnit tests for PHP versions below 7.0 in half, allowing them to run in parallel and reduce the overall test run duration on GitHub Actions
Merges [50441-50444] to the 5.7 branch.
Fixes#51734, #51735, #52645
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50464 602fd350-edb4-49c9-b593-d223f7449a82
Previously, jQuery 1.12.4 was added to the WordPress SVN repo in order to backport an upstream security patch from jQuery 3.4.0.
Now that WordPress includes an unmodified version of jQuery 3.5.1 and no longer needs to maintain a fork, it can be removed from the SVN repo and installed via NPM again as part of the build.
Follow-up to [45342], [49101].
Props peterwilsoncc, SergeyBiryukov.
Merges [50445] to the 5.7 branch.
Fixes#52647.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50457 602fd350-edb4-49c9-b593-d223f7449a82
When sending password reset emails, switch to the user's locale prior to obtaining the site title to allow for plugins filtering based on locale.
Follow up to [50129,50139-50141,50152,50415].
Props chouby.
Merges [50439] to the 5.7 branch.
Fixes#52605. See #34281.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50440 602fd350-edb4-49c9-b593-d223f7449a82
The `click()` method there is not the jQuery method, but is an HTML DOM method instead.
This makes the fly-out submenu header clickable again when the menu is folded.
Follow-up to [50420].
Props peterwilsoncc, SergeyBiryukov.
Merges [50429] to the 5.7 branch.
Fixes#52638. See #51812.
git-svn-id: https://develop.svn.wordpress.org/branches/5.7@50437 602fd350-edb4-49c9-b593-d223f7449a82
