The theme supports WordPress 5.3 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.
Follow-up to [55988], [57275], [57276].
Merges [57277] to the 6.4 branch.
Props poena, SergeyBiryukov.
Fixes#60241.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57293 602fd350-edb4-49c9-b593-d223f7449a82
The theme supports WordPress 4.7 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.
Follow-up to [55988], [57275].
Merges [57276] to the 6.4 branch.
Props poena, SergeyBiryukov.
See #60241.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57292 602fd350-edb4-49c9-b593-d223f7449a82
The theme supports WordPress 4.7 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.
Follow-up to [55988].
Merges [57275] to the 6.4 branch.
Props poena, SergeyBiryukov.
See #60241.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57291 602fd350-edb4-49c9-b593-d223f7449a82
When the `wp_login_errors` filter is used to add an error message followed by an instructional message, the former was not displayed and the latter was errouneously displayed twice above the login form.
This commit ensures that the error message is displayed as expected.
Follow-up to [56654].
Reviewed by jorbin.
Merges [57142] to the 6.4 branch.
Props mapumba, SergeyBiryukov.
Fixes#59983.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57288 602fd350-edb4-49c9-b593-d223f7449a82
This bumps the minimum required version of Node.js/npm from 16.19.1 and 8.19.3 to 20.10.0 and 10.2.3.
Since 20.10.0 is the latest 20.x version of Node.js, the check-latest option has been enabled for actions/setup-node in GitHub Actions workflows. This performs an additional external call to the Node.js API confirming the latest version is installed on the runner for use. In testing, it seems that 20.10.0 was not consistently deployed to all runner machines in use. This should be removed in the near future when the version of Node.js is reliably above the new minimum requirement.
The Gutenberg repository has also been updated to use the same values for engines.
Merges [57212] to the 6.4 branch.
Props jorbin, joemcgill, swissspidy, benharri, dhrupo, flootr, gziolo, noahtallen.
See #59663.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57214 602fd350-edb4-49c9-b593-d223f7449a82
This changes the default value for `LOCAL_PHP` in the 6.4 branch from `latest` to `8.3-fpm` to reflect the highest version of PHP this branch will support (with beta support).
After this change, future updates to the `latest` container built and published by the `wpdev-docker-images` repository will not cause failures in this branch.
While there are currently no failures in the 6.4 branch, the `latest` container was recently changed from using PHP 7.4 to 8.2 and caused failures in the 5.8-6.3 branches. Pinning a PHP version to this branch now will prevent that same scenario in the future. Going forward, this should be done at the time of branching.
Older branches already have specific PHP versions defined.
See #60095.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57198 602fd350-edb4-49c9-b593-d223f7449a82
This is a followup to [57167] to fix a version number in `package-lock.json` that was missed in the initial commit.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57168 602fd350-edb4-49c9-b593-d223f7449a82
The values of start and end are not fully supported by Opera Mini which has 1.01% usage. There is no material change in functionality with this change.
Reviewed by hellofromTonya.
Merges [57151] to 6.4 branch.
Props kebbet, NekoJonez, luminuu, hellofromTonya.
Fixes#59819.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57160 602fd350-edb4-49c9-b593-d223f7449a82
This fixes bugs introduced in [56635] whereby the template or stylesheet path could be memoized incorrectly if get_template_directory() or get_stylesheet_directory() were called before the theme has been fully initialized.
Reviewed by Jorbin.
Merges [57129] to 6.4 branch.
Props partyfrikadelle, coreyw, kdowns, rebasaurus, meta4, flixos90, mukesh27, joemcgill, icaleb.
Fixes#59847.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57156 602fd350-edb4-49c9-b593-d223f7449a82
Restores setting the site's logo, icon, and wp-admin's back button image (which defaults to W).
Prior to [56566], the site logo and icon were unconditionally added to the index. [56566] changed this by conditionally adding them if either the `_links` or `_embedded` fields were included. However, these fields are not included when using the Site Logo block, as it uses the `site_logo`, `site_icon`, and `site_icon_url` fields instead.
This changeset restores the functionality by checking specifically for the `site_*` fields when neither of the `_links` or `_embedded` fields are present.
Follow up to [56566].
Reviewed by jorbin.
Merges [57147] to the 6.4 branch.
Props antonvlasenko, hellofromTonya, ironprogrammer, priethor, wildworks.
Fixes#59935.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57154 602fd350-edb4-49c9-b593-d223f7449a82
The recently introduced Block Hooks API exposes a filter (`hooked_block_types`) which is given a `$context` argument, among others. If the filter is called on a block that's part of a template or template part, `$context` is set to the corresponding `WP_Block_Template` object.
However, that object's `$content` property is currently ''not'' exposed to the filter. This changeset amends that shortcoming.
This is useful for callbacks that might want to detect the presence of a serialized block instance (or potentially in the future utilize the HTML API) to restrict where the block is injected (before the template is rendered).
Addressing this also achieves parity with the structure of `$context` when it represents a pattern (where pattern serialized content is present).
Merges [57118] to the 6.4 branch.
Props nerrad.
Fixes#59882.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57119 602fd350-edb4-49c9-b593-d223f7449a82
The example code in the PHPDoc comment for the HTML Tag Processor class
previously showed calling `next_tag()` with an array containing a `class`
key, which should have been `class_name`. This patch fixes this by using
the appropriate `class_name` key.
Merges [57116] to the 6.4 branch.
Props dmsnell, gaambo, crstauf, atachibana, audrasjb, krupalpanchal.
Fixes#59891.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57117 602fd350-edb4-49c9-b593-d223f7449a82
This updates the '@since 6.4.0' annotation in _register_theme_block_patterns to reference WP_Theme::get_block_patterns instead of _wp_get_block_patterns, which was changed in [56978].
Reviewed by audrasjb.
Merges [57102] to the to the 6.4 branch.
Props audrasjb, mukesh27, joemcgill.
Fixes#59869.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57103 602fd350-edb4-49c9-b593-d223f7449a82
During a bulk edit of posts with different categories, the categories for the edited posts would be reset to the default category: uncategorized by default.
This reverts [56712] to resolve the issue.
Merges [57093] to the 6.4 branch.
Props peterwilsoncc, hellofromtonya, jorbin.
Fixes#59837.
See #11302.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57094 602fd350-edb4-49c9-b593-d223f7449a82
Partial revert of [56475] to reinstate the private `wpdb::$use_mysqli` property and set to its default to true. This private property was / is accessible through the magic methods. Though Core's usage of this property was removed by [56475], plugins are using the property. Reinstating it resolves the BC break.
Follow up to [56475].
Reviewed by jorbin.
Merges [57089] to the 6.4 branch.
Props jason_the_adams, joemcgill, johnbillion, johnjamesjacoby, jrf, rajinsharwar, renehermi.
Fixes#59846.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57090 602fd350-edb4-49c9-b593-d223f7449a82
This updates the Requests library from version 2.0.8 to 2.0.9. This is a hotfix release.
Reviewed by jorbin, desrosj.
Merges [57086] to 6.4 branch.
Props jorbin, hellofromTonya, desrosj, barry, cenkdemir, nexflaszlo, schlessera, jrf, Clorith, tomsommer, azaozz, pbiron, afragen, howdy_mcgee.
Fixes#59842.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57088 602fd350-edb4-49c9-b593-d223f7449a82
Documents the 4 new 6.4 Block Hooks global functions as private and for Core-only internal usage:
* `make_before_block_visitor()`
* `make_after_block_visitor()`
* `traverse_and_serialize_block()`
* `traverse_and_serialize_blocks()`
This is being done as the architectural design of these new functions may change in the next cycle. Further denoting them as private / Core only can help to avoid extender churn if any of these functions are deprecated.
Follow up to [56649], [56620].
Reviewed by karmatosed.
Merges [57066] to the 6.4 branch.
Props azaozz, hellofromTonya, bernhard-reiter, gziolo, mikeschroder.
Fixes#59783.
See #59313.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57071 602fd350-edb4-49c9-b593-d223f7449a82
This update includes the following fixes reported after RC3:
* Regression: [https://github.com/WordPress/gutenberg/pull/55858 Fixes patterns not working anymore as a post template for custom post types].
Scenario: When creating a new post for any custom post type registered with its "template" argument set to a pattern.
For this scenario, the pattern template no longer renders in the post editor or the frontend with 6.4, whereas it did render properly in 6.3.2.
This package update resolves the console error raised:
{{{
Uncaught TypeError: select(...).getCurrentTheme() is undefined
}}}
which restores the rendering of the pattern template.
* Regression: [https://github.com/WordPress/gutenberg/pull/55859 Fixes positioning and styles for the new lightbox's trigger] introduced in 6.4.
Follow up to [57048], [57034], [56987], [56961], [56849], [56818], [56816].
Reviewed by jorbin.
Merges [57063] to the 6.4 branch.
Props renathoc, rajinsharwar, richtabor, joen, mikachan, hellofromTonya.
Fixes#59411.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57064 602fd350-edb4-49c9-b593-d223f7449a82
Revert group name change in the 6.4 branch as the `functions.php` group was renamed `functions` after the branch was forked.
Props SergeyBiryukov.
See #59647, #58955.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57059 602fd350-edb4-49c9-b593-d223f7449a82
This second update for RC3 includes the following fixes:
* [https://github.com/WordPress/gutenberg/pull/55724 Update label for lightbox editor UI] - string change.
* [https://github.com/WordPress/gutenberg/pull/55720 Query: Require queryId for enhanced pagination to prevent PHP notices] and warnings.
* [https://github.com/WordPress/gutenberg/pull/55714 Query block enhanced pagination: Detect inner plugin blocks during render] - which avoids turning off enhanced pagination in TT4, includes string changes.
* [https://github.com/WordPress/gutenberg/pull/55309 Query Loop block: Reuse existing screen-reader-text CSS class for the enhanced pagination aria-live region].
Follow up to [57034], [56987], [56961], [56849], [56818], [56816].
Reviewed by davidbaumwald , jorbin.
Merges [57048] to the 6.4 branch.
Props afercia, aristath, artemiosans, czapla, darerodz, glendaviesnz, hellofromTonya, jameskoster, joen, luisherranz, mikachan, ocean90, peterwilsoncc, ramonopoly, rajinsharwar, swissspidy.
Fixes#59411.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57049 602fd350-edb4-49c9-b593-d223f7449a82
Changes the `'wp_pattern_category'` taxonomy's `'public'` argument to `false`.
Follow-up to [56642].
Reviewed by azaozz, mikeschroder.
Merges [57044] to the 6.4 branch.
Props vrajadas, glendaviesnz, hellofromTonya, ramonopoly.
Fixes#59569.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57045 602fd350-edb4-49c9-b593-d223f7449a82
Both the `$pre_callback` and `$post_callback` functions that are given as arguments to `traverse_and_serialize_block(s)` receive a reference to the current block as their first argument. However, while any changes that the "pre" callback makes to the block are reflected by the serialized markup, the same wasn't true for the "post" callback: Any changes that it made were only applied ''after'' the block had already been serialized.
This commit changes the behavior such that `$post_callback`'s changes to the current block are also reflected in the serialized markup.
Reviewed by hellofromTonya.
Merges [56970] to the 6.4 branch.
See #59646.
Props gziolo.
Fixes#59669.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57043 602fd350-edb4-49c9-b593-d223f7449a82
In WordPress 6.3, [https://wordpress.org/documentation/article/reusable-blocks/ Reusable Blocks were renamed to Patterns]. A synced pattern will behave in exactly the same way as a reusable block.
This commit updates some references in DocBlocks and inline comments to use the new name.
Follow-up to [56030].
Reviewed by hellofromTonya.
Merges [57032] and [57033] to the 6.4 branch.
Props benjaminknox, oglekler, hellofromTonya, marybaum, nicolefurlan.
Fixes#59388.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57040 602fd350-edb4-49c9-b593-d223f7449a82
The callbacks returned by `make_before_block_visitor` and `make_after_block_visitor`, respectively, (which are passed as arguments to `traverse_and_serialize_block(s)`) currently accept three arguments, all of which are block arrays (i.e. with properties `blockName`, `attrs`, etc.):
- A ''reference'' to the block they're currently visiting, `&$block`;
- the block's `$parent_block`; and
- the `$prev`ious block (for `make_before_block_visitor`), or the `$next` block (for `make_after_block_visitor`), respectively.
Those arguments are passed to the "block visitor" callbacks by `traverse_and_serialize_block(s)` during traversal. The block that the callback is currently visiting is passed ''by reference'' to allow modifying it, which is e.g. used to inject the `theme` attribute into Template Part blocks.
One major limitation of Block Hooks is that they currently only work with templates, parts, and patterns that ''don't have any user modifications'' (i.e. that come straight from the corresponding theme files, rather than from the database). For WordPress 6.5, it is planned to change that to make Block Hooks work for templates, parts, and patterns that ''do'' have user modifications: #59646.
This will be implemented by storing an attribute on the "anchor" block. While working on that feature, it was found that the aforementioned callbacks will need to modify not only the currently visited `$block`, but also the `$parent_block` -- i.e. that the latter argument needs to be passed by reference as well. This is consistent with the requirement of adding an attribute to an anchor block, as it's not only the currently visited block that can serve as an anchor block (in the case of `before` or `after` sibling insertion), but also its parent (for `first_child` and `last_child` insertion).
If the `$parent_block` argument were to be changed to become a reference in a later WordPress version, this could be considered a backwards-compatibility breaking change. For this reason, this change is instead proposed for 6.4 already, which is the cycle during which the relevant functions were first introduced. This should have no impact on existing code, since nothing currently relies on `$parent_block` remaining unmodified by the respective callback, nor is anything currently modifying that argument.
Reviewed by hellofromTonya.
Merges [57038] to the 6.4 branch.
Props hellofromTonya.
Fixes#59776.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57039 602fd350-edb4-49c9-b593-d223f7449a82
This update includes the following bugfixes:
- Fix: Added a new block pattern for the home template that inherits the page query and fits the design of the home page. (more context on the theme repo: https://github.com/WordPress/twentytwentyfour/pull/706)
- Fix: Rely on parent theme data for block style.
- Fix: Categories for some patterns.
- Fix: Minor labeling issues
Follow-up to [56999], [56951], [56813], [56764], [56716].
Reviewed by flixos90, jorbin.
Merges [57036] to the 6.4 branch.
Props anlino, beafialho, desrosj, devmuhib, didierjm, fabiorubioglio, flixos90, hanneslsm, hellofromTonya, huzaifaalmesbah, ktaron, luminuu, mshowes, onemaggie, phillsav, poena, rajinsharwar, richtabor, shailu25.
Fixes#59770, #59759.
git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57037 602fd350-edb4-49c9-b593-d223f7449a82
