35052 Commits

Author SHA1 Message Date
Jake Spurlock
69ad1bb1c9 General: WordPress updates
* XML-RPC: Improve error messages for unprivileged users.
* External Libraries: Disable deserialization in Requests_Utility_FilteredIterator
* Embeds: Disable embeds on deactivated Multisite sites.
* Coding standards: Modify escaping functions to avoid potential false positives.
* XML-RPC: Return error message if attachment ID is incorrect.
* Upgrade/install: Improve logic check when determining installation status.
* Meta: Sanitize meta key before checking protection status.
* Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.

Brings the changes from [49380,49382-49388] to the 4.6 branch.

Props xknown, zieladam, peterwilsoncc, whyisjake, desrosj, dd32.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@49400 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 18:59:47 +00:00
Sergey Biryukov
c1c6d978ba Administration: Pass the result of set-screen-option filter to the new set_screen_option_{$option} filter to ensure backward compatibility.
Rename the `$keep` parameter of both filters to `$screen_option` for clarity, update the documentation to better reflect its purpose.

Follow-up to [47951].

Props Chouby, sswells, SergeyBiryukov.
Merges [48241] to the 4.6 branch.
Fixes #50392.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@48252 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-01 09:48:22 +00:00
Jonathan Desrosiers
f4d2e067da WordPress 4.6.19.
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@47997 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 21:32:30 +00:00
Jake Spurlock
92d76485a1 General: Backport several commits for release.
- Embeds: Ensure that the title attribute is set correctly on embeds.
- Editor: Prevent HTML decoding on by setting the proper editor context.
- Formatting: Ensure that wp_validate_redirect() sanitizes a wider variety of characters.
- Themes: Ensure a broken theme name is returned properly.
- Administration: Add a new filter to extend set-screen-option.
Merges [47947-47951] to the 4.6 branch.
Props xknown, sstoqnov, vortfu, SergeyBiryukov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@47974 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 18:42:10 +00:00
Sergey Biryukov
d71f76df75 Update the About page for WordPress 4.6.18
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@47696 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 18:33:04 +00:00
Jonathan Desrosiers
386987b8ac WordPress 4.6.18
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@47674 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 17:56:16 +00:00
Jake Spurlock
1dddf957f2 Cache API: Ensure proper escaping around the stats method in the cache API.
Brings the changes in [47637] to the 4.6 branch.

Props: nickdaugherty, batmoo, whyisjake, westi.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@47655 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 16:45:01 +00:00
Jake Spurlock
e2b05084dc User: Invalidate user_activation_key on password update.
Query: Ensure that only a single post can be returned on date/time based queries.
Cache API: Ensure proper escaping around the stats method in the cache API.
Formatting: Expand `sanitize_file_name` to have better support for utf8 characters.

Brings the changes in [47634], [47635], [47637], and [47638] to the 4.6 branch.

Props: batmoo, ehti, nickdaugherty, peterwilsoncc, sergeybiryukov, sstoqnov, westi, whyisjake, whyisjake, xknown.



git-svn-id: https://develop.svn.wordpress.org/branches/4.6@47651 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 16:24:40 +00:00
Sergey Biryukov
df4fc0b054 Build/Test Tools: Remove unused ::assertPostHasTerms() method from tests/term.php.
The associated test was removed in [30241].

Merges [47341] to 3.7+ branches.
See #49485.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@47489 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 14:29:03 +00:00
Sergey Biryukov
8ee6e319da Embeds: Remove the external oEmbed tests for YouTube.
These tests no longer test anything that WordPress core has control over. YouTube now serves everything
over HTTPS by default, so the tests for #23149 will always pass, and the tests for #32714 aren't testing
anything that core has control over.

Tests for the responses from oEmbed providers has been attempted and reverted in #32360.

Props johnbillion.
Merges [41712] to the 4.4 branch.
See #42076, #32714, #23149.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@47483 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 13:57:09 +00:00
Sergey Biryukov
30988287b6 Embeds: Remove the external oEmbed tests for YouTube.
These tests no longer test anything that WordPress core has control over. YouTube now serves everything
over HTTPS by default, so the tests for #23149 will always pass, and the tests for #32714 aren't testing
anything that core has control over.

Tests for the responses from oEmbed providers has been attempted and reverted in #32360.

Props johnbillion.
Merges [41712] to the 4.6 branch.
See #42076, #32714, #23149.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@47481 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 13:45:45 +00:00
Sergey Biryukov
193c53e174 WordPress 4.6.17
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@46927 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 20:28:03 +00:00
Sergey Biryukov
14bb858ed3 Update wp_kses_bad_protocol() to recognize : on uri attributes,
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Brings r46895 to the 4.6 branch.

Props: xknown, nickdaugherty, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@46914 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 18:45:47 +00:00
Jonathan Desrosiers
8bb669e037 WordPress 4.6.16.
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@46514 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 20:08:14 +00:00
Jake Spurlock
15315e51a4 Backporting several bug fixes.
- Query: Remove the static query property.
- HTTP API: Protect against hex interpretation.
- Filesystem API: Prevent directory travelersals when creating new folders.
- Administration: Ensure that admin referer nonce is valid.
- REST API: Send a Vary: Origin header on GET requests.

Backports [46474], [46475], [46476], [46477], [46478], [46483], [46485] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@46496 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 19:01:10 +00:00
Jake Spurlock
d7a51ca010 Add .nvmrc files to older versions of WordPress
When jumping between branches, it would be nice to have the correct node version for the older versions of WordPress. Let's add .nvmrc files to these older branches for the supported versions.

Merges [46295] to the 4.6 branch.

Fixes #48140


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@46298 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-25 20:55:32 +00:00
Jonathan Desrosiers
51966e8eef WordPress 4.6.15.
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@46040 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 21:21:46 +00:00
Andrew Ozz
cf1c8c8c3b jQuery: Backport the patch from jQuery 3.4.0.
Merges [45342] to the 4.6 branch.

Props MikeNGarrett, peterwilsoncc, azaozz.
Fixes #47020.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@46026 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 18:45:35 +00:00
Jonathan Desrosiers
f4e42693a5 Fix for URL sanitization in wp_kses_bad_protocol_once().
Merges [45997] to the 4.6 branch.

Props irsdl, sstoqnov, whyisjake.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@46008 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 18:20:31 +00:00
Sergey Biryukov
e57576ef1d Improve handling the existing rel attribute in wp_rel_nofollow_callback().
Merges [45990] to the 4.6 branch.
Props xknown, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@45998 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:52:01 +00:00
Sergey Biryukov
d9655d8819 Improve URL validation in wp_validate_redirect().
Merges [45971] to the 4.6 branch.
Props vortfu, whyisjake, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@45978 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:11:07 +00:00
Jake Spurlock
d73484849f Remove _convert_urlencoded_to_entities() from the get_the_content() callback.
Merges [45937] to the 4.6 branch.

Props vortfu, whyisjake, peterwilsoncc


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@45956 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:37:44 +00:00
Sergey Biryukov
8e8b93fbef Escape the output in wp_ajax_upload_attachment().
Merges [45936] to the 4.6 branch.
Props whyisjake, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@45948 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:35:12 +00:00
John Blackbourn
09c0bc32da Build/Test tools: Further trimming of CI jobs on the 4.6 branch.
This removes the PHP 5.6 job which runs without an object cache in place as the likelihood of a change being backported that only breaks 5.6 environments without an object cache is small.

Merges [45005] into the 4.6 branch.

See #42387


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@45009 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-25 16:27:18 +00:00
John Blackbourn
ef1095679e Build/Test tools: Switch npm dependency caching strategy on Travis CI.
This switches to caching npm's local cache instead of `node_modules` in order to prevent issues caused by modules compiled using a different version of node.

Merges [44993] into the 4.6 branch.

See #46632


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44999 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-25 00:57:26 +00:00
Gary Pendergast
8a66e4659f WordPress 4.6.14
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44874 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-13 01:17:55 +00:00
Sergey Biryukov
6de345d505 Formatting: Fix a PHP warning in introduced in [44839].
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44864 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-13 00:34:42 +00:00
Sergey Biryukov
aa98e00bdb Comments: Improve comment content filtering.
Merges [44842] to the 4.6 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44848 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:36:59 +00:00
Sergey Biryukov
db7b94f7db Formatting: Improve rel="nofollow" handling in comments.
Merges [44833] to the 4.6 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44839 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 22:22:54 +00:00
Jeremy Felt
647892a950 Bump 4.6 branch to version 4.6.13.
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44081 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 02:12:04 +00:00
Gary Pendergast
cd1c717690 Editor: Remove unwanted fields before saving posts.
The `meta_input`, `file`, and `guid` fields are not intended to be updated through user input.

Merges [44047] to the 4.6 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44058 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:42:33 +00:00
Peter Wilson
4c86c721b4 Multisite: Validate activation links.
Merges [44048] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44057 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 01:41:38 +00:00
Ian Dunn
c7f6c4e451 KSES: Make the URI attributes DRY.
This commit introduces the `wp_kses_uri_attributes` function and filter. The function centralizes the list of attributes, in order to prevent inconsistency, and the filter provides a way for plugins to customize the attributes.

Merges [44014] and [44017] to the `4.6` branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44031 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 00:51:05 +00:00
Peter Wilson
58bc2a3411 Multisite: Improve messaging for previously activated users.
Ensure activation of a site is not attempted multiple times and users are shown the correct message if they follow the link a second time.

Merges [44021] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44028 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-13 00:44:19 +00:00
Jeremy Felt
ffd8c5336f Media: Remove invalid data from test data provider.
See [43922].


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44004 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:35:51 +00:00
Gary Pendergast
3299076c97 KSES: Conditionally remove the <form> element from $allowedposttags.
To avoid backwards compatibility issues, `<form>` is re-added if a custom filter has added the `<input>` or `<select>` elements to `$allowedposttags`.

Merges [43994] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@44001 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:26:46 +00:00
Jeremy Felt
9d7e7e4e0c Media: Improve verification of MIME file types.
Merges [43988] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@43992 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-12 23:07:55 +00:00
Aaron D. Campbell
771eabae2e Bump 4.6 branch to version 4.6.12
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@43410 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 16:10:29 +00:00
John Blackbourn
5a81a03217 Media: Limit thumbnail file deletions to the same directory as the original file.
Merges [43393] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@43396 602fd350-edb4-49c9-b593-d223f7449a82
2018-07-05 14:52:09 +00:00
Aaron D. Campbell
e8d2fc5f7c Bump 4.6 branch to version 4.6.11
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42936 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 20:26:52 +00:00
Dominik Schilling (ocean90)
196fdfac3c Template: Make sure the version string is correctly escaped for use in attributes.
Merge of [42893] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42920 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 16:05:36 +00:00
Dominik Schilling (ocean90)
aabcac25d8 Meta: Simplify the delete all meta query in delete_metadata().
Merge of [42913] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42915 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 15:41:04 +00:00
Dominik Schilling (ocean90)
24b130a4c2 HTTP: Don't treat localhost as same host by default.
Merge of [42894] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42911 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 15:34:52 +00:00
Dominik Schilling (ocean90)
ced89228f5 Login: Use wp_safe_redirect() when redirecting the login page if forced to use HTTPS.
Merge of [42892] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42898 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 15:28:37 +00:00
Sergey Biryukov
18d3e598a4 General: Update copyright year to 2018 in license.txt.
Props rachelbaker.
Merges [42424] to the 4.6 branch.
Fixes #43007.

git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42555 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 11:25:28 +00:00
Dion Hulse
d3ac4a37a3 Bump the 4.6 branch to 4.6.10.
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42497 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 21:39:55 +00:00
Dion Hulse
d261d5a928 External Libraries: Remove unnecessary / obsoleted MediaElement.js files.
Merges [42478] to the 4.6 branch.
Fixes #42720 for 4.6.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42480 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 08:05:41 +00:00
Dion Hulse
d751729ae9 Upgrade: When deleting old files, if deletion fails attempt to empty the file instead.
Props joemcgill, dd32.
Merges [42434] to the 4.6 branch.
Fixes #42963 for 4.6.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42468 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 06:53:28 +00:00
John Blackbourn
24842a5d25 Bump 4.6 branch to version 4.6.9.
git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42319 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-29 18:58:26 +00:00
John Blackbourn
4a5cb38358 Hardening: Remove the ability to upload JavaScript files for users who do not have the unfiltered_html capability.
Merges [42261] to the 4.6 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@42279 602fd350-edb4-49c9-b593-d223f7449a82
2017-11-29 16:22:46 +00:00